[ https://issues.jboss.org/browse/ISPN-2181?page=com.atlassian.jira.plugin.... ] Vladimir Blagojevic commented on ISPN-2181: ------------------------------------------- This was not trivial at all and we had to involve Pete :-) So the idea is that we will create a custom qualifier, say @ImpliedInputTaskCache or whatever you want to call it and annotate Cache field in addition to @Inject annotation. Transcript: pmuir: so 1) implement Bean (utilities in Solder make this easy - BeanBuilder is the one to look at, and you specify a ContextualLifecycle to it, which is where you do the magic extraction from cc) [7:01pm] pmuir: 2) in the extensions, AfterBeanDiscovery, register your custom bean [7:01pm] pmuir: 3) in the *Lifecycle, put the Cache into the CreationalContext [7:04pm] vblagoje: pmuir: thats it? it is not going to interfere with current mechanism in Infinispan CDI which currently injects default cache? [7:05pm] vblagoje: ok I will into this tomorrow; it sounds like an interesting task! Thanks pmuir [7:07pm] pmuir: vblagoje: not if you use a custom qualifier [7:07pm] pmuir: yeah I guess add 0) create @Blah qualifier -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ISPN-2181?page=com.atlassian.jira.plugin.... ] Pete Muir commented on ISPN-2181: --------------------------------- {quote} So for step 1) I have to do something similar to how we implement a Bean for RemoteCache? I don't think I need to capture these injection points like we do for RemoteBean? {quote} You just need one Bean, you don't need to call it in a loop or anything. {quote} When you mention extraction from cc you mean extraction from CreationalContext? {quote} Yes. {quote} Do I need to save Producer for Cache and use it to produce Cache similar to RemoteCache? {quote} I would just implement the necessary custom logic in the ContextualLifecycle. I think you don't need any producer. There, you extract the right cache from the creational context. {quote} Step 3) So I put the cache into CreationContext in onPreExecute callback? {quote} Yes. {quote} I simply use the same BeanManager, get the CreationContext and call push with the specific Cache? {quote} Hmm, I guess you can't use the default creational context. You can probably just wrap CreationalContext and add some additional field to it, and then cast it. If this breaks Weld, it's a bug in Weld, and we can look at other options {quote} Anything else? What about onPostExecute, do I have to do some cleanup? {quote} Don't think so. {quote} For step 0, lets call this qualifier @ImpliedInputTaskCache. Do I need to make a producer for it? {quote} No. Just give the bean in (1) that qualifier. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ISPN-2181?page=com.atlassian.jira.plugin.... ] Pete Muir commented on ISPN-2181: --------------------------------- Exactly. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ISPN-2181?page=com.atlassian.jira.plugin.... ] Vladimir Blagojevic commented on ISPN-2181: ------------------------------------------- After Pete's review and recommendations I have prepared this [pull request|https://github.com/infinispan/infinispan/pull/1288]. Nicolas I would appreciate your participation in the pull request review/discussion. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ISPN-2181?page=com.atlassian.jira.plugin.... ] Vladimir Blagojevic commented on ISPN-2181: ------------------------------------------- Nicolas, can you elaborate - I do not understand :-( -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ISPN-2181?page=com.atlassian.jira.plugin.... ] Vladimir Blagojevic updated ISPN-2181: -------------------------------------- Git Pull Request: https://github.com/infinispan/infinispan/pull/1288 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ISPN-2181?page=com.atlassian.jira.plugin.... ] Vladimir Blagojevic updated ISPN-2181: -------------------------------------- Git Pull Request: https://github.com/infinispan/infinispan/pull/1288 (was: https://github.com/infinispan/infinispan/pull/1288) Component/s: Distributed Execution and Map/Reduce (was: CDI integration) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ISPN-2181?page=com.atlassian.jira.plugin.... ] Vladimir Blagojevic commented on ISPN-2181: ------------------------------------------- I would want to keep things as they are. It does not make sense to inject input cache to Reducer as the input cache by design of Map/Reduce is only used in mapping phase. Having input cache in Reducer is terribly confusing. Nicolas, the originator of this issue agreed that only Mapper should have the ability to receive the input cache. I am going to update the name of this JIRA -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira