6:19 a.m.
Galder Zamarreño created ISPN-1963:
--------------------------------------
Summary: SampleConfigFilesCorrectnessTest does not work when run from IDE
Key: ISPN-1963
URL: https://issues.jboss.org/browse/ISPN-1963
Project: Infinispan
Issue Type: Bug
Affects Versions: 5.1.3.FINAL
Reporter: Galder Zamarreño
Assignee: Martin Gencur
Fix For: 5.1.4.FINAL
As a result of changes in ISPN-1911, the test does not work any more when run from IDE.
This is because the new getRootFolder() impl does not accomodate when the test is run from
IDE. Please find an implementation that works for all:
- running from cmd line, for UNIX env.
- running from cmd line for windows env
- running from IDE
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:01 a.m.
[
https://issues.jboss.org/browse/ISPN-1963?page=com.atlassian.jira.plugin....
]
Martin Gencur commented on ISPN-1963:
-------------------------------------
Galder, the following change works for me even in IDE (Eclipse), and worked also from a
command line on Unix and Windows:
{code:java}
private File getRootFolder() {
File file = new File(new File(CONFIG_ROOT).getAbsolutePath());
// File file = new File(CONFIG_ROOT);
// //this is a hack. If the tests are run from core folder then following if should
not be entered.
// //otherwise assume we are runnin
// if (!file.isDirectory()) {
// file = new File("core/" + CONFIG_ROOT);
// }
return file;
}
{code}
Which IDE do you use - that it did not work for you?
SampleConfigFilesCorrectnessTest does not work when run from IDE
----------------------------------------------------------------
Key: ISPN-1963
URL: https://issues.jboss.org/browse/ISPN-1963
Project: Infinispan
Issue Type: Bug
Affects Versions: 5.1.3.FINAL
Reporter: Galder Zamarreño
Assignee: Martin Gencur
Fix For: 5.1.4.FINAL
As a result of changes in ISPN-1911, the test does not work any more when run from IDE.
This is because the new getRootFolder() impl does not accomodate when the test is run from
IDE. Please find an implementation that works for all:
- running from cmd line, for UNIX env.
- running from cmd line for windows env
- running from IDE
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:55 a.m.
[
https://issues.jboss.org/browse/ISPN-1963?page=com.atlassian.jira.plugin....
]
Galder Zamarreño commented on ISPN-1963:
----------------------------------------
IntelliJ on Mac. I think this can easily be solved by having getRootFolder() look like
this:
{code}
private File getRootFolder() {
File file = new File(new File(CONFIG_ROOT).getAbsolutePath());
//this is a hack. If the tests are run from core folder then following if should not
be entered.
//otherwise assume we are runnin
if (!file.isDirectory()) {
file = new File("core/" + CONFIG_ROOT);
}
return file;
}
{code}
I think that'd make everyone happy. Can you try that in those environments?
SampleConfigFilesCorrectnessTest does not work when run from IDE
----------------------------------------------------------------
Key: ISPN-1963
URL: https://issues.jboss.org/browse/ISPN-1963
Project: Infinispan
Issue Type: Bug
Affects Versions: 5.1.3.FINAL
Reporter: Galder Zamarreño
Assignee: Martin Gencur
Fix For: 5.1.4.FINAL
As a result of changes in ISPN-1911, the test does not work any more when run from IDE.
This is because the new getRootFolder() impl does not accomodate when the test is run from
IDE. Please find an implementation that works for all:
- running from cmd line, for UNIX env.
- running from cmd line for windows env
- running from IDE
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:37 a.m.
[
https://issues.jboss.org/browse/ISPN-1963?page=com.atlassian.jira.plugin....
]
Martin Gencur commented on ISPN-1963:
-------------------------------------
Yes, working on it ;-)
SampleConfigFilesCorrectnessTest does not work when run from IDE
----------------------------------------------------------------
Key: ISPN-1963
URL: https://issues.jboss.org/browse/ISPN-1963
Project: Infinispan
Issue Type: Bug
Affects Versions: 5.1.3.FINAL
Reporter: Galder Zamarreño
Assignee: Martin Gencur
Fix For: 5.1.4.FINAL
As a result of changes in ISPN-1911, the test does not work any more when run from IDE.
This is because the new getRootFolder() impl does not accomodate when the test is run from
IDE. Please find an implementation that works for all:
- running from cmd line, for UNIX env.
- running from cmd line for windows env
- running from IDE
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:50 a.m.
[
https://issues.jboss.org/browse/ISPN-1963?page=com.atlassian.jira.plugin....
]
Martin Gencur commented on ISPN-1963:
-------------------------------------
This solution works on Linux, Windows, and from Eclipse IDE. I'll issue a pull
request.
SampleConfigFilesCorrectnessTest does not work when run from IDE
----------------------------------------------------------------
Key: ISPN-1963
URL: https://issues.jboss.org/browse/ISPN-1963
Project: Infinispan
Issue Type: Bug
Affects Versions: 5.1.3.FINAL
Reporter: Galder Zamarreño
Assignee: Martin Gencur
Fix For: 5.1.4.FINAL
As a result of changes in ISPN-1911, the test does not work any more when run from IDE.
This is because the new getRootFolder() impl does not accomodate when the test is run from
IDE. Please find an implementation that works for all:
- running from cmd line, for UNIX env.
- running from cmd line for windows env
- running from IDE
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:54 a.m.
[
https://issues.jboss.org/browse/ISPN-1963?page=com.atlassian.jira.plugin....
]
Martin Gencur updated ISPN-1963:
--------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/infinispan/infinispan/pull/1062,
https://github.com/infinispan/infinispan/pull/1061
SampleConfigFilesCorrectnessTest does not work when run from IDE
----------------------------------------------------------------
Key: ISPN-1963
URL: https://issues.jboss.org/browse/ISPN-1963
Project: Infinispan
Issue Type: Bug
Affects Versions: 5.1.3.FINAL
Reporter: Galder Zamarreño
Assignee: Martin Gencur
Fix For: 5.1.4.FINAL
As a result of changes in ISPN-1911, the test does not work any more when run from IDE.
This is because the new getRootFolder() impl does not accomodate when the test is run from
IDE. Please find an implementation that works for all:
- running from cmd line, for UNIX env.
- running from cmd line for windows env
- running from IDE
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:57 a.m.
[
https://issues.jboss.org/browse/ISPN-1963?page=com.atlassian.jira.plugin....
]
Galder Zamarreño updated ISPN-1963:
-----------------------------------
Status: Resolved (was: Pull Request Sent)
Fix Version/s: 5.1.4.CR1
Resolution: Done
SampleConfigFilesCorrectnessTest does not work when run from IDE
----------------------------------------------------------------
Key: ISPN-1963
URL: https://issues.jboss.org/browse/ISPN-1963
Project: Infinispan
Issue Type: Bug
Affects Versions: 5.1.3.FINAL
Reporter: Galder Zamarreño
Assignee: Martin Gencur
Fix For: 5.1.4.CR1, 5.1.4.FINAL
As a result of changes in ISPN-1911, the test does not work any more when run from IDE.
This is because the new getRootFolder() impl does not accomodate when the test is run from
IDE. Please find an implementation that works for all:
- running from cmd line, for UNIX env.
- running from cmd line for windows env
- running from IDE
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.jboss.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
5016
days inactive
5027
days old
infinispan-issues@lists.jboss.org
6 comments
2 participants
participants (2)
-
Galder Zamarreño (JIRA) -
Martin Gencur (JIRA)