[JBoss JIRA] Created: (ISPN-1035) Servers should avoid reading key/values multiple times per request
10:20 a.m.
Servers should avoid reading key/values multiple times per request
------------------------------------------------------------------
Key: ISPN-1035
URL: https://issues.jboss.org/browse/ISPN-1035
Project: Infinispan
Issue Type: Bug
Components: Cache Server
Affects Versions: 5.0.0.BETA1, 4.2.1.FINAL
Reporter: Galder Zamarreño
Assignee: Galder Zamarreño
Priority: Critical
Fix For: 4.2.2.BETA1, 5.0.0.BETA2, 5.0.0.FINAL
When Infinispan servers need to decode keys and values only once per request, otherwise it
can generate a lot of garbage byte[]s instances. This is particularly important when
bigger key/values are used. The way to do that is tell Netty about intermediate stages of
reading a request so that the entire request is not re-read if the entire request has not
been read in one go.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:28 a.m.
New subject: [JBoss JIRA] Commented: (ISPN-1035) Servers should avoid reading key/values multiple times per request
[
https://issues.jboss.org/browse/ISPN-1035?page=com.atlassian.jira.plugin....
]
Galder Zamarreño commented on ISPN-1035:
----------------------------------------
From an implementation point of view, a couple of states need to be
hooked with Netty's ReplayingDecoder in order to know when the keys has been read, and
when the value has been read, since you only want these to be done once.
Servers should avoid reading key/values multiple times per request
------------------------------------------------------------------
Key: ISPN-1035
URL: https://issues.jboss.org/browse/ISPN-1035
Project: Infinispan
Issue Type: Bug
Components: Cache Server
Affects Versions: 4.2.1.FINAL, 5.0.0.BETA1
Reporter: Galder Zamarreño
Assignee: Galder Zamarreño
Priority: Critical
Labels: hotrod, memcached
Fix For: 4.2.2.BETA1, 5.0.0.BETA2, 5.0.0.FINAL
When Infinispan servers need to decode keys and values only once per request, otherwise
it can generate a lot of garbage byte[]s instances. This is particularly important when
bigger key/values are used. The way to do that is tell Netty about intermediate stages of
reading a request so that the entire request is not re-read if the entire request has not
been read in one go.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:33 a.m.
New subject: [JBoss JIRA] Work started: (ISPN-1035) Servers should avoid reading key/values multiple times per request
[
https://issues.jboss.org/browse/ISPN-1035?page=com.atlassian.jira.plugin....
]
Work on ISPN-1035 started by Galder Zamarreño.
Servers should avoid reading key/values multiple times per request
------------------------------------------------------------------
Key: ISPN-1035
URL: https://issues.jboss.org/browse/ISPN-1035
Project: Infinispan
Issue Type: Bug
Components: Cache Server
Affects Versions: 4.2.1.FINAL, 5.0.0.BETA1
Reporter: Galder Zamarreño
Assignee: Galder Zamarreño
Priority: Critical
Labels: hotrod, memcached
Fix For: 4.2.2.BETA1, 5.0.0.BETA2, 5.0.0.FINAL
When Infinispan servers need to decode keys and values only once per request, otherwise
it can generate a lot of garbage byte[]s instances. This is particularly important when
bigger key/values are used. The way to do that is tell Netty about intermediate stages of
reading a request so that the entire request is not re-read if the entire request has not
been read in one go.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:54 a.m.
New subject: [JBoss JIRA] Commented: (ISPN-1035) Servers should avoid reading key/values multiple times per request
[
https://issues.jboss.org/browse/ISPN-1035?page=com.atlassian.jira.plugin....
]
Galder Zamarreño commented on ISPN-1035:
----------------------------------------
To fix this I had to implement checkpointing in Netty that fixes the problem by putting a
marker after key or value is read. This guarantees that key/value pairs which are
potentially lengthy are only read once.
To implement this I had rewrite a big chunk of the decoding part and I got rid of the
transport abstraction and instead used Netty directly, cos it was gonna make the code much
simpler and easier to maintain in the future.
The issue is almost fixed and after that I need to do some tidying up.
Servers should avoid reading key/values multiple times per request
------------------------------------------------------------------
Key: ISPN-1035
URL: https://issues.jboss.org/browse/ISPN-1035
Project: Infinispan
Issue Type: Bug
Components: Cache Server
Affects Versions: 4.2.1.FINAL, 5.0.0.BETA1
Reporter: Galder Zamarreño
Assignee: Galder Zamarreño
Priority: Critical
Labels: hotrod, memcached
Fix For: 4.2.2.BETA1, 5.0.0.BETA2, 5.0.0.FINAL
When Infinispan servers need to decode keys and values only once per request, otherwise
it can generate a lot of garbage byte[]s instances. This is particularly important when
bigger key/values are used. The way to do that is tell Netty about intermediate stages of
reading a request so that the entire request is not re-read if the entire request has not
been read in one go.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:05 p.m.
New subject: [JBoss JIRA] Updated: (ISPN-1035) Servers should avoid reading key/values multiple times per request
[
https://issues.jboss.org/browse/ISPN-1035?page=com.atlassian.jira.plugin....
]
Galder Zamarreño updated ISPN-1035:
-----------------------------------
Git Pull Request: https://github.com/infinispan/infinispan/pull/242
Servers should avoid reading key/values multiple times per request
------------------------------------------------------------------
Key: ISPN-1035
URL: https://issues.jboss.org/browse/ISPN-1035
Project: Infinispan
Issue Type: Bug
Components: Cache Server
Affects Versions: 4.2.1.FINAL, 5.0.0.BETA1
Reporter: Galder Zamarreño
Assignee: Galder Zamarreño
Priority: Critical
Labels: hotrod, memcached
Fix For: 4.2.2.BETA1, 5.0.0.BETA2, 5.0.0.FINAL
When Infinispan servers need to decode keys and values only once per request, otherwise
it can generate a lot of garbage byte[]s instances. This is particularly important when
bigger key/values are used. The way to do that is tell Netty about intermediate stages of
reading a request so that the entire request is not re-read if the entire request has not
been read in one go.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:28 p.m.
New subject: [JBoss JIRA] Commented: (ISPN-1035) Servers should avoid reading key/values multiple times per request
[
https://issues.jboss.org/browse/ISPN-1035?page=com.atlassian.jira.plugin....
]
Galder Zamarreño commented on ISPN-1035:
----------------------------------------
Apart from avoiding reading key/value multiple times, we need a more efficient solution
when reading the actual byte[] and avoid generating byte[] instances that then are thrown
away. I'm checking with Trustin to find a more efficient way of reading a ranged
byte[] (maybe buffering?)
Servers should avoid reading key/values multiple times per request
------------------------------------------------------------------
Key: ISPN-1035
URL: https://issues.jboss.org/browse/ISPN-1035
Project: Infinispan
Issue Type: Bug
Components: Cache Server
Affects Versions: 4.2.1.FINAL, 5.0.0.BETA1
Reporter: Galder Zamarreño
Assignee: Galder Zamarreño
Priority: Critical
Labels: hotrod, memcached
Fix For: 4.2.2.BETA1, 5.0.0.BETA2, 5.0.0.FINAL
When Infinispan servers need to decode keys and values only once per request, otherwise
it can generate a lot of garbage byte[]s instances. This is particularly important when
bigger key/values are used. The way to do that is tell Netty about intermediate stages of
reading a request so that the entire request is not re-read if the entire request has not
been read in one go.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:15 a.m.
New subject: [JBoss JIRA] Commented: (ISPN-1035) Servers should avoid reading key/values multiple times per request
[
https://issues.jboss.org/browse/ISPN-1035?page=com.atlassian.jira.plugin....
]
Galder Zamarreño commented on ISPN-1035:
----------------------------------------
A potential solution here would be to add a checkpoint as soon as the length of the value
has been read and the holder byte[] has been created, so if reading needs to be restarted,
it directly goes to update the byte[] and does not generate garbage.
Servers should avoid reading key/values multiple times per request
------------------------------------------------------------------
Key: ISPN-1035
URL: https://issues.jboss.org/browse/ISPN-1035
Project: Infinispan
Issue Type: Bug
Components: Cache Server
Affects Versions: 4.2.1.FINAL, 5.0.0.BETA1
Reporter: Galder Zamarreño
Assignee: Galder Zamarreño
Priority: Critical
Labels: hotrod, memcached
Fix For: 4.2.2.BETA1, 5.0.0.BETA2, 5.0.0.FINAL
When Infinispan servers need to decode keys and values only once per request, otherwise
it can generate a lot of garbage byte[]s instances. This is particularly important when
bigger key/values are used. The way to do that is tell Netty about intermediate stages of
reading a request so that the entire request is not re-read if the entire request has not
been read in one go.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:43 a.m.
New subject: [JBoss JIRA] Resolved: (ISPN-1035) Servers should avoid reading key/values multiple times per request
[
https://issues.jboss.org/browse/ISPN-1035?page=com.atlassian.jira.plugin....
]
Galder Zamarreño resolved ISPN-1035.
------------------------------------
Resolution: Done
Servers should avoid reading key/values multiple times per request
------------------------------------------------------------------
Key: ISPN-1035
URL: https://issues.jboss.org/browse/ISPN-1035
Project: Infinispan
Issue Type: Bug
Components: Cache Server
Affects Versions: 4.2.1.FINAL, 5.0.0.BETA1
Reporter: Galder Zamarreño
Assignee: Galder Zamarreño
Priority: Critical
Labels: hotrod, memcached
Fix For: 4.2.2.BETA1, 5.0.0.BETA2, 5.0.0.FINAL
When Infinispan servers need to decode keys and values only once per request, otherwise
it can generate a lot of garbage byte[]s instances. This is particularly important when
bigger key/values are used. The way to do that is tell Netty about intermediate stages of
reading a request so that the entire request is not re-read if the entire request has not
been read in one go.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4756
days inactive
4767
days old
infinispan-issues@lists.jboss.org
7 comments
1 participants
participants (1)
-
Galder Zamarreño (JIRA)