9:50 a.m.
Expensive to read a single byte in Lucene Directory
---------------------------------------------------
Key: ISPN-276
URL: https://jira.jboss.org/jira/browse/ISPN-276
Project: Infinispan
Issue Type: Bug
Components: Lucene Directory
Affects Versions: 4.0.0.CR2, 4.0.0.CR1
Reporter: Sanne Grinovero
Assignee: Sanne Grinovero
Fix For: 4.0.0.GA
public byte readByte() in org.infinispan.lucene.InfinispanIndexIO is doing some expensive
operations, while this is a very hot spot.
Spotted by Earwin Burrfoot on Lucene's developer list.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:20 a.m.
New subject: [JBoss JIRA] Updated: (ISPN-276) Expensive to read a single byte in Lucene Directory
[
https://jira.jboss.org/jira/browse/ISPN-276?page=com.atlassian.jira.plugi...
]
Davide Di Somma updated ISPN-276:
---------------------------------
Attachment: readByte.diff
In this patch I added a new test case to verify that readByte method (but also readBytes)
works properly.
I modified getChunkFromPosition InfinispanIndexInput's method to make the single byte
read operation faster
Expensive to read a single byte in Lucene Directory
---------------------------------------------------
Key: ISPN-276
URL: https://jira.jboss.org/jira/browse/ISPN-276
Project: Infinispan
Issue Type: Bug
Components: Lucene Directory
Affects Versions: 4.0.0.CR1, 4.0.0.CR2
Reporter: Sanne Grinovero
Assignee: Sanne Grinovero
Fix For: 4.0.0.GA
Attachments: readByte.diff
public byte readByte() in org.infinispan.lucene.InfinispanIndexIO is doing some expensive
operations, while this is a very hot spot.
Spotted by Earwin Burrfoot on Lucene's developer list.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:35 a.m.
New subject: [JBoss JIRA] Commented: (ISPN-276) Expensive to read a single byte in Lucene Directory
[
https://jira.jboss.org/jira/browse/ISPN-276?page=com.atlassian.jira.plugi...
]
Sanne Grinovero commented on ISPN-276:
--------------------------------------
Thanks for the patch Davide, it's going in the good direction but I've just
committed some additional tests you should look into.
It's a stresstest so it's disabled in default build by Maven, you'll have to
start it manually: org.infinispan.lucene.profiling.PerformanceCompareStressTest
To be meaningful this test requires a fix for Lucene:
https://issues.apache.org/jira/browse/LUCENE-2095
I'm attaching a fixed Lucene snapshot build, please add it to your local repo as
2.9.2-SNAPSHOT and cheat your pom.xml: unfurtunately Lucene doesn't release currently
snapshots.
Expensive to read a single byte in Lucene Directory
---------------------------------------------------
Key: ISPN-276
URL: https://jira.jboss.org/jira/browse/ISPN-276
Project: Infinispan
Issue Type: Bug
Components: Lucene Directory
Affects Versions: 4.0.0.CR1, 4.0.0.CR2
Reporter: Sanne Grinovero
Assignee: Sanne Grinovero
Fix For: 4.0.0.GA
Attachments: readByte.diff
public byte readByte() in org.infinispan.lucene.InfinispanIndexIO is doing some expensive
operations, while this is a very hot spot.
Spotted by Earwin Burrfoot on Lucene's developer list.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:39 a.m.
New subject: [JBoss JIRA] Updated: (ISPN-276) Expensive to read a single byte in Lucene Directory
[
https://jira.jboss.org/jira/browse/ISPN-276?page=com.atlassian.jira.plugi...
]
Sanne Grinovero updated ISPN-276:
---------------------------------
Attachment: lucene-core-2.9.2-SNAPSHOT.jar
Lucene version to use for StressTests
Expensive to read a single byte in Lucene Directory
---------------------------------------------------
Key: ISPN-276
URL: https://jira.jboss.org/jira/browse/ISPN-276
Project: Infinispan
Issue Type: Bug
Components: Lucene Directory
Affects Versions: 4.0.0.CR1, 4.0.0.CR2
Reporter: Sanne Grinovero
Assignee: Sanne Grinovero
Fix For: 4.0.0.GA
Attachments: lucene-core-2.9.2-SNAPSHOT.jar, readByte.diff
public byte readByte() in org.infinispan.lucene.InfinispanIndexIO is doing some expensive
operations, while this is a very hot spot.
Spotted by Earwin Burrfoot on Lucene's developer list.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:36 p.m.
New subject: [JBoss JIRA] Updated: (ISPN-276) Expensive to read a single byte in Lucene Directory
[
https://jira.jboss.org/jira/browse/ISPN-276?page=com.atlassian.jira.plugi...
]
Davide Di Somma updated ISPN-276:
---------------------------------
Attachment: readByte-1.1.diff
I apologize for not having seen that stress tests must be run manually.
This time I followed your instructions to run stress tests and I've added a new patch
.
Expensive to read a single byte in Lucene Directory
---------------------------------------------------
Key: ISPN-276
URL: https://jira.jboss.org/jira/browse/ISPN-276
Project: Infinispan
Issue Type: Bug
Components: Lucene Directory
Affects Versions: 4.0.0.CR1, 4.0.0.CR2
Reporter: Sanne Grinovero
Assignee: Sanne Grinovero
Fix For: 4.0.0.GA
Attachments: lucene-core-2.9.2-SNAPSHOT.jar, readByte-1.1.diff, readByte.diff
public byte readByte() in org.infinispan.lucene.InfinispanIndexIO is doing some expensive
operations, while this is a very hot spot.
Spotted by Earwin Burrfoot on Lucene's developer list.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:55 a.m.
New subject: [JBoss JIRA] Commented: (ISPN-276) Expensive to read a single byte in Lucene Directory
[
https://jira.jboss.org/jira/browse/ISPN-276?page=com.atlassian.jira.plugi...
]
Sanne Grinovero commented on ISPN-276:
--------------------------------------
Nice improvements!
Results by running a 5 minute benchmark:
Average slowdown compared to RAMDirectory - Infinispan Local cache - before patch: 114%
Average slowdown compared to RAMDirectory - Infinispan Local cache - after patch: 24%
Average slowdown compared to RAMDirectory - Infinispan Distributed cache - before patch:
123%
Average slowdown compared to RAMDirectory - Infinispan Distributed cache - after patch:
47%
Will do more tests on a long-running benchmark and profile, but I apply this now.
Expensive to read a single byte in Lucene Directory
---------------------------------------------------
Key: ISPN-276
URL: https://jira.jboss.org/jira/browse/ISPN-276
Project: Infinispan
Issue Type: Bug
Components: Lucene Directory
Affects Versions: 4.0.0.CR1, 4.0.0.CR2
Reporter: Sanne Grinovero
Assignee: Sanne Grinovero
Fix For: 4.0.0.GA
Attachments: lucene-core-2.9.2-SNAPSHOT.jar, readByte-1.1.diff, readByte.diff
public byte readByte() in org.infinispan.lucene.InfinispanIndexIO is doing some expensive
operations, while this is a very hot spot.
Spotted by Earwin Burrfoot on Lucene's developer list.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:21 a.m.
New subject: [JBoss JIRA] Updated: (ISPN-276) Expensive to read a single byte in Lucene Directory
[
https://jira.jboss.org/jira/browse/ISPN-276?page=com.atlassian.jira.plugi...
]
Sanne Grinovero updated ISPN-276:
---------------------------------
Affects Version/s: 4.0.0.CR3
Expensive to read a single byte in Lucene Directory
---------------------------------------------------
Key: ISPN-276
URL: https://jira.jboss.org/jira/browse/ISPN-276
Project: Infinispan
Issue Type: Bug
Components: Lucene Directory
Affects Versions: 4.0.0.CR1, 4.0.0.CR2, 4.0.0.CR3
Reporter: Sanne Grinovero
Assignee: Sanne Grinovero
Fix For: 4.0.0.GA
Attachments: lucene-core-2.9.2-SNAPSHOT.jar, readByte-1.1.diff, readByte.diff
public byte readByte() in org.infinispan.lucene.InfinispanIndexIO is doing some expensive
operations, while this is a very hot spot.
Spotted by Earwin Burrfoot on Lucene's developer list.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:21 a.m.
New subject: [JBoss JIRA] Resolved: (ISPN-276) Expensive to read a single byte in Lucene Directory
[
https://jira.jboss.org/jira/browse/ISPN-276?page=com.atlassian.jira.plugi...
]
Sanne Grinovero resolved ISPN-276.
----------------------------------
Resolution: Done
Expensive to read a single byte in Lucene Directory
---------------------------------------------------
Key: ISPN-276
URL: https://jira.jboss.org/jira/browse/ISPN-276
Project: Infinispan
Issue Type: Bug
Components: Lucene Directory
Affects Versions: 4.0.0.CR1, 4.0.0.CR2, 4.0.0.CR3
Reporter: Sanne Grinovero
Assignee: Sanne Grinovero
Fix For: 4.0.0.GA
Attachments: lucene-core-2.9.2-SNAPSHOT.jar, readByte-1.1.diff, readByte.diff
public byte readByte() in org.infinispan.lucene.InfinispanIndexIO is doing some expensive
operations, while this is a very hot spot.
Spotted by Earwin Burrfoot on Lucene's developer list.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:51 a.m.
New subject: [JBoss JIRA] Updated: (ISPN-276) Expensive to read a single byte in Lucene Directory
[
https://jira.jboss.org/jira/browse/ISPN-276?page=com.atlassian.jira.plugi...
]
Manik Surtani updated ISPN-276:
-------------------------------
Fix Version/s: 4.0.0.CR4
(was: 4.0.0.GA)
Expensive to read a single byte in Lucene Directory
---------------------------------------------------
Key: ISPN-276
URL: https://jira.jboss.org/jira/browse/ISPN-276
Project: Infinispan
Issue Type: Bug
Components: Lucene Directory
Affects Versions: 4.0.0.CR1, 4.0.0.CR2, 4.0.0.CR3
Reporter: Sanne Grinovero
Assignee: Sanne Grinovero
Fix For: 4.0.0.CR4
Attachments: lucene-core-2.9.2-SNAPSHOT.jar, readByte-1.1.diff, readByte.diff
public byte readByte() in org.infinispan.lucene.InfinispanIndexIO is doing some expensive
operations, while this is a very hot spot.
Spotted by Earwin Burrfoot on Lucene's developer list.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5445
days inactive
5524
days old
infinispan-issues@lists.jboss.org
8 comments
3 participants
participants (3)
-
Davide Di Somma (JIRA) -
Manik Surtani (JIRA)
-
Sanne Grinovero (JIRA)