[ https://issues.jboss.org/browse/ISPN-2033?page=com.atlassian.jira.plugin.... ] Jim Dunkerton updated ISPN-2033: -------------------------------- Description: A potential memory leak of pooled DB connections is present in JdbcBinaryCacheStore. Observe the catch and finally blocks of the purgeInternal() method. The pooled DB connection is not released unless an SQLException has been thrown. Contrast with JdbcStringBasedCacheStore.purgeInternal(), where the releaseConnection() is invoked in the finally block. When using a JdbcMixedCacheStore, I noticed a DB connection leak. It appeared that for every two connections being acquired, only one was being released. I believe it is down to the fact that the JdbcBinaryCacheStore inside the JdbcMixedCacheStore is not releasing its connections properly (i.e. in its finally block) whereas the JdbcStringBasedCacheStore is. I guess a workaround is to use only a JdbcStringBasedCacheStore, not a JdbcMixedCacheStore. was: A potential memory leak of pooled DB connections is present in JdbcCacheBinaryStore. Observe the catch and finally blocks of the purgeInternal() method: catch (SQLException ex) { //if something happens make sure buckets locks are being release releaseLocks(expiredBuckets); connectionFactory.releaseConnection(conn); log.failedClearingJdbcCacheStore(ex); throw new CacheLoaderException("Failed clearing JdbcBinaryCacheStore", ex); } finally { JdbcUtil.safeClose(ps); JdbcUtil.safeClose(rs); } The pooled DB connection is not released unless an SQLException has been thrown. Contrast with JdbcStringBasedCacheStore.purgeInternal(): } catch (SQLException ex) { log.failedClearingJdbcCacheStore(ex); throw new CacheLoaderException("Failed clearing string based JDBC store", ex); } finally { JdbcUtil.safeClose(ps); connectionFactory.releaseConnection(conn); } When using a JdbcMixedCacheStore, I noticed a DB connection leak. It appeared that for every two connections being acquired, only one was being released. I believe it is down to the fact that the JdbcBinaryCacheStore inside the JdbcMixedCacheStore is not releasing its connections properly (i.e. in its finally block) whereas the JdbcStringBasedCacheStore is. I guess a workaround is to use only a JdbcStringBasedCacheStore, not a JdbcMixedCacheStore. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ISPN-2033?page=com.atlassian.jira.plugin.... ] Tristan Tarrant commented on ISPN-2033: --------------------------------------- Jim, this is a potential duplicate of ISPN-2102 which has been resolved in 5.1.5.FINAL. The code there is a bit contrived and indeed connections should not be released in the finally blocks as they are needed in subsequent parts of the code. Could you try again with the later release and tell me if it works for you there ? -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.jboss.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ISPN-2033?page=com.atlassian.jira.plugin.... ] Thomas Weinlein commented on ISPN-2033: --------------------------------------- This connection leaks always occurs when the Statement tableManipulation.getSelectExpiredRowsSql() returns an empty result set. For long expiration times this almost certainly results in almost the whole application waiting for the next connection from the ConnectionPool. This issue occurs at least from 5.0.1 to master. Please consider the attched patch. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ISPN-2033?page=com.atlassian.jira.plugin.... ] Tristan Tarrant updated ISPN-2033: ---------------------------------- Git Pull Request: https://github.com/infinispan/infinispan/pull/1426 (was: https://github.com/infinispan/infinispan/pull/1405) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://issues.jboss.org/browse/ISPN-2033?page=com.atlassian.jira.plugin.... ] Galder Zamarreño updated ISPN-2033: ----------------------------------- Status: Resolved (was: Pull Request Sent) Resolution: Done -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira