[
https://issues.redhat.com/browse/ISPN-8241?page=com.atlassian.jira.plugin...
]
Diego Lovison commented on ISPN-8241:
-------------------------------------
Notes:
* We can't deprecate `clearThreshold` because it is used for
`NonSegmentedRocksDBHandler`. The segment info is part of the key
* This PR also fixes a critical issue when `segments != null`. The `clearThreshold`
technique was not used.
When we remove `NonSegmentedRocksDBHandler` we will be able to deprecate|remove
`clearThreshold`
Refactor RocksDB clearThreshold
-------------------------------
Key: ISPN-8241
URL:
https://issues.redhat.com/browse/ISPN-8241
Project: Infinispan
Issue Type: Sub-task
Components: Loaders and Stores
Affects Versions: 9.1.0.Final
Reporter: Ryan Emerson
Assignee: Diego Lovison
Priority: Major
Currently the RocksDB store utilises a "clearThreshold" to try to delete
entries individually before deleting and re-initiating the database. We should deprecate
this threshold and always delete/reinit the database.
Currently when deleting the database, we utilise Util.recursiveFileRemove which does not
confirm that the file has actually been deleted. Instead, we should provide a nio based
implementation instead, similar to the one stated
[
here|https://stackoverflow.com/questions/779519/delete-directories-recurs...].
This has the advantage that an IOException is thrown by java.nio.file.Files::delete
--
This message was sent by Atlassian Jira
(v7.13.8#713008)