[ https://issues.redhat.com/browse/IPROTO-161?page=com.atlassian.jira.plugi... ] Dan Berindei commented on IPROTO-161: ------------------------------------- I have reproduced the problem in a simpler project that doesn't use Quarkus. After debugging it I'd say it's an aggregate of a maven-core problem (or tradition?), a maven-compiler-plugin problem introduced in 3.8.1, and a protostream problem. # When you invoke {{mvn clean compile test}}, the {{default-compile}} execution runs twice. This is because {{org.apache.maven.lifecycle.internal.DefaultLifecycleExecutionPlanCalculator#calculateMojoExecutions()}} (which hasn't changed in 6 years) collects the list of mojo executions in a list, and for each phase on the command-line it adds the mojo executions for that phase and its dependencies, even if some executions already exist in the list. E.g. {noformat} mojoExecutions = {java.util.ArrayList} size = 8 0 = {org.apache.maven.plugin.MojoExecution} "org.apache.maven.plugins:maven-clean-plugin:2.5:clean {execution: default-clean}" 1 = {org.apache.maven.plugin.MojoExecution} "org.apache.maven.plugins:maven-resources-plugin:2.6:resources {execution: default-resources}" 2 = {org.apache.maven.plugin.MojoExecution} "org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile {execution: default-compile}" 3 = {org.apache.maven.plugin.MojoExecution} "org.apache.maven.plugins:maven-resources-plugin:2.6:resources {execution: default-resources}" 4 = {org.apache.maven.plugin.MojoExecution} "org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile {execution: default-compile}" 5 = {org.apache.maven.plugin.MojoExecution} "org.apache.maven.plugins:maven-resources-plugin:2.6:testResources {execution: default-testResources}" 6 = {org.apache.maven.plugin.MojoExecution} "org.apache.maven.plugins:maven-compiler-plugin:3.8.1:testCompile {execution: default-testCompile}" 7 = {org.apache.maven.plugin.MojoExecution} "org.apache.maven.plugins:maven-surefire-plugin:2.12.4:test {execution: default-test}" {noformat} # The second execution of {{maven-compiler-plugin}} version 3.8.0 used to check that the sources haven't changed and do nothing. But that check was wrong, because it didn't check any class files, and [MCOMPILER-349|https://issues.apache.org/jira/browse/MCOMPILER-349] replaced it with another check that is also wrong, because it ({{org.apache.maven.plugin.compiler.AbstractCompilerMojo#isDependencyChanged()}}) checks for changes since the start of the build in all the classes on the module's classpath, including {{target/classes}}. This means the second execution of {{maven-compiler-plugin}} verison 3.8.1 deletes all the {{.class}} files from {{target/classes}}. It does not delete the files generated by annotation processors in {{target/generated-sources/annotations}}, but it also doesn't add them to the Javac sources parameter because {{org.apache.maven.plugin.compiler.AbstractCompilerMojo#getCompileSources()}} ignores the generated sources directory: {noformat} compileSourceRoots = {java.util.ArrayList} size = 3 0 = "/home/dan/Work/maven-compiler-test/src/main/java" 1 = "/home/dan/Work/maven-compiler-test/target/generated-sources/annotations" 2 = "/home/dan/Work/maven-compiler-test/target/generated-sources/annotations" {noformat} {noformat} sources = {java.util.HashSet} size = 2 0 = {java.io.File} "/home/dan/Work/maven-compiler-test/src/main/java/ProtoStreamContextInitializer.java" 1 = {java.io.File} "/home/dan/Work/maven-compiler-test/src/main/java/A.java" {noformat} # The protostream annotation processor sees that the generated Java source file exists with the correct checksum and doesn't overwrite it ({{org.infinispan.protostream.annotations.impl.processor.GeneratedFilesWriter.SourceFile#write()}}). But this means the generated source file is not added to Javac's sources, and Javac does not compile it to a {{.class}} file. IMO issue #1 is just the way Maven works, and it's not going to change any time soon. Issue #2 should be fixed, and I'll create an issue in the maven-compiler-plugin JIRA. Issue #3 could also be fixed by removing the checksum check in {{org.infinispan.protostream.annotations.impl.processor.GeneratedFilesWriter.SourceFile#write()}} and always writing the generated Java source file. TBH I'm not sure what's the purpose of the check is, so I'm not 100% it can be removed, but I hope it can be removed. -- This message was sent by Atlassian Jira (v7.13.8#713008)