6:11 p.m.
Hi all,
I sent the following PR
https://github.com/arquillian/arquillian-showcase/pull/17 for an earlier
review. SO PLEASE DON'T MERGE IT YET.
I made most changes under the cdi/ folder and that's were you should focus.
Some changes:
- Removed BOMs project/folder
- Removed parent project/folder - Quickstarts should be treated as
standalone
- Removed gradlew, ant + ivy
- Removed other containers profile and keep only arq-jbossas-managed and
arq-jbossas-remote (removed -7 on the profile name)
- Added license headers and Readme.md
- Make cdi/pom.xml follow JDF guidelines.
- Update GAV to
org.jboss.quickstarts.wfk:jboss-arquillian-showcase-cdi:2.4.0-redhat-SNAPSHOT
- Minor other changes
I'll appreciate any feedbacks on this since I'll apply the same changes
to all other folders/quickstarts
--
Rafael Benevides | Senior Software Engineer
Red Hat Brazil
+55-61-9269-6576
Better technology. Faster innovation. Powered by community collaboration.
See how it works at redhat.com
10:09 a.m.
New subject: [wfk] (WFK2-49 / JDF-424) Add Arquillian Showcase to Quickstarts
This might be a stupid question, but I though that removing of other
containers/build tools should happen on JDF level, not as a part of
arquillian.org. While most of the changes makes sense to have upstream as well
to make fork closer to upstream, I can't agree with removal of profiles and
build tools in upstream. Shouldn't JDF rather fork and Arquillian update
Showcase based on a part of JDF work?
For Arquillian Showcase in upstream it is definitely reasonable to show other
possibilities, like GlassFish or Ivy. Arquillian is not tied to JBoss.
Karel
On Tue, 13 Aug 2013 13:11:57 -0300
Rafael Benevides <benevides(a)redhat.com> wrote:
Hi all,
I sent the following PR
https://github.com/arquillian/arquillian-showcase/pull/17 for an earlier
review. SO PLEASE DON'T MERGE IT YET.
I made most changes under the cdi/ folder and that's were you should focus.
Some changes:
- Removed BOMs project/folder
- Removed parent project/folder - Quickstarts should be treated as
standalone
- Removed gradlew, ant + ivy
- Removed other containers profile and keep only arq-jbossas-managed and
arq-jbossas-remote (removed -7 on the profile name)
- Added license headers and Readme.md
- Make cdi/pom.xml follow JDF guidelines.
- Update GAV to
org.jboss.quickstarts.wfk:jboss-arquillian-showcase-cdi:2.4.0-redhat-SNAPSHOT
- Minor other changes
I'll appreciate any feedbacks on this since I'll apply the same changes
to all other folders/quickstarts
2:58 p.m.
New subject: [wfk] (WFK2-49 / JDF-424) Add Arquillian Showcase to Quickstarts
In this case, shouldn't we want to merge this PR in a 'jdf-quickstart'
branch ?
As the Jira issue title says "Add Arquillian Showcase to Quickstart",
your previous opinion made total sense to me in this context:
/"Historically, we've been removing all other container Maven profiles
from code as we did community -> product conversion(take RichFaces for
example). If Arquillian Showcase is going from Arquillian org
(community) into JDF (product), we should follow the same path."/
Em 14/08/13 05:09, Karel Piwko escreveu:
This might be a stupid question, but I though that removing of other
containers/build tools should happen on JDF level, not as a part of
arquillian.org. While most of the changes makes sense to have upstream as well
to make fork closer to upstream, I can't agree with removal of profiles and
build tools in upstream. Shouldn't JDF rather fork and Arquillian update
Showcase based on a part of JDF work?
For Arquillian Showcase in upstream it is definitely reasonable to show other
possibilities, like GlassFish or Ivy. Arquillian is not tied to JBoss.
Karel
On Tue, 13 Aug 2013 13:11:57 -0300
Rafael Benevides <benevides(a)redhat.com> wrote:
> Hi all,
>
> I sent the following PR
> https://github.com/arquillian/arquillian-showcase/pull/17 for an earlier
> review. SO PLEASE DON'T MERGE IT YET.
>
> I made most changes under the cdi/ folder and that's were you should focus.
>
> Some changes:
>
> - Removed BOMs project/folder
> - Removed parent project/folder - Quickstarts should be treated as
> standalone
> - Removed gradlew, ant + ivy
> - Removed other containers profile and keep only arq-jbossas-managed and
> arq-jbossas-remote (removed -7 on the profile name)
> - Added license headers and Readme.md
> - Make cdi/pom.xml follow JDF guidelines.
> - Update GAV to
> org.jboss.quickstarts.wfk:jboss-arquillian-showcase-cdi:2.4.0-redhat-SNAPSHOT
> - Minor other changes
>
> I'll appreciate any feedbacks on this since I'll apply the same changes
> to all other folders/quickstarts
>
4 p.m.
New subject: [wfk] (WFK2-49 / JDF-424) Add Arquillian Showcase to Quickstarts
On Wed, 14 Aug 2013 09:58:32 -0300
Rafael Benevides <benevides(a)redhat.com> wrote:
In this case, shouldn't we want to merge this PR in a
'jdf-quickstart'
branch ?
I think it's up to Aslak, whether he wants to have a branch there used as input
source for JDF. If you plan to apply this model in JDF for
quickstarts/archetypes, it might be the way to go.
As the Jira issue title says "Add Arquillian Showcase to Quickstart",
your previous opinion made total sense to me in this context:
/"Historically, we've been removing all other container Maven profiles
from code as we did community -> product conversion(take RichFaces for
example). If Arquillian Showcase is going from Arquillian org
(community) into JDF (product), we should follow the same path."/
Right, be it does not mean that we removed them in community. We just removed
them from content was moved under JDF organization. Maybe I haven't worded this
correctly.
Em 14/08/13 05:09, Karel Piwko escreveu:
> This might be a stupid question, but I though that removing of other
> containers/build tools should happen on JDF level, not as a part of
> arquillian.org. While most of the changes makes sense to have upstream as
> well to make fork closer to upstream, I can't agree with removal of
> profiles and build tools in upstream. Shouldn't JDF rather fork and
> Arquillian update Showcase based on a part of JDF work?
>
> For Arquillian Showcase in upstream it is definitely reasonable to show
> other possibilities, like GlassFish or Ivy. Arquillian is not tied to JBoss.
>
> Karel
>
> On Tue, 13 Aug 2013 13:11:57 -0300
> Rafael Benevides <benevides(a)redhat.com> wrote:
>
>> Hi all,
>>
>> I sent the following PR
>> https://github.com/arquillian/arquillian-showcase/pull/17 for an earlier
>> review. SO PLEASE DON'T MERGE IT YET.
>>
>> I made most changes under the cdi/ folder and that's were you should focus.
>>
>> Some changes:
>>
>> - Removed BOMs project/folder
>> - Removed parent project/folder - Quickstarts should be treated as
>> standalone
>> - Removed gradlew, ant + ivy
>> - Removed other containers profile and keep only arq-jbossas-managed and
>> arq-jbossas-remote (removed -7 on the profile name)
>> - Added license headers and Readme.md
>> - Make cdi/pom.xml follow JDF guidelines.
>> - Update GAV to
>> org.jboss.quickstarts.wfk:jboss-arquillian-showcase-cdi:2.4.0-redhat-SNAPSHOT
>> - Minor other changes
>>;
>> I'll appreciate any feedbacks on this since I'll apply the same changes
>> to all other folders/quickstarts
>>
4161
days inactive
4162
days old
3 comments
2 participants
participants (2)
-
Karel Piwko -
Rafael Benevides