[JBoss JIRA] Created: (WELD-301) ProducerMethod.checkProducerMethod only checked method declarations in direct implemented interface and not super interfaces
11:28 a.m.
ProducerMethod.checkProducerMethod only checked method declarations in direct implemented
interface and not super interfaces
----------------------------------------------------------------------------------------------------------------------------
Key: WELD-301
URL: https://jira.jboss.org/jira/browse/WELD-301
Project: Weld
Issue Type: Bug
Affects Versions: 1.0.0.GA
Environment: X86/Ubuntu
Reporter: Hong Zhang
Priority: Critical
I am investigating the deployment failure when running
org.jboss.jsr299.tck.tests.implementation.producer.method.definition.enterprise.EnterpriseProducerMethodDefinitionTest.
The deployment failed due to some validation failure in weld RI code. It complains that
produceLightYellowPear method of LightYellowPearTree is not declared in
LightYellowPearTree business interface. But LightYellowTree implements
LightYellowPearTreeLocal which extends from PearTreeLocal which delares the
produceLightYellowPear method.
This seems a weld RI bug to me after stepping into the RI code:
In ProducerMethod.checkProducerMethod, when it's a session bean, it will check for its
implemented interface and super class for whether they declared this business method. But
the problem is it only goes to its direct implemented interface and not the interface
hierarchy. In this case it's true that the LightYellowPearTreeLocal does not declare
this method, but PearTreeLocal which the LightYellowPearTreeLocal extends from does
declare this method. The RI code should be modified to check for the whole interface
hierarchy and not just the direct implemented interface.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:38 a.m.
New subject: [JBoss JIRA] Commented: (WELD-301) ProducerMethod.checkProducerMethod only checked method declarations in direct implemented interface and not super interfaces
[
https://jira.jboss.org/jira/browse/WELD-301?page=com.atlassian.jira.plugi...
]
Pete Muir commented on WELD-301:
--------------------------------
Hong, thanks for the analysis. Could you give me a code snipped or line number that you
believe is wrong? The code I am looking at in checkProducerMethod() uses
declaringBean.getTypes() which returns the transitive closure of the business types
(interfaces and classes) of the declaring bean, so it should check the any business
interfaces provided in the EJBDescriptor for the bean (provided by the EE container).
ProducerMethod.checkProducerMethod only checked method declarations
in direct implemented interface and not super interfaces
----------------------------------------------------------------------------------------------------------------------------
Key: WELD-301
URL: https://jira.jboss.org/jira/browse/WELD-301
Project: Weld
Issue Type: Bug
Affects Versions: 1.0.0.GA
Environment: X86/Ubuntu
Reporter: Hong Zhang
Priority: Critical
I am investigating the deployment failure when running
org.jboss.jsr299.tck.tests.implementation.producer.method.definition.enterprise.EnterpriseProducerMethodDefinitionTest.
The deployment failed due to some validation failure in weld RI code. It complains that
produceLightYellowPear method of LightYellowPearTree is not declared in
LightYellowPearTree business interface. But LightYellowTree implements
LightYellowPearTreeLocal which extends from PearTreeLocal which delares the
produceLightYellowPear method.
This seems a weld RI bug to me after stepping into the RI code:
In ProducerMethod.checkProducerMethod, when it's a session bean, it will check for
its implemented interface and super class for whether they declared this business method.
But the problem is it only goes to its direct implemented interface and not the interface
hierarchy. In this case it's true that the LightYellowPearTreeLocal does not declare
this method, but PearTreeLocal which the LightYellowPearTreeLocal extends from does
declare this method. The RI code should be modified to check for the whole interface
hierarchy and not just the direct implemented interface.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:58 a.m.
New subject: [JBoss JIRA] Commented: (WELD-301) ProducerMethod.checkProducerMethod only checked method declarations in direct implemented interface and not super interfaces
[
https://jira.jboss.org/jira/browse/WELD-301?page=com.atlassian.jira.plugi...
]
Hong Zhang commented on WELD-301:
---------------------------------
When I traced the code, in this for loop:
for (Type type : getDeclaringBean().getTypes())
returns two classes: the direct interface LightYellowPearTreeLocal and the
java.lang.Object. But I think we need to get to all the super interfaces/classes as well.
For example, the glassfish code, when trying to find all the classes in the class
hierarchy uses the following code snippet:
Class parent = clazz;
while ((parent = parent.getSuperclass()) != null) {
if (parent.getPackage() == null ||
!parent.getPackage().getName().startsWith("java.lang")) {
classes.add(0, parent);
}
}
Basically the code needs to make sure classes like PearTreeLocal which is the super
interface of the LightYellowPearTreeLocal get examined in the for loop when looking for
the declared method.
ProducerMethod.checkProducerMethod only checked method declarations
in direct implemented interface and not super interfaces
----------------------------------------------------------------------------------------------------------------------------
Key: WELD-301
URL: https://jira.jboss.org/jira/browse/WELD-301
Project: Weld
Issue Type: Bug
Affects Versions: 1.0.0.GA
Environment: X86/Ubuntu
Reporter: Hong Zhang
Priority: Critical
I am investigating the deployment failure when running
org.jboss.jsr299.tck.tests.implementation.producer.method.definition.enterprise.EnterpriseProducerMethodDefinitionTest.
The deployment failed due to some validation failure in weld RI code. It complains that
produceLightYellowPear method of LightYellowPearTree is not declared in
LightYellowPearTree business interface. But LightYellowTree implements
LightYellowPearTreeLocal which extends from PearTreeLocal which delares the
produceLightYellowPear method.
This seems a weld RI bug to me after stepping into the RI code:
In ProducerMethod.checkProducerMethod, when it's a session bean, it will check for
its implemented interface and super class for whether they declared this business method.
But the problem is it only goes to its direct implemented interface and not the interface
hierarchy. In this case it's true that the LightYellowPearTreeLocal does not declare
this method, but PearTreeLocal which the LightYellowPearTreeLocal extends from does
declare this method. The RI code should be modified to check for the whole interface
hierarchy and not just the direct implemented interface.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:15 p.m.
New subject: [JBoss JIRA] Commented: (WELD-301) ProducerMethod.checkProducerMethod only checked method declarations in direct implemented interface and not super interfaces
[
https://jira.jboss.org/jira/browse/WELD-301?page=com.atlassian.jira.plugi...
]
Pete Muir commented on WELD-301:
--------------------------------
Yeah, when *we* do class hierarchy analysis we iterate up the class hierarchy, discovering
interfaces along the way. However in this case the discovery is done by the GlassFish /
Weld integration code (in the EJB portion) and transported to Weld via GlassFish's
implementation of EjbDescriptor, provided to the container by the relevant
BeanDeploymentArchive.
If you take a look at SessionBean.initTypes() (which populates sessionBean.getTypes()),
you can see that we simple iterate over all local business interfaces from the
EjbDescriptor, and collect them. So I would assume GlassFish is only providing
LightYellowPearTreeLocal as a business interface, and not PearTreeLocal.
ProducerMethod.checkProducerMethod only checked method declarations
in direct implemented interface and not super interfaces
----------------------------------------------------------------------------------------------------------------------------
Key: WELD-301
URL: https://jira.jboss.org/jira/browse/WELD-301
Project: Weld
Issue Type: Bug
Affects Versions: 1.0.0.GA
Environment: X86/Ubuntu
Reporter: Hong Zhang
Priority: Critical
I am investigating the deployment failure when running
org.jboss.jsr299.tck.tests.implementation.producer.method.definition.enterprise.EnterpriseProducerMethodDefinitionTest.
The deployment failed due to some validation failure in weld RI code. It complains that
produceLightYellowPear method of LightYellowPearTree is not declared in
LightYellowPearTree business interface. But LightYellowTree implements
LightYellowPearTreeLocal which extends from PearTreeLocal which delares the
produceLightYellowPear method.
This seems a weld RI bug to me after stepping into the RI code:
In ProducerMethod.checkProducerMethod, when it's a session bean, it will check for
its implemented interface and super class for whether they declared this business method.
But the problem is it only goes to its direct implemented interface and not the interface
hierarchy. In this case it's true that the LightYellowPearTreeLocal does not declare
this method, but PearTreeLocal which the LightYellowPearTreeLocal extends from does
declare this method. The RI code should be modified to check for the whole interface
hierarchy and not just the direct implemented interface.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:17 p.m.
New subject: [JBoss JIRA] Resolved: (WELD-301) ProducerMethod.checkProducerMethod only checked method declarations in direct implemented interface and not super interfaces
[
https://jira.jboss.org/jira/browse/WELD-301?page=com.atlassian.jira.plugi...
]
Pete Muir resolved WELD-301.
----------------------------
Fix Version/s: 1.0.1.CR1
Resolution: Rejected
Assignee: Pete Muir
I am marking this issue as resolved as there is no bug in Weld code I can see. Hong please
comment back here if you confirm the bug is in GlassFish code and I will close.
Thanks!
ProducerMethod.checkProducerMethod only checked method declarations
in direct implemented interface and not super interfaces
----------------------------------------------------------------------------------------------------------------------------
Key: WELD-301
URL: https://jira.jboss.org/jira/browse/WELD-301
Project: Weld
Issue Type: Bug
Affects Versions: 1.0.0.GA
Environment: X86/Ubuntu
Reporter: Hong Zhang
Assignee: Pete Muir
Priority: Critical
Fix For: 1.0.1.CR1
I am investigating the deployment failure when running
org.jboss.jsr299.tck.tests.implementation.producer.method.definition.enterprise.EnterpriseProducerMethodDefinitionTest.
The deployment failed due to some validation failure in weld RI code. It complains that
produceLightYellowPear method of LightYellowPearTree is not declared in
LightYellowPearTree business interface. But LightYellowTree implements
LightYellowPearTreeLocal which extends from PearTreeLocal which delares the
produceLightYellowPear method.
This seems a weld RI bug to me after stepping into the RI code:
In ProducerMethod.checkProducerMethod, when it's a session bean, it will check for
its implemented interface and super class for whether they declared this business method.
But the problem is it only goes to its direct implemented interface and not the interface
hierarchy. In this case it's true that the LightYellowPearTreeLocal does not declare
this method, but PearTreeLocal which the LightYellowPearTreeLocal extends from does
declare this method. The RI code should be modified to check for the whole interface
hierarchy and not just the direct implemented interface.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:23 p.m.
New subject: [JBoss JIRA] Commented: (WELD-301) ProducerMethod.checkProducerMethod only checked method declarations in direct implemented interface and not super interfaces
[
https://jira.jboss.org/jira/browse/WELD-301?page=com.atlassian.jira.plugi...
]
Hong Zhang commented on WELD-301:
---------------------------------
I don't know the details of this part of the EJB implementation in glassfish. We need
to wait for Ken Saks to come back to clarify (he is out next week).
But does the EJB spec say anything about the local business interfaces returned from the
EjbDescriptor must include all super interfaces? If not, then the implementation of Weld
RI cannot assume so with other vendor's implementation on this?
Can we keep the bug open till Ken Saks comes back to clarify (unless you find something
very clear in the EJB spec mandates this part)?
ProducerMethod.checkProducerMethod only checked method declarations
in direct implemented interface and not super interfaces
----------------------------------------------------------------------------------------------------------------------------
Key: WELD-301
URL: https://jira.jboss.org/jira/browse/WELD-301
Project: Weld
Issue Type: Bug
Affects Versions: 1.0.0.GA
Environment: X86/Ubuntu
Reporter: Hong Zhang
Assignee: Pete Muir
Priority: Critical
Fix For: 1.0.1.CR1
I am investigating the deployment failure when running
org.jboss.jsr299.tck.tests.implementation.producer.method.definition.enterprise.EnterpriseProducerMethodDefinitionTest.
The deployment failed due to some validation failure in weld RI code. It complains that
produceLightYellowPear method of LightYellowPearTree is not declared in
LightYellowPearTree business interface. But LightYellowTree implements
LightYellowPearTreeLocal which extends from PearTreeLocal which delares the
produceLightYellowPear method.
This seems a weld RI bug to me after stepping into the RI code:
In ProducerMethod.checkProducerMethod, when it's a session bean, it will check for
its implemented interface and super class for whether they declared this business method.
But the problem is it only goes to its direct implemented interface and not the interface
hierarchy. In this case it's true that the LightYellowPearTreeLocal does not declare
this method, but PearTreeLocal which the LightYellowPearTreeLocal extends from does
declare this method. The RI code should be modified to check for the whole interface
hierarchy and not just the direct implemented interface.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:37 p.m.
New subject: [JBoss JIRA] Reopened: (WELD-301) ProducerMethod.checkProducerMethod only checked method declarations in direct implemented interface and not super interfaces
[
https://jira.jboss.org/jira/browse/WELD-301?page=com.atlassian.jira.plugi...
]
Pete Muir reopened WELD-301:
----------------------------
ProducerMethod.checkProducerMethod only checked method declarations
in direct implemented interface and not super interfaces
----------------------------------------------------------------------------------------------------------------------------
Key: WELD-301
URL: https://jira.jboss.org/jira/browse/WELD-301
Project: Weld
Issue Type: Bug
Affects Versions: 1.0.0.GA
Environment: X86/Ubuntu
Reporter: Hong Zhang
Assignee: Pete Muir
Priority: Critical
Fix For: 1.0.1.CR1
I am investigating the deployment failure when running
org.jboss.jsr299.tck.tests.implementation.producer.method.definition.enterprise.EnterpriseProducerMethodDefinitionTest.
The deployment failed due to some validation failure in weld RI code. It complains that
produceLightYellowPear method of LightYellowPearTree is not declared in
LightYellowPearTree business interface. But LightYellowTree implements
LightYellowPearTreeLocal which extends from PearTreeLocal which delares the
produceLightYellowPear method.
This seems a weld RI bug to me after stepping into the RI code:
In ProducerMethod.checkProducerMethod, when it's a session bean, it will check for
its implemented interface and super class for whether they declared this business method.
But the problem is it only goes to its direct implemented interface and not the interface
hierarchy. In this case it's true that the LightYellowPearTreeLocal does not declare
this method, but PearTreeLocal which the LightYellowPearTreeLocal extends from does
declare this method. The RI code should be modified to check for the whole interface
hierarchy and not just the direct implemented interface.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:37 p.m.
New subject: [JBoss JIRA] Commented: (WELD-301) ProducerMethod.checkProducerMethod only checked method declarations in direct implemented interface and not super interfaces
[
https://jira.jboss.org/jira/browse/WELD-301?page=com.atlassian.jira.plugi...
]
Pete Muir commented on WELD-301:
--------------------------------
EjbDescriptor is a class in the Weld SPI, not in the EJB spec. The Javadoc says:
"* Gets the local business interfaces of the EJB"
This is, IMO, a clear requirement that the transitive closure of local business interfaces
must be returned, if you feel this isn't clear, I can update the Javadoc to make it
more explicit.
I believe the EJB spec requires that the entire interface hierarchy of the bean class is
considered when locating business annotated @Local or @Remote, not just the immediate
interfaces of the session bean (but I would like this clarified, I'll check with our
EJB team...). If it doesn't, this is a bug in the TCK :-/
ProducerMethod.checkProducerMethod only checked method declarations
in direct implemented interface and not super interfaces
----------------------------------------------------------------------------------------------------------------------------
Key: WELD-301
URL: https://jira.jboss.org/jira/browse/WELD-301
Project: Weld
Issue Type: Bug
Affects Versions: 1.0.0.GA
Environment: X86/Ubuntu
Reporter: Hong Zhang
Assignee: Pete Muir
Priority: Critical
Fix For: 1.0.1.CR1
I am investigating the deployment failure when running
org.jboss.jsr299.tck.tests.implementation.producer.method.definition.enterprise.EnterpriseProducerMethodDefinitionTest.
The deployment failed due to some validation failure in weld RI code. It complains that
produceLightYellowPear method of LightYellowPearTree is not declared in
LightYellowPearTree business interface. But LightYellowTree implements
LightYellowPearTreeLocal which extends from PearTreeLocal which delares the
produceLightYellowPear method.
This seems a weld RI bug to me after stepping into the RI code:
In ProducerMethod.checkProducerMethod, when it's a session bean, it will check for
its implemented interface and super class for whether they declared this business method.
But the problem is it only goes to its direct implemented interface and not the interface
hierarchy. In this case it's true that the LightYellowPearTreeLocal does not declare
this method, but PearTreeLocal which the LightYellowPearTreeLocal extends from does
declare this method. The RI code should be modified to check for the whole interface
hierarchy and not just the direct implemented interface.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:39 p.m.
New subject: [JBoss JIRA] Issue Comment Edited: (WELD-301) ProducerMethod.checkProducerMethod only checked method declarations in direct implemented interface and not super interfaces
[
https://jira.jboss.org/jira/browse/WELD-301?page=com.atlassian.jira.plugi...
]
Pete Muir edited comment on WELD-301 at 11/21/09 1:38 PM:
----------------------------------------------------------
EjbDescriptor is a class in the Weld SPI, not in the EJB spec. The Javadoc says:
"* Gets the local business interfaces of the EJB"
This is, IMO, a clear requirement that the transitive closure of local business interfaces
must be returned, if you feel this isn't clear, I can update the Javadoc to make it
more explicit.
I believe the EJB spec requires that all interfaces in the transitive closure of the bean
class type hierarchy is considered when locating business annotated @Local or @Remote, not
just the immediate interfaces of the session bean (but I would like this clarified,
I'll check with our EJB team...). If it doesn't, this is a bug in the TCK :-/
was (Author: petemuir):
EjbDescriptor is a class in the Weld SPI, not in the EJB spec. The Javadoc says:
"* Gets the local business interfaces of the EJB"
This is, IMO, a clear requirement that the transitive closure of local business interfaces
must be returned, if you feel this isn't clear, I can update the Javadoc to make it
more explicit.
I believe the EJB spec requires that the entire interface hierarchy of the bean class is
considered when locating business annotated @Local or @Remote, not just the immediate
interfaces of the session bean (but I would like this clarified, I'll check with our
EJB team...). If it doesn't, this is a bug in the TCK :-/
ProducerMethod.checkProducerMethod only checked method declarations
in direct implemented interface and not super interfaces
----------------------------------------------------------------------------------------------------------------------------
Key: WELD-301
URL: https://jira.jboss.org/jira/browse/WELD-301
Project: Weld
Issue Type: Bug
Affects Versions: 1.0.0.GA
Environment: X86/Ubuntu
Reporter: Hong Zhang
Assignee: Pete Muir
Priority: Critical
Fix For: 1.0.1.CR1
I am investigating the deployment failure when running
org.jboss.jsr299.tck.tests.implementation.producer.method.definition.enterprise.EnterpriseProducerMethodDefinitionTest.
The deployment failed due to some validation failure in weld RI code. It complains that
produceLightYellowPear method of LightYellowPearTree is not declared in
LightYellowPearTree business interface. But LightYellowTree implements
LightYellowPearTreeLocal which extends from PearTreeLocal which delares the
produceLightYellowPear method.
This seems a weld RI bug to me after stepping into the RI code:
In ProducerMethod.checkProducerMethod, when it's a session bean, it will check for
its implemented interface and super class for whether they declared this business method.
But the problem is it only goes to its direct implemented interface and not the interface
hierarchy. In this case it's true that the LightYellowPearTreeLocal does not declare
this method, but PearTreeLocal which the LightYellowPearTreeLocal extends from does
declare this method. The RI code should be modified to check for the whole interface
hierarchy and not just the direct implemented interface.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:13 p.m.
New subject: [JBoss JIRA] Commented: (WELD-301) ProducerMethod.checkProducerMethod only checked method declarations in direct implemented interface and not super interfaces
[
https://jira.jboss.org/jira/browse/WELD-301?page=com.atlassian.jira.plugi...
]
Gavin King commented on WELD-301:
---------------------------------
The spec says:
"The unrestricted set of bean types for a session bean contains all local interfaces
of the bean and their superinterfaces."
i.e. Weld should search for superinterfaces which are not themselves local interfaces.
Or am I misunderstanding the issues?
ProducerMethod.checkProducerMethod only checked method declarations
in direct implemented interface and not super interfaces
----------------------------------------------------------------------------------------------------------------------------
Key: WELD-301
URL: https://jira.jboss.org/jira/browse/WELD-301
Project: Weld
Issue Type: Bug
Affects Versions: 1.0.0.GA
Environment: X86/Ubuntu
Reporter: Hong Zhang
Assignee: Pete Muir
Priority: Critical
Fix For: 1.0.1.CR1
I am investigating the deployment failure when running
org.jboss.jsr299.tck.tests.implementation.producer.method.definition.enterprise.EnterpriseProducerMethodDefinitionTest.
The deployment failed due to some validation failure in weld RI code. It complains that
produceLightYellowPear method of LightYellowPearTree is not declared in
LightYellowPearTree business interface. But LightYellowTree implements
LightYellowPearTreeLocal which extends from PearTreeLocal which delares the
produceLightYellowPear method.
This seems a weld RI bug to me after stepping into the RI code:
In ProducerMethod.checkProducerMethod, when it's a session bean, it will check for
its implemented interface and super class for whether they declared this business method.
But the problem is it only goes to its direct implemented interface and not the interface
hierarchy. In this case it's true that the LightYellowPearTreeLocal does not declare
this method, but PearTreeLocal which the LightYellowPearTreeLocal extends from does
declare this method. The RI code should be modified to check for the whole interface
hierarchy and not just the direct implemented interface.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:13 p.m.
New subject: [JBoss JIRA] Commented: (WELD-301) ProducerMethod.checkProducerMethod only checked method declarations in direct implemented interface and not super interfaces
[
https://jira.jboss.org/jira/browse/WELD-301?page=com.atlassian.jira.plugi...
]
Gavin King commented on WELD-301:
---------------------------------
""Gets the local business interfaces of the EJB"
This is, IMO, a clear requirement that the transitive closure of local business interfaces
must be returned, if you feel this isn't clear, I can update the Javadoc to make it
more explicit. "
I don't read it that way, Pete. AFAIK, the EJB spec doesn't define a supertype of
a local interface to be a local interface.
So I think Weld is wrong and GlassFish is right.
ProducerMethod.checkProducerMethod only checked method declarations
in direct implemented interface and not super interfaces
----------------------------------------------------------------------------------------------------------------------------
Key: WELD-301
URL: https://jira.jboss.org/jira/browse/WELD-301
Project: Weld
Issue Type: Bug
Affects Versions: 1.0.0.GA
Environment: X86/Ubuntu
Reporter: Hong Zhang
Assignee: Pete Muir
Priority: Critical
Fix For: 1.0.1.CR1
I am investigating the deployment failure when running
org.jboss.jsr299.tck.tests.implementation.producer.method.definition.enterprise.EnterpriseProducerMethodDefinitionTest.
The deployment failed due to some validation failure in weld RI code. It complains that
produceLightYellowPear method of LightYellowPearTree is not declared in
LightYellowPearTree business interface. But LightYellowTree implements
LightYellowPearTreeLocal which extends from PearTreeLocal which delares the
produceLightYellowPear method.
This seems a weld RI bug to me after stepping into the RI code:
In ProducerMethod.checkProducerMethod, when it's a session bean, it will check for
its implemented interface and super class for whether they declared this business method.
But the problem is it only goes to its direct implemented interface and not the interface
hierarchy. In this case it's true that the LightYellowPearTreeLocal does not declare
this method, but PearTreeLocal which the LightYellowPearTreeLocal extends from does
declare this method. The RI code should be modified to check for the whole interface
hierarchy and not just the direct implemented interface.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7 a.m.
New subject: [JBoss JIRA] Commented: (WELD-301) ProducerMethod.checkProducerMethod only checked method declarations in direct implemented interface and not super interfaces
[
https://jira.jboss.org/jira/browse/WELD-301?page=com.atlassian.jira.plugi...
]
Pete Muir commented on WELD-301:
--------------------------------
I am still surprised that EJB (or at lest the GlassFish implementation) doesn't
traverse the interface hierarchy looking for the @Local interface. Gavin, what do you
think the local business interfaces (as defined by the EJB spec) of this should be?
@Stateful
public class LightYellowPearTree extends YellowPearTree implements
LightYellowPearTreeLocal { // body ommitted}
class YellowPearTree extends PearTree { // body ommitted }
@Stateful
public class PearTree implements PearTreeLocal { // body omitted }
@Local
public interface LightYellowPearTreeLocal extends PearTreeLocal {// body omitted }
@Local
public interface PearTreeLocal { // body ommitted }
GlassFish currently only provides one EJB local business interface
(LightYellowPearTreeLocal) whilst JBoss AS gives us both. I would *expect* EJB to see both
PearTreeLocal and LightYellowPearTreeLocal as local business interfaces, given both are
annotated @Local and both appear in the class hierarchy (though PearTreeLocal isn't
directly extending/implementing)
ProducerMethod.checkProducerMethod only checked method declarations
in direct implemented interface and not super interfaces
----------------------------------------------------------------------------------------------------------------------------
Key: WELD-301
URL: https://jira.jboss.org/jira/browse/WELD-301
Project: Weld
Issue Type: Bug
Affects Versions: 1.0.0.GA
Environment: X86/Ubuntu
Reporter: Hong Zhang
Assignee: Pete Muir
Priority: Critical
Fix For: 1.0.1.CR1
I am investigating the deployment failure when running
org.jboss.jsr299.tck.tests.implementation.producer.method.definition.enterprise.EnterpriseProducerMethodDefinitionTest.
The deployment failed due to some validation failure in weld RI code. It complains that
produceLightYellowPear method of LightYellowPearTree is not declared in
LightYellowPearTree business interface. But LightYellowTree implements
LightYellowPearTreeLocal which extends from PearTreeLocal which delares the
produceLightYellowPear method.
This seems a weld RI bug to me after stepping into the RI code:
In ProducerMethod.checkProducerMethod, when it's a session bean, it will check for
its implemented interface and super class for whether they declared this business method.
But the problem is it only goes to its direct implemented interface and not the interface
hierarchy. In this case it's true that the LightYellowPearTreeLocal does not declare
this method, but PearTreeLocal which the LightYellowPearTreeLocal extends from does
declare this method. The RI code should be modified to check for the whole interface
hierarchy and not just the direct implemented interface.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7 a.m.
New subject: [JBoss JIRA] Commented: (WELD-301) ProducerMethod.checkProducerMethod only checked method declarations in direct implemented interface and not super interfaces
[
https://jira.jboss.org/jira/browse/WELD-301?page=com.atlassian.jira.plugi...
]
Pete Muir commented on WELD-301:
--------------------------------
Gavin, thanks, I had missed that bit of the 299 spec, I will fix that in Weld (NB this is
a slightly different issue than the original one reported).
ProducerMethod.checkProducerMethod only checked method declarations
in direct implemented interface and not super interfaces
----------------------------------------------------------------------------------------------------------------------------
Key: WELD-301
URL: https://jira.jboss.org/jira/browse/WELD-301
Project: Weld
Issue Type: Bug
Affects Versions: 1.0.0.GA
Environment: X86/Ubuntu
Reporter: Hong Zhang
Assignee: Pete Muir
Priority: Critical
Fix For: 1.0.1.CR1
I am investigating the deployment failure when running
org.jboss.jsr299.tck.tests.implementation.producer.method.definition.enterprise.EnterpriseProducerMethodDefinitionTest.
The deployment failed due to some validation failure in weld RI code. It complains that
produceLightYellowPear method of LightYellowPearTree is not declared in
LightYellowPearTree business interface. But LightYellowTree implements
LightYellowPearTreeLocal which extends from PearTreeLocal which delares the
produceLightYellowPear method.
This seems a weld RI bug to me after stepping into the RI code:
In ProducerMethod.checkProducerMethod, when it's a session bean, it will check for
its implemented interface and super class for whether they declared this business method.
But the problem is it only goes to its direct implemented interface and not the interface
hierarchy. In this case it's true that the LightYellowPearTreeLocal does not declare
this method, but PearTreeLocal which the LightYellowPearTreeLocal extends from does
declare this method. The RI code should be modified to check for the whole interface
hierarchy and not just the direct implemented interface.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:44 a.m.
New subject: [JBoss JIRA] Commented: (WELD-301) ProducerMethod.checkProducerMethod only checked method declarations in direct implemented interface and not super interfaces
[
https://jira.jboss.org/jira/browse/WELD-301?page=com.atlassian.jira.plugi...
]
Carlo de Wolf commented on WELD-301:
------------------------------------
EJB 3.1 FR 4.9.7 bullet 3:
• The interface is allowed to have superinterfaces.
EJB 3.1 FR 4.9.7 bullet 5.2:
• A bean class is permitted to have more than one interface. If a bean class has more
than one interface—excluding the interfaces listed below—any business interface of
the bean class must be explicitly designated as a business interface of the bean by
means of the Local or Remote annotation on the bean class or interface or in the
deployment descriptor.
Since both interfaces are annotated with @Local I would consider both interfaces to be
valid local business interfaces.
ProducerMethod.checkProducerMethod only checked method declarations
in direct implemented interface and not super interfaces
----------------------------------------------------------------------------------------------------------------------------
Key: WELD-301
URL: https://jira.jboss.org/jira/browse/WELD-301
Project: Weld
Issue Type: Bug
Affects Versions: 1.0.0.GA
Environment: X86/Ubuntu
Reporter: Hong Zhang
Assignee: Pete Muir
Priority: Critical
Fix For: 1.0.1.CR1
I am investigating the deployment failure when running
org.jboss.jsr299.tck.tests.implementation.producer.method.definition.enterprise.EnterpriseProducerMethodDefinitionTest.
The deployment failed due to some validation failure in weld RI code. It complains that
produceLightYellowPear method of LightYellowPearTree is not declared in
LightYellowPearTree business interface. But LightYellowTree implements
LightYellowPearTreeLocal which extends from PearTreeLocal which delares the
produceLightYellowPear method.
This seems a weld RI bug to me after stepping into the RI code:
In ProducerMethod.checkProducerMethod, when it's a session bean, it will check for
its implemented interface and super class for whether they declared this business method.
But the problem is it only goes to its direct implemented interface and not the interface
hierarchy. In this case it's true that the LightYellowPearTreeLocal does not declare
this method, but PearTreeLocal which the LightYellowPearTreeLocal extends from does
declare this method. The RI code should be modified to check for the whole interface
hierarchy and not just the direct implemented interface.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:12 a.m.
New subject: [JBoss JIRA] Closed: (WELD-301) ProducerMethod.checkProducerMethod only checked method declarations in direct implemented interface and not super interfaces
[
https://jira.jboss.org/jira/browse/WELD-301?page=com.atlassian.jira.plugi...
]
Pete Muir closed WELD-301.
--------------------------
Resolution: Partially Completed
I've spun the issue Gavin raised out into WELD-305, marking this as partially
completed, as there is a bug in GlassFish as well, not considering super-interfaces marked
@Local as local business interfaces (at least when this info is passed to Weld).
ProducerMethod.checkProducerMethod only checked method declarations
in direct implemented interface and not super interfaces
----------------------------------------------------------------------------------------------------------------------------
Key: WELD-301
URL: https://jira.jboss.org/jira/browse/WELD-301
Project: Weld
Issue Type: Bug
Affects Versions: 1.0.0.GA
Environment: X86/Ubuntu
Reporter: Hong Zhang
Assignee: Pete Muir
Priority: Critical
Fix For: 1.0.1.CR1
I am investigating the deployment failure when running
org.jboss.jsr299.tck.tests.implementation.producer.method.definition.enterprise.EnterpriseProducerMethodDefinitionTest.
The deployment failed due to some validation failure in weld RI code. It complains that
produceLightYellowPear method of LightYellowPearTree is not declared in
LightYellowPearTree business interface. But LightYellowTree implements
LightYellowPearTreeLocal which extends from PearTreeLocal which delares the
produceLightYellowPear method.
This seems a weld RI bug to me after stepping into the RI code:
In ProducerMethod.checkProducerMethod, when it's a session bean, it will check for
its implemented interface and super class for whether they declared this business method.
But the problem is it only goes to its direct implemented interface and not the interface
hierarchy. In this case it's true that the LightYellowPearTreeLocal does not declare
this method, but PearTreeLocal which the LightYellowPearTreeLocal extends from does
declare this method. The RI code should be modified to check for the whole interface
hierarchy and not just the direct implemented interface.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:33 a.m.
New subject: [JBoss JIRA] Commented: (WELD-301) ProducerMethod.checkProducerMethod only checked method declarations in direct implemented interface and not super interfaces
[
https://jira.jboss.org/jira/browse/WELD-301?page=com.atlassian.jira.plugi...
]
Hong Zhang commented on WELD-301:
---------------------------------
I have filed a glassfish issue on this and assigned to ejb team to investigate.
https://glassfish.dev.java.net/issues/show_bug.cgi?id=11140
If ejb team agrees this is a glassfish bug, I think we should also modify the javadoc of
this SPI so it's clear what the expected behavior is.
ProducerMethod.checkProducerMethod only checked method declarations
in direct implemented interface and not super interfaces
----------------------------------------------------------------------------------------------------------------------------
Key: WELD-301
URL: https://jira.jboss.org/jira/browse/WELD-301
Project: Weld
Issue Type: Bug
Affects Versions: 1.0.0.GA
Environment: X86/Ubuntu
Reporter: Hong Zhang
Assignee: Pete Muir
Priority: Critical
Fix For: 1.0.1.CR1
I am investigating the deployment failure when running
org.jboss.jsr299.tck.tests.implementation.producer.method.definition.enterprise.EnterpriseProducerMethodDefinitionTest.
The deployment failed due to some validation failure in weld RI code. It complains that
produceLightYellowPear method of LightYellowPearTree is not declared in
LightYellowPearTree business interface. But LightYellowTree implements
LightYellowPearTreeLocal which extends from PearTreeLocal which delares the
produceLightYellowPear method.
This seems a weld RI bug to me after stepping into the RI code:
In ProducerMethod.checkProducerMethod, when it's a session bean, it will check for
its implemented interface and super class for whether they declared this business method.
But the problem is it only goes to its direct implemented interface and not the interface
hierarchy. In this case it's true that the LightYellowPearTreeLocal does not declare
this method, but PearTreeLocal which the LightYellowPearTreeLocal extends from does
declare this method. The RI code should be modified to check for the whole interface
hierarchy and not just the direct implemented interface.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5486
days inactive
5489
days old
15 comments
4 participants
participants (4)
-
Carlo de Wolf (JIRA) -
Gavin King (JIRA)
-
Hong Zhang (JIRA)
-
Pete Muir (JIRA)