[ https://jira.jboss.org/browse/WELD-674?page=com.atlassian.jira.plugin.sys... ] Davide Malpassini commented on WELD-674: ---------------------------------------- I'm adding th file to enable the integration. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/WELD-674?page=com.atlassian.jira.plugin.sys... ] Pete Muir commented on WELD-674: -------------------------------- If you can take a fork of weld on github, apply your changes, and link a pull request here, that will mean I can apply it straight away... Can you sign a contributor agreement at http://cla.jboss.org as well? Thanks. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/WELD-674?page=com.atlassian.jira.plugin.sys... ] Davide Malpassini edited comment on WELD-674 at 9/8/10 9:53 PM: ---------------------------------------------------------------- I have done . I think that i have done a pull request. If not i will retry Thanks was (Author: psini82): I have done . The pull request i think is http://github.com/weld/core/pull/7 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/WELD-674?page=com.atlassian.jira.plugin.sys... ] Pete Muir commented on WELD-674: -------------------------------- I have reviewed your changes, and made some subsequent fixes. In the future please make an attempt to make your changes tidier. Specifically, your whitespace was way outside of guidelines (http://seamframework.org/Weld/GuidelinesForWeldDevelopment), none of the javadoc was updated, the exception messages referred to the code you had copied, not your new code. Also, you may want to look at merging commits in git to produce a tidier change log. Otherwise, looks good. I've pushed your changes despite lack of tests, as this is new area for us -- if you have some time maybe you could look at WELD-691 and add a new module which can run the tests in Tomcat 7? Thanks again! -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/browse/WELD-674?page=com.atlassian.jira.plugin.sys... ] Pete Muir closed WELD-674. -------------------------- -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira