Configure vert.x in WildFly
by Kabir Khan
Hi,
At the moment the SmallRye/MP Reactive Messaging integration just uses a
default created vert.x.
I think otel uses vert.x too, probably in much the same way? Then there
might be other subsystems in various feature packs.
It seems there is some desire to be able to configure the vert.x instance
https://github.com/smallrye/smallrye-reactive-messaging/discussions/2725.
Being able to configure vert.x is TBH something I've totally ignored.
I guess this would mean a Vert.X subsystem, which can optionally create a
vert.x instance with the configured parameters. Does it make sense to
create more than one instance in case subsystems have slightly different
needs?
Then the reactive messaging subsystem can use that, if present (or perhaps
this should be a configuration parameter in the reactive messaging
subsystem). If not (or not configured to do so), it will use the default
like it does today.
Thanks,
Kabir
1 day, 8 hours
WildFly Cloud Tests
by Kabir Khan
Hi,
These tests need some modernisation, and there are two things in my opinion
that need addressing.
*1 Space issues*
Recently we were running out of space when running these tests. James fixed
this by deleting the built WildFly, but when trying to resurrect an old PR
I had forgotten all about, we ran out of space again.
I believe the issue is that the way the tests work at the moment, which is
to:
* Start minikube with the registry
* Build all the test images
* Run all the tests
Essentially we end up building all the server images (different layers)
before running the tests, which takes space, and then each test installs
the image into minikube's registry. Also, some tests also install other
images (e.g postgres, strimzi) into the minikube instance.
My initial thought was that it would be good to build the server images
more on demand, rather than before the tests, and to be able to call
'docker system prune' now and again.
However, this does not take into account the minikube registry, which will
also accumulate a lot of images. It will at least become populated with the
test images, I am unsure if it also becomes populated with the images
pulled from elsewhere (i.e. postgres, strimzi etc)?
If `minikube addons disable registry` followed by a 'minikube addons enable
registry' deletes the registry contents from the disk, having a hook to do
that between each test could be something easy to look into. Does anyone
know if this is the case?
An alternative could be to have one job building wildfly, and uploading the
maven repository as an artifact, and then have separate jobs to run each
test (or perhaps set of tests requiring the same WildFly server image).
However, as this test is quite fiddly since it runs remotely, I'm not sure
how the reporting would look.
*2 Pull request trigger*
PRs in wildfly/wildfly execute a remote dispatch which results in the job
getting run in the wildfly-extras/wildfly-cloud-tests repository.
There is no reporting back from the wildfly-extras/wildfly-cloud-tests
repository about the run id of the resulting run.
What I did when I implemented this was to have the calling wildfly/wildfly
job wait and poll a branch in wildfly-extras/wildfly-cloud-tests for the
results of the job (IIRC I have a file with the triggering PR number). The
job on the other side would then write to this branch once the job is done.
Which is all quite ugly!
However, playing in other repositories, I found
https://www.kenmuse.com/blog/creating-github-checks/. Basically this would
result in
* the WIldFly pull request trigger completing immediately once it has done
the remote dispatch
* When the wildfly-cloud-tests job starts it will do a remote dispatch to
wildfly, which will get picked up by a workflow which can add a status
check on the PR conversation page saying remote testing in
wildfly-cloud-tests is in progres
* Once the wildfly-cloud-tests job is done, it will do another remote
dispatch to wildfly, which will update the status check with success/failure
So we'd have two checks in the section rather than the current one.
*Other ideas*
While writing the above, the following occurred to me.
The reason for the split is that the cloud test framework is quite
involved, and IMO does not belong in WildFly. So the remote dispatch
approach was used.
However, I wonder now if a saner approach would be to update the
wildfly-cloud-tests workflow to be reusable so they can be used from
WildFly?
That would allow the tests, test framework etc., and the workflow to
continue to live in wildfly-cloud-tests, while running in wildfly itself.
That should get rid of the remote dispatch issues, and make that side of
things simpler.
It does not address the space issue, but I think if this approach works, it
will be easier to deal with the space issue.
Any thoughts/insights are welcome.
Thanks,
Kabir
3 weeks, 2 days
Re: Vulnerabilities in wildfly version 32.0.1.Final
by Pawan Verma
I used WildFly 33.0.1.Final assuming in one of our application and hoping that High vulnerability in undertow-core will be rectified.
But there is still High vulnerability in undertow-core-2.3.15.Final.jar (CVE-2024-7885).
Is it going to be rectified sooner?
Thanks,
Pawan
2 months
'Critical' JIRA cleanup
by Brian Stansberry
We've got a lot ofJIRAs with 'Critical' priority that have been inactive
for a long time. I think we should define 'Critical' as roughly "important
enough that we need to work on it soon." At some point if something goes
unaddressed long enough that's a sign that it's not important enough to be
called critical.
I propose doing the following: for any Critical WFLY or WFCORE that was
opened > 12 months ago and hasn't shown signs of activity since the WF 32
release, I'll leave a comment saying I plan to downgrade it to Major unless
the assignee says they plan to deal with it for the WF 34 cycle. And then a
couple weeks later downgrade issues.
Similarly, for issues with Fix Version 33.0.0.Final that have been rolling
from release to release since WF 31 or earlier, when I release 33 I intend
to remove the Fix Version instead of rolling it to 34.
WDYT?
Best regards,
--
Brian Stansberry
Principal Architect, Red Hat JBoss EAP
WildFly Project Lead
He/Him/His
2 months, 1 week
