Re: [wildfly-dev] Policies for merging PRs on master

On Thu, Nov 30, 2017 at 5:50 PM, Alessio Soldano <asoldano(a)redhat.com&gt; wrote: > As suggested by Brian, I'd like to draw attention to the discussion on > https://github.com/wildfly/wildfly/pull/10604 . > The PR is an upgrade of the webservices stack, including JBossWS, Apache > CXF, JAXB-RI and JAXB API. In particular, the JAXB upgrade is for EE8 and > better JDK 9 compatibility. > Now, due to the upgrade of the JAXB API spec jar, the PR is essentially > stalled since 20 days; the new spec is released as an alpha (as it's been > tested within JBossWS only) and that does not satisfy a rule that requires > any artifact being pulled to be Final. > We're talking about a spec jar, we could simply re-tag that as Final, > chances are we won't need changes any time soon there anyway, but as Tomaz > pointed out, in principle that would be dishonest. My opinion is that you should go ahead and make a .Final tag. In the (unlikely?) event that the spec has to be modified for some reason, I think you could make a 1.0.1.Final tag and call it a "bug fix". The alternative is to simply wait. I don't think there is any middle position. > While I see the point in requiring that only sufficiently stable upgrades > are applied to the codebase, I'm wondering whether, maybe, we're going a bit > too far with the rules. Brian wrote on this topic: "how to determine that > something is good enough to go in without using master as a test bed" ? I don't think we are; I agree with the policy as it stands. If you look at it in terms of being able to release at any time, then it follows that everything _must_ be stable. -- - DML