11:43 a.m.
On 8/14/2013 3:08 PM, Farah Juma wrote:
Hi,
I recently worked on CDI and Bean Validation integration for method validation
(WFLY-529). As described in [1], part of this work involved replacing the delegate of the
EE LazyValidatorFactory with a CDI-enabled ValidatorFactory. However, JCA and JPA still
currently use copied versions of the old EE LazyValidatorFactory. Since JCA and JPA should
also have access to the CDI-enabled ValidatorFactory, it would be good if we could remove
the copies (i.e., remove JCAValidatorFactory and JPALazyValidatorFactory) and use the
current EE LazyValidatorFactory directly instead. As discussed with Scott Marlow, for JPA,
it looks like we can access the EE LazyValidatorFactory from the deployment unit
attachment (i.e., via
deploymentUnit.getAttachment(BeanValidationAttachments.VALIDATOR_FACTORY)), as described
in WFLY-1705 [2]. However, for JCA, it doesn't seem like this will be possible since
the code that currently instantiates the JCAValidatorFactory doesn't have access to
the deploymen!
tUnit (and it seems like there isn't a way to modify the code to be able to access
this). Another option might be to register the ValidatorFactory as a service and then
perform a manual lookup on the service.
I was wondering if anyone had any thoughts about what approach to take for JCA or how to
go about removing the JCAValidatorFactory. I've created WFLY-1882 [3] to track this.
In addition to JCA and JPA, we'll need to consider what should be done for JSF since
it will also need to be able to access the CDI-enabled ValidatorFactory. Note that JSF
doesn't use a copy of the EE LazyValidatorFactory and so it seems to be bootstrapping
Bean Validation in another way.
Farah,
JSF bootstraps Bean Validation as per JSF spec section 3.5.6.2:
/The Bean Validation ValidatorFactory is the main entry point into
Bean Validation and is responsible for creating//
//Validator instances. [P1-start-validatoryfactory]A
ValidatorFactory is retrieved using the following algorithm://
//If the servlet context contains a ValidatorFactory instance under
the attribute named//
//javax.faces.validator.beanValidator.ValidatorFactory, this
instance is used by JSF to acquire Validator instances//
//(specifically in the BeanValidator). This key should be defined in
the constant named VALIDATOR_FACTORY_KEY//
//on BeanValidator.//
//If the servlet context does not contain such an entry, JSF looks
for a Bean Validation provider in the classpath. If//
//present, the standard Bean Validation bootstrap strategy is used.
If not present, Bean Validation integration is//
//disabled.//
/
In our case, we use the second method, which is to simply place the Bean
Validation provider in the classpath. For every deployment that uses
JSF, the JSF subsystem will add the org.hibernate.validator module to
the deployment.
[1]
https://issues.jboss.org/browse/WFLY-529?focusedCommentId=12787076&pa...
[2] https://issues.jboss.org/browse/WFLY-1705
[3] https://issues.jboss.org/browse/WFLY-1882
Thanks,
Farah
_______________________________________________
wildfly-dev mailing list
wildfly-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/wildfly-dev