Hi, I'm looking at contributing a fix to WildFly. I'm looking at bug WFLY-2205 that prints a deployment's name as null when it's deployed and undeployed. For deploment: 21:16:30,975 INFO [org.jboss.as.server.deployment] (MSC service thread 1-9) JBAS015876: Starting deployment of "EnterpriseApplication1.ear" (runtime-name: "EnterpriseApplication1.ear") 21:16:31,041 INFO [org.jboss.as.server.deployment] (MSC service thread 1-6) JBAS015876: Starting deployment of "null" (runtime-name: "EnterpriseApplication1-war.war") 21:16:31,146 INFO [org.wildfly.extension.undertow] (MSC service thread 1-15) JBAS017534: Registered web context: /EnterpriseApplication1-war 21:16:31,377 INFO [org.jboss.as.server] (DeploymentScanner-threads - 1) JBAS018559: Deployed "EnterpriseApplication1.ear" (runtime-name : "EnterpriseApplication1.ear") For undeployment: 21:16:00,660 INFO [org.jboss.as.server.deployment] (MSC service thread 1-5) JBAS015877: Stopped deployment null (runtime-name: EnterpriseApplication1-war.war) in 58ms 21:16:00,669 INFO [org.jboss.as.server.deployment] (MSC service thread 1-12) JBAS015877: Stopped deployment EnterpriseApplication1.ear (runtime-name: EnterpriseApplication1.ear) in 69ms 21:16:00,886 INFO [org.jboss.as.server] (DeploymentScanner-threads - 1) JBAS018558: Undeployed "EnterpriseApplication1.ear" (runtime-name: "EnterpriseApplication1.ear") I've traced the bug to the SubDeploymentUnitService not having a MANAGEMENT_NAME like the RootDeploymentUnitService has (hence the correct message is displayed when deploying an .ear file, but not on it's enclosed .war file). My question is what should be done to fix this? Should it log just the runtime name and if there is no management name log an empty string instead of null? Thanks, David. _______________________________________________ wildfly-dev mailing list wildfly-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/wildfly-dev

Hi Brian. That makes sense. I've submitted a pull request. Hope that's OK.

Thanks, David. -----Original Message----- From: wildfly-dev-bounces(a)lists.jboss.org [mailto:wildfly-dev-bounces@lists.jboss.org] On Behalf Of Brian Stansberry Sent: 28 February 2014 03:22 To: wildfly-dev(a)lists.jboss.org Subject: Re: [wildfly-dev] Undeployment printing null Thanks for looking into this. I think it should use different messages if deploymentUnit.getParent() != null. "Starting subdeployment (runtime-name: "EnterpriseApplication1-war.war")" "Stopped subdeployment (runtime-name: msginflow1_mdb_msginflow_ejb.jar) in 16ms" On 2/27/14, 3:31 PM, David Salter wrote: > Hi, > > I'm looking at contributing a fix to WildFly. > > I'm looking at bug WFLY-2205 that prints a deployment's name as null > when it's deployed and undeployed. > > For deploment: > 21:16:30,975 INFO [org.jboss.as.server.deployment] (MSC service > thread > 1-9) JBAS015876: Starting deployment of "EnterpriseApplication1.ear" > (runtime-name: "EnterpriseApplication1.ear") > 21:16:31,041 INFO [org.jboss.as.server.deployment] (MSC service > thread > 1-6) JBAS015876: Starting deployment of "null" (runtime-name: > "EnterpriseApplication1-war.war") > 21:16:31,146 INFO [org.wildfly.extension.undertow] (MSC service > thread > 1-15) JBAS017534: Registered web context: /EnterpriseApplication1-war > 21:16:31,377 INFO [org.jboss.as.server] (DeploymentScanner-threads - > 1) > JBAS018559: Deployed "EnterpriseApplication1.ear" (runtime-name : > "EnterpriseApplication1.ear") > > For undeployment: > 21:16:00,660 INFO [org.jboss.as.server.deployment] (MSC service > thread > 1-5) JBAS015877: Stopped deployment null (runtime-name: > EnterpriseApplication1-war.war) in 58ms > 21:16:00,669 INFO [org.jboss.as.server.deployment] (MSC service > thread > 1-12) JBAS015877: Stopped deployment EnterpriseApplication1.ear > (runtime-name: EnterpriseApplication1.ear) in 69ms > 21:16:00,886 INFO [org.jboss.as.server] (DeploymentScanner-threads - > 1) > JBAS018558: Undeployed "EnterpriseApplication1.ear" (runtime-name: > "EnterpriseApplication1.ear") > > I've traced the bug to the SubDeploymentUnitService not having a > MANAGEMENT_NAME like the RootDeploymentUnitService has (hence the > correct message is displayed when deploying an .ear file, but not on > it's enclosed .war file). > > My question is what should be done to fix this? Should it log just > the runtime name and if there is no management name log an empty > string instead of null? > > Thanks, > > David. > > > _______________________________________________ > wildfly-dev mailing list > wildfly-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/wildfly-dev > -- Brian Stansberry Senior Principal Software Engineer JBoss by Red Hat _______________________________________________ wildfly-dev mailing list wildfly-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/wildfly-dev _______________________________________________ wildfly-dev mailing list wildfly-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/wildfly-dev