Hi, to better understand subsystem api, I am changing the WS subsystem to use the PersistentResourceXMLDescription, more in line with the other subsystem api. There are some wsdl settings, they are xml elements. <subsystem xmlns="urn:jboss:domain:webservices:2.0"> <modify-wsdl-address>${ws.modify-wsdl-address:true}</modify-wsdl-address> <wsdl-host>${jboss.bind.address:localhost}</wsdl-host> <wsdl-port>${ws.wsdl-port:9090}</wsdl-port> <wsdl-secure-port>${ws.wsdl-secure-port:9443}</wsdl-secure-port> <wsdl-uri-scheme>https</wsdl-uri-scheme> <wsdl-path-rewrite-rule>s/jaxws-jbws2150-codefirst/xx\/jaxws-jbws2150-codefirst/g</wsdl-path-rewrite-rule> What do you think of those settings as attributes ? <subsystem xmlns="urn:jboss:domain:webservices:2.0"> <wsdl-settings modify-wsdl-address="${ws.modify-wsdl-address:true}" wsdl-host="${jboss.bind.address:localhost}" wsdl-port="${ws.wsdl-port:9090}" wsdl-secure-port="${ws.wsdl-secure-port:9443}" wsdl-uri-scheme="https" wsdl-path-rewrite-rule="s/jaxws-jbws2150-codefirst/xx\/jaxws-jbws2150-codefirst/g"/> Later I can submit it for review if is of interest. Kind regards -- Claudio Miranda claudio(a)claudius.com.br http://www.claudius.com.br _______________________________________________ wildfly-dev mailing list wildfly-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/wildfly-dev

On 12/8/14, 8:09 AM, Claudio Miranda wrote: > > Later I can submit it for review if is of interest. Look for a response from Alessio Soldano as I'd ask him to approve the PR anyway. I definitely prefer attributes to text elements.

My understanding was this was the xml only. For the resource model (which I have not checked to see what is there), be careful restructuring that, since transformation to the legacy models is hard.

There are two proposed changes: 1. change subsystem implementation to use PersistentResourceXMLDescription 2. modify subsystem xml, the wsdl elements to attributes. On Tue, Dec 9, 2014 at 9:07 AM, Alessio Soldano <asoldano(a)redhat.com&gt; wrote: > Frankly, I don't see any immediate benefit from these changes (perhaps the model would look a bit > clearer to the final user?), while it looks like we might get some in the future. It brings no immediate benefit for users. I saw other subsystem implementation (mail, undertow) uses PersistentResourceXMLDescription and attributes, so I thought it would be a good idea to (kind of) "modernize" webservices subsystem. This is much more a personal exercise for me to better understand subsystem implementation, if it doesn't fail the tests, would be good to PR it.