9:58 a.m.
CDI facet should add cdi-api to maven dependencies
---------------------------------------------------
Key: SEAMFORGE-97
URL: https://issues.jboss.org/browse/SEAMFORGE-97
Project: Seam Forge
Issue Type: Enhancement
Components: Builtin Plugins
Reporter: Paul Bakker
After adding CDI it should be possible to use @Inject etc. in code, but the dependencies
are not added to the project.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
11:54 a.m.
New subject: [JBoss JIRA] Updated: (SEAMFORGE-97) CDI facet should add cdi-api to maven dependencies
[
https://issues.jboss.org/browse/SEAMFORGE-97?page=com.atlassian.jira.plug...
]
Paul Bakker updated SEAMFORGE-97:
---------------------------------
Status: Pull Request Sent (was: Open)
Git Pull Request: https://github.com/seam/forge/pull/7
CDI facet should add cdi-api to maven dependencies
---------------------------------------------------
Key: SEAMFORGE-97
URL: https://issues.jboss.org/browse/SEAMFORGE-97
Project: Seam Forge
Issue Type: Enhancement
Components: Builtin Plugins
Reporter: Paul Bakker
After adding CDI it should be possible to use @Inject etc. in code, but the dependencies
are not added to the project.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
12:10 p.m.
New subject: [JBoss JIRA] Commented: (SEAMFORGE-97) CDI facet should add cdi-api to maven dependencies
[
https://issues.jboss.org/browse/SEAMFORGE-97?page=com.atlassian.jira.plug...
]
Paul Bakker commented on SEAMFORGE-97:
--------------------------------------
I've implemented this and did a pull request.
CDI facet should add cdi-api to maven dependencies
---------------------------------------------------
Key: SEAMFORGE-97
URL: https://issues.jboss.org/browse/SEAMFORGE-97
Project: Seam Forge
Issue Type: Enhancement
Components: Builtin Plugins
Reporter: Paul Bakker
After adding CDI it should be possible to use @Inject etc. in code, but the dependencies
are not added to the project.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:59 a.m.
New subject: [JBoss JIRA] Commented: (SEAMFORGE-97) CDI facet should add cdi-api to maven dependencies
[
https://issues.jboss.org/browse/SEAMFORGE-97?page=com.atlassian.jira.plug...
]
Lincoln Baxter III commented on SEAMFORGE-97:
---------------------------------------------
Actually. I'm not sure this should actually take care of adding the dependencies. I
think that might better be a role of the "beans" plugin.
Since CDI defines a beans archive as an archive containing beans.xml, it would be
potentially harmful to force people to include the CDI api, unless marked as provided
scope in the POM.
I might be in agreement with this, but I think we need to make sure that transitive
(parent) dependencies are taken into account here. Also, users probably don't want to
care which version of the CDI api to include... that could get complicated, but we could
always default to the most recent and mark as provided, which should prevent issues. I
think that's probably the way to go.
CDI facet should add cdi-api to maven dependencies
---------------------------------------------------
Key: SEAMFORGE-97
URL: https://issues.jboss.org/browse/SEAMFORGE-97
Project: Seam Forge
Issue Type: Enhancement
Components: Builtin Plugins
Reporter: Paul Bakker
After adding CDI it should be possible to use @Inject etc. in code, but the dependencies
are not added to the project.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:20 a.m.
New subject: [JBoss JIRA] Commented: (SEAMFORGE-97) CDI facet should add cdi-api to maven dependencies
[
https://issues.jboss.org/browse/SEAMFORGE-97?page=com.atlassian.jira.plug...
]
Paul Bakker commented on SEAMFORGE-97:
--------------------------------------
I agree that it would be best to add it as provided. Do you change that when pulling, or
should I change and commit it?
CDI facet should add cdi-api to maven dependencies
---------------------------------------------------
Key: SEAMFORGE-97
URL: https://issues.jboss.org/browse/SEAMFORGE-97
Project: Seam Forge
Issue Type: Enhancement
Components: Builtin Plugins
Reporter: Paul Bakker
After adding CDI it should be possible to use @Inject etc. in code, but the dependencies
are not added to the project.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:38 p.m.
New subject: [JBoss JIRA] Commented: (SEAMFORGE-97) CDI facet should add cdi-api to maven dependencies
[
https://issues.jboss.org/browse/SEAMFORGE-97?page=com.atlassian.jira.plug...
]
Lincoln Baxter III commented on SEAMFORGE-97:
---------------------------------------------
Actually. I don't think this should be part of the Facet. This should be in the
BeansPlugin.setup() method, not the CDIFacet itself. The facet represents when CDI is
installed, you do not need the dependency in order to enable CDI in a project. Let's
implement that instead.
Let's also do a new pull request for this.
CDI facet should add cdi-api to maven dependencies
---------------------------------------------------
Key: SEAMFORGE-97
URL: https://issues.jboss.org/browse/SEAMFORGE-97
Project: Seam Forge
Issue Type: Enhancement
Components: Builtin Plugins
Reporter: Paul Bakker
After adding CDI it should be possible to use @Inject etc. in code, but the dependencies
are not added to the project.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:21 p.m.
New subject: [JBoss JIRA] Commented: (SEAMFORGE-97) CDI facet should add cdi-api to maven dependencies
[
https://issues.jboss.org/browse/SEAMFORGE-97?page=com.atlassian.jira.plug...
]
Paul Bakker commented on SEAMFORGE-97:
--------------------------------------
Now I know a little more about Forge I see you're right. I'll extend it a bit too
when I make the changes:
-Check if either cdi-api or jboss-specs are in the pom already -> if so, don't add
anything
-if not promt the user if cdi-api should be installed (defaults to Y)
-if Y, promt the user what scope it should get, defaults to compile (probably it's a
standalone project, otherwise the specs should have been on the classpath)
Do you agree?
CDI facet should add cdi-api to maven dependencies
---------------------------------------------------
Key: SEAMFORGE-97
URL: https://issues.jboss.org/browse/SEAMFORGE-97
Project: Seam Forge
Issue Type: Enhancement
Components: Builtin Plugins
Reporter: Paul Bakker
After adding CDI it should be possible to use @Inject etc. in code, but the dependencies
are not added to the project.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:19 p.m.
New subject: [JBoss JIRA] Updated: (SEAMFORGE-97) CDI facet should add cdi-api to maven dependencies
[
https://issues.jboss.org/browse/SEAMFORGE-97?page=com.atlassian.jira.plug...
]
Paul Bakker updated SEAMFORGE-97:
---------------------------------
Status: Pull Request Sent (was: Pull Request Sent)
Git Pull Request: https://github.com/seam/forge/pull/8 (was:
https://github.com/seam/forge/pull/7)
New pull request
CDI facet should add cdi-api to maven dependencies
---------------------------------------------------
Key: SEAMFORGE-97
URL: https://issues.jboss.org/browse/SEAMFORGE-97
Project: Seam Forge
Issue Type: Enhancement
Components: Builtin Plugins
Reporter: Paul Bakker
After adding CDI it should be possible to use @Inject etc. in code, but the dependencies
are not added to the project.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:27 p.m.
New subject: [JBoss JIRA] Assigned: (SEAMFORGE-97) CDI facet should add cdi-api to maven dependencies
[
https://issues.jboss.org/browse/SEAMFORGE-97?page=com.atlassian.jira.plug...
]
Lincoln Baxter III reassigned SEAMFORGE-97:
-------------------------------------------
Assignee: Lincoln Baxter III
CDI facet should add cdi-api to maven dependencies
---------------------------------------------------
Key: SEAMFORGE-97
URL: https://issues.jboss.org/browse/SEAMFORGE-97
Project: Seam Forge
Issue Type: Enhancement
Components: Builtin Plugins
Reporter: Paul Bakker
Assignee: Lincoln Baxter III
After adding CDI it should be possible to use @Inject etc. in code, but the dependencies
are not added to the project.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:29 p.m.
New subject: [JBoss JIRA] Updated: (SEAMFORGE-97) CDI facet should add cdi-api to maven dependencies
[
https://issues.jboss.org/browse/SEAMFORGE-97?page=com.atlassian.jira.plug...
]
Lincoln Baxter III updated SEAMFORGE-97:
----------------------------------------
Status: Closed (was: Pull Request Sent)
Fix Version/s: 1.0.0.Alpha4
Resolution: Done
upstream
CDI facet should add cdi-api to maven dependencies
---------------------------------------------------
Key: SEAMFORGE-97
URL: https://issues.jboss.org/browse/SEAMFORGE-97
Project: Seam Forge
Issue Type: Enhancement
Components: Builtin Plugins
Reporter: Paul Bakker
Assignee: Lincoln Baxter III
Fix For: 1.0.0.Alpha4
After adding CDI it should be possible to use @Inject etc. in code, but the dependencies
are not added to the project.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
4771
days inactive
4787
days old
9 comments
2 participants
participants (2)
-
Lincoln Baxter III (JIRA) -
Paul Bakker (JIRA)