Re: [Hawkular-dev] Tag concept in metrics and alerts

On 06/24/2015 04:54 PM, Gary Brown wrote: > > ----- Original Message ----- >> >> On 6/24/2015 9:13 AM, Gary Brown wrote: >>> ----- Original Message ----- >>>> In alert context, the incoming data should match >>>> org.hawkular.alerts.api.model.data >>>> https://github.com/hawkular/hawkular-alerts/tree/master/hawkular-alerts-a... >>>> These data is carried and stored in the evaluation details for an >>>> alert. But "Tag" in alerts is used as a way to put "alias" on >>>> definitions but is not related to specific incoming data. >>> Sorry when I referred to 'tag', I meant the tag in the metrics event, which >>> is a map of name/value pairs. >>> >>> So when the alerts engine is analysing a metric, is the tag information on >>> the metric stored in the alert's condition evaluation data? >> As you mentioned earlier, Tags are labels that can be attached ad-hoc to >> Trigger definitions. They can then be used to filter queries, like, >> "give me all of the unresolved alerts for triggers labeled XYZ". That >> mechanism is for use by the clients, to be used in their own way. > Yes, this is where the use of 'tag' in alerts and metrics differs, so might be good if Tag in Alerts could be renamed Label. Do we need 1 word labelling at all or key/value pairs only ? (BTW to make it more confusing OpenShift/Kubernetes use the term label for key=value things) Thomas