6:41 a.m.
Hi *,
I have sent the PR [1] to remove the Line length rule from checkstyle
altogether. Based on the feedback collected through the dev survey, this
seems to be the most annoying rule.
I propose to keep the max line line length of 120 chars as an informal
recommendation, that would also stay present in the IDE settings as we
have them now.
Does anybody want to veto?
Thanks,
Peter
[1] https://github.com/hawkular/hawkular-build-tools/pull/24
9:26 a.m.
Hello Everybody,
Just had a brief chat with Peter. The main problem with that rule is not its application
for actual code lines, I think almost everybody liked that. 99% of the frustration came
from commented code not formatted to length by the IDEs. The classic example is having a
line with 120 characters of Java code, the developer decides to test something by
commenting out this line; the commenting takes 3 extra characters for a total of 123
characters. The IDE does not re-format to length and now there is a build error.
From my discussions with Peter there is no way to apply this rule
selectively (eg. do not enforce line length for Java comments). So making the rule
optional until that option is available (if it will ever be available) is the only way to
remove the source collective of frustration.
Peter, I second your proposal. Thank you!
Stefan
----- Original Message -----
From: "Peter Palaga" <ppalaga(a)redhat.com>
To: "Discussions around Hawkular development"
<hawkular-dev(a)lists.jboss.org>
Sent: Friday, March 18, 2016 6:41:52 AM
Subject: [Hawkular-dev] Line length rule to be removed from Checkstyle
Hi *,
I have sent the PR [1] to remove the Line length rule from checkstyle
altogether. Based on the feedback collected through the dev survey, this
seems to be the most annoying rule.
I propose to keep the max line line length of 120 chars as an informal
recommendation, that would also stay present in the IDE settings as we
have them now.
Does anybody want to veto?
Thanks,
Peter
[1] https://github.com/hawkular/hawkular-build-tools/pull/24
_______________________________________________
hawkular-dev mailing list
hawkular-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hawkular-dev
9:48 a.m.
On 18 Mar 2016, at 15:26, Stefan Negrea wrote:
IDEs. The classic example is having a line with 120 characters of
Java
code, the developer decides to test something by commenting out this
line; the commenting takes 3 extra characters for a total of 123
characters. The IDE does not re-format to length and now there is a
build error.
Exactly - that was my pain point over the year
9:52 a.m.
Le 18/03/2016 15:48, Heiko W.Rupp a écrit :
On 18 Mar 2016, at 15:26, Stefan Negrea wrote:
> IDEs. The classic example is having a line with 120 characters of Java
> code, the developer decides to test something by commenting out this
> line; the commenting takes 3 extra characters for a total of 123
> characters. The IDE does not re-format to length and now there is a
> build error.
Exactly - that was my pain point over the year
Not sure about Eclipse but Intellij has an option to reformat comments
11:10 a.m.
On 18 Mar 2016, at 15:52, Thomas Segismont wrote:
Le 18/03/2016 15:48, Heiko W.Rupp a écrit :
> On 18 Mar 2016, at 15:26, Stefan Negrea wrote:
>
>> IDEs. The classic example is having a line with 120 characters of Java
>> code, the developer decides to test something by commenting out this
>> line; the commenting takes 3 extra characters for a total of 123
>> characters. The IDE does not re-format to length and now there is a
>> build error.
>
> Exactly - that was my pain point over the year
Not sure about Eclipse but Intellij has an option to reformat comments
Which I don't want when just commenting out one bad line
when trying things.
This whole checkstyle / license / ... machinery is great for the moment
just before the changes are going out your computer to co-workers.
Before you should be able to roundtrip as fast as possible
11:37 a.m.
Le 18/03/2016 17:10, Heiko W.Rupp a écrit :
On 18 Mar 2016, at 15:52, Thomas Segismont wrote:
> Le 18/03/2016 15:48, Heiko W.Rupp a écrit :
>> On 18 Mar 2016, at 15:26, Stefan Negrea wrote:
>>
>>> IDEs. The classic example is having a line with 120 characters of Java
>>> code, the developer decides to test something by commenting out this
>>> line; the commenting takes 3 extra characters for a total of 123
>>> characters. The IDE does not re-format to length and now there is a
>>> build error.
>>
>> Exactly - that was my pain point over the year
>
> Not sure about Eclipse but Intellij has an option to reformat comments
Which I don't want when just commenting out one bad line
when trying things.
This whole checkstyle / license / ... machinery is great for the moment
just before the changes are going out your computer to co-workers.
Before you should be able to roundtrip as fast as possible
Just wanted to share as it works well for me. The code snippet is
reformatted but then I can open the diff revert this small part.
3196
days inactive
3196
days old
5 comments
4 participants
participants (4)
-
Heiko W.Rupp -
Peter Palaga -
Stefan Negrea -
Thomas Segismont