4:20 p.m.
I was getting really tired of checkstyle complaining about line-too-long
and trailing spaces for Java comment lines. I altered the config file
(attached) to be more flexible. But I don't have perms to create a PR
against hawkular-build-tools.
If you'd like to see this changed maybe chime in and the powers that be
will apply the change.
2:28 a.m.
Hi,
the change is basically the same as this PR
https://github.com/hawkular/hawkular-build-tools/pull/10
I can re-open it, however, I am pretty fine with using -Dcheckstyle.skip all the time and
do the dirty work only once before the commit.
jk
----- Original Message -----
| From: "Jay Shaughnessy" <jshaughn(a)redhat.com>
| To: hawkular-dev(a)lists.jboss.org
| Sent: Monday, 18 May, 2015 11:20:24 PM
| Subject: [Hawkular-dev] relaxing checkstyle on java comment lines
|
|
| I was getting really tired of checkstyle complaining about line-too-long and
| trailing spaces for Java comment lines. I altered the config file (attached)
| to be more flexible. But I don't have perms to create a PR against
| hawkular-build-tools.
|
| If you'd like to see this changed maybe chime in and the powers that be will
| apply the change.
|
| _______________________________________________
| hawkular-dev mailing list
| hawkular-dev(a)lists.jboss.org
| https://lists.jboss.org/mailman/listinfo/hawkular-dev
|
7:03 a.m.
On 19 May 2015, at 9:28, Jiri Kremser wrote:
the change is basically the same as this PR
https://github.com/hawkular/hawkular-build-tools/pull/10
I can re-open it, however, I am pretty fine with using
-Dcheckstyle.skip all the time and do the dirty work only once before
the commit.
I sort of think this is wrong, that one has to specify -D*.skip to get
things done. People will put -D*.skip in settings.xml or a shell alias
and then the commit/push will have the bad changes.
If everyone says, that
| I was getting really tired of checkstyle complaining about
line-too-long and
| trailing spaces for Java comment lines. I altered the config file
(attached)
then we should fix the rules. And not have everyone bend them.
8:23 a.m.
Hi Jiri,
I was unaware of that PR, sorry. I see now there has been previous
debate on this topic. My config changes also dealt with block comments
and trailing spaces. I suppose I should commit to the existing PR
branch. The -Dcheckstyle.skip is fine, I use that along with
license.skip, just to speed things up while developing. But it's not
the same as changing the policy we have in place. I'd argue that
comments should not be subject to line length or trailing whitespace
constraints, and that is why I made the change. We can keep things as
is, but if no one really cares I'd rather the change go in.
On 5/19/2015 3:28 AM, Jiri Kremser wrote:
Hi,
the change is basically the same as this PR
https://github.com/hawkular/hawkular-build-tools/pull/10
I can re-open it, however, I am pretty fine with using -Dcheckstyle.skip all the time and
do the dirty work only once before the commit.
jk
----- Original Message -----
| From: "Jay Shaughnessy" <jshaughn(a)redhat.com>
| To: hawkular-dev(a)lists.jboss.org
| Sent: Monday, 18 May, 2015 11:20:24 PM
| Subject: [Hawkular-dev] relaxing checkstyle on java comment lines
|
|
| I was getting really tired of checkstyle complaining about line-too-long and
| trailing spaces for Java comment lines. I altered the config file (attached)
| to be more flexible. But I don't have perms to create a PR against
| hawkular-build-tools.
|
| If you'd like to see this changed maybe chime in and the powers that be will
| apply the change.
|
| _______________________________________________
| hawkular-dev mailing list
| hawkular-dev(a)lists.jboss.org
| https://lists.jboss.org/mailman/listinfo/hawkular-dev
|
_______________________________________________
hawkular-dev mailing list
hawkular-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hawkular-dev
3465
days inactive
3466
days old
3 comments
3 participants
participants (3)
-
Heiko W.Rupp -
Jay Shaughnessy -
Jiri Kremser