June 2020 - hibernate-issues - Jboss List Archives

[JIRA] (HHH-14062) @Transactional timeout attribute wrong work

by ssosso (JIRA)

ssosso ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *updated* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiMzI0OGEwZWM0... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-14062?atlOrigin=eyJpIjoiMzI0OG... ) HHH-14062 ( https://hibernate.atlassian.net/browse/HHH-14062?atlOrigin=eyJpIjoiMzI0OG... ) @Transactional timeout attribute wrong work ( https://hibernate.atlassian.net/browse/HHH-14062?atlOrigin=eyJpIjoiMzI0OG... ) Change By: ssosso ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) !1 (cca38fb1-5eec-4a43-92cf-de14bc8fbb7d).png|width=672,height=82! !2 (a9640152-45ff-46b7-bc19-8d62af5f0cb9).png|width=855,height=199! org/hibernate/engine/jdbc/internal/JdbcCoordinatorImpl.class([242 line|https://github.com/hibernate/hibernate-orm/blob/5963dc7fe8/hibernate...]) If set as @Transactional(timeout=1), the transaction timeout will fail unconditionally due to the current timeout checking logic. This is because the / (divide) operation is used. When set as @Transactional(timeout=1), {code:java}(Timeout upper limit date and time - Transaction end date and time) / 1000{code} is always 0 (zero). !3 (0e92237d-95aa-42dd-873c-fb13416d9bc1).png|width=643,height=1280! Therefore, TransactionException is always caused by the following logic. {code:java}if (secondsRemaining <= 0) { throw new TransactionException( "transaction timeout expired" ); }{code} I am considering this as a bug, so I suggest to fix the code as below. {code:java}if (secondsRemaining < 0) { throw new TransactionException( "transaction timeout expired" ); }{code} If necessary, please refer to my PR. [https://github.com/hibernate/hibernate-orm/pull/3429|https://github.com/h...] ( https://hibernate.atlassian.net/browse/HHH-14062#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-14062#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100128- sha1:078e4e4 )

6 years

1
0
0 / 0

[JIRA] (HHH-14062) @Transactional timeout attribute wrong work

by ssosso (JIRA)

ssosso ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *updated* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiNjA1ZjcwNWUy... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-14062?atlOrigin=eyJpIjoiNjA1Zj... ) HHH-14062 ( https://hibernate.atlassian.net/browse/HHH-14062?atlOrigin=eyJpIjoiNjA1Zj... ) @Transactional timeout attribute wrong work ( https://hibernate.atlassian.net/browse/HHH-14062?atlOrigin=eyJpIjoiNjA1Zj... ) Change By: ssosso ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) !1 (cca38fb1-5eec-4a43-92cf-de14bc8fbb7d).png|width=672,height=82! !2 (a9640152-45ff-46b7-bc19-8d62af5f0cb9).png|width=855,height=199! org/hibernate/engine/jdbc/internal/JdbcCoordinatorImpl.class([242 line|https://github.com/hibernate/hibernate-orm/blob/5963dc7fe8/hibernate...]) If set as @Transactional(timeout=1), the transaction timeout will fail unconditionally due to the current timeout checking logic. This is because the / (divide) operation is used. When set as @Transactional(timeout=1), {code:java}(Timeout upper limit date and time - Transaction end date and time) / 1000{code} is always 0 (zero). !3 (0e92237d-95aa-42dd-873c-fb13416d9bc1).png|width=643,height=1280! Therefore, TransactionException is always caused by the following logic. {code:java}if (secondsRemaining <= 0) { throw new TransactionException( "transaction timeout expired" ); }{code} I am considering this as a bug, so I suggest to fix the code as below. {code:java}if (secondsRemaining < 0) { throw new TransactionException( "transaction timeout expired" ); }{code} If necessary, please refer to my PR. [https://github.com/hibernate/hibernate-orm/pull/3429|https://github.com/h...] ( https://hibernate.atlassian.net/browse/HHH-14062#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-14062#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100128- sha1:078e4e4 )

6 years

1
0
0 / 0

[JIRA] (HHH-14062) @Transactional timeout attribute wrong work

by ssosso (JIRA)

ssosso ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *updated* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiYmE1ZDM4MDc5... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-14062?atlOrigin=eyJpIjoiYmE1ZD... ) HHH-14062 ( https://hibernate.atlassian.net/browse/HHH-14062?atlOrigin=eyJpIjoiYmE1ZD... ) @Transactional timeout attribute wrong work ( https://hibernate.atlassian.net/browse/HHH-14062?atlOrigin=eyJpIjoiYmE1ZD... ) Change By: ssosso ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) !1 (cca38fb1-5eec-4a43-92cf-de14bc8fbb7d).png|width=672,height=82! !2 (a9640152-45ff-46b7-bc19-8d62af5f0cb9).png|width=855,height=199! org/hibernate/engine/jdbc/internal/JdbcCoordinatorImpl.class([242 line|https://github.com/hibernate/hibernate-orm/blob/5963dc7fe8/hibernate...]) If set as @Transactional(timeout=1), the transaction timeout will fail unconditionally due to the current timeout checking logic. This is because the / (divide) operation is used. When set as @Transactional(timeout=1), {code:java}(Timeout upper limit date and time - Transaction end date and time) / 1000{code} is always 0 (zero). !3 (0e92237d-95aa-42dd-873c-fb13416d9bc1).png|width=643,height=1280! Therefore, TransactionException is always caused by the following logic. {code:java}if (secondsRemaining <= 0) { throw new TransactionException( "transaction timeout expired" ); }{code} I am considering this as a bug, so I suggest to fix the code as below. {code:java}if (secondsRemaining < 0) { throw new TransactionException( "transaction timeout expired" ); }{code} If necessary, I will please refer to my PR. ( https://hibernate.atlassian.net/browse/HHH-14062#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-14062#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100128- sha1:078e4e4 )

6 years

1
0
0 / 0

[JIRA] (HHH-14062) @Transactional timeout attribute wrong work

by ssosso (JIRA)

6 years

1
0
0 / 0

[JIRA] (HHH-14062) @Transactional timeout attribute wrong work

by ssosso (JIRA)

ssosso ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *updated* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiYmE1NjM1OWNm... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-14062?atlOrigin=eyJpIjoiYmE1Nj... ) HHH-14062 ( https://hibernate.atlassian.net/browse/HHH-14062?atlOrigin=eyJpIjoiYmE1Nj... ) @Transactional timeout attribute wrong work ( https://hibernate.atlassian.net/browse/HHH-14062?atlOrigin=eyJpIjoiYmE1Nj... ) Change By: ssosso ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) !1 (cca38fb1-5eec-4a43-92cf-de14bc8fbb7d).png| thumbnail width=672,height=82 ! !2 (a9640152-45ff-46b7-bc19-8d62af5f0cb9).png| thumbnail width=855,height=199 ! org/hibernate/engine/jdbc/internal/JdbcCoordinatorImpl.class([242 line|https://github.com/hibernate/hibernate-orm/blob/5963dc7fe8/hibernate...]) If set as @Transactional(timeout=1), the transaction timeout will fail unconditionally due to the current timeout checking logic. This is because the / (divide) operation is used. When set as @Transactional(timeout=1), {code:java} (Timeout upper limit date and time - Transaction end date and time) / 1000 {code} is always 0 (zero). !3 (0e92237d-95aa-42dd-873c-fb13416d9bc1).png|width=643,height=1280! Therefore, TransactionException is always caused by the following logic. {code:java} if (secondsRemaining <= 0) { throw new TransactionException( "transaction timeout expired" ); } {code} !3.png|thumbnail! I am considering this as a bug, so I suggest to fix the code as below. {code:java} if (secondsRemaining * < * 0) { throw new TransactionException( "transaction timeout expired" ); } {code} If necessary, I will PR. ( https://hibernate.atlassian.net/browse/HHH-14062#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-14062#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100128- sha1:078e4e4 )

6 years

1
0
0 / 0

[JIRA] (HHH-14062) @Transactional timeout attribute wrong work

by ssosso (JIRA)

ssosso ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiZTk0ZDkzNjFl... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-14062?atlOrigin=eyJpIjoiZTk0ZD... ) HHH-14062 ( https://hibernate.atlassian.net/browse/HHH-14062?atlOrigin=eyJpIjoiZTk0ZD... ) @Transactional timeout attribute wrong work ( https://hibernate.atlassian.net/browse/HHH-14062?atlOrigin=eyJpIjoiZTk0ZD... ) Issue Type: Bug Affects Versions: 5.4.17 Assignee: Unassigned Attachments: 1.png, 2.png, 3.png Components: hibernate-core Created: 06/Jun/2020 20:15 PM Labels: transaction Priority: Major Reporter: ssosso ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) ( https://hibernate.atlassian.net/secure/attachment/49694/49694_1.png ) ( https://hibernate.atlassian.net/secure/attachment/49693/49693_2.png ) org/hibernate/engine/jdbc/internal/JdbcCoordinatorImpl.class( 242 line ( https://github.com/hibernate/hibernate-orm/blob/5963dc7fe8/hibernate-core... ) ) If set as @Transactional(timeout=1), the transaction timeout will fail unconditionally due to the current timeout checking logic. This is because the / (divide) operation is used. When set as @Transactional(timeout=1), (Timeout upper limit date and time - Transaction end date and time) / 1000 is always 0 (zero). Therefore, TransactionException is always caused by the following logic. if (secondsRemaining <= 0) { throw new TransactionException( "transaction timeout expired" ); } ( https://hibernate.atlassian.net/secure/attachment/49692/49692_3.png ) I am considering this as a bug, so I suggest to fix the code as below. if (secondsRemaining *<* 0) { throw new TransactionException( "transaction timeout expired" ); } If necessary, I will PR. ( https://hibernate.atlassian.net/browse/HHH-14062#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-14062#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100128- sha1:078e4e4 )

6 years

1
0
0 / 0

[JIRA] (HHH-14059) Cannot use full qualified enum name which has two uppercase alphabet prefix

by zheng hank (JIRA)

6 years

1
0
0 / 0

[JIRA] (BVAL-750) Is @Valid supported in composite constraints

by user (JIRA)

user ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=5edaad5... ) *updated* an issue Bean Validation ( https://hibernate.atlassian.net/browse/BVAL?atlOrigin=eyJpIjoiYzhiOWY5MDg... ) / Bug ( https://hibernate.atlassian.net/browse/BVAL-750?atlOrigin=eyJpIjoiYzhiOWY... ) BVAL-750 ( https://hibernate.atlassian.net/browse/BVAL-750?atlOrigin=eyJpIjoiYzhiOWY... ) Is @Valid supported in composite constraints ( https://hibernate.atlassian.net/browse/BVAL-750?atlOrigin=eyJpIjoiYzhiOWY... ) Change By: user ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=5edaad5... ) I have been trying to get @Valid to work in a composite constraint but no luck so far. I went through HV documentation and searched online to find out if @Valid is not supported in composite constraints but I can't find any mention of that. Here is a simple example that shows the issue: {code:java} public class Foo { @NotNull // without composite constraint. both work as expected @Valid Bar bar @NotNullAndValid // composite constraint consisting of @NotNull and @Valid Baz baz; // @NotNull gets applied but cascade validation (@Valid) does not } @NotNull @Valid @Constraint(validatedBy={}) // RUNTIME retention, FIELD target for simplicity public @interface NotNullAndValid { // message, groups, payload } {code} So my question is this: Is @Valid supported in composite constraint? If not, can you please point me to some online resource that explains why. My guess is that it's not supported for the following reason: @Valid does not support groups (i.e., if you have @Valid declared somewhere then cascade validation will always take place regardless of the validation group that was specified in/passed to the validator API call). On the other hand, composite constraints support groups/can be turned on/off by validating a bean for a specific group. If @Valid were to be placed in a composite constraint then you effectively make @Valid support groups (i.e., cascade validation will become group based rather than the mere presence/absence of @Valid constraint). Any thoughts? ( https://hibernate.atlassian.net/browse/BVAL-750#add-comment?atlOrigin=eyJ... ) Add Comment ( https://hibernate.atlassian.net/browse/BVAL-750#add-comment?atlOrigin=eyJ... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100128- sha1:078e4e4 )

6 years

1
0
0 / 0

[JIRA] (BVAL-750) Is @Valid supported in composite constraints

by user (JIRA)

user ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=5edaad5... ) *created* an issue Bean Validation ( https://hibernate.atlassian.net/browse/BVAL?atlOrigin=eyJpIjoiYzAyOGIwMTB... ) / Bug ( https://hibernate.atlassian.net/browse/BVAL-750?atlOrigin=eyJpIjoiYzAyOGI... ) BVAL-750 ( https://hibernate.atlassian.net/browse/BVAL-750?atlOrigin=eyJpIjoiYzAyOGI... ) Is @Valid supported in composite constraints ( https://hibernate.atlassian.net/browse/BVAL-750?atlOrigin=eyJpIjoiYzAyOGI... ) Issue Type: Bug Affects Versions: 2.0.2 Assignee: Unassigned Components: api, spec-general Created: 05/Jun/2020 14:14 PM Environment: OpenJDK 14 Hibernate Validator 6.1.4.Final SE environment Labels: validation Priority: Minor Reporter: user ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=5edaad5... ) I have been trying to get @Valid to work in a composite constraint but no luck so far. I went through HV documentation and searched online to find out if @Valid is not supported in composite constraints but I can't find any mention of that. Here is a simple example that shows the issue: public class Foo { @NotNull // without composite constraint. both work as expected @Valid Bar bar @NotNullAndValid // composite constraint consisting of @NotNull and @Valid Baz baz; // @NotNull gets applied but cascade validation (@Valid) does not } @NotNull @Valid @Constraint(validatedBy={}) // RUNTIME retention, FIELD target for simplicity public @ interface NotNullAndValid { // message, groups, payload } So my question is this: Is @Valid supported in composite constraint? If not, can you please point me to some online resource that explains why. My guess is that it's not supported for the following reason: @Valid does not support groups (i.e., if you have @Valid declared somewhere then cascade validation will always take place regardless of the validation group that was specified in/passed to the validator API call). On the other hand, composite constraints support groups/can be turned on/off by validating a bean for a specific group. If @Valid were to be placed in a composite constraint then you effectively make @Valid support groups (i.e., cascade validation will become group based rather than the mere presence/absence of @Valid constraint). Any thoughts? ( https://hibernate.atlassian.net/browse/BVAL-750#add-comment?atlOrigin=eyJ... ) Add Comment ( https://hibernate.atlassian.net/browse/BVAL-750#add-comment?atlOrigin=eyJ... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100128- sha1:078e4e4 )

6 years

1
0
0 / 0

[JIRA] (HSEARCH-3939) Use a single field for GeoPoint storage in Lucene

by Yoann Rodière (JIRA)

6 years

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues June 2020