[hibernate-issues] [Hibernate-JIRA] Issue Comment Edited: (HV-495) Many locks on AnnotatedElements

[ http://opensource.atlassian.com/projects/hibernate/browse/HV-495?page=com... ] Loïc DIAS DA SILVA edited comment on HV-495 at 6/15/11 9:35 AM: ---------------------------------------------------------------- No, i have not kept the JRA traces sorry.. ;( You can find below an example (incomplete) of some of our annotations : {code} @ValidatedMethodCall public Response xxxxxxx ( @User(message = ID_ERROR) @PathParam("xxx") int otherMemberId, @Page @Range(min = MIN_PAGE, max = MAX_PAGE_CONTACTS, message = PAGE_NUMBER_ERROR_CONTACTS) @DefaultValue(DEFAULT_PAGE) @QueryParam(PAGE_PARAM) Integer pageNumber, @Limit @Range(min = MIN_LIMIT, max = MAX_LIMIT, message = LIMIT_SIZE_ERROR) @DefaultValue(DEFAULT_LIMIT) @QueryParam(LIMIT_PARAM) Integer limit, @DefaultValue("false") @QueryParam("xxxxxxxx") Boolean xxxxxxxxx, @DefaultValue(GraphUtils.NONE_DETAIL_LEVEL) @QueryParam(DETAIL_PARAM) DetailLevel xxxxxxx) {code} I used a tomcat instance with 300 threads and the locks begin to occur when i launch the third injector (each JMeter injector configured with 500 threads). I used previously Apache bval with exactly the same issue and really closed trace, i have kept in some mails the trace, if it can be useful : {noformat} {noformat} I instanciate the validator in this way, using AspectJ : {code:title=MethodValidationAspect.java|borderStyle=solid} import java.util.Arrays; import java.util.Set; import javax.validation.ConstraintViolation; import javax.validation.Validation; import javax.validation.ValidatorFactory; import org.aspectj.lang.JoinPoint; import org.aspectj.lang.annotation.Aspect; import org.aspectj.lang.annotation.Before; import org.aspectj.lang.annotation.Pointcut; import org.aspectj.lang.reflect.MethodSignature; import org.hibernate.validator.method.MethodValidator; @Aspect public class MethodValidationAspect { static private ValidatorFactory factory; // ========================================================================== static { factory = Validation.buildDefaultValidatorFactory(); } // ========================================================================== static private MethodValidator getMethodValidator() { return factory.getValidator().unwrap(MethodValidator.class); } @Pointcut(&quot;execution((a)xxxxxx.ValidatedMethodCall * *(..))") public void validatedMethodCall(final JoinPoint _thisJoinPoint) { } // ========================================================================== /** * @param _thisJoinPoint */ @Before("validatedMethodCall(JoinPoint)") public void validatedMethodCallBefore(final JoinPoint _thisJoinPoint) { final MethodSignature methodSignature = (MethodSignature) _thisJoinPoint.getSignature(); final Set<? extends ConstraintViolation<?>> validationErrors = MethodValidationAspect.getMethodValidator() .validateAllParameters(_thisJoinPoint.getThis(), methodSignature.getMethod(), _thisJoinPoint.getArgs()); if (!validationErrors.isEmpty()) { throw buildValidationException(validationErrors); } } // ========================================================================== /** * @param validationErrors The errors detected in a method/constructor call. * @return A RuntimeException with information about the detected validation errors. */ private IllegalArgumentException buildValidationException( final Set<? extends ConstraintViolation<?>> _validationErrors) { final StringBuilder sb = new StringBuilder(); for (ConstraintViolation<?> cv : _validationErrors) { sb.append(cv.getMessage() + "\n"); } return new IllegalArgumentException(sb.toString()); } } {code} Hope it can helps.. Regards. ++ was (Author: mglcel): No, i have not kept the JRA traces sorry.. ;( You can find below an example (incomplete) of some of our annotations : @ValidatedMethodCall public Response xxxxxxx ( @User(message = ID_ERROR) @PathParam("xxx") int otherMemberId, @Page @Range(min = MIN_PAGE, max = MAX_PAGE_CONTACTS, message = PAGE_NUMBER_ERROR_CONTACTS) @DefaultValue(DEFAULT_PAGE) @QueryParam(PAGE_PARAM) Integer pageNumber, @Limit @Range(min = MIN_LIMIT, max = MAX_LIMIT, message = LIMIT_SIZE_ERROR) @DefaultValue(DEFAULT_LIMIT) @QueryParam(LIMIT_PARAM) Integer limit, @DefaultValue("false") @QueryParam("xxxxxxxx") Boolean xxxxxxxxx, @DefaultValue(GraphUtils.NONE_DETAIL_LEVEL) @QueryParam(DETAIL_PARAM) DetailLevel xxxxxxx) I used a tomcat instance with 300 threads and the locks begin to occur when i launch the third injector (each JMeter injector configured with 500 threads). I used previously Apache bval with exactly the same issue and really closed trace, i have kept in some mails the trace, if it can be useful : {noformat} {noformat} I instanciate the validator in this way, using AspectJ : {code:title=MethodValidationAspect.java|borderStyle=solid} import java.util.Arrays; import java.util.Set; import javax.validation.ConstraintViolation; import javax.validation.Validation; import javax.validation.ValidatorFactory; import org.aspectj.lang.JoinPoint; import org.aspectj.lang.annotation.Aspect; import org.aspectj.lang.annotation.Before; import org.aspectj.lang.annotation.Pointcut; import org.aspectj.lang.reflect.MethodSignature; import org.hibernate.validator.method.MethodValidator; @Aspect public class MethodValidationAspect { static private ValidatorFactory factory; // ========================================================================== static { factory = Validation.buildDefaultValidatorFactory(); } // ========================================================================== static private MethodValidator getMethodValidator() { return factory.getValidator().unwrap(MethodValidator.class); } @Pointcut(&quot;execution((a)xxxxxx.ValidatedMethodCall * *(..))") public void validatedMethodCall(final JoinPoint _thisJoinPoint) { } // ========================================================================== /** * @param _thisJoinPoint */ @Before("validatedMethodCall(JoinPoint)") public void validatedMethodCallBefore(final JoinPoint _thisJoinPoint) { final MethodSignature methodSignature = (MethodSignature) _thisJoinPoint.getSignature(); final Set<? extends ConstraintViolation<?>> validationErrors = MethodValidationAspect.getMethodValidator() .validateAllParameters(_thisJoinPoint.getThis(), methodSignature.getMethod(), _thisJoinPoint.getArgs()); if (!validationErrors.isEmpty()) { throw buildValidationException(validationErrors); } } // ========================================================================== /** * @param validationErrors The errors detected in a method/constructor call. * @return A RuntimeException with information about the detected validation errors. */ private IllegalArgumentException buildValidationException( final Set<? extends ConstraintViolation<?>> _validationErrors) { final StringBuilder sb = new StringBuilder(); for (ConstraintViolation<?> cv : _validationErrors) { sb.append(cv.getMessage() + "\n"); } return new IllegalArgumentException(sb.toString()); } } {code} Hope it can helps.. Regards. ++ -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira