2:11 a.m.
Multiple class validators of the same annotationtype
----------------------------------------------------
Key: ANN-513
URL: http://opensource.atlassian.com/projects/hibernate/browse/ANN-513
Project: Hibernate Annotations
Type: Improvement
Components: validator
Versions: 3.2.1
Reporter: Edwin van der Elst
Priority: Minor
I have a suggestion for the following problem:
I created an Validator to check if a 'date'> 'another date'
The annotation looks like this:
@After(property="endDate", after="beginDate", message="End should
be after begin")
Since it involves 2 properties, it is a class-level validation.
Now....
I want multiple 'after' validations on a single bean.
But that is not possible (you can only place an annotation once on a class).
My proposal is to add an annotation 'Validations':
@Validations( {@After(...), @After(..)} )
I could do the multiple validations in a single validatorclass, but I want all the
messages added to the invalidValues array, not a single message.
This change would also require changes in the ClassValidator class.
What do you think of this proposal? Should I add it to Jira (I can propably implement it
if there are no objections to the required changes)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
6:09 a.m.
New subject: [Hibernate-JIRA] Commented: (ANN-513) Multiple class validators of the same annotationtype
[
http://opensource.atlassian.com/projects/hibernate/browse/ANN-513?page=co...
]
Emmanuel Bernard commented on ANN-513:
--------------------------------------
Edwin,
I believe you can implement an untyped version
@GenericValidator( class=..., parameters = @Params(key=, value=) )
Then @Validators(GenericValidator[] value() )
Hibernate Annotations has the ability to "create" annotations (ie recreate the
actual validator).
have a look at org.hibernate.test.annotationfactory.AnnotationFactoryTest
Multiple class validators of the same annotationtype
----------------------------------------------------
Key: ANN-513
URL: http://opensource.atlassian.com/projects/hibernate/browse/ANN-513
Project: Hibernate Annotations
Type: Improvement
Components: validator
Versions: 3.2.1
Reporter: Edwin van der Elst
Priority: Minor
I have a suggestion for the following problem:
I created an Validator to check if a 'date'> 'another date'
The annotation looks like this:
@After(property="endDate", after="beginDate", message="End
should be after begin")
Since it involves 2 properties, it is a class-level validation.
Now....
I want multiple 'after' validations on a single bean.
But that is not possible (you can only place an annotation once on a class).
My proposal is to add an annotation 'Validations':
@Validations( {@After(...), @After(..)} )
I could do the multiple validations in a single validatorclass, but I want all the
messages added to the invalidValues array, not a single message.
This change would also require changes in the ClassValidator class.
What do you think of this proposal? Should I add it to Jira (I can propably implement it
if there are no objections to the required changes)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
8:12 a.m.
New subject: [Hibernate-JIRA] Updated: (ANN-513) Multiple class validators of the same annotationtype
[ http://opensource.atlassian.com/projects/hibernate/browse/ANN-513?page=all ]
Edwin van der Elst updated ANN-513:
-----------------------------------
Attachment: validators_patch.txt
Hereby a patch for ValidatorList (based on latest svn checkout)
Also included, a test-case for a 'Loan' class and a bean validatorclass
'After'.
Feel free to comment on the implementation :-)
Edwin
Multiple class validators of the same annotationtype
----------------------------------------------------
Key: ANN-513
URL: http://opensource.atlassian.com/projects/hibernate/browse/ANN-513
Project: Hibernate Annotations
Type: Improvement
Components: validator
Versions: 3.2.1
Reporter: Edwin van der Elst
Priority: Minor
Attachments: validators_patch.txt
I have a suggestion for the following problem:
I created an Validator to check if a 'date'> 'another date'
The annotation looks like this:
@After(property="endDate", after="beginDate", message="End
should be after begin")
Since it involves 2 properties, it is a class-level validation.
Now....
I want multiple 'after' validations on a single bean.
But that is not possible (you can only place an annotation once on a class).
My proposal is to add an annotation 'Validations':
@Validations( {@After(...), @After(..)} )
I could do the multiple validations in a single validatorclass, but I want all the
messages added to the invalidValues array, not a single message.
This change would also require changes in the ClassValidator class.
What do you think of this proposal? Should I add it to Jira (I can propably implement it
if there are no objections to the required changes)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
5:41 p.m.
New subject: [Hibernate-JIRA] Commented: (ANN-513) Multiple class validators of the same annotationtype
[
http://opensource.atlassian.com/projects/hibernate/browse/ANN-513?page=co...
]
John Gilbert commented on ANN-513:
----------------------------------
I have the same problem but the GenericValidator seems very verbos. Here is an example of
something I am playing with:
@Expressions(
{ @Expression(value = "value.field1 ne value.field2", message = "Field1
must not equal Field2."),
@Expression(value = "value.field3 > value.field4", message = "Field3
must be greater than Field4.")
})
public class Entity {
private String field1;
private String field2;
private Integer field3;
private Integer field4;
...
}
Ignore the fact that I am using expression language.
The Expressions annotation is not linked to a ValidatorClass, but the Expression
annotation is.
public @interface Expressions {
Expression[] value();
}
@ValidatorClass(ExpressionValidator.class)
public @interface Expression {
String value();
String message() default "";
}
In ClassValidator when it initializes it gets all the annotations off of the class and
members and checks if they have a ValidatorClass. It could also use reflection to see if
the annotations aggregate other annotations which in turn are linked to a ValidatorClass.
This would require a moderate bit of rework to ClassValidator, but would make using it
much cleaner.
Thoughts?
Multiple class validators of the same annotationtype
----------------------------------------------------
Key: ANN-513
URL: http://opensource.atlassian.com/projects/hibernate/browse/ANN-513
Project: Hibernate Annotations
Type: Improvement
Components: validator
Versions: 3.2.1
Reporter: Edwin van der Elst
Priority: Minor
Attachments: validators_patch.txt
I have a suggestion for the following problem:
I created an Validator to check if a 'date'> 'another date'
The annotation looks like this:
@After(property="endDate", after="beginDate", message="End
should be after begin")
Since it involves 2 properties, it is a class-level validation.
Now....
I want multiple 'after' validations on a single bean.
But that is not possible (you can only place an annotation once on a class).
My proposal is to add an annotation 'Validations':
@Validations( {@After(...), @After(..)} )
I could do the multiple validations in a single validatorclass, but I want all the
messages added to the invalidValues array, not a single message.
This change would also require changes in the ClassValidator class.
What do you think of this proposal? Should I add it to Jira (I can propably implement it
if there are no objections to the required changes)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
12:37 a.m.
New subject: [Hibernate-JIRA] Commented: (ANN-513) Multiple class validators of the same annotationtype
[
http://opensource.atlassian.com/projects/hibernate/browse/ANN-513?page=co...
]
Emmanuel Bernard commented on ANN-513:
--------------------------------------
Problem is the user needs to create the Annotation container for each specific type.
I guess that's the price to pay, the solution is more elegant when reading the code.
the algorithm should check if the return type of value() is a array of annotations.
checking all the members make few sense, I think.
I like the el annotation btw, I'm waiting for the unified el spec.
Multiple class validators of the same annotationtype
----------------------------------------------------
Key: ANN-513
URL: http://opensource.atlassian.com/projects/hibernate/browse/ANN-513
Project: Hibernate Annotations
Type: Improvement
Components: validator
Versions: 3.2.1
Reporter: Edwin van der Elst
Priority: Minor
Attachments: validators_patch.txt
I have a suggestion for the following problem:
I created an Validator to check if a 'date'> 'another date'
The annotation looks like this:
@After(property="endDate", after="beginDate", message="End
should be after begin")
Since it involves 2 properties, it is a class-level validation.
Now....
I want multiple 'after' validations on a single bean.
But that is not possible (you can only place an annotation once on a class).
My proposal is to add an annotation 'Validations':
@Validations( {@After(...), @After(..)} )
I could do the multiple validations in a single validatorclass, but I want all the
messages added to the invalidValues array, not a single message.
This change would also require changes in the ClassValidator class.
What do you think of this proposal? Should I add it to Jira (I can propably implement it
if there are no objections to the required changes)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
12:43 p.m.
New subject: [Hibernate-JIRA] Updated: (ANN-513) Multiple class validators of the same annotationtype
[ http://opensource.atlassian.com/projects/hibernate/browse/ANN-513?page=all ]
John Gilbert updated ANN-513:
-----------------------------
Attachment: ClassValidator.java
This was easier than I thought it would be. I just added the handleAggregateAnnotations()
method and called it in two places.
NOTE: The source I attached is from 3.2.0.CR1, because I am still using and older version
of the jboss embedded container.
Btw, I would be glad to donate the EL validator, but I am using commons-jexl.
Multiple class validators of the same annotationtype
----------------------------------------------------
Key: ANN-513
URL: http://opensource.atlassian.com/projects/hibernate/browse/ANN-513
Project: Hibernate Annotations
Type: Improvement
Components: validator
Versions: 3.2.1
Reporter: Edwin van der Elst
Priority: Minor
Attachments: ClassValidator.java, validators_patch.txt
I have a suggestion for the following problem:
I created an Validator to check if a 'date'> 'another date'
The annotation looks like this:
@After(property="endDate", after="beginDate", message="End
should be after begin")
Since it involves 2 properties, it is a class-level validation.
Now....
I want multiple 'after' validations on a single bean.
But that is not possible (you can only place an annotation once on a class).
My proposal is to add an annotation 'Validations':
@Validations( {@After(...), @After(..)} )
I could do the multiple validations in a single validatorclass, but I want all the
messages added to the invalidValues array, not a single message.
This change would also require changes in the ClassValidator class.
What do you think of this proposal? Should I add it to Jira (I can propably implement it
if there are no objections to the required changes)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
12:44 p.m.
New subject: [Hibernate-JIRA] Updated: (ANN-513) Multiple validators of the same type per element (John Gilbert)
[ http://opensource.atlassian.com/projects/hibernate/browse/ANN-513?page=all ]
Emmanuel Bernard updated ANN-513:
---------------------------------
Summary: Multiple validators of the same type per element (John Gilbert) (was:
Multiple class validators of the same annotationtype)
Fix Version: 3.2.2
Assign To: Emmanuel Bernard
Multiple validators of the same type per element (John Gilbert)
---------------------------------------------------------------
Key: ANN-513
URL: http://opensource.atlassian.com/projects/hibernate/browse/ANN-513
Project: Hibernate Annotations
Type: Improvement
Components: validator
Versions: 3.2.1
Reporter: Edwin van der Elst
Assignee: Emmanuel Bernard
Priority: Minor
Fix For: 3.2.2
Attachments: ClassValidator.java, validators_patch.txt
I have a suggestion for the following problem:
I created an Validator to check if a 'date'> 'another date'
The annotation looks like this:
@After(property="endDate", after="beginDate", message="End
should be after begin")
Since it involves 2 properties, it is a class-level validation.
Now....
I want multiple 'after' validations on a single bean.
But that is not possible (you can only place an annotation once on a class).
My proposal is to add an annotation 'Validations':
@Validations( {@After(...), @After(..)} )
I could do the multiple validations in a single validatorclass, but I want all the
messages added to the invalidValues array, not a single message.
This change would also require changes in the ClassValidator class.
What do you think of this proposal? Should I add it to Jira (I can propably implement it
if there are no objections to the required changes)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
12:46 p.m.
New subject: [Hibernate-JIRA] Resolved: (ANN-513) Multiple validators of the same type per element (John Gilbert)
[ http://opensource.atlassian.com/projects/hibernate/browse/ANN-513?page=all ]
Emmanuel Bernard resolved ANN-513:
----------------------------------
Resolution: Fixed
Commited John's patch. I don't think Edwin's solution is needed anymore.
Thanks to both of you guys :-)
Multiple validators of the same type per element (John Gilbert)
---------------------------------------------------------------
Key: ANN-513
URL: http://opensource.atlassian.com/projects/hibernate/browse/ANN-513
Project: Hibernate Annotations
Type: Improvement
Components: validator
Versions: 3.2.1
Reporter: Edwin van der Elst
Assignee: Emmanuel Bernard
Priority: Minor
Fix For: 3.2.2
Attachments: ClassValidator.java, validators_patch.txt
I have a suggestion for the following problem:
I created an Validator to check if a 'date'> 'another date'
The annotation looks like this:
@After(property="endDate", after="beginDate", message="End
should be after begin")
Since it involves 2 properties, it is a class-level validation.
Now....
I want multiple 'after' validations on a single bean.
But that is not possible (you can only place an annotation once on a class).
My proposal is to add an annotation 'Validations':
@Validations( {@After(...), @After(..)} )
I could do the multiple validations in a single validatorclass, but I want all the
messages added to the invalidValues array, not a single message.
This change would also require changes in the ClassValidator class.
What do you think of this proposal? Should I add it to Jira (I can propably implement it
if there are no objections to the required changes)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
1:07 p.m.
New subject: [Hibernate-JIRA] Commented: (ANN-513) Multiple validators of the same type per element (John Gilbert)
[
http://opensource.atlassian.com/projects/hibernate/browse/ANN-513?page=co...
]
John Gilbert commented on ANN-513:
----------------------------------
Great! I have created a blog entry that talks about this topic:
http://jroller.com/page/jgilbert01?entry=extending_the_hibernate_validati...
Multiple validators of the same type per element (John Gilbert)
---------------------------------------------------------------
Key: ANN-513
URL: http://opensource.atlassian.com/projects/hibernate/browse/ANN-513
Project: Hibernate Annotations
Type: Improvement
Components: validator
Versions: 3.2.1
Reporter: Edwin van der Elst
Assignee: Emmanuel Bernard
Priority: Minor
Fix For: 3.2.2
Attachments: ClassValidator.java, validators_patch.txt
I have a suggestion for the following problem:
I created an Validator to check if a 'date'> 'another date'
The annotation looks like this:
@After(property="endDate", after="beginDate", message="End
should be after begin")
Since it involves 2 properties, it is a class-level validation.
Now....
I want multiple 'after' validations on a single bean.
But that is not possible (you can only place an annotation once on a class).
My proposal is to add an annotation 'Validations':
@Validations( {@After(...), @After(..)} )
I could do the multiple validations in a single validatorclass, but I want all the
messages added to the invalidValues array, not a single message.
This change would also require changes in the ClassValidator class.
What do you think of this proposal? Should I add it to Jira (I can propably implement it
if there are no objections to the required changes)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
1:47 p.m.
New subject: [Hibernate-JIRA] Commented: (ANN-513) Multiple validators of the same type per element (John Gilbert)
[
http://opensource.atlassian.com/projects/hibernate/browse/ANN-513?page=co...
]
Emmanuel Bernard commented on ANN-513:
--------------------------------------
cool, nice ideas. I like the EL actually
Multiple validators of the same type per element (John Gilbert)
---------------------------------------------------------------
Key: ANN-513
URL: http://opensource.atlassian.com/projects/hibernate/browse/ANN-513
Project: Hibernate Annotations
Type: Improvement
Components: validator
Versions: 3.2.1
Reporter: Edwin van der Elst
Assignee: Emmanuel Bernard
Priority: Minor
Fix For: 3.2.2
Attachments: ClassValidator.java, validators_patch.txt
I have a suggestion for the following problem:
I created an Validator to check if a 'date'> 'another date'
The annotation looks like this:
@After(property="endDate", after="beginDate", message="End
should be after begin")
Since it involves 2 properties, it is a class-level validation.
Now....
I want multiple 'after' validations on a single bean.
But that is not possible (you can only place an annotation once on a class).
My proposal is to add an annotation 'Validations':
@Validations( {@After(...), @After(..)} )
I could do the multiple validations in a single validatorclass, but I want all the
messages added to the invalidValues array, not a single message.
This change would also require changes in the ClassValidator class.
What do you think of this proposal? Should I add it to Jira (I can propably implement it
if there are no objections to the required changes)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
2:38 a.m.
New subject: [Hibernate-JIRA] Commented: (ANN-513) Multiple validators of the same type per element (John Gilbert)
[
http://opensource.atlassian.com/projects/hibernate/browse/ANN-513?page=co...
]
Edwin van der Elst commented on ANN-513:
----------------------------------------
I like John's solution better too :-)
Multiple validators of the same type per element (John Gilbert)
---------------------------------------------------------------
Key: ANN-513
URL: http://opensource.atlassian.com/projects/hibernate/browse/ANN-513
Project: Hibernate Annotations
Type: Improvement
Components: validator
Versions: 3.2.1
Reporter: Edwin van der Elst
Assignee: Emmanuel Bernard
Priority: Minor
Fix For: 3.2.2
Attachments: ClassValidator.java, validators_patch.txt
I have a suggestion for the following problem:
I created an Validator to check if a 'date'> 'another date'
The annotation looks like this:
@After(property="endDate", after="beginDate", message="End
should be after begin")
Since it involves 2 properties, it is a class-level validation.
Now....
I want multiple 'after' validations on a single bean.
But that is not possible (you can only place an annotation once on a class).
My proposal is to add an annotation 'Validations':
@Validations( {@After(...), @After(..)} )
I could do the multiple validations in a single validatorclass, but I want all the
messages added to the invalidValues array, not a single message.
This change would also require changes in the ClassValidator class.
What do you think of this proposal? Should I add it to Jira (I can propably implement it
if there are no objections to the required changes)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
6440
days inactive
6495
days old
hibernate-issues@lists.jboss.org
10 comments
3 participants
participants (3)
-
Edwin van der Elst (JIRA) -
Emmanuel Bernard (JIRA)
-
John Gilbert (JIRA)