[ http://opensource.atlassian.com/projects/hibernate/browse/HV-457?page=com... ] Kevin Pollet updated HV-457: ---------------------------- Summary: Simplify annotation processor setup in IDEs by providing a shaded jar (was: Simplify IDE setup of annotation processor by providing a shaded jar) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HV-457?page=com... ] Kevin Pollet edited comment on HV-457 at 3/21/11 9:10 AM: ---------------------------------------------------------- I've created a shaded jar with the {{maven-shade-plugin}}. After that, I've configured an annotation processor with this shaded jar in Eclipse, Netbeans and IntelliJ. It seems that all works fine. To configure the annotation processor I've used the following steps: * Eclipse: just add the shaded jar in the Processor path (by default the AP and project classpath are isolated). * Netbeans: Remove {{Classpath for Compiling Sources}} from the Processor path and add the shaded jar. * IntelliJ : Add the shaded jar path in the {{Processor path}} option. was (Author: kevinpollet): I've created a shaded jar with the {{maven-shade-plugin}}. After that, I've configured an annotation processor with this shaded jar in Eclipse, Netbeans and IntelliJ. It seems that all works fine. To configure the annotation processor I've used the following steps: * Eclipse: just add the shaded jar in the Processor path (by default the AP and project classpath are isolated). * Netbeans: Remove {{Classpath for Compiling Sources}} from the Processor path and add the shaded jar. * IntelliJ : Add the shaded jar path in the _Processor path_ option. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HV-457?page=com... ] Kevin Pollet commented on HV-457: --------------------------------- Maybe we could provide two jar of the AP (the shaded and the original AP jar). I'm thinking that the shaded is only a "distribution" artifact of the AP to simplify the user setup in IDEs and the use with the maven annotation plugin (if the shaded jar is deployed with the original jar). The original jar could be used when the AP is added to the project class path (like a normal maven dependency). The disadvantage of this approach is that it can be a source of misuse for the user. WDYT ? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://hibernate.onjira.com/browse/HV-457?page=com.atlassian.jira.plugin... ] Hardy Ferentschik commented on HV-457: -------------------------------------- I became a little reluctant towards shading after our experience with shading in HV directly. Our of interest, why do we need any dependency. Just for the annotations? If so, I had the same issue in meamodelgen which required initially the JPA spec. However, it was just using it, because it was referencing some annotation classes. In the end I as able to remove the dependency and just work with strings. Would that not be an option for the HV AP as well? -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://hibernate.onjira.com/browse/HV-457?page=com.atlassian.jira.plugin... ] Gunnar Morling commented on HV-457: ----------------------------------- {quote} Would that not be an option for the HV AP as well? {quote} The built-in constraints are used to register the supported data-types. Also some other BV annotations are referenced to get the corresponding annotation mirrors. Working with Strings might be an option, although I'm a bit concerned a bit type-safety. On the other hand the BV API doesn't change that frequently. I'll give a try and look how it works out. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://hibernate.onjira.com/browse/HV-457?page=com.atlassian.jira.plugin... ] Hardy Ferentschik commented on HV-457: -------------------------------------- {quote} although I'm a bit concerned a bit type-safety {quote} I would in this case sacrifice the type-safety for the benefit of a single (non shaded) jar. Given the issues you sometimes have with integrating an AP in an IDE, the simpler is really the better. {quote} On the other hand the BV API doesn't change that frequently. {quote} Right. Give it a go. I was initially also a little concerned about dropping the JPA dependency for the metamodelgen generator, but in the end I was pleased with the result. :-) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://hibernate.onjira.com/browse/HV-457?page=com.atlassian.jira.plugin... ] Gunnar Morling updated HV-457: ------------------------------ Fix Version/s: 4.3.0.Beta1 -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://hibernate.onjira.com/browse/HV-457?page=com.atlassian.jira.plugin... ] Gunnar Morling updated HV-457: ------------------------------ Pull Requests: https://github.com/hibernate/hibernate-validator/pull/113 -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira