[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2893?page=c... ] Max Rydahl Andersen updated HHH-2893: ------------------------------------- Component/s: core -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2893?page=c... ] Antony Stubbs updated HHH-2893: ------------------------------- Attachment: hibernate criterion patch.patch Woah. Not at all as easy as I thought. Quite an interesting look into the guts of Hibernate this time though. This is a rough cut first attempt at a fix. It works for me for a query that looks like this: [code] Criteria c2 = s.createCriteria(TankerLog.class); c2.setProjection( Projections.projectionList() .add( Projections.max("id.sampleTimestamp") ) .add( Projections.groupProperty("t.tankerRefId",true) ) .add( Projections.groupProperty("id.variableId",true) ) ); c2.createAlias("tankerHeader", "h"); c2.createAlias("tankerHeader.tanker", "t"); c2.add(Restrictions.in("t.tankerRefId", tankerRefIds)); c2.add(Restrictions.in("id.variableId", varIds)); [/code] those 'true' statements indicate that it's a groupProperty which should not be included in the select. Tomorrow when I get time, I will try running the unit tests. Haven't figured out how they work yet. Until then! -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2893?page=c... ] Max Rydahl Andersen updated HHH-2893: ------------------------------------- Issue Type: Patch (was: Bug) Component/s: (was: core) query-criteria -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2893?page=c... ] Antony Stubbs commented on HHH-2893: ------------------------------------ P.s. The test case for the exclusion of the group by for this criteria: Criteria exclude = s.createCriteria(Student.class).setProjection(Projections.projectionList().add( Projections.max("studentNumber")).add( Projections.groupProperty("name", true)) ); produces this sql: select max(this_.studentId) as y0_ from Student this_ group by this_.name As opposed to this sql for inclusion: select max(this_.studentId) as y0_, this_.name as y1_ from Student this_ group by this_.name The default behaviour where you don't specify an option: Criteria exclude = s.createCriteria(Student.class).setProjection(Projections.projectionList().add( Projections.max("studentNumber")).add( Projections.groupProperty("name") ); produces the same result as if you chose to not exclude it select max(this_.studentId) as y0_, this_.name as y1_ from Student this_ group by this_.name I have only tested this on the default db (hsqldb) as the test runner uses. This should definitely be tested on the other databases as well. Do you have a process for doing that? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2893?page=c... ] Antony Stubbs commented on HHH-2893: ------------------------------------ I usppose it's more _related_ than dependant... The javadoc comments in the other patch helped me to understand how to implement this patch you see. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-2893?page=c... ] Antony Stubbs commented on HHH-2893: ------------------------------------ -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira