[ http://opensource.atlassian.com/projects/hibernate/browse/BVAL-232?page=c... ] Gunnar Morling edited comment on BVAL-232 at 7/8/11 3:31 PM: ------------------------------------------------------------- Adding some possible approaches as discussed on hibernate-dev: Approach #1a: A generic constraint similar to HV's @ScriptAssert which would allow to use script expressions in place like this: {code:java} @ParameterAssert(script="args[1].before(args[2])", lang="javascript") void bookHotel(@NotNull @Valid Customer customer, Date from, Date to); {code} was (Author: gunnar.morling): Adding some possible approaches as discussed on hibernate-dev: Approach #1a: A generic constraint similar to HV's @ScriptAssert which would allow to use script expressions in place like this: @ParameterAssert(script="args[1].before(args[2])", lang="javascript") void bookHotel(@NotNull @Valid Customer customer, Date from, Date to); -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/BVAL-232?page=c... ] Gunnar Morling commented on BVAL-232: ------------------------------------- Approach #2a: Use dedicated constraints/validators: {code:java} @DateParameterCheck void bookHotel(@NotNull @Valid Customer customer, Date from, Date to); {code} The validator for the constraint would get passed the parameter values as array/list, maybe one would have a new interface {{MethodConstraintValidator}} for this: {code:java} public class DateParameterCheckValidator implements MethodConstraintValidator<DateParameterCheck> { public void initialize(DateParameterCheck constraint) {} public boolean isValid(Object[] parameterValues, ConstraintValidatorContext context) { return ((Date)parameterValues[1]).before((Date)parameterValues[2]); } } {code} -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/BVAL-232?page=c... ] Gunnar Morling edited comment on BVAL-232 at 7/8/11 3:41 PM: ------------------------------------------------------------- Approach #2a: Use dedicated constraints/validators: {code:java} @DateParameterCheck void bookHotel(@NotNull @Valid Customer customer, Date from, Date to); {code} The validator for the constraint would get passed the parameter values as array/list, maybe one would have a new interface {{MethodConstraintValidator}} for this: {code:java} public class DateParameterCheckValidator implements MethodConstraintValidator<DateParameterCheck> { @Override public void initialize(DateParameterCheck constraint) {} @Override public boolean isValid(Object[] parameterValues, ConstraintValidatorContext context) { return ((Date)parameterValues[1]).before((Date)parameterValues[2]); } } {code} was (Author: gunnar.morling): Approach #2a: Use dedicated constraints/validators: {code:java} @DateParameterCheck void bookHotel(@NotNull @Valid Customer customer, Date from, Date to); {code} The validator for the constraint would get passed the parameter values as array/list, maybe one would have a new interface {{MethodConstraintValidator}} for this: {code:java} public class DateParameterCheckValidator implements MethodConstraintValidator<DateParameterCheck> { public void initialize(DateParameterCheck constraint) {} public boolean isValid(Object[] parameterValues, ConstraintValidatorContext context) { return ((Date)parameterValues[1]).before((Date)parameterValues[2]); } } {code} -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/BVAL-232?page=c... ] Emmanuel Bernard commented on BVAL-232: --------------------------------------- I like 2b but... I don't think Java can properly model this in a type-safe way. I know Ceylon can but afaik that's the only language that can. In other words nothing will prevent someone from writing the wrong signature. 1. can be built atop 2.a. And regardless, I think we should offer 2.a. I guess what we could do is have the interface be 2.a. and allow other isValid methods (a la 2.b) and call them upon matching. Not sure I like that but that should be explored. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/BVAL-232?page=c... ] Gunnar Morling updated BVAL-232: -------------------------------- Issue Type: Sub-task (was: New Feature) Parent: BVAL-241 -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/BVAL-232?page=c... ] Hardy Ferentschik commented on BVAL-232: ---------------------------------------- +1 for 2a -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://hibernate.onjira.com/browse/BVAL-232?page=com.atlassian.jira.plug... ] Gunnar Morling updated BVAL-232: -------------------------------- Parent Issue: BVAL-272 (was: BVAL-241) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira