[Hibernate-JIRA] Created: (HHH-5042) TableGenerator does not increment hibernate_sequences.next_hi_value anymore after having exhausted the current lo-range
3:07 a.m.
TableGenerator does not increment hibernate_sequences.next_hi_value anymore after having
exhausted the current lo-range
-----------------------------------------------------------------------------------------------------------------------
Key: HHH-5042
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5042
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.5.0-CR-2, 3.5.0-CR-1, 3.5.0-Beta-4, 3.5.0-Beta-3, 3.5.0-Beta-2,
3.5.0.Beta-1
Environment: Hibernate: 3.5 , db: HSQLDB (not relevant)
Reporter: Guenther Demetz
Priority: Critical
Attachments: TestTableGenerator.java
This bug is new in 3.5
In version 3.5 class MultipleHiLoPerTableGenerator.java was modified introducing a
new increment variable
IntegralDataTypeHolder value;
along with
int lo;
The problem in the new code is that only value get's incremented whilst variable lo
is still used to check when a new hiVal must be obtained.
if ( lo > maxLo ) {
IntegralDataTypeHolder hiVal = (IntegralDataTypeHolder) doWorkInNewTransaction( session
);
as lo is never incremented, MultipleHiLoPerTableGenerator continues to deliver numbers
without ever update
hibernate_sequences.next_hi_value on the database (only one unique update is propagates at
the first insert)
This lead to duplicate keys as soon another session from another sessionfactory tries to
insert new objects on the concerning table.
Please see attached testcase.
IMPORTANT ADVICE TO RUN THE TESTCASE:
as the testcase uses 2 sessionfactories hibernate.hbm2ddl.auto=create cannot be used!!
Schema has to be exported separately and the testcase must run without hbm2ddl.auto
property!
Here the schema for HSQLDB:
create table A (oid bigint not null, name varchar(255), version integer not null, primary
key (oid), unique (name))
create table hibernate_sequences ( sequence_name varchar(255), sequence_next_hi_value
integer )
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
3:11 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-5042) TableGenerator does not increment hibernate_sequences.next_hi_value anymore after having exhausted the current lo-range
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5042?page=c...
]
Guenther Demetz commented on HHH-5042:
--------------------------------------
Advice: The attached file is a JAR file not a Java file.
I should have named it TestTableGenerator.jar instead to name it TestTableGenerator.java,
sorry.
TableGenerator does not increment hibernate_sequences.next_hi_value
anymore after having exhausted the current lo-range
-----------------------------------------------------------------------------------------------------------------------
Key: HHH-5042
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5042
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.5.0.Beta-1, 3.5.0-Beta-2, 3.5.0-Beta-3, 3.5.0-Beta-4, 3.5.0-CR-1,
3.5.0-CR-2
Environment: Hibernate: 3.5 , db: HSQLDB (not relevant)
Reporter: Guenther Demetz
Priority: Critical
Attachments: TestTableGenerator.java
This bug is new in 3.5
In version 3.5 class MultipleHiLoPerTableGenerator.java was modified introducing a
new increment variable
IntegralDataTypeHolder value;
along with
int lo;
The problem in the new code is that only value get's incremented whilst variable lo
is still used to check when a new hiVal must be obtained.
if ( lo > maxLo ) {
IntegralDataTypeHolder hiVal = (IntegralDataTypeHolder) doWorkInNewTransaction( session
);
as lo is never incremented, MultipleHiLoPerTableGenerator continues to deliver numbers
without ever update
hibernate_sequences.next_hi_value on the database (only one unique update is propagates
at the first insert)
This lead to duplicate keys as soon another session from another sessionfactory tries to
insert new objects on the concerning table.
Please see attached testcase.
IMPORTANT ADVICE TO RUN THE TESTCASE:
as the testcase uses 2 sessionfactories hibernate.hbm2ddl.auto=create cannot be used!!
Schema has to be exported separately and the testcase must run without hbm2ddl.auto
property!
Here the schema for HSQLDB:
create table A (oid bigint not null, name varchar(255), version integer not null, primary
key (oid), unique (name))
create table hibernate_sequences ( sequence_name varchar(255), sequence_next_hi_value
integer )
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:40 a.m.
New subject: [Hibernate-JIRA] Updated: (HHH-5042) TableGenerator does not increment hibernate_sequences.next_hi_value anymore after having exhausted the current lo-range
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5042?page=c...
]
Guenther Demetz updated HHH-5042:
---------------------------------
Attachment: TestHiloGenerators.jar
Also classes TableHiLoGenerator and SequenceHiLoGenerator are affect of the same bug.
Please see attached Testcase
TestHiloGenerators.jar (please ignore the prior testcase attachment )
It also contains patches (based on version 3.5-CR2) for classes
MultipleHiLoPerTableGenerator.java and TableHiLoGenerator.java
(testcase + patch on SequenceHiLoGenerator still todo).
TableGenerator does not increment hibernate_sequences.next_hi_value
anymore after having exhausted the current lo-range
-----------------------------------------------------------------------------------------------------------------------
Key: HHH-5042
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5042
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.5.0.Beta-1, 3.5.0-Beta-2, 3.5.0-Beta-3, 3.5.0-Beta-4, 3.5.0-CR-1,
3.5.0-CR-2
Environment: Hibernate: 3.5 , db: HSQLDB (not relevant)
Reporter: Guenther Demetz
Priority: Critical
Attachments: TestHiloGenerators.jar, TestTableGenerator.java
This bug is new in 3.5
In version 3.5 class MultipleHiLoPerTableGenerator.java was modified introducing a
new increment variable
IntegralDataTypeHolder value;
along with
int lo;
The problem in the new code is that only value get's incremented whilst variable lo
is still used to check when a new hiVal must be obtained.
if ( lo > maxLo ) {
IntegralDataTypeHolder hiVal = (IntegralDataTypeHolder) doWorkInNewTransaction( session
);
as lo is never incremented, MultipleHiLoPerTableGenerator continues to deliver numbers
without ever update
hibernate_sequences.next_hi_value on the database (only one unique update is propagates
at the first insert)
This lead to duplicate keys as soon another session from another sessionfactory tries to
insert new objects on the concerning table.
Please see attached testcase.
IMPORTANT ADVICE TO RUN THE TESTCASE:
as the testcase uses 2 sessionfactories hibernate.hbm2ddl.auto=create cannot be used!!
Schema has to be exported separately and the testcase must run without hbm2ddl.auto
property!
Here the schema for HSQLDB:
create table A (oid bigint not null, name varchar(255), version integer not null, primary
key (oid), unique (name))
create table hibernate_sequences ( sequence_name varchar(255), sequence_next_hi_value
integer )
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:46 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-5042) TableGenerator does not increment hibernate_sequences.next_hi_value anymore after having exhausted the current lo-range
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5042?page=c...
]
Guenther Demetz commented on HHH-5042:
--------------------------------------
Here again the complete revised schema for running the attached junit tests (HSQLDB):
create table A (oid bigint not null, name varchar(255), version integer not null, primary
key (oid), unique (name))
create table F (oid bigint not null, name varchar(255), primary key (oid), unique (name))
create table hibernate_sequences ( sequence_name varchar(255), sequence_next_hi_value
integer )
create table hibernate_unique_key ( next_hi integer )
TableGenerator does not increment hibernate_sequences.next_hi_value
anymore after having exhausted the current lo-range
-----------------------------------------------------------------------------------------------------------------------
Key: HHH-5042
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5042
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.5.0.Beta-1, 3.5.0-Beta-2, 3.5.0-Beta-3, 3.5.0-Beta-4, 3.5.0-CR-1,
3.5.0-CR-2
Environment: Hibernate: 3.5 , db: HSQLDB (not relevant)
Reporter: Guenther Demetz
Priority: Critical
Attachments: TestHiloGenerators.jar, TestTableGenerator.java
This bug is new in 3.5
In version 3.5 class MultipleHiLoPerTableGenerator.java was modified introducing a
new increment variable
IntegralDataTypeHolder value;
along with
int lo;
The problem in the new code is that only value get's incremented whilst variable lo
is still used to check when a new hiVal must be obtained.
if ( lo > maxLo ) {
IntegralDataTypeHolder hiVal = (IntegralDataTypeHolder) doWorkInNewTransaction( session
);
as lo is never incremented, MultipleHiLoPerTableGenerator continues to deliver numbers
without ever update
hibernate_sequences.next_hi_value on the database (only one unique update is propagates
at the first insert)
This lead to duplicate keys as soon another session from another sessionfactory tries to
insert new objects on the concerning table.
Please see attached testcase.
IMPORTANT ADVICE TO RUN THE TESTCASE:
as the testcase uses 2 sessionfactories hibernate.hbm2ddl.auto=create cannot be used!!
Schema has to be exported separately and the testcase must run without hbm2ddl.auto
property!
Here the schema for HSQLDB:
create table A (oid bigint not null, name varchar(255), version integer not null, primary
key (oid), unique (name))
create table hibernate_sequences ( sequence_name varchar(255), sequence_next_hi_value
integer )
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5:31 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-5042) TableGenerator does not increment hibernate_sequences.next_hi_value anymore after having exhausted the current lo-range
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5042?page=c...
]
Gail Badner commented on HHH-5042:
----------------------------------
Does this issue duplicate or relate to HHH-5053?
Is this still an issue using 3.5.1?
TableGenerator does not increment hibernate_sequences.next_hi_value
anymore after having exhausted the current lo-range
-----------------------------------------------------------------------------------------------------------------------
Key: HHH-5042
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5042
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.5.0.Beta-1, 3.5.0-Beta-2, 3.5.0-Beta-3, 3.5.0-Beta-4, 3.5.0-CR-1,
3.5.0-CR-2
Environment: Hibernate: 3.5 , db: HSQLDB (not relevant)
Reporter: Guenther Demetz
Priority: Critical
Attachments: TestHiloGenerators.jar, TestTableGenerator.java
This bug is new in 3.5
In version 3.5 class MultipleHiLoPerTableGenerator.java was modified introducing a
new increment variable
IntegralDataTypeHolder value;
along with
int lo;
The problem in the new code is that only value get's incremented whilst variable lo
is still used to check when a new hiVal must be obtained.
if ( lo > maxLo ) {
IntegralDataTypeHolder hiVal = (IntegralDataTypeHolder) doWorkInNewTransaction( session
);
as lo is never incremented, MultipleHiLoPerTableGenerator continues to deliver numbers
without ever update
hibernate_sequences.next_hi_value on the database (only one unique update is propagates
at the first insert)
This lead to duplicate keys as soon another session from another sessionfactory tries to
insert new objects on the concerning table.
Please see attached testcase.
IMPORTANT ADVICE TO RUN THE TESTCASE:
as the testcase uses 2 sessionfactories hibernate.hbm2ddl.auto=create cannot be used!!
Schema has to be exported separately and the testcase must run without hbm2ddl.auto
property!
Here the schema for HSQLDB:
create table A (oid bigint not null, name varchar(255), version integer not null, primary
key (oid), unique (name))
create table hibernate_sequences ( sequence_name varchar(255), sequence_next_hi_value
integer )
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:40 p.m.
New subject: [Hibernate-JIRA] Updated: (HHH-5042) TableGenerator does not increment hibernate_sequences.next_hi_value anymore after having exhausted the current lo-range
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5042?page=c...
]
Gail Badner updated HHH-5042:
-----------------------------
Affects Version/s: 3.5.1
Fix Version/s: 3.5.x
This is confirmed to be an issue in 3.5.1 by Rostic Sheykhet in HHH-5053.
TableGenerator does not increment hibernate_sequences.next_hi_value
anymore after having exhausted the current lo-range
-----------------------------------------------------------------------------------------------------------------------
Key: HHH-5042
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5042
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.5.0.Beta-1, 3.5.0-Beta-2, 3.5.0-Beta-3, 3.5.0-Beta-4, 3.5.0-CR-1,
3.5.0-CR-2, 3.5.1
Environment: Hibernate: 3.5 , db: HSQLDB (not relevant)
Reporter: Guenther Demetz
Priority: Critical
Fix For: 3.5.x
Attachments: TestHiloGenerators.jar, TestTableGenerator.java
This bug is new in 3.5
In version 3.5 class MultipleHiLoPerTableGenerator.java was modified introducing a
new increment variable
IntegralDataTypeHolder value;
along with
int lo;
The problem in the new code is that only value get's incremented whilst variable lo
is still used to check when a new hiVal must be obtained.
if ( lo > maxLo ) {
IntegralDataTypeHolder hiVal = (IntegralDataTypeHolder) doWorkInNewTransaction( session
);
as lo is never incremented, MultipleHiLoPerTableGenerator continues to deliver numbers
without ever update
hibernate_sequences.next_hi_value on the database (only one unique update is propagates
at the first insert)
This lead to duplicate keys as soon another session from another sessionfactory tries to
insert new objects on the concerning table.
Please see attached testcase.
IMPORTANT ADVICE TO RUN THE TESTCASE:
as the testcase uses 2 sessionfactories hibernate.hbm2ddl.auto=create cannot be used!!
Schema has to be exported separately and the testcase must run without hbm2ddl.auto
property!
Here the schema for HSQLDB:
create table A (oid bigint not null, name varchar(255), version integer not null, primary
key (oid), unique (name))
create table hibernate_sequences ( sequence_name varchar(255), sequence_next_hi_value
integer )
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:51 p.m.
New subject: [Hibernate-JIRA] Updated: (HHH-5042) TableGenerator does not increment hibernate_sequences.next_hi_value anymore after having exhausted the current lo-range
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5042?page=c...
]
Gail Badner updated HHH-5042:
-----------------------------
Fix Version/s: 3.6
TableGenerator does not increment hibernate_sequences.next_hi_value
anymore after having exhausted the current lo-range
-----------------------------------------------------------------------------------------------------------------------
Key: HHH-5042
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5042
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.5.0.Beta-1, 3.5.0-Beta-2, 3.5.0-Beta-3, 3.5.0-Beta-4, 3.5.0-CR-1,
3.5.0-CR-2, 3.5.1
Environment: Hibernate: 3.5 , db: HSQLDB (not relevant)
Reporter: Guenther Demetz
Priority: Critical
Fix For: 3.5.x, 3.6
Attachments: TestHiloGenerators.jar, TestTableGenerator.java
This bug is new in 3.5
In version 3.5 class MultipleHiLoPerTableGenerator.java was modified introducing a
new increment variable
IntegralDataTypeHolder value;
along with
int lo;
The problem in the new code is that only value get's incremented whilst variable lo
is still used to check when a new hiVal must be obtained.
if ( lo > maxLo ) {
IntegralDataTypeHolder hiVal = (IntegralDataTypeHolder) doWorkInNewTransaction( session
);
as lo is never incremented, MultipleHiLoPerTableGenerator continues to deliver numbers
without ever update
hibernate_sequences.next_hi_value on the database (only one unique update is propagates
at the first insert)
This lead to duplicate keys as soon another session from another sessionfactory tries to
insert new objects on the concerning table.
Please see attached testcase.
IMPORTANT ADVICE TO RUN THE TESTCASE:
as the testcase uses 2 sessionfactories hibernate.hbm2ddl.auto=create cannot be used!!
Schema has to be exported separately and the testcase must run without hbm2ddl.auto
property!
Here the schema for HSQLDB:
create table A (oid bigint not null, name varchar(255), version integer not null, primary
key (oid), unique (name))
create table hibernate_sequences ( sequence_name varchar(255), sequence_next_hi_value
integer )
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:47 a.m.
New subject: [Hibernate-JIRA] Updated: (HHH-5042) TableGenerator does not increment hibernate_sequences.next_hi_value anymore after having exhausted the current lo-range
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5042?page=c...
]
Steve Ebersole updated HHH-5042:
--------------------------------
Assignee: Steve Ebersole
TableGenerator does not increment hibernate_sequences.next_hi_value
anymore after having exhausted the current lo-range
-----------------------------------------------------------------------------------------------------------------------
Key: HHH-5042
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5042
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.5.0.Beta-1, 3.5.0-Beta-2, 3.5.0-Beta-3, 3.5.0-Beta-4, 3.5.0-CR-1,
3.5.0-CR-2, 3.5.1
Environment: Hibernate: 3.5 , db: HSQLDB (not relevant)
Reporter: Guenther Demetz
Assignee: Steve Ebersole
Priority: Critical
Fix For: 3.5.x, 3.6
Attachments: TestHiloGenerators.jar, TestTableGenerator.java
This bug is new in 3.5
In version 3.5 class MultipleHiLoPerTableGenerator.java was modified introducing a
new increment variable
IntegralDataTypeHolder value;
along with
int lo;
The problem in the new code is that only value get's incremented whilst variable lo
is still used to check when a new hiVal must be obtained.
if ( lo > maxLo ) {
IntegralDataTypeHolder hiVal = (IntegralDataTypeHolder) doWorkInNewTransaction( session
);
as lo is never incremented, MultipleHiLoPerTableGenerator continues to deliver numbers
without ever update
hibernate_sequences.next_hi_value on the database (only one unique update is propagates
at the first insert)
This lead to duplicate keys as soon another session from another sessionfactory tries to
insert new objects on the concerning table.
Please see attached testcase.
IMPORTANT ADVICE TO RUN THE TESTCASE:
as the testcase uses 2 sessionfactories hibernate.hbm2ddl.auto=create cannot be used!!
Schema has to be exported separately and the testcase must run without hbm2ddl.auto
property!
Here the schema for HSQLDB:
create table A (oid bigint not null, name varchar(255), version integer not null, primary
key (oid), unique (name))
create table hibernate_sequences ( sequence_name varchar(255), sequence_next_hi_value
integer )
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:28 p.m.
New subject: [Hibernate-JIRA] Resolved: (HHH-5042) TableGenerator does not increment hibernate_sequences.next_hi_value anymore after having exhausted the current lo-range
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5042?page=c...
]
Steve Ebersole resolved HHH-5042.
---------------------------------
Resolution: Fixed
Fix Version/s: (was: 3.5.x)
3.5.2
TableGenerator does not increment hibernate_sequences.next_hi_value
anymore after having exhausted the current lo-range
-----------------------------------------------------------------------------------------------------------------------
Key: HHH-5042
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5042
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.5.0.Beta-1, 3.5.0-Beta-2, 3.5.0-Beta-3, 3.5.0-Beta-4, 3.5.0-CR-1,
3.5.0-CR-2, 3.5.1
Environment: Hibernate: 3.5 , db: HSQLDB (not relevant)
Reporter: Guenther Demetz
Assignee: Steve Ebersole
Priority: Critical
Fix For: 3.6, 3.5.2
Attachments: TestHiloGenerators.jar, TestTableGenerator.java
Time Spent: 3h 35m
Remaining Estimate: 0h
This bug is new in 3.5
In version 3.5 class MultipleHiLoPerTableGenerator.java was modified introducing a
new increment variable
IntegralDataTypeHolder value;
along with
int lo;
The problem in the new code is that only value get's incremented whilst variable lo
is still used to check when a new hiVal must be obtained.
if ( lo > maxLo ) {
IntegralDataTypeHolder hiVal = (IntegralDataTypeHolder) doWorkInNewTransaction( session
);
as lo is never incremented, MultipleHiLoPerTableGenerator continues to deliver numbers
without ever update
hibernate_sequences.next_hi_value on the database (only one unique update is propagates
at the first insert)
This lead to duplicate keys as soon another session from another sessionfactory tries to
insert new objects on the concerning table.
Please see attached testcase.
IMPORTANT ADVICE TO RUN THE TESTCASE:
as the testcase uses 2 sessionfactories hibernate.hbm2ddl.auto=create cannot be used!!
Schema has to be exported separately and the testcase must run without hbm2ddl.auto
property!
Here the schema for HSQLDB:
create table A (oid bigint not null, name varchar(255), version integer not null, primary
key (oid), unique (name))
create table hibernate_sequences ( sequence_name varchar(255), sequence_next_hi_value
integer )
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:27 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-5042) TableGenerator does not increment hibernate_sequences.next_hi_value anymore after having exhausted the current lo-range
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5042?page=c...
]
Mike Youngstrom commented on HHH-5042:
--------------------------------------
I wonder if fixing this issue might have caused a regression. In my application I'm
using Oracle and @SequenceGenerator with an allocationSize=1 after upgrading to 3.5.2 I
get an error on startup: If I change my allocationSize to 2 then it starts up fine but
debugging into LegacyHiLoAlgorithmOptimizer it sets a value of 1.
Caused by: javax.persistence.PersistenceException: [PersistenceUnit:
org.lds.stack.stack-pet-store-ws] Unable to build EntityManagerFactory
at
org.hibernate.ejb.Ejb3Configuration.buildEntityManagerFactory(Ejb3Configuration.java:896)
at
org.hibernate.ejb.HibernatePersistence.createContainerEntityManagerFactory(HibernatePersistence.java:73)
at
org.springframework.orm.jpa.LocalContainerEntityManagerFactoryBean.createNativeEntityManagerFactory(LocalContainerEntityManagerFactoryBean.java:225)
at
org.springframework.orm.jpa.AbstractEntityManagerFactoryBean.afterPropertiesSet(AbstractEntityManagerFactoryBean.java:308)
at
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.invokeInitMethods(AbstractAutowireCapableBeanFactory.java:1469)
at
org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.initializeBean(AbstractAutowireCapableBeanFactory.java:1409)
... 38 more
Caused by: org.hibernate.MappingException: Could not instantiate id generator
[entity-name=org.lds.stack.petstore.model.Animal]
at
org.hibernate.id.factory.DefaultIdentifierGeneratorFactory.createIdentifierGenerator(DefaultIdentifierGeneratorFactory.java:117)
at org.hibernate.mapping.SimpleValue.createIdentifierGenerator(SimpleValue.java:178)
at org.hibernate.impl.SessionFactoryImpl.<init>(SessionFactoryImpl.java:257)
at org.hibernate.cfg.Configuration.buildSessionFactory(Configuration.java:1385)
at
org.hibernate.cfg.AnnotationConfiguration.buildSessionFactory(AnnotationConfiguration.java:954)
at
org.hibernate.ejb.Ejb3Configuration.buildEntityManagerFactory(Ejb3Configuration.java:887)
... 43 more
Caused by: org.hibernate.HibernateException: increment size cannot be less than 1
at
org.hibernate.id.enhanced.OptimizerFactory$LegacyHiLoAlgorithmOptimizer.<init>(OptimizerFactory.java:336)
at org.hibernate.id.SequenceHiLoGenerator.configure(SequenceHiLoGenerator.java:64)
at
org.hibernate.id.factory.DefaultIdentifierGeneratorFactory.createIdentifierGenerator(DefaultIdentifierGeneratorFactory.java:110)
... 48 more
TableGenerator does not increment hibernate_sequences.next_hi_value
anymore after having exhausted the current lo-range
-----------------------------------------------------------------------------------------------------------------------
Key: HHH-5042
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5042
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.5.0.Beta-1, 3.5.0-Beta-2, 3.5.0-Beta-3, 3.5.0-Beta-4, 3.5.0-CR-1,
3.5.0-CR-2, 3.5.1
Environment: Hibernate: 3.5 , db: HSQLDB (not relevant)
Reporter: Guenther Demetz
Assignee: Steve Ebersole
Priority: Critical
Fix For: 3.5.2, 3.6
Attachments: TestHiloGenerators.jar, TestTableGenerator.java
Time Spent: 3h 35m
Remaining Estimate: 0h
This bug is new in 3.5
In version 3.5 class MultipleHiLoPerTableGenerator.java was modified introducing a
new increment variable
IntegralDataTypeHolder value;
along with
int lo;
The problem in the new code is that only value get's incremented whilst variable lo
is still used to check when a new hiVal must be obtained.
if ( lo > maxLo ) {
IntegralDataTypeHolder hiVal = (IntegralDataTypeHolder) doWorkInNewTransaction( session
);
as lo is never incremented, MultipleHiLoPerTableGenerator continues to deliver numbers
without ever update
hibernate_sequences.next_hi_value on the database (only one unique update is propagates
at the first insert)
This lead to duplicate keys as soon another session from another sessionfactory tries to
insert new objects on the concerning table.
Please see attached testcase.
IMPORTANT ADVICE TO RUN THE TESTCASE:
as the testcase uses 2 sessionfactories hibernate.hbm2ddl.auto=create cannot be used!!
Schema has to be exported separately and the testcase must run without hbm2ddl.auto
property!
Here the schema for HSQLDB:
create table A (oid bigint not null, name varchar(255), version integer not null, primary
key (oid), unique (name))
create table hibernate_sequences ( sequence_name varchar(255), sequence_next_hi_value
integer )
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
6:32 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-5042) TableGenerator does not increment hibernate_sequences.next_hi_value anymore after having exhausted the current lo-range
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5042?page=c...
]
atomicknight commented on HHH-5042:
-----------------------------------
I'm also seeing the same error on PostgreSQL 8.4.3 (using allocationSize=1). This
error definitely wasn't there in previous 3.5.x releases.
TableGenerator does not increment hibernate_sequences.next_hi_value
anymore after having exhausted the current lo-range
-----------------------------------------------------------------------------------------------------------------------
Key: HHH-5042
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5042
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.5.0.Beta-1, 3.5.0-Beta-2, 3.5.0-Beta-3, 3.5.0-Beta-4, 3.5.0-CR-1,
3.5.0-CR-2, 3.5.1
Environment: Hibernate: 3.5 , db: HSQLDB (not relevant)
Reporter: Guenther Demetz
Assignee: Steve Ebersole
Priority: Critical
Fix For: 3.5.2, 3.6
Attachments: TestHiloGenerators.jar, TestTableGenerator.java
Time Spent: 3h 35m
Remaining Estimate: 0h
This bug is new in 3.5
In version 3.5 class MultipleHiLoPerTableGenerator.java was modified introducing a
new increment variable
IntegralDataTypeHolder value;
along with
int lo;
The problem in the new code is that only value get's incremented whilst variable lo
is still used to check when a new hiVal must be obtained.
if ( lo > maxLo ) {
IntegralDataTypeHolder hiVal = (IntegralDataTypeHolder) doWorkInNewTransaction( session
);
as lo is never incremented, MultipleHiLoPerTableGenerator continues to deliver numbers
without ever update
hibernate_sequences.next_hi_value on the database (only one unique update is propagates
at the first insert)
This lead to duplicate keys as soon another session from another sessionfactory tries to
insert new objects on the concerning table.
Please see attached testcase.
IMPORTANT ADVICE TO RUN THE TESTCASE:
as the testcase uses 2 sessionfactories hibernate.hbm2ddl.auto=create cannot be used!!
Schema has to be exported separately and the testcase must run without hbm2ddl.auto
property!
Here the schema for HSQLDB:
create table A (oid bigint not null, name varchar(255), version integer not null, primary
key (oid), unique (name))
create table hibernate_sequences ( sequence_name varchar(255), sequence_next_hi_value
integer )
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:42 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-5042) TableGenerator does not increment hibernate_sequences.next_hi_value anymore after having exhausted the current lo-range
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5042?page=c...
]
Mike Youngstrom commented on HHH-5042:
--------------------------------------
Created an issue HHH-5230 to track this regression.
TableGenerator does not increment hibernate_sequences.next_hi_value
anymore after having exhausted the current lo-range
-----------------------------------------------------------------------------------------------------------------------
Key: HHH-5042
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5042
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.5.0.Beta-1, 3.5.0-Beta-2, 3.5.0-Beta-3, 3.5.0-Beta-4, 3.5.0-CR-1,
3.5.0-CR-2, 3.5.1
Environment: Hibernate: 3.5 , db: HSQLDB (not relevant)
Reporter: Guenther Demetz
Assignee: Steve Ebersole
Priority: Critical
Fix For: 3.5.2, 3.6
Attachments: TestHiloGenerators.jar, TestTableGenerator.java
Time Spent: 3h 35m
Remaining Estimate: 0h
This bug is new in 3.5
In version 3.5 class MultipleHiLoPerTableGenerator.java was modified introducing a
new increment variable
IntegralDataTypeHolder value;
along with
int lo;
The problem in the new code is that only value get's incremented whilst variable lo
is still used to check when a new hiVal must be obtained.
if ( lo > maxLo ) {
IntegralDataTypeHolder hiVal = (IntegralDataTypeHolder) doWorkInNewTransaction( session
);
as lo is never incremented, MultipleHiLoPerTableGenerator continues to deliver numbers
without ever update
hibernate_sequences.next_hi_value on the database (only one unique update is propagates
at the first insert)
This lead to duplicate keys as soon another session from another sessionfactory tries to
insert new objects on the concerning table.
Please see attached testcase.
IMPORTANT ADVICE TO RUN THE TESTCASE:
as the testcase uses 2 sessionfactories hibernate.hbm2ddl.auto=create cannot be used!!
Schema has to be exported separately and the testcase must run without hbm2ddl.auto
property!
Here the schema for HSQLDB:
create table A (oid bigint not null, name varchar(255), version integer not null, primary
key (oid), unique (name))
create table hibernate_sequences ( sequence_name varchar(255), sequence_next_hi_value
integer )
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:25 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-5042) TableGenerator does not increment hibernate_sequences.next_hi_value anymore after having exhausted the current lo-range
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5042?page=c...
]
Martin Gubser commented on HHH-5042:
------------------------------------
It seems that this issue is not solved!
Running the attached test program twice results in a constraint violation because the same
Id is given twice.
TableGenerator does not increment hibernate_sequences.next_hi_value
anymore after having exhausted the current lo-range
-----------------------------------------------------------------------------------------------------------------------
Key: HHH-5042
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5042
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.5.0.Beta-1, 3.5.0-Beta-2, 3.5.0-Beta-3, 3.5.0-Beta-4, 3.5.0-CR-1,
3.5.0-CR-2, 3.5.1
Environment: Hibernate: 3.5 , db: HSQLDB (not relevant)
Reporter: Guenther Demetz
Assignee: Steve Ebersole
Priority: Critical
Fix For: 3.5.2, 3.6
Attachments: TestHiloGenerators.jar, TestTableGenerator.java
Time Spent: 3h 35m
Remaining Estimate: 0h
This bug is new in 3.5
In version 3.5 class MultipleHiLoPerTableGenerator.java was modified introducing a
new increment variable
IntegralDataTypeHolder value;
along with
int lo;
The problem in the new code is that only value get's incremented whilst variable lo
is still used to check when a new hiVal must be obtained.
if ( lo > maxLo ) {
IntegralDataTypeHolder hiVal = (IntegralDataTypeHolder) doWorkInNewTransaction( session
);
as lo is never incremented, MultipleHiLoPerTableGenerator continues to deliver numbers
without ever update
hibernate_sequences.next_hi_value on the database (only one unique update is propagates
at the first insert)
This lead to duplicate keys as soon another session from another sessionfactory tries to
insert new objects on the concerning table.
Please see attached testcase.
IMPORTANT ADVICE TO RUN THE TESTCASE:
as the testcase uses 2 sessionfactories hibernate.hbm2ddl.auto=create cannot be used!!
Schema has to be exported separately and the testcase must run without hbm2ddl.auto
property!
Here the schema for HSQLDB:
create table A (oid bigint not null, name varchar(255), version integer not null, primary
key (oid), unique (name))
create table hibernate_sequences ( sequence_name varchar(255), sequence_next_hi_value
integer )
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:27 p.m.
New subject: [Hibernate-JIRA] Updated: (HHH-5042) TableGenerator does not increment hibernate_sequences.next_hi_value anymore after having exhausted the current lo-range
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5042?page=c...
]
Martin Gubser updated HHH-5042:
-------------------------------
Attachment: HiLoTest.java
A.java
Sorry, here are the files
TableGenerator does not increment hibernate_sequences.next_hi_value
anymore after having exhausted the current lo-range
-----------------------------------------------------------------------------------------------------------------------
Key: HHH-5042
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5042
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.5.0.Beta-1, 3.5.0-Beta-2, 3.5.0-Beta-3, 3.5.0-Beta-4, 3.5.0-CR-1,
3.5.0-CR-2, 3.5.1
Environment: Hibernate: 3.5 , db: HSQLDB (not relevant)
Reporter: Guenther Demetz
Assignee: Steve Ebersole
Priority: Critical
Fix For: 3.5.2, 3.6
Attachments: A.java, HiLoTest.java, TestHiloGenerators.jar,
TestTableGenerator.java
Time Spent: 3h 35m
Remaining Estimate: 0h
This bug is new in 3.5
In version 3.5 class MultipleHiLoPerTableGenerator.java was modified introducing a
new increment variable
IntegralDataTypeHolder value;
along with
int lo;
The problem in the new code is that only value get's incremented whilst variable lo
is still used to check when a new hiVal must be obtained.
if ( lo > maxLo ) {
IntegralDataTypeHolder hiVal = (IntegralDataTypeHolder) doWorkInNewTransaction( session
);
as lo is never incremented, MultipleHiLoPerTableGenerator continues to deliver numbers
without ever update
hibernate_sequences.next_hi_value on the database (only one unique update is propagates
at the first insert)
This lead to duplicate keys as soon another session from another sessionfactory tries to
insert new objects on the concerning table.
Please see attached testcase.
IMPORTANT ADVICE TO RUN THE TESTCASE:
as the testcase uses 2 sessionfactories hibernate.hbm2ddl.auto=create cannot be used!!
Schema has to be exported separately and the testcase must run without hbm2ddl.auto
property!
Here the schema for HSQLDB:
create table A (oid bigint not null, name varchar(255), version integer not null, primary
key (oid), unique (name))
create table hibernate_sequences ( sequence_name varchar(255), sequence_next_hi_value
integer )
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:03 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-5042) TableGenerator does not increment hibernate_sequences.next_hi_value anymore after having exhausted the current lo-range
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5042?page=c...
]
Gail Badner commented on HHH-5042:
----------------------------------
Martin, this has been fixed by HHH-5230.
TableGenerator does not increment hibernate_sequences.next_hi_value
anymore after having exhausted the current lo-range
-----------------------------------------------------------------------------------------------------------------------
Key: HHH-5042
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5042
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.5.0.Beta-1, 3.5.0-Beta-2, 3.5.0-Beta-3, 3.5.0-Beta-4, 3.5.0-CR-1,
3.5.0-CR-2, 3.5.1
Environment: Hibernate: 3.5 , db: HSQLDB (not relevant)
Reporter: Guenther Demetz
Assignee: Steve Ebersole
Priority: Critical
Fix For: 3.5.2, 3.6
Attachments: A.java, HiLoTest.java, TestHiloGenerators.jar,
TestTableGenerator.java
Time Spent: 3h 35m
Remaining Estimate: 0h
This bug is new in 3.5
In version 3.5 class MultipleHiLoPerTableGenerator.java was modified introducing a
new increment variable
IntegralDataTypeHolder value;
along with
int lo;
The problem in the new code is that only value get's incremented whilst variable lo
is still used to check when a new hiVal must be obtained.
if ( lo > maxLo ) {
IntegralDataTypeHolder hiVal = (IntegralDataTypeHolder) doWorkInNewTransaction( session
);
as lo is never incremented, MultipleHiLoPerTableGenerator continues to deliver numbers
without ever update
hibernate_sequences.next_hi_value on the database (only one unique update is propagates
at the first insert)
This lead to duplicate keys as soon another session from another sessionfactory tries to
insert new objects on the concerning table.
Please see attached testcase.
IMPORTANT ADVICE TO RUN THE TESTCASE:
as the testcase uses 2 sessionfactories hibernate.hbm2ddl.auto=create cannot be used!!
Schema has to be exported separately and the testcase must run without hbm2ddl.auto
property!
Here the schema for HSQLDB:
create table A (oid bigint not null, name varchar(255), version integer not null, primary
key (oid), unique (name))
create table hibernate_sequences ( sequence_name varchar(255), sequence_next_hi_value
integer )
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
7:39 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-5042) TableGenerator does not increment hibernate_sequences.next_hi_value anymore after having exhausted the current lo-range
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5042?page=c...
]
Martin Gubser commented on HHH-5042:
------------------------------------
Gail, thanks for you reply. Maybe I do have another problem, but the generator does not
work correctly for me: it increments the hi-value when it grabs the first lo-sequence but
no more when it grabs further lo-sequences. That error shows only if you run the attached
program twice. Setting <property
name="hibernate.id.new_generator_mappings">true</property> in my
hibernate.cfg.xml does not change this behaviour. Connection.pool_size=4, second-level
cache is disabled. Affected versions: 5.1 and 5.2.
Can you run the test program twice without error?
TableGenerator does not increment hibernate_sequences.next_hi_value
anymore after having exhausted the current lo-range
-----------------------------------------------------------------------------------------------------------------------
Key: HHH-5042
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5042
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.5.0.Beta-1, 3.5.0-Beta-2, 3.5.0-Beta-3, 3.5.0-Beta-4, 3.5.0-CR-1,
3.5.0-CR-2, 3.5.1
Environment: Hibernate: 3.5 , db: HSQLDB (not relevant)
Reporter: Guenther Demetz
Assignee: Steve Ebersole
Priority: Critical
Fix For: 3.5.2, 3.6
Attachments: A.java, HiLoTest.java, TestHiloGenerators.jar,
TestTableGenerator.java
Time Spent: 3h 35m
Remaining Estimate: 0h
This bug is new in 3.5
In version 3.5 class MultipleHiLoPerTableGenerator.java was modified introducing a
new increment variable
IntegralDataTypeHolder value;
along with
int lo;
The problem in the new code is that only value get's incremented whilst variable lo
is still used to check when a new hiVal must be obtained.
if ( lo > maxLo ) {
IntegralDataTypeHolder hiVal = (IntegralDataTypeHolder) doWorkInNewTransaction( session
);
as lo is never incremented, MultipleHiLoPerTableGenerator continues to deliver numbers
without ever update
hibernate_sequences.next_hi_value on the database (only one unique update is propagates
at the first insert)
This lead to duplicate keys as soon another session from another sessionfactory tries to
insert new objects on the concerning table.
Please see attached testcase.
IMPORTANT ADVICE TO RUN THE TESTCASE:
as the testcase uses 2 sessionfactories hibernate.hbm2ddl.auto=create cannot be used!!
Schema has to be exported separately and the testcase must run without hbm2ddl.auto
property!
Here the schema for HSQLDB:
create table A (oid bigint not null, name varchar(255), version integer not null, primary
key (oid), unique (name))
create table hibernate_sequences ( sequence_name varchar(255), sequence_next_hi_value
integer )
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:23 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-5042) TableGenerator does not increment hibernate_sequences.next_hi_value anymore after having exhausted the current lo-range
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5042?page=c...
]
Steve Ebersole commented on HHH-5042:
-------------------------------------
Martin, you are not using @TableGenerator nor MultipleHiLoPerTableGenerator. You use a
@GenericGenerator, naming the "hilo" strategy which maps to TableHiLoGenerator.
So if you are having issues with that class, then please open a new issue
TableGenerator does not increment hibernate_sequences.next_hi_value
anymore after having exhausted the current lo-range
-----------------------------------------------------------------------------------------------------------------------
Key: HHH-5042
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5042
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.5.0.Beta-1, 3.5.0-Beta-2, 3.5.0-Beta-3, 3.5.0-Beta-4, 3.5.0-CR-1,
3.5.0-CR-2, 3.5.1
Environment: Hibernate: 3.5 , db: HSQLDB (not relevant)
Reporter: Guenther Demetz
Assignee: Steve Ebersole
Priority: Critical
Fix For: 3.5.2, 3.6
Attachments: A.java, HiLoTest.java, TestHiloGenerators.jar,
TestTableGenerator.java
Time Spent: 3h 35m
Remaining Estimate: 0h
This bug is new in 3.5
In version 3.5 class MultipleHiLoPerTableGenerator.java was modified introducing a
new increment variable
IntegralDataTypeHolder value;
along with
int lo;
The problem in the new code is that only value get's incremented whilst variable lo
is still used to check when a new hiVal must be obtained.
if ( lo > maxLo ) {
IntegralDataTypeHolder hiVal = (IntegralDataTypeHolder) doWorkInNewTransaction( session
);
as lo is never incremented, MultipleHiLoPerTableGenerator continues to deliver numbers
without ever update
hibernate_sequences.next_hi_value on the database (only one unique update is propagates
at the first insert)
This lead to duplicate keys as soon another session from another sessionfactory tries to
insert new objects on the concerning table.
Please see attached testcase.
IMPORTANT ADVICE TO RUN THE TESTCASE:
as the testcase uses 2 sessionfactories hibernate.hbm2ddl.auto=create cannot be used!!
Schema has to be exported separately and the testcase must run without hbm2ddl.auto
property!
Here the schema for HSQLDB:
create table A (oid bigint not null, name varchar(255), version integer not null, primary
key (oid), unique (name))
create table hibernate_sequences ( sequence_name varchar(255), sequence_next_hi_value
integer )
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:23 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-5042) TableGenerator does not increment hibernate_sequences.next_hi_value anymore after having exhausted the current lo-range
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5042?page=c...
]
Steve Ebersole commented on HHH-5042:
-------------------------------------
Or switch generators...
TableGenerator does not increment hibernate_sequences.next_hi_value
anymore after having exhausted the current lo-range
-----------------------------------------------------------------------------------------------------------------------
Key: HHH-5042
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5042
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.5.0.Beta-1, 3.5.0-Beta-2, 3.5.0-Beta-3, 3.5.0-Beta-4, 3.5.0-CR-1,
3.5.0-CR-2, 3.5.1
Environment: Hibernate: 3.5 , db: HSQLDB (not relevant)
Reporter: Guenther Demetz
Assignee: Steve Ebersole
Priority: Critical
Fix For: 3.5.2, 3.6
Attachments: A.java, HiLoTest.java, TestHiloGenerators.jar,
TestTableGenerator.java
Time Spent: 3h 35m
Remaining Estimate: 0h
This bug is new in 3.5
In version 3.5 class MultipleHiLoPerTableGenerator.java was modified introducing a
new increment variable
IntegralDataTypeHolder value;
along with
int lo;
The problem in the new code is that only value get's incremented whilst variable lo
is still used to check when a new hiVal must be obtained.
if ( lo > maxLo ) {
IntegralDataTypeHolder hiVal = (IntegralDataTypeHolder) doWorkInNewTransaction( session
);
as lo is never incremented, MultipleHiLoPerTableGenerator continues to deliver numbers
without ever update
hibernate_sequences.next_hi_value on the database (only one unique update is propagates
at the first insert)
This lead to duplicate keys as soon another session from another sessionfactory tries to
insert new objects on the concerning table.
Please see attached testcase.
IMPORTANT ADVICE TO RUN THE TESTCASE:
as the testcase uses 2 sessionfactories hibernate.hbm2ddl.auto=create cannot be used!!
Schema has to be exported separately and the testcase must run without hbm2ddl.auto
property!
Here the schema for HSQLDB:
create table A (oid bigint not null, name varchar(255), version integer not null, primary
key (oid), unique (name))
create table hibernate_sequences ( sequence_name varchar(255), sequence_next_hi_value
integer )
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:22 p.m.
New subject: [Hibernate-JIRA] Closed: (HHH-5042) TableGenerator does not increment hibernate_sequences.next_hi_value anymore after having exhausted the current lo-range
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-5042?page=c...
]
Steve Ebersole closed HHH-5042.
-------------------------------
TableGenerator does not increment hibernate_sequences.next_hi_value
anymore after having exhausted the current lo-range
-----------------------------------------------------------------------------------------------------------------------
Key: HHH-5042
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5042
Project: Hibernate Core
Issue Type: Bug
Components: core
Affects Versions: 3.5.0.Beta-1, 3.5.0-Beta-2, 3.5.0-Beta-3, 3.5.0-Beta-4, 3.5.0-CR-1,
3.5.0-CR-2, 3.5.1
Environment: Hibernate: 3.5 , db: HSQLDB (not relevant)
Reporter: Guenther Demetz
Assignee: Steve Ebersole
Priority: Critical
Fix For: 3.5.2, 3.6
Attachments: A.java, HiLoTest.java, TestHiloGenerators.jar,
TestTableGenerator.java
Time Spent: 3h 35m
Remaining Estimate: 0h
This bug is new in 3.5
In version 3.5 class MultipleHiLoPerTableGenerator.java was modified introducing a
new increment variable
IntegralDataTypeHolder value;
along with
int lo;
The problem in the new code is that only value get's incremented whilst variable lo
is still used to check when a new hiVal must be obtained.
if ( lo > maxLo ) {
IntegralDataTypeHolder hiVal = (IntegralDataTypeHolder) doWorkInNewTransaction( session
);
as lo is never incremented, MultipleHiLoPerTableGenerator continues to deliver numbers
without ever update
hibernate_sequences.next_hi_value on the database (only one unique update is propagates
at the first insert)
This lead to duplicate keys as soon another session from another sessionfactory tries to
insert new objects on the concerning table.
Please see attached testcase.
IMPORTANT ADVICE TO RUN THE TESTCASE:
as the testcase uses 2 sessionfactories hibernate.hbm2ddl.auto=create cannot be used!!
Schema has to be exported separately and the testcase must run without hbm2ddl.auto
property!
Here the schema for HSQLDB:
create table A (oid bigint not null, name varchar(255), version integer not null, primary
key (oid), unique (name))
create table hibernate_sequences ( sequence_name varchar(255), sequence_next_hi_value
integer )
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5229
days inactive
5341
days old
hibernate-issues@lists.jboss.org
18 comments
6 participants
participants (6)
-
atomicknight (JIRA) -
Gail Badner (JIRA)
-
Guenther Demetz (JIRA)
-
Martin Gubser (JIRA)
-
Mike Youngstrom (JIRA)
-
Steve Ebersole (JIRA)