[Hibernate-JIRA] Created: (HHH-2604) Isolator.JdbcDelegate masks the exception if it isn't possible to open a connection.
4:07 a.m.
Isolator.JdbcDelegate masks the exception if it isn't possible to open a connection.
------------------------------------------------------------------------------------
Key: HHH-2604
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2604
Project: Hibernate3
Issue Type: Bug
Affects Versions: 3.2.4
Environment: Hibernate 3.2.2ga
Reporter: Tushar
Priority: Minor
A defect in Isolator.JdbcDelegate makes it throw the wrong exception - a
NullPointerException - that masks the true exception. In my case it was an
UnsupportedOperationException("The user must supply a JDBC connection").
The trouble is at the start of Isolator.JdbcDelegate.delegateWork(...):
{code}
174 public void delegateWork(IsolatedWork work, boolean transacted) throws
HibernateException {
175 Connection connection = null;
176 boolean wasAutoCommit = false;
177 try {
178 connection = session.getBatcher().openConnection();
{code}
If there is a failure opening a connection on line 178, the finally clause is executed.
The finally clause needs the connection, which of course is null :-)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:09 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2604) Isolator.JdbcDelegate masks the exception if it isn't possible to open a connection.
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2604?page=c...
]
Tushar commented on HHH-2604:
-----------------------------
The environment was Hibernate 3.2.4ga (not 3.2.2)
Isolator.JdbcDelegate masks the exception if it isn't possible to
open a connection.
------------------------------------------------------------------------------------
Key: HHH-2604
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2604
Project: Hibernate3
Issue Type: Bug
Affects Versions: 3.2.4
Environment: Hibernate 3.2.2ga
Reporter: Tushar
Priority: Minor
A defect in Isolator.JdbcDelegate makes it throw the wrong exception - a
NullPointerException - that masks the true exception. In my case it was an
UnsupportedOperationException("The user must supply a JDBC connection").
The trouble is at the start of Isolator.JdbcDelegate.delegateWork(...):
{code}
174 public void delegateWork(IsolatedWork work, boolean transacted) throws
HibernateException {
175 Connection connection = null;
176 boolean wasAutoCommit = false;
177 try {
178 connection = session.getBatcher().openConnection();
{code}
If there is a failure opening a connection on line 178, the finally clause is executed.
The finally clause needs the connection, which of course is null :-)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
4:22 a.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2604) Isolator.JdbcDelegate masks the exception if it isn't possible to open a connection.
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2604?page=c...
]
Tushar Pokle commented on HHH-2604:
-----------------------------------
I believe this is the same problem that the following poster encountered:
http://mail-archives.apache.org/mod_mbox/db-derby-user/200603.mbox/%3C031...
From acemcclou...(a)comcast.net
Subject Null Pointer Exception
Date Fri, 10 Mar 2006 16:21:21 GMT
I am getting the stack trace shown below. Could someone provide a clue as to what I'm
doing
wrong?
Thank you,
Ace
-----------------------------------------------------------------------------------------
java.lang.NullPointerException
at org.hibernate.jdbc.AbstractBatcher.closeConnection(AbstractBatcher.java:462)
at
org.hibernate.engine.TransactionHelper.doWorkInNewTransaction(TransactionHelper.java:128)
at org.hibernate.id.TableGenerator.generate(TableGenerator.java:94)
at org.hibernate.id.TableHiLoGenerator.generate(TableHiLoGenerator.java:61)
at
org.hibernate.event.def.AbstractSaveEventListener.saveWithGeneratedId(AbstractSaveEventListener.java:85)
at
org.hibernate.event.def.DefaultSaveOrUpdateEventListener.saveWithGeneratedOrRequestedId(DefaultSaveOrUpdateEventListener.java:184)
at
org.hibernate.event.def.DefaultSaveEventListener.saveWithGeneratedOrRequestedId(DefaultSaveEventListener.java:33)
at
org.hibernate.event.def.DefaultSaveOrUpdateEventListener.entityIsTransient(DefaultSaveOrUpdateEventListener.java:173)
at
org.hibernate.event.def.DefaultSaveEventListener.performSaveOrUpdate(DefaultSaveEventListener.java:27)
at
org.hibernate.event.def.DefaultSaveOrUpdateEventListener.onSaveOrUpdate(DefaultSaveOrUpdateEventListener.java:69)
at org.hibernate.impl.SessionImpl.save(SessionImpl.java:481)
at org.hibernate.impl.SessionImpl.save(SessionImpl.java:476)
at <some code of mine that calls save with an object>
Isolator.JdbcDelegate masks the exception if it isn't possible to
open a connection.
------------------------------------------------------------------------------------
Key: HHH-2604
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2604
Project: Hibernate3
Issue Type: Bug
Affects Versions: 3.2.4
Environment: Hibernate 3.2.2ga
Reporter: Tushar Pokle
Priority: Minor
A defect in Isolator.JdbcDelegate makes it throw the wrong exception - a
NullPointerException - that masks the true exception. In my case it was an
UnsupportedOperationException("The user must supply a JDBC connection").
The trouble is at the start of Isolator.JdbcDelegate.delegateWork(...):
{code}
174 public void delegateWork(IsolatedWork work, boolean transacted) throws
HibernateException {
175 Connection connection = null;
176 boolean wasAutoCommit = false;
177 try {
178 connection = session.getBatcher().openConnection();
{code}
If there is a failure opening a connection on line 178, the finally clause is executed.
The finally clause needs the connection, which of course is null :-)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
1:17 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2604) Isolator.JdbcDelegate masks the exception if it isn't possible to open a connection.
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2604?page=c...
]
Allon Rauer commented on HHH-2604:
----------------------------------
bump.
we were just bitten by this issue as well. seems trivial to fix...hopefully can be
addressed soon.
Isolator.JdbcDelegate masks the exception if it isn't possible to
open a connection.
------------------------------------------------------------------------------------
Key: HHH-2604
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2604
Project: Hibernate3
Issue Type: Bug
Affects Versions: 3.2.4
Environment: Hibernate 3.2.2ga
Reporter: Tushar Pokle
Priority: Minor
A defect in Isolator.JdbcDelegate makes it throw the wrong exception - a
NullPointerException - that masks the true exception. In my case it was an
UnsupportedOperationException("The user must supply a JDBC connection").
The trouble is at the start of Isolator.JdbcDelegate.delegateWork(...):
{code}
174 public void delegateWork(IsolatedWork work, boolean transacted) throws
HibernateException {
175 Connection connection = null;
176 boolean wasAutoCommit = false;
177 try {
178 connection = session.getBatcher().openConnection();
{code}
If there is a failure opening a connection on line 178, the finally clause is executed.
The finally clause needs the connection, which of course is null :-)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:07 p.m.
New subject: [Hibernate-JIRA] Commented: (HHH-2604) Isolator.JdbcDelegate masks the exception if it isn't possible to open a connection.
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2604?page=c...
]
Diego Plentz commented on HHH-2604:
-----------------------------------
The current finally block looks like this:
finally {
if ( transacted && wasAutoCommit ) {
try {
connection.setAutoCommit( true );
}
catch( Throwable ignore ) {
log.trace( "was unable to reset connection back to auto-commit" );
}
}
session.getBatcher().closeConnection( connection );
}
So, the problem is that AbstractBatcher.closeConnection method does not verify if
connection is null (then NPE...). I thinking if is better to check at closeConnection
method or before calling the method in the finally block.
Isolator.JdbcDelegate masks the exception if it isn't possible to
open a connection.
------------------------------------------------------------------------------------
Key: HHH-2604
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2604
Project: Hibernate3
Issue Type: Bug
Affects Versions: 3.2.4
Environment: Hibernate 3.2.2ga
Reporter: Tushar Pokle
Priority: Minor
A defect in Isolator.JdbcDelegate makes it throw the wrong exception - a
NullPointerException - that masks the true exception. In my case it was an
UnsupportedOperationException("The user must supply a JDBC connection").
The trouble is at the start of Isolator.JdbcDelegate.delegateWork(...):
{code}
174 public void delegateWork(IsolatedWork work, boolean transacted) throws
HibernateException {
175 Connection connection = null;
176 boolean wasAutoCommit = false;
177 try {
178 connection = session.getBatcher().openConnection();
{code}
If there is a failure opening a connection on line 178, the finally clause is executed.
The finally clause needs the connection, which of course is null :-)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
2:09 p.m.
New subject: [Hibernate-JIRA] Assigned: (HHH-2604) Isolator.JdbcDelegate masks the exception if it isn't possible to open a connection.
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2604?page=c...
]
Diego Plentz reassigned HHH-2604:
---------------------------------
Assignee: Diego Plentz
Isolator.JdbcDelegate masks the exception if it isn't possible to
open a connection.
------------------------------------------------------------------------------------
Key: HHH-2604
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2604
Project: Hibernate3
Issue Type: Bug
Affects Versions: 3.2.4
Environment: Hibernate 3.2.2ga
Reporter: Tushar Pokle
Assignee: Diego Plentz
Priority: Minor
A defect in Isolator.JdbcDelegate makes it throw the wrong exception - a
NullPointerException - that masks the true exception. In my case it was an
UnsupportedOperationException("The user must supply a JDBC connection").
The trouble is at the start of Isolator.JdbcDelegate.delegateWork(...):
{code}
174 public void delegateWork(IsolatedWork work, boolean transacted) throws
HibernateException {
175 Connection connection = null;
176 boolean wasAutoCommit = false;
177 try {
178 connection = session.getBatcher().openConnection();
{code}
If there is a failure opening a connection on line 178, the finally clause is executed.
The finally clause needs the connection, which of course is null :-)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:32 a.m.
New subject: [Hibernate-JIRA] Updated: (HHH-2604) Isolator.JdbcDelegate masks the exception if it isn't possible to open a connection.
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2604?page=c...
]
Steve Ebersole updated HHH-2604:
--------------------------------
Fix Version/s: 3.3.0.CR2
3.2.x
Isolator.JdbcDelegate masks the exception if it isn't possible to
open a connection.
------------------------------------------------------------------------------------
Key: HHH-2604
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2604
Project: Hibernate3
Issue Type: Bug
Affects Versions: 3.2.4
Environment: Hibernate 3.2.2ga
Reporter: Tushar Pokle
Assignee: Diego Plentz
Priority: Minor
Fix For: 3.2.x, 3.3.0.CR2
A defect in Isolator.JdbcDelegate makes it throw the wrong exception - a
NullPointerException - that masks the true exception. In my case it was an
UnsupportedOperationException("The user must supply a JDBC connection").
The trouble is at the start of Isolator.JdbcDelegate.delegateWork(...):
{code}
174 public void delegateWork(IsolatedWork work, boolean transacted) throws
HibernateException {
175 Connection connection = null;
176 boolean wasAutoCommit = false;
177 try {
178 connection = session.getBatcher().openConnection();
{code}
If there is a failure opening a connection on line 178, the finally clause is executed.
The finally clause needs the connection, which of course is null :-)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
8:53 a.m.
New subject: [Hibernate-JIRA] Updated: (HHH-2604) Isolator.JdbcDelegate masks the exception if it isn't possible to open a connection.
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2604?page=c...
]
Alex Savitsky updated HHH-2604:
-------------------------------
Attachment: Patch-HHH-2604-trunk.txt
I believe this patch should do - it adds a null check for connection at the beginning of
finally. I did it against the trunk, let me know if it's needed against any specific
branch.
Isolator.JdbcDelegate masks the exception if it isn't possible to
open a connection.
------------------------------------------------------------------------------------
Key: HHH-2604
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2604
Project: Hibernate3
Issue Type: Bug
Affects Versions: 3.2.4
Environment: Hibernate 3.2.2ga
Reporter: Tushar Pokle
Assignee: Diego Plentz
Priority: Minor
Fix For: 3.2.x, 3.3.0.CR2
Attachments: Patch-HHH-2604-trunk.txt
A defect in Isolator.JdbcDelegate makes it throw the wrong exception - a
NullPointerException - that masks the true exception. In my case it was an
UnsupportedOperationException("The user must supply a JDBC connection").
The trouble is at the start of Isolator.JdbcDelegate.delegateWork(...):
{code}
174 public void delegateWork(IsolatedWork work, boolean transacted) throws
HibernateException {
175 Connection connection = null;
176 boolean wasAutoCommit = false;
177 try {
178 connection = session.getBatcher().openConnection();
{code}
If there is a failure opening a connection on line 178, the finally clause is executed.
The finally clause needs the connection, which of course is null :-)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
9:44 a.m.
New subject: [Hibernate-JIRA] Updated: (HHH-2604) Isolator.JdbcDelegate masks the exception if it isn't possible to open a connection.
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2604?page=c...
]
Diego Plentz updated HHH-2604:
------------------------------
Fix Version/s: (was: 3.3.0.CR2)
(was: 3.2.x)
3.3.x
Isolator.JdbcDelegate masks the exception if it isn't possible to
open a connection.
------------------------------------------------------------------------------------
Key: HHH-2604
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2604
Project: Hibernate3
Issue Type: Bug
Affects Versions: 3.2.4
Environment: Hibernate 3.2.2ga
Reporter: Tushar Pokle
Assignee: Diego Plentz
Priority: Minor
Fix For: 3.3.x
Attachments: Patch-HHH-2604-trunk.txt
A defect in Isolator.JdbcDelegate makes it throw the wrong exception - a
NullPointerException - that masks the true exception. In my case it was an
UnsupportedOperationException("The user must supply a JDBC connection").
The trouble is at the start of Isolator.JdbcDelegate.delegateWork(...):
{code}
174 public void delegateWork(IsolatedWork work, boolean transacted) throws
HibernateException {
175 Connection connection = null;
176 boolean wasAutoCommit = false;
177 try {
178 connection = session.getBatcher().openConnection();
{code}
If there is a failure opening a connection on line 178, the finally clause is executed.
The finally clause needs the connection, which of course is null :-)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:11 a.m.
New subject: [Hibernate-JIRA] Closed: (HHH-2604) Isolator.JdbcDelegate masks the exception if it isn't possible to open a connection.
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2604?page=c...
]
Steve Ebersole closed HHH-2604.
-------------------------------
Resolution: Fixed
Isolator.JdbcDelegate masks the exception if it isn't possible to
open a connection.
------------------------------------------------------------------------------------
Key: HHH-2604
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2604
Project: Hibernate3
Issue Type: Bug
Affects Versions: 3.2.4
Environment: Hibernate 3.2.2ga
Reporter: Tushar Pokle
Assignee: Steve Ebersole
Priority: Minor
Fix For: 3.2.x, 3.3.0.CR2
Attachments: Patch-HHH-2604-trunk.txt
A defect in Isolator.JdbcDelegate makes it throw the wrong exception - a
NullPointerException - that masks the true exception. In my case it was an
UnsupportedOperationException("The user must supply a JDBC connection").
The trouble is at the start of Isolator.JdbcDelegate.delegateWork(...):
{code}
174 public void delegateWork(IsolatedWork work, boolean transacted) throws
HibernateException {
175 Connection connection = null;
176 boolean wasAutoCommit = false;
177 try {
178 connection = session.getBatcher().openConnection();
{code}
If there is a failure opening a connection on line 178, the finally clause is executed.
The finally clause needs the connection, which of course is null :-)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
10:11 a.m.
New subject: [Hibernate-JIRA] Updated: (HHH-2604) Isolator.JdbcDelegate masks the exception if it isn't possible to open a connection.
[
http://opensource.atlassian.com/projects/hibernate/browse/HHH-2604?page=c...
]
Steve Ebersole updated HHH-2604:
--------------------------------
Assignee: Steve Ebersole (was: Diego Plentz)
Fix Version/s: (was: 3.3.x)
3.3.0.CR2
3.2.x
Isolator.JdbcDelegate masks the exception if it isn't possible to
open a connection.
------------------------------------------------------------------------------------
Key: HHH-2604
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2604
Project: Hibernate3
Issue Type: Bug
Affects Versions: 3.2.4
Environment: Hibernate 3.2.2ga
Reporter: Tushar Pokle
Assignee: Steve Ebersole
Priority: Minor
Fix For: 3.2.x, 3.3.0.CR2
Attachments: Patch-HHH-2604-trunk.txt
A defect in Isolator.JdbcDelegate makes it throw the wrong exception - a
NullPointerException - that masks the true exception. In my case it was an
UnsupportedOperationException("The user must supply a JDBC connection").
The trouble is at the start of Isolator.JdbcDelegate.delegateWork(...):
{code}
174 public void delegateWork(IsolatedWork work, boolean transacted) throws
HibernateException {
175 Connection connection = null;
176 boolean wasAutoCommit = false;
177 try {
178 connection = session.getBatcher().openConnection();
{code}
If there is a failure opening a connection on line 178, the finally clause is executed.
The finally clause needs the connection, which of course is null :-)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
5911
days inactive
6359
days old
hibernate-issues@lists.jboss.org
10 comments
6 participants
participants (6)
-
Alex Savitsky (JIRA) -
Allon Rauer (JIRA)
-
Diego Plentz (JIRA)
-
Steve Ebersole (JIRA)
-
Tushar (JIRA)
-
Tushar Pokle (JIRA)