[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3810?page=c... ] Gail Badner commented on HHH-3810: ---------------------------------- Here is a more complicated test (also based on the test case from HHH-3046) that illustrates the same bug caused by the fix in HHH-3229. This test also failed before the fix was applied, but instead it was because a not-null property references a transient value. This failure was originally documented in HHH-3229. -- (N : 1) -- Tour | | -- (1 : N) -- (pickup) ---- | | | Route -- (1 : N) -- Node Transport | | -- (1 : N) -- (delivery) -- Collections are sets. Node.route has cascade="none". All other associations are cascade="merge,refresh". All many-to-one associations have not-null="true" There are 5 objects: route (persistent) deliveryNode (transient) pickupNode (transient) transport (transient) tour (transient) route.nodes { deliveryNode, pickupNode } tour.nodes = { deliveryNode, pickupNode } pickupNode.route = route pickupNode.tour = tour pickupNode.pickupTransports = { transport } deliveryNode.route = route deliveryNode.tour = tour deliveryNode.deliveryTransports = { transport } transport.pickupNode = pickupNode transport.deliveryNode = deliveryNode The following shows the execution path after applying the fix in HHH-3229, which results in deliveryNode and transport being saved twice. The test ultimately fails with a ConstraintViolationException because there are 2 Transport entities with the same pickupNode. MERGE EVENT route (persistent, routeID=1 ) MERGE EVENT deliveryNode | | A) CASCADE_BEFORE_SAVE deliveryNode | | MERGE EVENT tour | | | | A) CASCADE_BEFORE_SAVE tour (nothing to do) | | | | B) SAVE tour (tourID=2) | | | | C) CASCADE_AFTER_SAVE tour | | | | MERGE EVENT deliveryNode | | | (BUG: embedded merge event for same transient entity!!!) | | | | | | A) CASCADE_BEFORE_SAVE deliveryNode | | | | | | MERGE EVENT tour (skip because it is already saved) | | | | | | B) SAVE deliveryNode (nodeID=3) | | | (BUG: saved in embedded merge event!!!) | | | | | | C) CASCADE_AFTER_SAVE deliveryNode | | | | | | MERGE EVENT transport | | | | | | | | A) CASCADE_BEFORE_SAVE transport | | | | | | | | MERGE EVENT deliveryNode (skip because it is already saved) | | | | | | | | MERGE EVENT pickupNode | | | | | | | | | | A) CASCADE_BEFORE_SAVE pickupNode | | | | | | | | | | MERGE EVENT tour (skip because it is already saved) | | | | | | | | | | B) SAVE pickupNode (nodeID=4) | | | | | | | | | | C) CASCADE_AFTER_SAVE pickupNode | | | | | | | | | | MERGE EVENT transport | | | | | | (BUG: embedded merge event for same transient entity!!!) | | | | | | | | | | | | A) CASCADE_BEFORE_SAVE transport | | | | | | | | | | | | MERGE EVENT deliveryNode (skip because it is already saved) | | | | | | MERGE EVENT pickupNode (skip because it is already saved) | | | | | | | | | | | | B) SAVE transport (transportID=5) | | | | | | (BUG: saved in embedded merge event!!!) | | | | | | | | | | | | C) CASCADE_AFTER_SAVE transport (nothing to do) | | | | | | | | B) SAVE transport (transportID=6) | | | | (BUG: saved again in original merge event!!!) | | | | | | | | C) CASCADE_AFTER_SAVE transport (nothing to do) | | | | | MERGE EVENT pickupNode (skip because it is already saved) | | B) SAVE deliveryNode (nodeID=7) | (BUG: saved again in original merge event!!!) | | C) CASCADE_AFTER_SAVE deliveryNode | | MERGE EVENT transport (skip because it is already saved) After merge completes, the action queue shows 6 inserts (should only be 4): tour [ EntityInsertAction.id=2, tour.tourID=2 ] pickupNode [ EntityInsertAction.id=3, pickupNode.nodeID=3 ] deliveryNode [ EntityInsertAction.id=4, deliveryNode.nodeID=7 ] <-- inconsistent ID transport [ EntityInsertAction.id=5, transport.transportID=6 ] <-- inconsistent ID transport [ EntityInsertAction.id=6, transport.transportID=6 ] deliveryNode [ EntityInsertAction.id=7, deliveryNode.nodeID=7 ] When the session flushes, the test fails with a ConstraintViolationException because there are 2 Transport entities with the same pickupNode ------------------------------------------------------------------------------------------------------------------ The following shows the execution path before applying the fix in HHH-3229, which fails with org.hibernate.PropertyValueException because transport.pickupNode is transient when transport is saved. MERGE EVENT route (persistent) MERGE EVENT deliveryNode | | A) CASCADE_BEFORE_SAVE deliveryNode | | MERGE EVENT tour | | | | A) CASCADE_BEFORE_SAVE tour (nothing to do) | | | | B) SAVE tour | | | | C) CASCADE_AFTER_SAVE tour | | | | MERGE EVENT deliveryNode (skip because it is already being merged) | | | | MERGE EVENT pickupNode | | | | | | A) CASCADE_BEFORE_SAVE pickupNode | | | | | | MERGE EVENT tour (skip because it is already being merged) | | | | | | B) SAVE pickupNode | | | | | | C) CASCADE_AFTER_SAVE pickupNode | | | | | | MERGE EVENT transport | | | | | | | A) CASCADE_BEFORE_SAVE transport | | | | | | | | MERGE EVENT deliveryNode (skip because it is already being merged) | | | | | | | | MERGE EVENT pickupNode (skip because it is already being merged) | | | | | | | | B) SAVE transport | | | | (fails because transport.deliveryNode is non-nullable, but is still transient!!!) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3810?page=c... ] Gail Badner commented on HHH-3810: ---------------------------------- I've checked the fix into Branch_3_2. I'll check it into the other branches tonight or tomorrow morning. If you are interested in trying this fix out to make sure it fixes your issue before it is released, then you can check the code out from http://anonsvn.jboss.org/repos/hibernate/core/branches/Branch_3_2/. If you do try it out, please let me know if it works for your issue. Thanks, Gail -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-3810?page=c... ] Gail Badner resolved HHH-3810. ------------------------------ Resolution: Fixed Fixed in trunk / Branch_3_3 / Branch_3_2 / Branch_3_2_4_SP1_CP -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira