January 2008 - hibernate-issues - Jboss List Archives

[Hibernate-JIRA] Created: (HHH-2645) Synchronization bottleneck in EntityModeToTuplizerMapping

by Erik Bergersjö (JIRA)

Synchronization bottleneck in EntityModeToTuplizerMapping --------------------------------------------------------- Key: HHH-2645 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2645 Project: Hibernate3 Issue Type: Patch Components: core Affects Versions: 3.2.4.sp1, 3.2.4, 3.2.3 Environment: Hibernate 3.2.3 (and later), Sun's JDK 1.4.2_12 (server VM) on SunOS 5.10, Oracle 10g R2 Reporter: Erik Bergersjö Priority: Minor We have had a major performance bottleneck in EntityModeToTuplizerMapping with Hibernate version 3.2.3 and the code for that class in 3.2.4sp1 is unchanged. We have found a solution that solves the issue and would like to get it into the real version. I submitted to the user forum first and was asked to create a JIRA issue. The problematic line is: private final Map tuplizers = Collections.synchronizedMap( new SequencedHashMap() ); We have changed it to (using util.concurrent): private final Map tuplizers = new EDU.oswego.cs.dl.util.concurrent.ConcurrentReaderHashMap(); This change alone makes our use cases six times faster. The difference is that ConcurrentReaderHashMap handles concurrent readers much better, they don't have to wait for each other. The problem occurs when a high number of threads try to initialize sets (see mapping below). A thread dump showed a high number of threads waiting for the same monitor, see partial stack trace below. The code runs on Sun's JDK 1.4.2_12 (server VM) on SunOS 5.10 and the kernel spends a lot of time handling mutexes with the original implementation. That time disappears from the radar screen with the fixed version. Example mapping for set: [code] <set name="lines" lazy="true" inverse="true" cascade="all-delete-orphan"> <key> <column name="col1" not-null="true" /> <column name="col2" not-null="true" /> </key> <one-to-many class="LineClass" /> </set> [/code] Stack trace (partial): "Thread-108" prio=5 tid=0x05852e90 nid=0x103 waiting for monitor entry [0x3ed7e000..0x3ed7fc28] at java.util.Collections$SynchronizedMap.get(Collections.java:1942) - waiting to lock <0x89d30788> (a java.util.Collections$SynchronizedMap) at org.hibernate.tuple.EntityModeToTuplizerMapping.getTuplizerOrNull(EntityModeToTuplizerMapping.java:53) at org.hibernate.tuple.EntityModeToTuplizerMapping.getTuplizer(EntityModeToTuplizerMapping.java:66) at org.hibernate.type.ComponentType.getPropertyValues(ComponentType.java:353) at org.hibernate.type.ComponentType.isEqual(ComponentType.java:141) at org.hibernate.engine.CollectionKey.equals(CollectionKey.java:50) at java.util.HashMap.eq(HashMap.java:274) at java.util.HashMap.get(HashMap.java:323) at org.hibernate.engine.loading.CollectionLoadContext.getLocalLoadingCollectionEntry(CollectionLoadContext.java:163) at org.hibernate.engine.loading.CollectionLoadContext.locateLoadingCollectionEntry(CollectionLoadContext.java:150) at org.hibernate.engine.loading.CollectionLoadContext.getLoadingCollection(CollectionLoadContext.java:92) at org.hibernate.loader.Loader.readCollectionElement(Loader.java:1003) at org.hibernate.loader.Loader.readCollectionElements(Loader.java:646) at org.hibernate.loader.Loader.getRowFromResultSet(Loader.java:591) at org.hibernate.loader.Loader.doQuery(Loader.java:701) at org.hibernate.loader.Loader.doQueryAndInitializeNonLazyCollections(Loader.java:236) at org.hibernate.loader.Loader.loadCollection(Loader.java:1994) at org.hibernate.loader.collection.CollectionLoader.initialize(CollectionLoader.java:36) at org.hibernate.persister.collection.AbstractCollectionPersister.initialize(AbstractCollectionPersister.java:565) at org.hibernate.event.def.DefaultInitializeCollectionEventListener.onInitializeCollection(DefaultInitializeCollectionEventListener.java:60) at org.hibernate.impl.SessionImpl.initializeCollection(SessionImpl.java:1716) at org.hibernate.collection.AbstractPersistentCollection.initialize(AbstractPersistentCollection.java:344) at org.hibernate.collection.AbstractPersistentCollection.read(AbstractPersistentCollection.java:86) at org.hibernate.collection.PersistentSet.iterator(PersistentSet.java:163) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

15 years, 10 months

8
28
0 / 0

[Hibernate-JIRA] Created: (HHH-3050) Convert usage of Hibernate's FastHashMap to ConcurrentHashMap (Java 1.5)

by Gail Badner (JIRA)

Convert usage of Hibernate's FastHashMap to ConcurrentHashMap (Java 1.5) ------------------------------------------------------------------------ Key: HHH-3050 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3050 Project: Hibernate3 Issue Type: Improvement Reporter: Gail Badner Assignee: Gail Badner Fix For: 3.3 The performance test attached to HHH-2645 shows that java.util.concurrent.ConcurrentHashMap (introduced in Java 1.5) performs nearly as well as org.hibernate.util.FastHashMap. Hibernate needs to move to Java 1.5 before this can be done. As noted in HHH-2645, it might be worthwhile to convert usages of FastHashMap to ConcurrentHashMap so that FastHashMap does not need to be maintained. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

15 years, 10 months

2
4
0 / 0

[Hibernate-JIRA] Created: (HHH-3068) Update of an entity with immutable natural-id and many-to-one relation seems to fail

by Pascal Cohen (JIRA)

Update of an entity with immutable natural-id and many-to-one relation seems to fail ------------------------------------------------------------------------------------ Key: HHH-3068 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3068 Project: Hibernate3 Issue Type: Bug Components: core Affects Versions: 3.2.5 Environment: Hibernate 3.2.5 Linux Fedora 32bits Postgres 8.2.5 Reporter: Pascal Cohen Priority: Minor I have posted in the forum the following question and someone seems to confirm this might be a bug. http://forum.hibernate.org/viewtopic.php?t=982385&highlight= Thanks in advance for advice -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

15 years, 11 months

2
1
0 / 0

[Hibernate-JIRA] Created: (HHH-2041) Update with unaltered natural-id fails

by Jim Pease (JIRA)

Update with unaltered natural-id fails -------------------------------------- Key: HHH-2041 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2041 Project: Hibernate3 Type: Bug Components: core Versions: 3.1.3 Environment: hibernate-3.1.3, mysql-4.1.12 Reporter: Jim Pease This may be a duplicate of http://opensource.atlassian.com/projects/hibernate/browse/HHH-1574. Getting following error: caused by: org.hibernate.HibernateException: immutable natural identifier of an instance of edu.syr.lsb.gmt.impl.LinkImpl was altered at org.hibernate.event.def.DefaultFlushEntityEventListener.checkNaturalId(DefaultFlushEntityEventListener.java:80) at org.hibernate.event.def.DefaultFlushEntityEventListener.getValues(DefaultFlushEntityEventListener.java:155) at org.hibernate.event.def.DefaultFlushEntityEventListener.onFlushEntity(DefaultFlushEntityEventListener.java:106) at org.hibernate.event.def.AbstractFlushingEventListener.flushEntities(AbstractFlushingEventListener.java:195) at org.hibernate.event.def.AbstractFlushingEventListener.flushEverythingToExecutions(AbstractFlushingEventListener.java:76) at org.hibernate.event.def.DefaultFlushEventListener.onFlush(DefaultFlushEventListener.java:26) ... This is occurring without modifications to the natural identifier, which is mapped as follows: <natural-id> <property name="activityRef" column="ACTIVITY_REF" length="255" not-null="true" /> <many-to-one name="goal" class="GoalImpl" column="GOAL_ID" not-null="true" cascade="none" /> </natural-id> -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

15 years, 11 months

2
1
0 / 0

[Hibernate-JIRA] Created: (HHH-1992) Some cascade actions should not trigger a property access on lazy properties

by Emmanuel Bernard (JIRA)

Some cascade actions should not trigger a property access on lazy properties ---------------------------------------------------------------------------- Key: HHH-1992 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-1992 Project: Hibernate3 Type: Bug Components: core Versions: 3.2.0.cr3 Reporter: Emmanuel Bernard Assigned to: Emmanuel Bernard Priority: Critical Fix For: 3.2.0.ga -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

15 years, 11 months

3
4
0 / 0

[Hibernate-JIRA] Created: (HHH-3005) DTD: map-key should allow nested type rather than attribute.

by Mattias Jiderhamn (JIRA)

DTD: map-key should allow nested type rather than attribute. ------------------------------------------------------------ Key: HHH-3005 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3005 Project: Hibernate3 Issue Type: Bug Affects Versions: 3.2.5 Reporter: Mattias Jiderhamn Priority: Minor The metamodel allows for user typed 'map-key's via nested <type> tags but the DTD requires a type, attribute. See HHH-822 for a similar problem with key-property. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

15 years, 11 months

4
6
0 / 0

[Hibernate-JIRA] Created: (HHH-2584) PersistentMap.remove() incorrect on uninitialized, non-extra-lazy map

by Daniel Wellman (JIRA)

PersistentMap.remove() incorrect on uninitialized, non-extra-lazy map --------------------------------------------------------------------- Key: HHH-2584 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2584 Project: Hibernate3 Issue Type: Patch Components: core Affects Versions: 3.2.3, 3.2.2, 3.2.1 Environment: Hibernate 3.2.3 ga, MySQL 5.0.24a, for Win32 Reporter: Daniel Wellman Attachments: persistentmap_remove.patch This problem is nearly identical to HHH-2476: PersistentMap.put() incorrect on uninitialized, non-extra-lazy map. remove() has the same problem. See also issue HHH-2142. The write up for HHH-2476 was so concise that I will transform it here, substituting remove() for put(). --- Essentially, an uninitialized PersistentMap loses the first remove() into it if defined as non-extra-lazy. The underlying cause is the code in PersistentMap#remove() which attempts to readElementByIndex(). In the case of non-extra-lazy, readElementByIndex() returns the UNKNOWN marker object which is supposed to be used to signal that the delegate map is now initialized and to remove the element directly from the map. Long story short, PersistentMap#remove() does not properly check the return value from readElementByIndex() and react accordingly. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

15 years, 11 months

8
12
0 / 0

[Hibernate-JIRA] Created: (HHH-3030) NullPointerException happens in versioning

by John (JIRA)

NullPointerException happens in versioning ------------------------------------------ Key: HHH-3030 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3030 Project: Hibernate3 Issue Type: Bug Components: core Affects Versions: 3.2.5 Environment: any Reporter: John Priority: Minor Here is the stack trace: java.lang.NullPointerException at org.hibernate.type.IntegerType.next(IntegerType.java:59) at org.hibernate.engine.Versioning.increment(Versioning.java:25) at org.hibernate.event.def.DefaultFlushEntityEventListener.getNextVersion(DefaultFlushEntityEventListener.java:358) at org.hibernate.event.def.DefaultFlushEntityEventListener.scheduleUpdate(DefaultFlushEntityEventListener.java:250) at org.hibernate.event.def.DefaultFlushEntityEventListener.onFlushEntity(DefaultFlushEntityEventListener.java:121) at org.hibernate.event.def.AbstractFlushingEventListener.flushEntities(AbstractFlushingEventListener.java:196) at org.hibernate.event.def.AbstractFlushingEventListener.flushEverythingToExecutions(AbstractFlushingEventListener.java:76) at org.hibernate.event.def.DefaultAutoFlushEventListener.onAutoFlush(DefaultAutoFlushEventListener.java:35) at org.hibernate.impl.SessionImpl.autoFlushIfRequired(SessionImpl.java:969) at org.hibernate.impl.SessionImpl.list(SessionImpl.java:1114) at org.hibernate.impl.QueryImpl.list(QueryImpl.java:79) ...... The code is: public Object next(Object current, SessionImplementor session) { return new Integer( ( (Integer) current ).intValue() + 1 ); } Should there be a null checking for the object "current"? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

15 years, 11 months

10
11
0 / 0

[Hibernate-JIRA] Created: (HHH-2380) Hibernate3.2.0 GA is JDK 1.3 Incompatible

by Alessandro Lazarotti (JIRA)

Hibernate3.2.0 GA is JDK 1.3 Incompatible ----------------------------------------- Key: HHH-2380 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2380 Project: Hibernate3 Type: Bug Components: core Versions: 3.2.0.ga Environment: Hibernate 3.2.0 GA Reporter: Alessandro Lazarotti Priority: Minor The class org.hibernate.persister.entity.AbstractEntityPersister uses Boolean.valueOf, incompatible with JDK 1.3. Update for new Boolean. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

15 years, 11 months

4
8
0 / 0

[Hibernate-JIRA] Created: (HHH-2809) dialect changes: limit string

by Anthony Patricio (JIRA)

dialect changes: limit string ----------------------------- Key: HHH-2809 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2809 Project: Hibernate3 Issue Type: Bug Components: core Affects Versions: 3.2.3 Reporter: Anthony Patricio Attachments: IngresDialect.svndiff32 In Ingres we use "SELECT FIRST $n col1,... FROM ..." to limit the resultset. The old dialect replaces the first 6 chars of the select statement with "SELECT FIRST $n". When running our partner application, hibernate has put 2 or 3 blanks at the begining of the query, which causes an error, of course. Patch attached -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

16 years

2
1
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues January 2008