April 2008 - hibernate-issues - Jboss List Archives

[Hibernate-JIRA] Created: (HHH-2668) Caching Fails with Composite-Ids Containing Nested, Complex Entities

by Juan Osuna (JIRA)

Caching Fails with Composite-Ids Containing Nested, Complex Entities -------------------------------------------------------------------- Key: HHH-2668 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2668 Project: Hibernate3 Issue Type: Bug Components: caching (L2) Affects Versions: 3.2.4.sp1 Environment: Problem is independent of environment or platform and most likely exists in prior versions. Reporter: Juan Osuna Attachments: hibernate-caching-fix.zip Description of Failing Test Case Scenario Preconditions: An entity class is mapped that uses a composite-id that contains a nested entity class. Only the composite-id class implements equals/hashcode, not the nested entity class. Steps to Reproduce: 1. open session and fetch object using composite-id 2. open new session and fetch same object again using different instance of composite-id but with same identity Invalid Postconditions: On second retrieve, Hibernate fails to get the object from the cache and unnecessarily reloads the object. CachKeys containing different instances of the composite-id always fail to be equal even though they have the same persistent identity. Attachment Contents Code fix is attached as well as a Junit test case that reproduces the problem and validates the fix. The full Hibernate suite was also executed with no impact. Attachment contains: New Test Method: org.hibernate.test.cache.BaseCacheProviderTestCase.testQueryCacheComplexItem New Test Entity Items: org\hibernate\test\cache\ComplexItem.hbm.xml org.hibernate.test.cache.ComplexItem org.hibernate.test.cache.ComplexItemPK Code Fix: org.hibernate.cache.CacheKey (see FIX comments) Problem and Fix Details Hibernate generally strives to use persistent identifiers for managing object identity rather than the equals/hashcode methods implemented by entity classes. While it is good practice to implement equals/hashcode, Hibernate does not generally force users to do this. When wrapping a composite-id object, the current implementation of CacheKey fails to recurse through nested complex entities to query for equality based on persistent identity. Instead, when the recursion algorithm hits a complex entity, it invokes equals directly on that entity rather than further recursing through the identifier object. Notably, the recursion logic for equals is not symmetrical with the recursion logic for hashcode, which does recurse through identifier objects. So, while CacheKey never invokes hashcode on nested complex entities, it does invoke equals on these entities. A simple fix to this inconsistency is to store the factory parameter passed to CacheKey and later pass that parameter to the overloaded method: Type.isEqual(Object x, Object y, EntityMode entityMode, SessionFactoryImplementor factory). This fix restores symmetry to equals and hashcode behavior. By calling this overloaded method, the thread of execution will enter EntityType. isEqual(Object x, Object y, EntityMode entityMode, SessionFactoryImplementor factory), which correctly recurses through complex identifiers. Design Principles Hibernate should strive to behave predictably even in scenarios where users do not follow best practices. Hibernate should strive to be as forgiving as possible as long there is no negative consequence caused by such forgiveness. Hibernate should behave as consistently as possible. If Hibernate does not generally rely user-implemented equals/hashcode, it is best to avoid exceptions to this rule wherever possible. Possible Future Enhancement Mapping composite-ids that contain complex entities can cause deep object graphs to be cached as part of CacheKey. This is unsettling because of it's potential to consume memory unnecessarily and unpredictably. Currently, CacheKey caches the hashcode by recursing through a complex graph of identifier objects. Perhaps, it would also be possible for CacheKey to cache an object graph of identifier objects whose leaves hold primitive values. This would further add symmetry between hashcode and equals and lighten the load for caching composite-ids that hold entity classes. Robustly supporting composite-ids that hold complex identifiers seems like a worthwhile design goal. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

16 years, 1 month

6
8
0 / 0

[Hibernate-JIRA] Created: (HHH-2047) make Query and Criteria extend java.lang.Iterable

by Amir Pashazadeh (JIRA)

make Query and Criteria extend java.lang.Iterable ------------------------------------------------- Key: HHH-2047 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2047 Project: Hibernate3 Type: Improvement Components: core Versions: 3.2.0.cr2 Reporter: Amir Pashazadeh Priority: Trivial Objects which implement java.lang.Iterable can be iterated using extended for loop. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

16 years, 1 month

2
2
0 / 0

[Hibernate-JIRA] Created: (ANN-407) <synchronize table="table_name"/> is missed using annotations

by Amir Pashazadeh (JIRA)

<synchronize table="table_name"/> is missed using annotations -------------------------------------------------------------- Key: ANN-407 URL: http://opensource.atlassian.com/projects/hibernate/browse/ANN-407 Project: Hibernate Annotations Type: Patch Components: binder Versions: 3.2.0.cr1 Reporter: Amir Pashazadeh in old .hbm.xml notation there was a possibility to set a synchronize for caches on particular tables, and I could not find such thing using annotations, is it possible to set "synchronize" tables using annotations? and if not will it be added to 3.2? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

16 years, 1 month

3
3
0 / 0

[Hibernate-JIRA] Created: (ANN-660) HHH-2545 Alive

by Eugene Batogov (JIRA)

HHH-2545 Alive -------------- Key: ANN-660 URL: http://opensource.atlassian.com/projects/hibernate/browse/ANN-660 Project: Hibernate Annotations Issue Type: Bug Affects Versions: 3.3.0.ga Environment: Gentoo Linux x86 JDK: 1.6. SUN and BEA JBoss-4.2.1.GA Hibernate: 3.2.5 Annotation: 3.3.0.GA EntityManager: 3.3.1 Reporter: Eugene Batogov Priority: Critical I have a same problem how in HHH-2545 bug ! I update Hibernate to 3.2.5, hibernate-annotation to 3.3.0.GA hibernate-entitymanager to 3.3.1.GA. But this bug alive! I use ehcache-1.3.0. jBoss-4.2.1.GA. My query, which get from cache with null elements in collections: Long customerAccount = customerIdentity.getCustomerAccount().getId(); try{ String sql = "select npvr.npvrChannels from NpvrServiceSpec npvr"+ " where npvr.id in ("+ " select ss.id from Customer cust join cust.accounts acc join cust.subscriptions sub"+ " join sub.serviceSpecifications ss"+ " where acc.id =:customerAccount and"+ " ss in (from NpvrServiceSpec))"; Query query = emanager.createQuery(sql); query.setParameter("customerAccount", customerAccount); query.setHint("org.hibernate.cacheRegion", "query.findQueryNpvrChannelsBySubsription"); query.setHint("org.hibernate.cacheable", true); result = query.getResultList(); Help me, please ! Thanks in advance. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

16 years, 1 month

5
12
0 / 0

[Hibernate-JIRA] Created: (HSEARCH-53) Add support for projection (ie read the data from the index only)

by Emmanuel Bernard (JIRA)

Add support for projection (ie read the data from the index only) ----------------------------------------------------------------- Key: HSEARCH-53 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-53 Project: Hibernate Search Issue Type: New Feature Components: query Reporter: Emmanuel Bernard Assignee: Emmanuel Bernard Fix For: 3.0.0.beta2 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

16 years, 1 month

2
2
0 / 0

[Hibernate-JIRA] Created: (HHH-2928) optimizers for enhanced id generators should be synchronized against multi-threaded access

by Steve Ebersole (JIRA)

optimizers for enhanced id generators should be synchronized against multi-threaded access ------------------------------------------------------------------------------------------ Key: HHH-2928 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2928 Project: Hibernate3 Issue Type: Bug Components: core Affects Versions: 3.2.5 Reporter: Steve Ebersole Assignee: Steve Ebersole Fix For: 3.2.6 Currently the optimizers do not serialize access to their internal state when applying their optimizations. This only affects the pooled and hilo optimizers. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

16 years, 1 month

4
12
0 / 0

[Hibernate-JIRA] Created: (HSEARCH-87) Avoid to trigger optimization during intermediate batches

by Emmanuel Bernard (JIRA)

Avoid to trigger optimization during intermediate batches --------------------------------------------------------- Key: HSEARCH-87 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-87 Project: Hibernate Search Issue Type: New Feature Reporter: Emmanuel Bernard A queue can be batched (esp session.index()) optimization should be delayed for the end of the transaction -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

16 years, 2 months

2
3
0 / 0

[Hibernate-JIRA] Created: (HHH-3125) BigDecimal support for id generator from DB sequence

by Tomas Rada (JIRA)

BigDecimal support for id generator from DB sequence ---------------------------------------------------- Key: HHH-3125 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3125 Project: Hibernate3 Issue Type: New Feature Environment: Hibernate 3.2, Oracle 10 Reporter: Tomas Rada Currently with using BigDecimal as entity id is thrown exception " this id generator generates long, integer, short or string" - class "IdentifierGeneratorFactory". Is there possibility to add BigDecimal support for id generator? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

16 years, 2 months

6
9
0 / 0

[Hibernate-JIRA] Created: (HHH-2975) Interceptor onFlushDirty collections - previous and current state the same instance

by Clayton J. Kovar (JIRA)

Interceptor onFlushDirty collections - previous and current state the same instance ----------------------------------------------------------------------------------- Key: HHH-2975 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2975 Project: Hibernate3 Issue Type: Bug Components: core Affects Versions: 3.2.2 Environment: Hibernate 3.2.2 - Oracle thin driver 10.1.0.4.0 Reporter: Clayton J. Kovar When calling Session.merge(entity) {therefore the previous state is available} the interceptor's onFlushDirty is called and the previous state for all of the simple properties correctly passes the previous values but with a collection the same collection instance is passed in both the previous and current state arrays. So far I have only seen this behavior on a Map with a one-to-many relationship to another entity. I have not tried it yet with Lists, Sets, or Bags. I'm assuming this is not expected behavior, but please let me know if it is. Best regards. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

16 years, 2 months

2
1
0 / 0

[Hibernate-JIRA] Created: (HHH-2862) Collection is not associated with any session exception when doing an eager fetch on a non-unique collection.

by Paul Andrews (JIRA)

Collection is not associated with any session exception when doing an eager fetch on a non-unique collection. ------------------------------------------------------------------------------------------------------------- Key: HHH-2862 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2862 Project: Hibernate3 Issue Type: Bug Environment: Hibernate 3.1.3 - Hibernate 3.2.5, HSQLDB, Java5 Reporter: Paul Andrews It is basically caused by having an eager collection where the key of the collection is not unique in the results. The code works as follows in CollectionType.getCollection(): .... persistenceContext.addUninitializedCollection( persister, collection, key ); // some collections are not lazy: if ( initializeImmediately( entityMode ) ) { session.initializeCollection( collection, false ); } else if ( !persister.isLazy() ) { persistenceContext.addNonLazyCollection( collection ); } if ( hasHolder( entityMode ) ) { session.getPersistenceContext().addCollectionHolder( collection ); } if persistenceContext.addUninitializedCollection() detects that the collection with the given key has already been added it clears the session on the old instance of the collection (sets it to null). However, that collection has already been added to the persistence context by an earlier call to this method. So later when StatefulPersistenceContext.initializeNonLazyCollections() is called it iterates through all of the collections in the persistence context (including those which have had their session set to null by addUninitializedCollection()), calling forceInitialization() which throws a 'collection is not associated with any session' exception. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

16 years, 2 months

10
11
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues April 2008