February 2009 - hibernate-issues - Jboss List Archives

[Hibernate-JIRA] Created: (HV-75) Error message localization fails with polymorphism

by Samppa Saarela (JIRA)

Error message localization fails with polymorphism -------------------------------------------------- Key: HV-75 URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-75 Project: Hibernate Validator Issue Type: Bug Components: engine Affects Versions: 3.1.0.GA, 3.1.0.CR2, 3.1.0.CR1, 3.0.0.ga Reporter: Samppa Saarela Error message localization fails with polymorphism. ClassValidator doesn't pass messageBundle to the nested validator: 1 private ClassValidator getClassValidator(Object value) { 2 Class clazz = value.getClass(); 3 ClassValidator validator = childClassValidators.get( reflectionManager.toXClass( clazz ) ); 4 if ( validator == null ) { //handles polymorphism 5 validator = new ClassValidator( clazz ); 6 } 7 return validator; 8 } This can be solved easily(?) by passing on the messageBundle on line 5: validator = new ClassValidator( clazz, messageBundle ); -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

17 years, 1 month

2
2
0 / 0

[Hibernate-JIRA] Updated: (HV-21) Base class validations are not over-ridden

by Hardy Ferentschik (JIRA)

[ http://opensource.atlassian.com/projects/hibernate/browse/HV-21?page=com.... ] Hardy Ferentschik updated HV-21: -------------------------------- Component/s: (was: engine) legacy Moved issue into legacy component. This issue applies to codebase prior 4.x > Base class validations are not over-ridden > ------------------------------------------ > > Key: HV-21 > URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-21 > Project: Hibernate Validator > Issue Type: Improvement > Components: legacy > Environment: hibernate 3.2 cr2 > Reporter: Aseel Abbas > > When the same validation annotation is applied to an over-riding method in a subclass the expected behaviour is that the validation annotation in the base class is over-ridden. Currently, both validations are executed. This severely limits the usability of the package for domain models where inheritance is used. > The problem also occurs with over-riding interfaces. > For example: > class A { > @Length (min = 0, max = 32) > Integer getFoo() { > return foo; > } > } > class B extends A > { > @Length (min = 15, max = 20) > Integer getFoo() { > return super.getFoo(); > } > } > In this case validating an instance of class B which has a foo value of 100 will result in two error messages: "foo must be between 15 and 20" and "foo must be between 0 and 32". -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

17 years, 1 month

1
0
0 / 0

[Hibernate-JIRA] Created: (HV-32) Provide a way to turn on recursive validation by default without @Valid needed

by Jacques Morel (JIRA)

Provide a way to turn on recursive validation by default without @Valid needed ------------------------------------------------------------------------------ Key: HV-32 URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-32 Project: Hibernate Validator Issue Type: Improvement Reporter: Jacques Morel Hibernate validation annotation is a great way to specify declaratively and cohesively the validation rules of a domain model. Unfortunately it can also become very verbose. As any good frameworks, hibernate validator should provide ways to set sensible defaults. In the case of recursive validation, we should have a way to turn it one at the class level or at the ClassValidator level. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

17 years, 1 month

4
3
0 / 0

[Hibernate-JIRA] Updated: (HV-16) Validator ignores components

by Hardy Ferentschik (JIRA)

[ http://opensource.atlassian.com/projects/hibernate/browse/HV-16?page=com.... ] Hardy Ferentschik updated HV-16: -------------------------------- Component/s: (was: engine) legacy Moved issue into legacy component. This issue applies to codebase prior 4.x > Validator ignores components > ---------------------------- > > Key: HV-16 > URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-16 > Project: Hibernate Validator > Issue Type: Bug > Components: legacy > Reporter: Emmanuel Bernard > -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

17 years, 1 month

1
0
0 / 0

[Hibernate-JIRA] Created: (HV-28) "connection already null in cleanup" when using validators

by David J. M. Karlsen (JIRA)

"connection already null in cleanup" when using validators ---------------------------------------------------------- Key: HV-28 URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-28 Project: Hibernate Validator Issue Type: Bug Environment: hibernate annotations 3.3.0ga hibernate validator 3.0.0ga hibernate 3.2.4.sp1 hibernate-commons-annotations 3.3.0.ga Reporter: David J. M. Karlsen Priority: Critical 2007-06-27 21:18:39,133 [WorkManager.DefaultWorkManager : 0] DEBUG org.hibernate.impl.SessionImpl - opened session at timestamp: 11829719154 (SessionImpl.java:220) 2007-06-27 21:18:39,159 [WorkManager.DefaultWorkManager : 0] TRACE org.hibernate.event.def.DefaultSaveOrUpdateEventListener - saving transient instance (DefaultSaveOrUpdateEventListener.java:158) 2007-06-27 21:18:39,162 [WorkManager.DefaultWorkManager : 0] DEBUG org.hibernate.event.def.AbstractSaveEventListener - generated identifier: e2632934-a800-4a91-a9ff-ce8e1f95a03d, using strategy: org.hibernate.id.Assigned (AbstractSaveE ventListener.java:112) 2007-06-27 21:18:39,168 [WorkManager.DefaultWorkManager : 0] TRACE org.hibernate.event.def.AbstractSaveEventListener - saving [mypackage.server.types.Fee#e2632934-a800-4a91-a9ff-ce8e1f95a03d] (AbstractSaveEventListener.java: 153) 2007-06-27 21:18:39,228 [WorkManager.DefaultWorkManager : 0] TRACE org.hibernate.event.def.AbstractFlushingEventListener - flushing session (AbstractFlushingEventListener.java:58) 2007-06-27 21:18:39,232 [WorkManager.DefaultWorkManager : 0] DEBUG org.hibernate.event.def.AbstractFlushingEventListener - processing flush-time cascades (AbstractFlushingEventListener.java:111) 2007-06-27 21:18:39,237 [WorkManager.DefaultWorkManager : 0] DEBUG org.hibernate.event.def.AbstractFlushingEventListener - dirty checking collections (AbstractFlushingEventListener.java:154) 2007-06-27 21:18:39,238 [WorkManager.DefaultWorkManager : 0] TRACE org.hibernate.event.def.AbstractFlushingEventListener - Flushing entities and processing referenced collections (AbstractFlushingEventListener.java:171) 2007-06-27 21:18:39,249 [WorkManager.DefaultWorkManager : 0] TRACE org.hibernate.event.def.AbstractFlushingEventListener - Processing unreferenced collections (AbstractFlushingEventListener.java:210) 2007-06-27 21:18:39,251 [WorkManager.DefaultWorkManager : 0] TRACE org.hibernate.event.def.AbstractFlushingEventListener - Scheduling collection removes/(re)creates/updates (AbstractFlushingEventListener.java:224) 2007-06-27 21:18:39,252 [WorkManager.DefaultWorkManager : 0] DEBUG org.hibernate.event.def.AbstractFlushingEventListener - Flushed: 1 insertions, 0 updates, 0 deletions to 1 objects (AbstractFlushingEventListener.java:85) 2007-06-27 21:18:39,254 [WorkManager.DefaultWorkManager : 0] DEBUG org.hibernate.event.def.AbstractFlushingEventListener - Flushed: 0 (re)creations, 0 updates, 0 removals to 0 collections (AbstractFlushingEventListener.java:91) 2007-06-27 21:18:39,260 [WorkManager.DefaultWorkManager : 0] DEBUG org.hibernate.pretty.Printer - listing entities: (Printer.java:83) 2007-06-27 21:18:39,262 [WorkManager.DefaultWorkManager : 0] DEBUG org.hibernate.pretty.Printer - mypackage.types.Fee{<values anonymized>} (Printer.java:90) 2007-06-27 21:18:39,264 [WorkManager.DefaultWorkManager : 0] TRACE org.hibernate.event.def.AbstractFlushingEventListener - executing flush (AbstractFlushingEventListener.java:290) 2007-06-27 21:18:39,265 [WorkManager.DefaultWorkManager : 0] TRACE org.hibernate.jdbc.ConnectionManager - registering flush begin (ConnectionManager.java:469) 2007-06-27 21:18:39,276 [WorkManager.DefaultWorkManager : 0] TRACE org.hibernate.jdbc.ConnectionManager - registering flush end (ConnectionManager.java:478) 2007-06-27 21:18:39,278 [WorkManager.DefaultWorkManager : 0] TRACE org.hibernate.impl.SessionImpl - after transaction completion (SessionImpl.java:422) 2007-06-27 21:18:39,280 [WorkManager.DefaultWorkManager : 0] TRACE org.hibernate.impl.SessionImpl - closing session (SessionImpl.java:273) 2007-06-27 21:18:39,281 [WorkManager.DefaultWorkManager : 0] TRACE org.hibernate.jdbc.ConnectionManager - connection already null in cleanup : no action (ConnectionManager.java:375) 2007-06-27 21:18:39,298 [WorkManager.DefaultWorkManager : 0] ERROR Could not insert Fee org.hibernate.validator.InvalidStateException: validation failed for: mypackage.server.types.Fee at org.hibernate.validator.event.ValidateEventListener.validate(ValidateEventListener.java:148) at org.hibernate.validator.event.ValidateEventListener.onPreInsert(ValidateEventListener.java:172) at org.hibernate.action.EntityInsertAction.preInsert(EntityInsertAction.java:156) at org.hibernate.action.EntityInsertAction.execute(EntityInsertAction.java:49) at org.hibernate.engine.ActionQueue.execute(ActionQueue.java:250) at org.hibernate.engine.ActionQueue.executeActions(ActionQueue.java:234) at org.hibernate.engine.ActionQueue.executeActions(ActionQueue.java:141) This only seems to happen when I'm running inside an appserver (WebSphere 6.1) with pooled connections - in my unit-tests using a org.springframework.jdbc.datasource.DriverManagerDataSource (eg. non-pooled) it works OK - and only if adding validating annotations (@NotEmpty) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

17 years, 1 month

4
5
0 / 0

[Hibernate-JIRA] Created: (HV-37) Validating a lazy collection of composite-elements causes flush problem

by Ian Long (JIRA)

Validating a lazy collection of composite-elements causes flush problem ------------------------------------------------------------------------ Key: HV-37 URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-37 Project: Hibernate Validator Issue Type: Bug Affects Versions: 3.0.0.ga Environment: Hibernate 3.2.4ga Hibernate Annotations 3.3.0.ga mysql 5.0.27 Reporter: Ian Long Using the event listeners(pre-update,pre-insert) in hibernate, a problem occurs when validating a lazy collection of composite-elements. I was using the @Size validator, but I'm sure others will cause the same problem. For example: <set name="activatedModules" lazy="true" table="location_module_activation"> <key column="location_id" /> <composite-element class="com.opterus.opscenter.model.module.ActivatedModule" > <property name="activationDate" column="activate_date" not-null="true" /> <many-to-one name="module" class="com.opterus.opscenter.model.module.Module" column="module_id" not-null="true" unique="false" /> </composite-element> </set> will cause an exception during flush: 01:53:55,587 ERROR [http-8080-Processor23] AssertionFailure:22 - an assertion failure occured (this may indicate a bug in Hibernate, but is more likely due to unsafe use of the session) org.hibernate.AssertionFailure: collection [com.opterus.opscenter.model.common.Brand.regions] was not processed by flush() at org.hibernate.engine.CollectionEntry.postFlush(CollectionEntry.java:205) at org.hibernate.event.def.AbstractFlushingEventListener.postFlush(AbstractFlushingEventListener.java:333) at org.hibernate.event.def.DefaultFlushEventListener.onFlush(DefaultFlushEventListener.java:28) Since it tries to access the proxied collection. A collection of entity objects does not cause this problem. I guess the composite-element is handled differently than regular collections? Filed at the request of emmanuel, from the following thread: http://forum.hibernate.org/viewtopic.php?p=2361829#2361829 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

17 years, 1 month

4
4
0 / 0

[Hibernate-JIRA] Created: (HV-77) Listing InvalidValues instead of aborting when checking a class

by Mark Schmitt (JIRA)

Listing InvalidValues instead of aborting when checking a class --------------------------------------------------------------- Key: HV-77 URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-77 Project: Hibernate Validator Issue Type: Improvement Components: engine Environment: Hibernate 3.3.1, Hibernate Validators 3.1.0.CR2 Reporter: Mark Schmitt Priority: Minor Attachments: invalidValues_add.diff Hello there, I'm working in a project where we use hibernate validators a lot. We don't just need to validate one attribute at a time, but also compare two or more attributes of a class. We use a combination of validating the class itself and the attributes, f.e.: @OurClassValidator class OurClassBO { ... @FloatRange ( min = 1, max = 100 ) private Double textLength; ... } In the OurClassValidator, it validates several other attributes (that cannot be implemented with a simple validator on the attribute, because they depend on other attributes ). And here's the catch, we still want the attributes that failed to appear in the InvalidValue-list. So we throw an InvalidStateException in the "isValid" method of the OurClassValidator and catch it with the ClassValidator and add all the invalidvalues that were caught to the list of invalid values. I've attached a patch to the ClassValidator and the ValidateEventListener. I'm horrible at explaining .. I think the code is pretty easy to understand. Err, doing that in every "OurClassValidator" would be a pain, so I wrote a Generic Validator and a lot of magic to call the respecive class validators based on data we transform from Datasources, that are like "tables" in "Smartclient", a JavaScript UI/AJAX etc. library that we use for our frontend ... anyways, my boss wanted the validators in Smartclient to work in Hibernate as well. Hmm... what else might be important .. hmm... we're not actually modifying the validator source, just extending. I copied the code back into the hibernate validator legacy -repository so it's easier for you guys to apply the patch. We're going to release this smartclient-to-hibernate-validator package as open source in a while .. it still needs some finetuning, but the general idea is working quite nicely. Now .. the big question is, is this worth a thought patching the validators to allow the validator-implementations (OurClassValidator, FloatRange) to throw their own invalidstatexception? I'm sure I'm not the only one who faced this problem, but perhaps everyone who really needs this should just extend the ClassValidator and the EventListener like I did? I don't know what's right ... It's the first time ever I send a patch to a project ;). keep up the good work! best regards, Mark -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

17 years, 1 month

2
1
0 / 0

[Hibernate-JIRA] Created: (HHH-3701) SQL function "trim" is not available in Sybase Dialect

by Juraci Paixao Krohling (JIRA)

SQL function "trim" is not available in Sybase Dialect ------------------------------------------------------ Key: HHH-3701 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3701 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.2.x Environment: Sybase ASE 15 Reporter: Juraci Paixao Krohling Assignee: Juraci Paixao Krohling Fix For: 3.2.x The current AnsiTrimEmulationFunction doesn't handles the "replace" function properly for Sybase, as it should use "str_replace" instead of "replace", so, AnsiTrimEmulationFunction needs to be aware of this, or a new class based on it should be developed. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

17 years, 1 month

4
7
0 / 0

[Hibernate-JIRA] Created: (HHH-3640) Some standard SQL functions are not implemented in Sybase

by Juraci Paixao Krohling (JIRA)

Some standard SQL functions are not implemented in Sybase --------------------------------------------------------- Key: HHH-3640 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3640 Project: Hibernate Core Issue Type: Improvement Components: testsuite Environment: Sybase ASE 15.0.2 Reporter: Juraci Paixao Krohling Assignee: Juraci Paixao Krohling Attachments: ASTParserLoadingTest.java.diff Some standard SQL functions are not implemented in Sybase, like "mod" * , bit_length, trim. Thus, the tests which uses these functions needs to be evicted. ASTParserLoadingTest, contains "trim(trailing '_' column) ... " , mod(x,y) and bit_length -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

17 years, 1 month

2
10
0 / 0

[Hibernate-JIRA] Commented: (HBX-218) rev.eng should pick up table synonyms

by Francisco Peredo (JIRA)

[ http://opensource.atlassian.com/projects/hibernate/browse/HBX-218?page=co... ] Francisco Peredo commented on HBX-218: -------------------------------------- Or at least ignore them without crashing and effectively disabling schema updating > rev.eng should pick up table synonyms > ------------------------------------- > > Key: HBX-218 > URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-218 > Project: Hibernate Tools > Issue Type: Improvement > Components: reverse-engineer > Reporter: Max Rydahl Andersen > Assignee: David Channon > Fix For: 3.2LATER > > > synonyms has a place in databases where the application is run in a different schema than the schema owner (and they dont want to expose the schema name) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

17 years, 1 month

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues February 2009