February 2010 - hibernate-issues - Jboss List Archives

[Hibernate-JIRA] Created: (HHH-2668) Caching Fails with Composite-Ids Containing Nested, Complex Entities

by Juan Osuna (JIRA)

Caching Fails with Composite-Ids Containing Nested, Complex Entities -------------------------------------------------------------------- Key: HHH-2668 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2668 Project: Hibernate3 Issue Type: Bug Components: caching (L2) Affects Versions: 3.2.4.sp1 Environment: Problem is independent of environment or platform and most likely exists in prior versions. Reporter: Juan Osuna Attachments: hibernate-caching-fix.zip Description of Failing Test Case Scenario Preconditions: An entity class is mapped that uses a composite-id that contains a nested entity class. Only the composite-id class implements equals/hashcode, not the nested entity class. Steps to Reproduce: 1. open session and fetch object using composite-id 2. open new session and fetch same object again using different instance of composite-id but with same identity Invalid Postconditions: On second retrieve, Hibernate fails to get the object from the cache and unnecessarily reloads the object. CachKeys containing different instances of the composite-id always fail to be equal even though they have the same persistent identity. Attachment Contents Code fix is attached as well as a Junit test case that reproduces the problem and validates the fix. The full Hibernate suite was also executed with no impact. Attachment contains: New Test Method: org.hibernate.test.cache.BaseCacheProviderTestCase.testQueryCacheComplexItem New Test Entity Items: org\hibernate\test\cache\ComplexItem.hbm.xml org.hibernate.test.cache.ComplexItem org.hibernate.test.cache.ComplexItemPK Code Fix: org.hibernate.cache.CacheKey (see FIX comments) Problem and Fix Details Hibernate generally strives to use persistent identifiers for managing object identity rather than the equals/hashcode methods implemented by entity classes. While it is good practice to implement equals/hashcode, Hibernate does not generally force users to do this. When wrapping a composite-id object, the current implementation of CacheKey fails to recurse through nested complex entities to query for equality based on persistent identity. Instead, when the recursion algorithm hits a complex entity, it invokes equals directly on that entity rather than further recursing through the identifier object. Notably, the recursion logic for equals is not symmetrical with the recursion logic for hashcode, which does recurse through identifier objects. So, while CacheKey never invokes hashcode on nested complex entities, it does invoke equals on these entities. A simple fix to this inconsistency is to store the factory parameter passed to CacheKey and later pass that parameter to the overloaded method: Type.isEqual(Object x, Object y, EntityMode entityMode, SessionFactoryImplementor factory). This fix restores symmetry to equals and hashcode behavior. By calling this overloaded method, the thread of execution will enter EntityType. isEqual(Object x, Object y, EntityMode entityMode, SessionFactoryImplementor factory), which correctly recurses through complex identifiers. Design Principles Hibernate should strive to behave predictably even in scenarios where users do not follow best practices. Hibernate should strive to be as forgiving as possible as long there is no negative consequence caused by such forgiveness. Hibernate should behave as consistently as possible. If Hibernate does not generally rely user-implemented equals/hashcode, it is best to avoid exceptions to this rule wherever possible. Possible Future Enhancement Mapping composite-ids that contain complex entities can cause deep object graphs to be cached as part of CacheKey. This is unsettling because of it's potential to consume memory unnecessarily and unpredictably. Currently, CacheKey caches the hashcode by recursing through a complex graph of identifier objects. Perhaps, it would also be possible for CacheKey to cache an object graph of identifier objects whose leaves hold primitive values. This would further add symmetry between hashcode and equals and lighten the load for caching composite-ids that hold entity classes. Robustly supporting composite-ids that hold complex identifiers seems like a worthwhile design goal. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 10 months

6
8
0 / 0

[Hibernate-JIRA] Created: (HHH-4812) Add fetch profile support in annotations

by Emmanuel Bernard (JIRA)

Add fetch profile support in annotations ---------------------------------------- Key: HHH-4812 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4812 Project: Hibernate Core Issue Type: New Feature Components: annotations Reporter: Emmanuel Bernard Fix For: 3.5 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 10 months

4
13
0 / 0

[Hibernate-JIRA] Created: (HBX-1160) Hibernate-tools don't compile with hibernate-core 3.5

by André Lehmann (JIRA)

Hibernate-tools don't compile with hibernate-core 3.5 ----------------------------------------------------- Key: HBX-1160 URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-1160 Project: Hibernate Tools Issue Type: Patch Components: annotations (obsolete), ant, consoleconfiguration, datagen, doc, eclipse, hbm2doc, hbm2java, hbm2seam, hbmlint, middlegenplugin, reverse-engineer, visualizations Environment: hibernate-core 3.5 Reporter: André Lehmann Attachments: hibernate-tools3.5.patch The lastest code of Hibernate-tools don't more compile with hibernate-core trunk. The attached patch allow just compile HBX with hibernate-core trunk. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 10 months

2
12
0 / 0

[Hibernate-JIRA] Created: (HHH-4666) Implement the clarified rules for resource discovery (esp for <mapping-file> and co)

by Emmanuel Bernard (JIRA)

Implement the clarified rules for resource discovery (esp for <mapping-file> and co) ------------------------------------------------------------------------------------ Key: HHH-4666 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4666 Project: Hibernate Core Issue Type: Sub-task Reporter: Emmanuel Bernard -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 10 months

3
12
0 / 0

[Hibernate-JIRA] Created: (HSEARCH-464) Upgrade Lucene to 2.9.2

by Sanne Grinovero (JIRA)

Upgrade Lucene to 2.9.2 ----------------------- Key: HSEARCH-464 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-464 Project: Hibernate Search Issue Type: Improvement Reporter: Sanne Grinovero Assignee: Sanne Grinovero Fix For: 3.2.0.Beta2 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 10 months

1
1
0 / 0

[Hibernate-JIRA] Created: (HSEARCH-455) Keep Search compatible with latest Hibernate Core

by Sanne Grinovero (JIRA)

Keep Search compatible with latest Hibernate Core ------------------------------------------------- Key: HSEARCH-455 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-455 Project: Hibernate Search Issue Type: Task Reporter: Sanne Grinovero Assignee: Sanne Grinovero Some abstract methods where added in core 3.5-Beta-4 and after that some more code is breaking the Search build. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 10 months

2
3
0 / 0

[Hibernate-JIRA] Created: (HHH-2047) make Query and Criteria extend java.lang.Iterable

by Amir Pashazadeh (JIRA)

make Query and Criteria extend java.lang.Iterable ------------------------------------------------- Key: HHH-2047 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-2047 Project: Hibernate3 Type: Improvement Components: core Versions: 3.2.0.cr2 Reporter: Amir Pashazadeh Priority: Trivial Objects which implement java.lang.Iterable can be iterated using extended for loop. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 10 months

2
2
0 / 0

[Hibernate-JIRA] Created: (HSEARCH-463) Change the master docbook document to use the version number provided by the docbook plugin

by Hardy Ferentschik (JIRA)

Change the master docbook document to use the version number provided by the docbook plugin ------------------------------------------------------------------------------------------- Key: HSEARCH-463 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-463 Project: Hibernate Search Issue Type: Task Components: documentation Affects Versions: 3.2.0.Beta1 Reporter: Hardy Ferentschik Assignee: Hardy Ferentschik Fix For: 3.2.0.Beta2 This way one does not have to update the version number prior to releases. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 10 months

1
1
0 / 0

[Hibernate-JIRA] Created: (ANN-407) <synchronize table="table_name"/> is missed using annotations

by Amir Pashazadeh (JIRA)

<synchronize table="table_name"/> is missed using annotations -------------------------------------------------------------- Key: ANN-407 URL: http://opensource.atlassian.com/projects/hibernate/browse/ANN-407 Project: Hibernate Annotations Type: Patch Components: binder Versions: 3.2.0.cr1 Reporter: Amir Pashazadeh in old .hbm.xml notation there was a possibility to set a synchronize for caches on particular tables, and I could not find such thing using annotations, is it possible to set "synchronize" tables using annotations? and if not will it be added to 3.2? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 10 months

3
3
0 / 0

[Hibernate-JIRA] Resolved: (HHH-4374) @Subselect

by Sharath Reddy (JIRA)

[ http://opensource.atlassian.com/projects/hibernate/browse/HHH-4374?page=c... ] Sharath Reddy resolved HHH-4374. -------------------------------- Resolution: Fixed Fix Version/s: 3.5.0.Next > @Subselect > ---------- > > Key: HHH-4374 > URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4374 > Project: Hibernate Core > Issue Type: Improvement > Components: annotations > Reporter: Steve Ebersole > Assignee: Sharath Reddy > Priority: Trivial > Fix For: 3.5.0.Next > > > @Subselect( sql="select name, phone from Person", synchronize={@Table(name="Person")} ) > Equivalent of > <class> > <subselect>select name, phone from Person</subselect> > <synchrosize table="Person"/> > ... > </class> -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 10 months

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues February 2010