June 2010 - hibernate-issues - Jboss List Archives

[Hibernate-JIRA] Created: (HHH-5094) PersistenceUtilHelper cannot access non-public fields/methods (it should be able to)

by Philip Clay (JIRA)

PersistenceUtilHelper cannot access non-public fields/methods (it should be able to) ------------------------------------------------------------------------------------ Key: HHH-5094 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5094 Project: Hibernate Core Issue Type: Bug Components: entity-manager Affects Versions: 3.5.0-Final Environment: 3.5.0-Final. Any environment Reporter: Philip Clay Attachments: hibernate-entitymanager-bugreproduction.tgz PersistenceUtilHelper is only able to access public fields and public methods. As it is written, it cannot access non-public members. Internally, it incorrectly uses Class.getField(...) and Class.getMethod(...). It should use Class.getDeclaredField(...) and Class.getDeclaredMethod(...), so that it can see non-public members. I believe the use of getField and getMethod is not indented, because setAccessibility is the next call after that. Here is the code... {code} private static Object get(Object proxy, String property) { final Class<?> clazz = proxy.getClass(); try { try { final Field field = clazz.getField( property ); // only retrieves public fields!!! setAccessibility( field ); // if you really only wanted public fields, this call is unnecessary! return field.get( proxy ); } catch ( NoSuchFieldException e ) { final Method method = getMethod( clazz, property ); if (method != null) { setAccessibility( method ); // if you really only wanted public methods, this call is unnecessary! return method.invoke( proxy ); } ... } private static Method getMethod(Class<?> clazz, String methodName) { try { char string[] = methodName.toCharArray(); string[0] = Character.toUpperCase( string[0] ); methodName = new String( string ); try { return clazz.getMethod( "get" + methodName ); // only retrieves public methods!!! } catch ( NoSuchMethodException e ) { return clazz.getMethod( "is" + methodName ); // only retrieves public methods!!! } ... } private static void setAccessibility(Member member) { if ( !Modifier.isPublic( member.getModifiers() ) ) { //Sun's ease of use, sigh... ( ( AccessibleObject ) member ).setAccessible( true ); // This is dead code! The input member will always be public } } {code} Notice the call to setAccessibility. The call to setAccessibility shows that one assumes that the field retrieved from getField() (or method from getMethod()) could be non-public, which in fact it can't. All fields returned from getField will always be public (same for getMethod()). So, essentially the code inside the if statement in setAccessibility is dead code. I have attached a tarball containing a failing testcase that shows the incorrect behavior. Explode the tarball and run "mvn test" to reproduce the incorrect behavior. Also, within the tarball, I have included an svn diff for a proposed patch. See the README.txt file within the tarball for more info. I first noticed this problem when using hibernate validator to validate some protected members, but I narrowed it down to a problem in PersistenceUtilHelper. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

15 years, 9 months

5
9
0 / 0

[Hibernate-JIRA] Created: (HHH-5324) Testes fail on mysql

by Strong Liu (JIRA)

Testes fail on mysql -------------------- Key: HHH-5324 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5324 Project: Hibernate Core Issue Type: Bug Components: testsuite Affects Versions: 3.5.x, 3.6 Reporter: Strong Liu Assignee: Strong Liu Fix For: 3.5.x, 3.6 1. org.hibernate.test.criteria.CriteriaQueryTest.testProjectedCompositeId() line 1283, the Criteria.list return type is List, in the following assert, it converted to Long, then CCE. this has not been found till now is because of the default test db (hsqldb) does not support Tuple Distinct Counts 2. org.hibernate.test.sql.hand.quotedidentifiers.NativeSqlAndQuotedIdentifiersTest in this test class, it overrides the prepareTest method, and calls sfi() to get a sessionfactory, but this test also has an applyTo method to determine if the dialect.openQuote() is quote ("), when the open quote is not quote ("), the sfi() return null 3. org.hibernate.test.schemaupdate.MigrationTest does not clean the DB when it finished 4. org.hibernate.test.component.basic.ComponentTest.testComponentFormulaQuery() parameters does not match 5. org.hibernate.test.annotations.quote.resultsetmappings.ExplicitSqlResultSetMappingTest uses quote(") as the Quote character in the query string, this fails on Mysql -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

15 years, 9 months

3
3
0 / 0

[Hibernate-JIRA] Created: (HHH-4945) Replace all usages of EJB3TestCase with org.hibernate.ejb.test.TestCase

by Hardy Ferentschik (JIRA)

Replace all usages of EJB3TestCase with org.hibernate.ejb.test.TestCase ----------------------------------------------------------------------- Key: HHH-4945 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4945 Project: Hibernate Core Issue Type: Improvement Components: entity-manager Affects Versions: 3.5.0-CR-1 Reporter: Hardy Ferentschik Fix For: 3.5.x The setup in EJB3TestCase is really strange and we really want to have as many test as possible to derive from your main test base class. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

15 years, 9 months

3
8
0 / 0

[Hibernate-JIRA] Created: (HHH-3765) Fill the "end revision" column with appropriate data in add/mod/del/collection work units

by Adam Warski (JIRA)

Fill the "end revision" column with appropriate data in add/mod/del/collection work units ----------------------------------------------------------------------------------------- Key: HHH-3765 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3765 Project: Hibernate Core Issue Type: Sub-task Components: envers Reporter: Adam Warski Assignee: Adam Warski In case of modifications, not only the "end revision" column should be set on new data, but also modified on existing data. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

15 years, 9 months

2
2
0 / 0

[Hibernate-JIRA] Created: (HHH-5317) Update Annotations and EM to use latest version of Hibernate Validator

by Hardy Ferentschik (JIRA)

Update Annotations and EM to use latest version of Hibernate Validator ----------------------------------------------------------------------- Key: HHH-5317 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5317 Project: Hibernate Core Issue Type: Task Components: annotations, entity-manager Reporter: Hardy Ferentschik Assignee: Hardy Ferentschik Fix For: 3.6 We should upgrade 4.1.0 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

15 years, 9 months

2
2
0 / 0

[Hibernate-JIRA] Created: (HHH-3764) Add the "end-revision" column when generating metadata

by Adam Warski (JIRA)

Add the "end-revision" column when generating metadata ------------------------------------------------------ Key: HHH-3764 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3764 Project: Hibernate Core Issue Type: Sub-task Components: envers Reporter: Adam Warski Assignee: Adam Warski The column would only be added if the necessary setting is set to true. The column will have the same type as the revision number, but will be nullable. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

15 years, 9 months

2
2
0 / 0

[Hibernate-JIRA] Created: (HHH-5260) Tweak for query-cache via hibernate.hbm.xml needed

by Galder Zamarreno (JIRA)

Tweak for query-cache via hibernate.hbm.xml needed -------------------------------------------------- Key: HHH-5260 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5260 Project: Hibernate Core Issue Type: New Feature Components: caching (L2) Reporter: Galder Zamarreno Assignee: Galder Zamarreno >From Niktia Koksharov in https://jira.jboss.org/browse/ISPN-458: "In current implementation of hibernate-infinispan we can tune only entity and collection settings via hibernate.xml.cfg. But tuning in same way for queries needed too. In current version there are always the same cache region for all queries (look at org.hibernate.cache.infinispan.InfinispanRegionFactory.buildQueryResultsRegion) and it's incorrect. In org.hibernate.cache.infinispan.InfinispanRegionFactory.buildQueryResultsRegion Replace those lines: String cacheName = typeOverrides.get(QUERY_KEY).getCacheName(); CacheAdapter cacheAdapter = CacheAdapterImpl.newInstance(manager.getCache(cacheName)); To: Cache cache = getCache(regionName, QUERY_KEY, properties); CacheAdapter cacheAdapter = CacheAdapterImpl.newInstance(cache); " -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

15 years, 9 months

3
13
0 / 0

[Hibernate-JIRA] Created: (HHH-5337) Allow customization of import files and multi files imports

by Emmanuel Bernard (JIRA)

Allow customization of import files and multi files imports ----------------------------------------------------------- Key: HHH-5337 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5337 Project: Hibernate Core Issue Type: New Feature Components: core Reporter: Emmanuel Bernard Assignee: Emmanuel Bernard Fix For: 3.6 default is still /import.sql you can override it with {code}hibernate.hbm2ddl.import_files /mydbload.sql,/mydbload2.sql{code} ordering matters -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

15 years, 9 months

2
3
0 / 0

[Hibernate-JIRA] Created: (HHH-5332) JndiInfinispanRegionFactory cannot be instantiated

by Galder Zamarreno (JIRA)

JndiInfinispanRegionFactory cannot be instantiated -------------------------------------------------- Key: HHH-5332 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5332 Project: Hibernate Core Issue Type: Bug Components: caching (L2) Affects Versions: 3.5.3, 3.5.2, 3.5.1, 3.5.0-Final Reporter: Galder Zamarreno Assignee: Galder Zamarreno Fix For: 3.5.x, 3.6 org.hibernate.HibernateException: could not instantiate RegionFactory [org.hibernate.cache.infinispan.JndiInfinispanRegionFactory] at org.hibernate.cfg.SettingsFactory.createRegionFactory(SettingsFactory.java:412) at org.hibernate.test.cache.infinispan.JndiInfinispanRegionFactoryTestCase.testConstruction(JndiInfinispanRegionFactoryTestCase.java:19) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at com.intellij.junit3.JUnit3IdeaTestRunner.doRun(JUnit3IdeaTestRunner.java:108) at com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:64) Caused by: java.lang.NoSuchMethodException: org.hibernate.cache.infinispan.JndiInfinispanRegionFactory.<init>(java.util.Properties) at java.lang.Class.getConstructor0(Class.java:2706) at java.lang.Class.getConstructor(Class.java:1657) at org.hibernate.cfg.SettingsFactory.createRegionFactory(SettingsFactory.java:407) ... 19 more -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

15 years, 9 months

2
2
0 / 0

[Hibernate-JIRA] Created: (HHH-4568) Sybase - Test "BatchTest" fails due to "unexpected row count from update"

by Strong Liu (JIRA)

Sybase - Test "BatchTest" fails due to "unexpected row count from update" ------------------------------------------------------------------------- Key: HHH-4568 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4568 Project: Hibernate Core Issue Type: Bug Components: core Affects Versions: 3.5.0-Beta-2, 3.5.0.Beta-1, 3.3.2, 3.2.4.sp1 Environment: Sybase Reporter: Strong Liu Assignee: Strong Liu Fix For: 3.2.x, 3.3.x, 3.5, 3.3.0.GA, 3.2.4.sp1 The test "BatchTest" fails due to "org.hibernate.StaleStateException: Batch update returned unexpected row count from update [0]; actual row count: 0; expected: 1". The database server seems configured properly, as the "BatchUpdates" sample from jConnect 6 works correctly. The problem specifically occurs with a table that has a numeric column with precision (e.g. numeric(10,4)) Sybase does not thrown any SQLException when you try and persist a numeric value whose scale exceeds that defined on the column. Instead, it returns an updateCount of zero -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

15 years, 9 months

3
9
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues June 2010