September 2010 - hibernate-issues

[Hibernate-JIRA] Created: (HV-264) Validation of List of primitives

by Michenaud Laurent (JIRA)

Validation of List of primitives -------------------------------- Key: HV-264 URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-264 Project: Hibernate Validator Issue Type: Bug Components: engine Affects Versions: 4.0.1 Environment: Linux Reporter: Michenaud Laurent Hi, I have a list of String in my bean : These strings are email and i want to validate them. So, i did in my bean : @NotEmpty @Email //@Valid <= uncommenting that line doesnot change anything. List<String> emails ; At execution, i've got the error : Exception in thread "main" javax.validation.UnexpectedTypeException: No validator could be found for type: java.util.List<java.lang.String> at org.hibernate.validator.engine.ConstraintTree.verifyResolveWasUnique(ConstraintTree.java:236) at org.hibernate.validator.engine.ConstraintTree.findMatchingValidatorClass(ConstraintTree.java:219) at org.hibernate.validator.engine.ConstraintTree.getInitializedValidator(ConstraintTree.java:167) at org.hibernate.validator.engine.ConstraintTree.validateConstraints(ConstraintTree.java:113) at org.hibernate.validator.metadata.MetaConstraint.validateConstraint(MetaConstraint.java:121) at org.hibernate.validator.engine.ValidatorImpl.validateConstraint(ValidatorImpl.java:334) at org.hibernate.validator.engine.ValidatorImpl.validateConstraintsForRedefinedDefaultGroup(ValidatorImpl.java:278) at org.hibernate.validator.engine.ValidatorImpl.validateConstraintsForCurrentGroup(ValidatorImpl.java:260) at org.hibernate.validator.engine.ValidatorImpl.validateInContext(ValidatorImpl.java:213) at org.hibernate.validator.engine.ValidatorImpl.validate(ValidatorImpl.java:119) at com.adeuza.movalys.validation.hibernate.TestMain.main(TestMain.java:75) I don't know if it is a bug in hibernate validator. I have looked at the JSR303 and i have not seen anything about List of primitives. You can validate per example List<Person> with @Valid and it works well because the validator knows about Person class. I have used a little the Oval framework and with it, you can tell if the check applies to the container, or the values inside, or the keys(for map). I don't know if you can do that with JSR303. I'm interesting with your point of view. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 1 month

3
12
0 / 0

[Hibernate-JIRA] Created: (HV-270) Verify in the annotation processor that constraints are not stupid

by Emmanuel Bernard (JIRA)

Verify in the annotation processor that constraints are not stupid ------------------------------------------------------------------ Key: HV-270 URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-270 Project: Hibernate Validator Issue Type: New Feature Reporter: Emmanuel Bernard Assignee: Hardy Ferentschik For example @Pattern shoudl ahve a valid regular exception @Size should have min <= max etc -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 1 month

3
10
0 / 0

[Hibernate-JIRA] Created: (HV-135) Constraints can contains constraint annotations to validate params before initialize is called

by Emmanuel Bernard (JIRA)

Constraints can contains constraint annotations to validate params before initialize is called ---------------------------------------------------------------------------------------------- Key: HV-135 URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-135 Project: Hibernate Validator Issue Type: New Feature Components: engine Reporter: Emmanuel Bernard not high priority >From Sebastian Thomschke -------------------------------------- I just had a look through the Hibernate Validator code, what struck me was the way how you validate parameters. E.g. private void validateParameters() { if ( min < 0 ) { throw new ValidationException( "The min parameter cannot be negative." ); } if ( max < 0 ) { throw new ValidationException( "The max paramter cannot be negative." ); } if ( max < min ) { throw new ValidationException( "The length cannot be negative." ); } } I just had the idea, why don't we use the constraint annotations for the built-in constraints themselves? E.g. /** * @return size the element must be higher or equal to */ @Min(0) int min() default 0; /** * @return size the element must be lower or equal to */ @Min(0) int max() default Integer.MAX_VALUE; Then this kind of parameter validation could be done by the framework and must not be repeated in every validator implementation. What do you think? Regards, Seb -------------------------------------- Emmanuel Your idea is interesting. It could lead to infinite recursion if someone does not pay attention but could work. I think it would better be a product feature though instead of a spec feature for this rev at least. We can't have "class" level constraints though as it conflicts with the composition model. WDYT? it seems to me that the ValidationException is wrong in the example you gave. http://opensource.atlassian.com/projects/hibernate/browse/HV-134 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 1 month

2
3
0 / 0

[Hibernate-JIRA] Created: (HV-308) Annotation processor should consider validators registered by XML constraint mapping

by Gunnar Morling (JIRA)

Annotation processor should consider validators registered by XML constraint mapping ------------------------------------------------------------------------------------ Key: HV-308 URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-308 Project: Hibernate Validator Issue Type: Improvement Components: annotation-processor Reporter: Gunnar Morling Assignee: Hardy Ferentschik Fix For: 4.1.0 Background: The Bean Validation API allows the set of validators for a given constraint to be specified/overridden using XML constraint mapping files (http://docs.jboss.org/hibernate/stable/validator/reference/en/html_single...). Right now the annotation processor does not process any XML configuration files at all (neither validation.xml nor mapping files). To do: While it seems ok for now that the AP does not check constraint declarations given in XML (after all it's an *annotation* processor), I think it should evaluate the constraint definitions and the validators configured in XML. Otherwise the AP would raise false errors (as validators added in XML are ignored) or would give false positives (as validators given in @Constraint#validatedBy could be removed by "include-existing-validator='false'"). -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 1 month

2
8
0 / 0

[Hibernate-JIRA] Created: (BVAL-22) Dynamic metadata mode

by Emmanuel Bernard (JIRA)

Dynamic metadata mode --------------------- Key: BVAL-22 URL: http://opensource.atlassian.com/projects/hibernate/browse/BVAL-22 Project: Bean Validation Issue Type: New Feature Components: ri-general Reporter: Emmanuel Bernard Priority: Minor Test how a dynamic reloading mode would work. Instead of caching metadata by ValidationFactory, reload as the data might have changed (annotations or XML) This can be a configuration setting. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 1 month

2
9
0 / 0

[Hibernate-JIRA] Created: (BVAL-44) Explore integration with Bean Validation APIs and a Rule engine

by Emmanuel Bernard (JIRA)

Explore integration with Bean Validation APIs and a Rule engine --------------------------------------------------------------- Key: BVAL-44 URL: http://opensource.atlassian.com/projects/hibernate/browse/BVAL-44 Project: Bean Validation Issue Type: New Feature Components: ri-general Reporter: Emmanuel Bernard Priority: Minor http://forum.hibernate.org/viewtopic.php?t=991847 If possible community driven. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 1 month

2
3
0 / 0

[Hibernate-JIRA] Created: (HV-356) Consider if issue when bean's hashCode() uses lazy-loaded property needs to be addressed in default event listener/validator implementation

by Roman Arkadijovych Muntyanu (JIRA)

Consider if issue when bean's hashCode() uses lazy-loaded property needs to be addressed in default event listener/validator implementation ------------------------------------------------------------------------------------------------------------------------------------------- Key: HV-356 URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-356 Project: Hibernate Validator Issue Type: Task Components: validators Affects Versions: 4.1.0.Final Environment: Hibernate 3.5.3-Final, Spring 3.0.3.RELEASE, Hibernate Validator 4.1.0.Final Reporter: Roman Arkadijovych Muntyanu Assignee: Hardy Ferentschik Priority: Minor This issue has been created based on contributor's request in discussion https://forum.hibernate.org/viewtopic.php?f=9&t=1006194&start=0 related to the issue occurring when persisted object's hashCode() implementation uses lazily-loaded properties. This triggers "collection [...] was not processed by flush()" issue with default Hibernate Validator event listener (org.hibernate.cfg.beanvalidation.BeanValidationEventListener) and validator (org.hibernate.validator.engine.ValidatorImpl) implementations because of hashCode() usage in SingleThreadCachedTraversableResolver.buildHashCode(). The purpose of this task is to consider whether this is or is not an overlook in assumptions made in validator implementation. And depending on the result following outcomes are expected: * either create a separate task for addressing the issue in default validator implementation; * or provide suggestions and (if possible) examples on how the issue can be addressed at the framework user's site if lazily-loaded properties usage IS appropriate. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 1 month

2
6
0 / 0

[Hibernate-JIRA] Created: (BVAL-189) Bean Validation should use java.beans.PropertyDescriptor

by Brian (JIRA)

Bean Validation should use java.beans.PropertyDescriptor -------------------------------------------------------- Key: BVAL-189 URL: http://opensource.atlassian.com/projects/hibernate/browse/BVAL-189 Project: Bean Validation Issue Type: Bug Affects Versions: 4.0.0.Alpha1 Environment: Any Reporter: Brian Priority: Minor Right now, hibernate determines a matching getter and setters by matching methods that start with "get" and "set" or "is" and "set". But the spec says that "is" should only be considered when the type is little boolean. Hibernate should fail validation in this case because it doesn't match the spec: public Boolean isVariable() public Boolean setVariable() because in this case "is" should be "get" since it is not a little boolean. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 1 month

3
5
0 / 0

[Hibernate-JIRA] Created: (BVAL-197) validation of a persisted map

by tho gau (JIRA)

validation of a persisted map ----------------------------- Key: BVAL-197 URL: http://opensource.atlassian.com/projects/hibernate/browse/BVAL-197 Project: Bean Validation Issue Type: Bug Environment: hibernate-core 3.5.0-Beta-3 Validator 4.0.1.GA MySQL 5.1 Reporter: tho gau Attachments: mapValidation.zip Hi, I am trying to validate an entity that holds a Map<K, V> of other persisted entities (just checking wether the map holds some predefined values). I can validate it "by hand" using validator.validate() and my map is correctly filled at validation time However when validation framework is called by persistence callbacks, my map is always empty... I am using Validator 4.0.1.GA and hibernate-core 3.5.0-Beta-2 I tryed to pinpoint the problem and it seems that the map is not touched in the following method of AbstractType during the merge : {code} public Object replace( Object original, Object target, SessionImplementor session, Object owner, Map copyCache, ForeignKeyDirection foreignKeyDirection) throws HibernateException { boolean include; if ( isAssociationType() ) { AssociationType atype = (AssociationType) this; include = atype.getForeignKeyDirection()==foreignKeyDirection; } else { include = ForeignKeyDirection.FOREIGN_KEY_FROM_PARENT==foreignKeyDirection; } return include ? replace(original, target, session, owner, copyCache) : target; } {code} -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 1 month

4
14
0 / 0

[Hibernate-JIRA] Created: (HHH-5419) COUNT operator with composite primary key and JPA 2.0 Criteria API produces bad sql

by Fabio Braga de Oliveira (JIRA)

COUNT operator with composite primary key and JPA 2.0 Criteria API produces bad sql ----------------------------------------------------------------------------------- Key: HHH-5419 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-5419 Project: Hibernate Core Issue Type: Bug Affects Versions: 3.6.0.Beta1, 3.5.4, 3.5.3, 3.5.2, 3.5.1 Environment: hibernate-entitymanager 3.6.0.Beta1, glassfish 3.0.1, linux ubuntu 10.04, MS SQL Server 2008 Reporter: Fabio Braga de Oliveira Attachments: hibernate-count-bug.zip Hibernate produces a invalid SQL if anyone use the count() operator with the JPA 2.0 Criteria API. Code: CriteriaBuilder cb = getEntityManager().getCriteriaBuilder(); CriteriaQuery<Object[]> cq = cb.createQuery(Object[].class); Root<EntityCompositePK> r = cq.from(EntityCompositePK.class); cq.multiselect(cb.count(r)); assertEquals(0, ((Long) (getEntityManager().createQuery(cq).getSingleResult())[0]).intValue()); I'm sending a little maven project which reproduces the bug. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

14 years, 1 month

8
17
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues September 2010