[Hibernate-JIRA] Created: (HV-445) Ensure meta models are completely unmodifiable
by Gunnar Morling (JIRA)
Ensure meta models are completely unmodifiable
----------------------------------------------
Key: HV-445
URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-445
Project: Hibernate Validator
Issue Type: Improvement
Reporter: Gunnar Morling
Fix For: 4.2.0.CR1
The internal meta model (BeanMetaDataImpl et al.) as well as the external one (BeanDescriptorImpl et al.) should be completely unmodifiable, as they could potentially be accessed from multiple threads at the same time.
I made some more fields final/unmodifiable with HV-371, but there are some places left which I couldn't change easily and need some more consideration:
* ConstraintDescriptorImpl#compositionType
* ElementDescriptorImpl#constraintDescriptors
* BeanMetaDatImpl#cascadedMembers (could be made unmodifiable after initialization instead of creating a new unmodifiable set with each call of getCascadedMembers()
When looking through the model I found it quite complex to find out which collection fields are already unmodifiable and which not. I therefore thought about introducing a marker annotation @Unmodifiable which could be used to document unmodifiable fields. WDYT?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
14 years
[Hibernate-JIRA] Created: (HHH-4962) @ManyToOne with @JoinTable fails
by Clint Popetz (JIRA)
@ManyToOne with @JoinTable fails
--------------------------------
Key: HHH-4962
URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-4962
Project: Hibernate Core
Issue Type: Bug
Components: envers
Affects Versions: 3.3.2
Reporter: Clint Popetz
$ cat src/main/java/test/User.java
package test;
import javax.persistence.*;
import org.hibernate.envers.Audited;
import java.util.Set;
The below code fails with "org.hibernate.MappingException: Unable to read the mapped by attribute for widgets in test.User!" but is supported by JPA, at least under hibernate.
@Entity
@Audited
public class User
{
@Id
private long id;
@OneToMany(mappedBy="user")
private Set<Widget> widgets;
}
$ cat src/main/java/test/Widget.java
package test;
import javax.persistence.*;
import org.hibernate.envers.Audited;
@Entity
@Audited
public class Widget
{
@Id
private long id;
@ManyToOne(fetch=FetchType.LAZY)
@JoinTable(name = "widget_to_user",
joinColumns = @JoinColumn(name = "widget_id"),
inverseJoinColumns = @JoinColumn(name = "user_id"))
private User user;
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators....
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
14 years