December 2011 - hibernate-issues - Jboss List Archives

[Hibernate-JIRA] Created: (BVAL-225) JSR303 1.1: support resource bundles in constraint annotation packages

by Gabriele Del Prete (JIRA)

JSR303 1.1: support resource bundles in constraint annotation packages ---------------------------------------------------------------------- Key: BVAL-225 URL: http://opensource.atlassian.com/projects/hibernate/browse/BVAL-225 Project: Bean Validation Issue Type: Improvement Affects Versions: 1.1 Reporter: Gabriele Del Prete Attachments: ResourceBundleMessageInterpolator.java (I published this same proposal also on the forum, and copying it here so that it does not get lost) This is a proposal for the new version of JSR 303 (v1.1 ?). The proposal is: modify the default message interpolation algorithm (section 4.3.1.1) so that the validation engine looks for a Resource Bundle called "ValidationMessages" in the constraint annotation's own package. For example, when validating constraint annotation com.gdpcons.constraints.MustEqual, validator should also look for messages in a resource bundle called com.gdpcons.constraints.ValidationMessages. The constraint annotation package ValidationMessages resource bundle should be checked after the "user" ValidationMessages resource bundle, but before the BeanValidation provider's own private ValidationMessages resource bundle, so as to allow users to override the string provided by the constraint annotation resource bundle. This would allow people to write redistributable collections of constraint annotations, since as of today it's not possible to use multiple ValidationMessages resource bundles files (one will override all the others in the classpath); and it would still allow users to override the provided messages just by a new definition for the message key in their own ValidationMessages resource bundle. I've written an example implementation, by modifying Hibernate Validator's own ResourceBundleMessageInterpolator. It seams to work without side effects, and is a very straightforward implementation. See it attached to this issue. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 2 months

3
4
0 / 0

[Hibernate-JIRA] Created: (BVAL-252) Improve support for the creation of constraint libraries

by Gunnar Morling (JIRA)

Improve support for the creation of constraint libraries -------------------------------------------------------- Key: BVAL-252 URL: http://opensource.atlassian.com/projects/hibernate/browse/BVAL-252 Project: Bean Validation Issue Type: Improvement Components: spec-general Affects Versions: 1.0 final Reporter: Gunnar Morling As of BV 1.0 the support for the creation of constraint libraries is rather limited. It should be possible: * to provide messages for custom constraints without requiring the end user to explicitely import additional bundles * to deliver constraints and validator implementations in separate JARs without requiring the end user to import additional constraint mappings or similar Related discussion: http://lists.jboss.org/pipermail/beanvalidation-dev/2011-October/000071.html -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 2 months

3
4
0 / 0

[Hibernate-JIRA] Created: (HSEARCH-735) Create a test for HSEARCH-734

by Sanne Grinovero (JIRA)

Create a test for HSEARCH-734 ----------------------------- Key: HSEARCH-735 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-735 Project: Hibernate Search Issue Type: Task Reporter: Sanne Grinovero Assignee: Sanne Grinovero Fix For: 3.5 Preventing the NPE reported as HSEARCH-734 was trivial, but we are missing a test for it. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 2 months

1
5
0 / 0

[Hibernate-JIRA] Created: (BVAL-209) Upload schema where they are due

by Emmanuel Bernard (JIRA)

Upload schema where they are due -------------------------------- Key: BVAL-209 URL: http://opensource.atlassian.com/projects/hibernate/browse/BVAL-209 Project: Bean Validation Issue Type: Bug Reporter: Emmanuel Bernard Assignee: Hardy Ferentschik Like http://java.sun.com/xml/ns/javaee/ we should have http://jboss.org/xml/ns/javax/validation/configuration should point to a descriptive html page. This page pointing to validation-configuration-1.0.xsd http://jboss.org/xml/ns/javax/validation/mapping should point to a descriptive html page. This page pointing to validation-mapping-1.0.xsd -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 2 months

3
5
0 / 0

[Hibernate-JIRA] Created: (BVAL-211) Consider making javax.validation.ValidatorContext a self-referential generic type

by Gunnar Morling (JIRA)

Consider making javax.validation.ValidatorContext a self-referential generic type --------------------------------------------------------------------------------- Key: BVAL-211 URL: http://opensource.atlassian.com/projects/hibernate/browse/BVAL-211 Project: Bean Validation Issue Type: Improvement Components: spec-general Affects Versions: 1.0 final Reporter: Gunnar Morling Priority: Minor It should be investigated whether the interface javax.validation.ValidatorContext could be re-defined as self-referential generic type as follows: {code:java} public interface ValidatorContext <V extends ValidatorContext<V>> { V messageInterpolator(MessageInterpolator messageInterpolator); V traversableResolver(TraversableResolver traversableResolver); V constraintValidatorFactory(ConstraintValidatorFactory factory); Validator getValidator(); } {code} Provider-specific extensions of this interface (such as [HibernateValidatorContext|https://github.com/hibernate/hibernate-validato...]) then wouldn't have to re-define all of ValidatorContext's methods returning their own type (which they currently must do in order to allow for the method chaining pattern to work correctly). Generally this is a breaking change, as existing implementations wouldn't compile with the proposed new version of the interface. But as it is intended to be implemented by BV providers only, this seems acceptable. API users would get a raw type warning if they have variables of type ValidatorContext. This should happen very rarely though, as ValidatorContext typically is only used in chained method calls (with a final getValidator() invocation) but not assigned to a variable. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 2 months

2
1
0 / 0

[Hibernate-JIRA] Created: (BVAL-222) Add a ALL group to validate all groups instead of DEFAULT or the selected ones

by Emmanuel Bernard (JIRA)

Add a ALL group to validate all groups instead of DEFAULT or the selected ones ------------------------------------------------------------------------------ Key: BVAL-222 URL: http://opensource.atlassian.com/projects/hibernate/browse/BVAL-222 Project: Bean Validation Issue Type: New Feature Components: spec-general Reporter: Emmanuel Bernard Gerhard #2 it would be nice to have #validateAll or a group called javax.validation.groups.All to validate all groups without knowing the concrete groups. Emmanuel What's the use case they were invoking? ( my favorite mantra :) ) Gerhard i think it was just: if you are using groups for partial validation you might have a wizard and in every step you validate with a different group and they needed the concept instead of collecting all groups manually (e.g. in the service which finally saves the new entry) -> they requested an api for validating every constraint which is available in the given object-graph -> the service can perform a full validation before it processes the data. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 2 months

1
2
0 / 0

[Hibernate-JIRA] Created: (BVAL-234) Netbeans 7 default generated entity classes conflict with bean validation

by Richard Clarke (JIRA)

Netbeans 7 default generated entity classes conflict with bean validation -------------------------------------------------------------------------- Key: BVAL-234 URL: http://opensource.atlassian.com/projects/hibernate/browse/BVAL-234 Project: Bean Validation Issue Type: Improvement Components: spec-general Affects Versions: 1.1 Environment: Netbeans 7, Seam 3 under JBOSS AS 7 Reporter: Richard Clarke Priority: Minor When using NetBeans 7 to generate entity classes from a database table, the entity classes are generated with the following annotations... public class Orders implements Serializable { private static final long serialVersionUID = 1L; @Id @GeneratedValue(strategy = GenerationType.IDENTITY) @Basic(optional = false) @NotNull @Column(name = "orderid") private Integer orderid; ..... When persisting, bean validation fails because the autogenerated primary key is null at the time the object is persisted. Netbeans have stated that they wont fix this as they see it as bean validation issue rather than their generated classes. See here: http://netbeans.org/bugzilla/show_bug.cgi?id=197845 Related Forum posting is here... https://forum.hibernate.org/viewtopic.php?f=9&t=1011908 Suggest modifying Bean Validation Pre-Persist to ignore @NotNull if @GeneratedValue exists. Thanks Rich -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 2 months

4
9
0 / 0

[Hibernate-JIRA] Created: (BVAL-248) Introduce order for propery constraints and allow to stop validation for first failing property constraint

by Hardy Ferentschik (JIRA)

Introduce order for propery constraints and allow to stop validation for first failing property constraint ---------------------------------------------------------------------------------------------------------- Key: BVAL-248 URL: http://opensource.atlassian.com/projects/hibernate/browse/BVAL-248 Project: Bean Validation Issue Type: New Feature Components: spec-general Affects Versions: 1.0 final Reporter: Hardy Ferentschik Atm it is very cumbersome to specify multiple constraint per property and stop validation (on a property level) for the first failing constraint. See also HV-462 Since the Java reflection API does not allow to reflect on the order of the specified constraints you would need to introduce an _order_ property for the constraints or some additional annotation. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 2 months

2
2
0 / 0

[Hibernate-JIRA] Created: (HV-462) Allow ordered validator's annotations

by Pavla Nováková (JIRA)

Allow ordered validator's annotations ------------------------------------- Key: HV-462 URL: http://opensource.atlassian.com/projects/hibernate/browse/HV-462 Project: Hibernate Validator Issue Type: New Feature Affects Versions: 4.1.0.Final Reporter: Pavla Nováková 1) Consider domain object with simple constraints (just to demonstrate required feature, my real example uses custom cost-expensive validation of pictures): {code} public class DomainObject { @Size(max=50) // constraint 1a @Pattern(regexp="[a-z]*") // constraint 1b private String name; @Size(max=20) // constraint 2a @URL // constraint 2b private String email; @Size(max=100) // constraint 3a @Pattern(regexp="[0-9]*") // constraint 3b private String password; {code} 2) Consider validation requirements: * all properties should be validated together (like one virtual group) * FOR EACH PROPERTY validation should occur in ordered steps given by order of annotations for given property (if first validation step fails, SKIP following validation process on given property and add validation message specific to failed / last validated constraint for the property) 3) Why it is useful: * simple cost-effective validation followed by cost-expensive validation (not executed if simple constraint fails) * we get just the "main and specific validation error" (otherwise we have to iterate over all errors "to find the cause" or we display two or more errors for one property which is not user-friendly according my opinion) 3) What is unusable: * groups and group sequences (it is not possible to create proper combination of groups and sequences for more than one property with two or more constraints) * composed constraints (@ReportAsSingleViolation included) ** we cannot use @ReportAsSingleViolation since we want specific message for each failed constraint ** and main problem is: if we use composed constraints all constraints are evaluated for given property 4) Proposed solution: * add optional order attribute to validator annotations and stop validation on first failure if order is specified * possibly this can be configured on global validator level with property "skipOnFirstFailure" together with some given convention for annotation order Please let me know if need better explanation or working examples. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 2 months

3
8
0 / 0

[Hibernate-JIRA] Created: (BVAL-255) Simplify GroupSequence for ordered checking

by Cemo Koc (JIRA)

Simplify GroupSequence for ordered checking ------------------------------------------- Key: BVAL-255 URL: http://opensource.atlassian.com/projects/hibernate/browse/BVAL-255 Project: Bean Validation Issue Type: New Feature Components: spec-general Affects Versions: 1.0 final Reporter: Cemo Koc The JSR 303 is becoming defacto solution at enterprise level projects however I think that it has a significant useless part. The current implementation states group sequence must be utilized to ordered validation. In order to use group sequence, one has to define interfaces for each order sequence such this: {code} public class AccountBean { @CheapValidation(groups=Name1.class) @ExpensiveValidation(groups=Name2.class) @VeryExpensiveValidation(groups=Name3.class) String name; @CheapValidation(groups=Surname1.class) @ExpensiveValidation(groups=Surname2.class) @VeryExpensiveValidation(groups=Surname3.class) String surname; public interface Name1 {} public interface Name2 {} public interface Name3 {} @GroupSequence({Name1.class, Name2.class, Name3.class}) public interface Name {} public interface Surname1 {} public interface Surname2 {} public interface Surname3 {} @GroupSequence({Surname1.class, Surname2.class, Surname3.class}) public interface Surname {} } {code} Look the code how it is ugly and useless. What I am offering is a simplified version of ordering such this: {code} public class AccountBean { @CheapValidation(order=0,groups=Name1.class) @ExpensiveValidation(order=1,groups=Name2.class) @VeryExpensiveValidation(order=2,groups=Name3.class) String name; @CheapValidation(order=0,groups=Surname1.class) @ExpensiveValidation(order=1,groups=Surname2.class) @VeryExpensiveValidation(order=2,groups=Surname3.class) String surname; } {code} Almost all enterprise projects needs such kind of things. For example lets say that you want to validate email field by NotEmpty and UniqueAtDatabase. Why should we show two error messages in this case? Shortly, to increase usability and adaptability please solve this issue. PS: This issue is cross posted here and forums. https://forum.hibernate.org/viewtopic.php?f=26&t=1007328 -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira

11 years, 2 months

2
1
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues December 2011