June 2011 - hibernate-issues - Jboss List Archives

[Hibernate-JIRA] Created: (HBX-1081) Generation of meta attributes for composite-id

by Anders Reinhardt Hansen (JIRA)

Generation of meta attributes for composite-id ---------------------------------------------- Key: HBX-1081 URL: http://opensource.atlassian.com/projects/hibernate/browse/HBX-1081 Project: Hibernate Tools Issue Type: Improvement Components: reverse-engineer Affects Versions: 3.2.beta11 Environment: All, not related to platform. Reporter: Anders Reinhardt Hansen Priority: Minor The ReverseEngineeringStrategy has a method; "public Map tableToMetaAttributes(TableIdentifier tableIdentifier)" This method returns a Map of meta tags which will be put inside the class node of the hbm files that are generated. It would be a nice addition if we could have a method like this which placed meta tags inside the composite id node. the method could be called "public Map tableToMetaAttributesForCompositeId(TableIdentifier tableIdentifier)" An example of the problem is shown in the below example; <class name="XXX1" table="XXX1"> <meta attribute="generated-class">XXX1Base</meta>  <composite-id name="XXX2" class="XXX2"> <meta attribute="generated-class">XXX2Base</meta>  <key-property name="propertyXXX" type="int"> <column name="ColoumnXXX" /> </key-property> <key-property name="YYY" type="int"> <column name="ColoumnYYY" /> </key-property> </composite-id> ... </class> The issue was discussed on the forum in topic http://forum.hibernate.org/viewtopic.php?t=989476 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 11 months

5
6
0 / 0

[Hibernate-JIRA] Created: (OGM-63) Remove unused code branches and unnecessary null checks

by Juraci Paixao Krohling (JIRA)

Remove unused code branches and unnecessary null checks ------------------------------------------------------- Key: OGM-63 URL: http://opensource.atlassian.com/projects/hibernate/browse/OGM-63 Project: Hibernate OGM Issue Type: Improvement Components: core Affects Versions: 3.0.0.Alpha1 Reporter: Juraci Paixao Krohling Assignee: Juraci Paixao Krohling Fix For: 3.0-next I ran the FindBugs code analysis tool and noticed that there are some unnecessary null checks and unused code branches in Hibernate OGM Core module, like the following example from OgmLoader: {code:title=OgmLoader.java} //we don't load more than one instance per row, shortcircuiting it for the moment final int[] collectionOwners = null; for ( int i=0; i<collectionPersisters.length; i++ ) { final CollectionAliases[] descriptors = getCollectionAliases(); final boolean hasCollectionOwners = collectionOwners !=null && collectionOwners[i] > -1; //true if this is a query and we are loading multiple instances of the same collection role //otherwise this is a CollectionInitializer and we are loading up a single collection or batch final Object owner = hasCollectionOwners ? row[ collectionOwners[i] ] : null; //if null, owner will be retrieved from session final CollectionPersister collectionPersister = collectionPersisters[i]; final Serializable key; if ( owner == null ) { key = null; } else { key = collectionPersister.getCollectionType().getKeyOfOwner( owner, session ); //TODO: old version did not require hashmap lookup: //keys[collectionOwner].getIdentifier() } readCollectionElement( owner, key, collectionPersister, descriptors[i], resultSet, //TODO CURRENT must use the same instance across all calls session ); {code} Note that {{collectionOwners}} is always {{null}}. Thus, {{hasCollectionOwners}} is always {{false}}, causing {{owner}} to always be {{null}}. Then, the {{if ( owner == null ) }} will always be evaluated as true, turning the else part to be unnecessary. The above code can be rewritten as: {code:title=OgmLoader.java} final CollectionAliases[] descriptors = getCollectionAliases(); // this line was inside the for loop... it seems it can be outside for ( int i=0; i<collectionPersisters.length; i++ ) { final CollectionPersister collectionPersister = collectionPersisters[i]; readCollectionElement( null, null, collectionPersister, descriptors[i], resultSet, //TODO CURRENT must use the same instance across all calls session ); } {code} This JIRA is to track similar issues to the example above. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 11 months

3
3
0 / 0

[Hibernate-JIRA] Created: (HSEARCH-740) TimeoutTest and ClasstypeFieldCacheExtractionTest

by Hardy Ferentschik (JIRA)

TimeoutTest and ClasstypeFieldCacheExtractionTest ------------------------------------------------- Key: HSEARCH-740 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-740 Project: Hibernate Search Issue Type: Bug Components: build, tests Affects Versions: 3.4.0.Final Reporter: Hardy Ferentschik Assignee: Hardy Ferentschik Fix For: 4.0 * _TimeoutTest_ uses query timeouts which are not available via the postgres jdbc driver (see also JBPAPP-2945) * _ClasstypeFieldCacheExtractionTest_ does not properly close a transaction -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 11 months

2
3
0 / 0

[Hibernate-JIRA] Created: (HSEARCH-780) Dirty analysis of @IndexedEmbedded on a superclass collection fails

by Samppa Saarela (JIRA)

Dirty analysis of @IndexedEmbedded on a superclass collection fails ------------------------------------------------------------------- Key: HSEARCH-780 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-780 Project: Hibernate Search Issue Type: Bug Affects Versions: 3.4.0.Final Reporter: Samppa Saarela AbstractDocumentBuilder.indexedEmbeddedCollectionRoles contains roles that are bound to given indexed class (e.g. ASubclass.commonCollection). In Hibernate collection roles are bound to the class they are defined in (e.g. ASuperclass.commonCollection). Given this mismatch the collection gets excluded from being indexed in FullTextIndexEventListener.processCollectionEvent > AbstractDocumentBuilder.isCollectionRoleExcluded. In the test case (in github pull request) this bug is reproduced using an abstract superclass, but I suspect it affects also other kind of indexed hierarchies. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 11 months

3
3
0 / 0

[Hibernate-JIRA] Created: (HSEARCH-772) Isolate JGroups tests to be able to run different test profiles in parallel

by Sanne Grinovero (JIRA)

Isolate JGroups tests to be able to run different test profiles in parallel --------------------------------------------------------------------------- Key: HSEARCH-772 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-772 Project: Hibernate Search Issue Type: Task Reporter: Sanne Grinovero When running the full testsuite on CI, each profile is executed in parallel in separate workspaces and using each it's own database. Still it seems that JGroups occasionally forms clusters among the different runnin testsuites, causing many failures. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 11 months

2
3
0 / 0

[Hibernate-JIRA] Created: (HSEARCH-739) Define an M2Eclipse configuration section in the parent pom.xml

by Sanne Grinovero (JIRA)

Define an M2Eclipse configuration section in the parent pom.xml --------------------------------------------------------------- Key: HSEARCH-739 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-739 Project: Hibernate Search Issue Type: Task Components: build Reporter: Sanne Grinovero Assignee: Sanne Grinovero Priority: Minor Fix For: 3.5 Recent versions of M2 require this configuration, or the project won't build out of the box. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 11 months

2
3
0 / 0

[Hibernate-JIRA] Created: (HSEARCH-771) ProgrammaticMappingTest should work when executed in any order

by Sanne Grinovero (JIRA)

ProgrammaticMappingTest should work when executed in any order -------------------------------------------------------------- Key: HSEARCH-771 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-771 Project: Hibernate Search Issue Type: Task Components: tests Reporter: Sanne Grinovero Assignee: Sanne Grinovero Priority: Trivial Fix For: 4.0.0.Alpha1 testNumeric is not cleaning up the data it stores, this affects other test methods; was hard to spot as it's not reproduced as testNumeric happens to be the last test executed from commandline or from any IDE, but it happens to be executed in a different order on CI. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 11 months

2
3
0 / 0

[Hibernate-JIRA] Created: (HSEARCH-769) dummy is a reserved keyword on sybase

by Sanne Grinovero (JIRA)

dummy is a reserved keyword on sybase ------------------------------------- Key: HSEARCH-769 URL: http://opensource.atlassian.com/projects/hibernate/browse/HSEARCH-769 Project: Hibernate Search Issue Type: Task Reporter: Sanne Grinovero Assignee: Sanne Grinovero Priority: Trivial Fix For: 4.0.0.Alpha1 As it's used as property name in some tests, these are failing when run on Sybase. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 11 months

1
2
0 / 0

[Hibernate-JIRA] Created: (OGM-69) Introduce a Tuple object instead of Map<String, Object> and the equivalent for the association info

by Emmanuel Bernard (JIRA)

Introduce a Tuple object instead of Map<String,Object> and the equivalent for the association info -------------------------------------------------------------------------------------------------- Key: OGM-69 URL: http://opensource.atlassian.com/projects/hibernate/browse/OGM-69 Project: Hibernate OGM Issue Type: Improvement Reporter: Emmanuel Bernard sanne other thing, you keep passing around "tuples", i.e. "Map<String, Object>" . wouldn't it be nice to make our object for that? I know we discussed it about the keys, but for objects we where unsure, depending on how it's looking in the end. but it looks like to make sense to me now.. emmanuel yes indeed, my train of thoughts is the following we will replace Cache with our own object (see Bucket discussion) and yes I think having a Tuple object would make sense as wll (same of the association info potentially Tuple and thw Association info one would record the list of changes applied (ie add / update / remove such and such column) And from this set of information the Dialect will be able to store the data accordingly 15:11 In ISPN via an AtomicMap for example I'm a little bit concerned about the overhead of creating and maintaining two sets of object in the end the Tuple and what ISPN or other dialect end up having but that might not be too problematic sannegrinovero: but I'd keep this enhancement for a different JIRA / pull-request -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 11 months

2
3
0 / 0

[Hibernate-JIRA] Created: (HHH-3305) hbm2ddl: MS SQL Server 2005 defaults to Clustered Index on PK, lets use PRIMARY KEY NONCLUSTERED for hbm2ddl as a more reasonable default

by Jim Doyle (JIRA)

hbm2ddl: MS SQL Server 2005 defaults to Clustered Index on PK, lets use PRIMARY KEY NONCLUSTERED for hbm2ddl as a more reasonable default ------------------------------------------------------------------------------------------------------------------------------------------- Key: HHH-3305 URL: http://opensource.atlassian.com/projects/hibernate/browse/HHH-3305 Project: Hibernate3 Issue Type: Bug Components: metamodel Affects Versions: 3.2.1 Reporter: Jim Doyle In SQL Server 2005, PRIMARY KEY defaults to creating a Clustered Index for the PK column at table creation time. To confirm this behaviour Please see: http://msdn.microsoft.com/en-us/library/ms188066.aspx This default behaviour is un-desireable for a number of reasons: 1. No other databases default to a clustered IDX at the PK ; Not DB2, nor Oracle nor MySQL 2. There may only be ONE clustered IDX per table. By using this as a default makes it difficult for the app developer or DBA to quickly add or change the once-per-table opportunity to use the cluster to improve query performance. 3. The default cluster index that Microsoft applies seems only to benefit naive SQL server users with little to no DBA skills. Table insert of new rows onto a Clustered Index PK is always very fast and while this optimization may be impressive if your problem space is rapidly inserting new data into large tables, this optimization is often an antipattern to users with more plausible query patterns such as scan by non-primary key date, numeric amounts or alphabetical data. 4. Defaulting the PK to clustered creates SUBSTANTIAL burden for a DBA when the Clustered Index needs to be removed from the PK to be deployed on other columns on the table. As an example of the burden that this creates, for EACH TABLE one must: - Discover all tables and columns that link back to the table in question through FOREIGN KEY - Drop all foreign keys - Drop the PK - Add the PK back, with NONCLUSTERED - Put back all the dropped Foreign keys 5. Additional arguments against supporting Microsoft's unusual default is given here: http://tonesdotnetblog.wordpress.com/2008/05/26/twelve-tips-for-optimisin... (Please See Section 2: Use Clustered Index). I propose ANY ONE of the following enhancements to the DDL generator for the SQL Server 2005 Dialect: 1. Change the generated SQL from colname coltype PRIMARY KEY TO colname coltype PRIMARY KEY NONCLUSTERED such that PK index generate conforms the the usual, sensible defaults of other database products. 2. Use a Properties attribute (i.e. hibernate.hbm2ddl.dialect.mssql.use_non_clustered_pk) that is evaluated at hbm2ddl runtime that will emit 'NONCLUSTERED' to the PK clause. If this Property is not defined, the hbm2ddl will simply emit PRIMARY KEY as it does now and MS SQL Server will use its peculiar and annoying default. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://opensource.atlassian.com/projects/hibernate/secure/Administrators.... - For more information on JIRA, see: http://www.atlassian.com/software/jira

12 years, 11 months

3
2
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues June 2011