February 2020 - hibernate-issues - Jboss List Archives

[JIRA] (HSEARCH-3824) Automatically filter search results based on provided routing keys

by Yoann Rodière (JIRA)

Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *updated* an issue Hibernate Search ( https://hibernate.atlassian.net/browse/HSEARCH?atlOrigin=eyJpIjoiNmU0Y2Iz... ) / Improvement ( https://hibernate.atlassian.net/browse/HSEARCH-3824?atlOrigin=eyJpIjoiNmU... ) HSEARCH-3824 ( https://hibernate.atlassian.net/browse/HSEARCH-3824?atlOrigin=eyJpIjoiNmU... ) Automatically filter search results based on provided routing keys ( https://hibernate.atlassian.net/browse/HSEARCH-3824?atlOrigin=eyJpIjoiNmU... ) Change By: Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Currently, when a routing key is specified in a search query, we take care of targeting only the shards that can actually contain documents with the given routing keys. However, since a shard may contain documents with different routing keys, it is possible that some matching documents found in these shards actually used a different routing key. The only reason we don't currently apply a filter automatically is performance: users defining routing keys are likely to already filter their results based on an indexed field with the same value as the routing key. However, I don't think it would be very expensive to also create an indexed meta-field holding the routing key, and to automatically add a filter on that field for all search queries that define routing keys explicitly. The field already exists in ES: {{ _routing }} ), and it's indexed. For Lucene, we would need to add it. Out of the top of my head, here are the changes we would need. They're actually quite reasonable: * For the Lucene backend, we'd need to index the routing key: currently it's just used for routing, not indexed. * For the Lucene and Elasticsearch backends, we'd need to automatically add a filter to the query when routing keys are specified. * - For the Lucene and Elasticsearch backends, we'd need to offer a way to retrieve the routing key of a particular search hit... maybe? Not sure you need this. - => No * - For the Lucene backend, we may want to introduce a new (default) sharding strategy where routing keys are enabled but only used as discriminators, not for actual sharding. * In mapper APIs - => Not necessary , we'll need to add a way to purge specific routing keys the default sharding strategy works just fine for that. (e.g. {{ SearchWorkspace.purge( "key1", "key2" ) }} ) ( https://hibernate.atlassian.net/browse/HSEARCH-3824#add-comment?atlOrigin... ) Add Comment ( https://hibernate.atlassian.net/browse/HSEARCH-3824#add-comment?atlOrigin... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100121- sha1:96a3924 )

4 years, 4 months

1
0
0 / 0

[JIRA] (HSEARCH-3834) Nested documents are never deleted

by Yoann Rodière (JIRA)

Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *updated* an issue Hibernate Search ( https://hibernate.atlassian.net/browse/HSEARCH?atlOrigin=eyJpIjoiMGJmMDNk... ) / Bug ( https://hibernate.atlassian.net/browse/HSEARCH-3834?atlOrigin=eyJpIjoiMGJ... ) HSEARCH-3834 ( https://hibernate.atlassian.net/browse/HSEARCH-3834?atlOrigin=eyJpIjoiMGJ... ) Nested documents are never deleted ( https://hibernate.atlassian.net/browse/HSEARCH-3834?atlOrigin=eyJpIjoiMGJ... ) Change By: Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Our current code in the Lucene backend deletes only the root document, but leaves nested documents in the index. That's because we use the " {{ __HSEARCH_id " }} field to designate nested documents to delete, but nested documents to not have that field. Instead, they have a " {{ __HSEARCH_root_id " }} field, and that field is not even indexed. Maybe we should use the same ID field for nested documents? I managed to check that locally using luke, but I believe we could design an automated test that creates a document with nested documents, deletes it, then recreates it without nested documents. The nested documents will magically still be matched when searching, which is an evidence there is a bug. We should also check updates, since they rely on the same principle. ( https://hibernate.atlassian.net/browse/HSEARCH-3834#add-comment?atlOrigin... ) Add Comment ( https://hibernate.atlassian.net/browse/HSEARCH-3834#add-comment?atlOrigin... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100121- sha1:b179e60 )

4 years, 4 months

1
0
0 / 0

[JIRA] (HSEARCH-3835) Remove the unused "__HSEARCH_root_index_name" and "__HSEARCH_root_id" fields from nested documents

by Yoann Rodière (JIRA)

4 years, 4 months

1
0
0 / 0

[JIRA] (HHH-13872) Make the Java Stream close the underlying ScrollableResultsIterator upon calling a terminal operation

by Vlad Mihalcea (JIRA)

Vlad Mihalcea ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiODUxMTI3YzMx... ) / Improvement ( https://hibernate.atlassian.net/browse/HHH-13872?atlOrigin=eyJpIjoiODUxMT... ) HHH-13872 ( https://hibernate.atlassian.net/browse/HHH-13872?atlOrigin=eyJpIjoiODUxMT... ) Make the Java Stream close the underlying ScrollableResultsIterator upon calling a terminal operation ( https://hibernate.atlassian.net/browse/HHH-13872?atlOrigin=eyJpIjoiODUxMT... ) Issue Type: Improvement Affects Versions: 5.4.12 Assignee: Vlad Mihalcea ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Components: hibernate-core Created: 20/Feb/2020 01:15 AM Fix Versions: 5.4.13 Priority: Major Reporter: Vlad Mihalcea ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) The JPA 2.2 Query#getResultStream returns a Stream wrapping a Hibernate ScrollableResultsIterator. However, even if a terminal Stream operation is called, the underlying ScrollableResultsIterator will stay open until the Session is closed. More, the current implementation does not pass the closeHandler to the IntStream , LongStream , or DoubleStream when calling mapToInt or other methods that return a primitive stream. We need to create a StreamDecorator , IntStreamDecorator , LongStreamDecorator , and DoubleStreamDecorator that can both delegate the stream calls and close the stream upon executing a terminal operation. ( https://hibernate.atlassian.net/browse/HHH-13872#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-13872#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100121- sha1:b179e60 )

4 years, 4 months

1
0
0 / 0

[JIRA] (HSEARCH-3835) Remove the unused "__HSEARCH_root_index_name" and "__HSEARCH_root_id" fields in nested documents

by Yoann Rodière (JIRA)

4 years, 4 months

1
0
0 / 0

[JIRA] (HSEARCH-3835) Remove the unused "__HSEARCH_root_index_name" and "__HSEARCH_root_id" fields in nested documents

by Yoann Rodière (JIRA)

Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate Search ( https://hibernate.atlassian.net/browse/HSEARCH?atlOrigin=eyJpIjoiZGVlY2Zm... ) / Improvement ( https://hibernate.atlassian.net/browse/HSEARCH-3835?atlOrigin=eyJpIjoiZGV... ) HSEARCH-3835 ( https://hibernate.atlassian.net/browse/HSEARCH-3835?atlOrigin=eyJpIjoiZGV... ) Remove the unused "__HSEARCH_root_index_name" and "__HSEARCH_root_id" fields in nested documents ( https://hibernate.atlassian.net/browse/HSEARCH-3835?atlOrigin=eyJpIjoiZGV... ) Issue Type: Improvement Assignee: Unassigned Components: backend-lucene Created: 20/Feb/2020 01:15 AM Fix Versions: 6.0.0.Beta-backlog-high-priority Priority: Major Reporter: Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) See org.hibernate.search.backend.lucene.document.impl.LuceneNestedObjectDocumentBuilder#contribute: the two fields are only used when indexing. Operations on nested documents, for example org.hibernate.search.backend.lucene.search.predicate.impl.LuceneNestedPredicateBuilder#doBuild , rely on the nested document path and ignore anything else: joins rely on the fact that the root document and nested documents are indexed in the same "block", so there's no need to Note we will still need to index the root ID somewhere as explained in HSEARCH-3834 ( https://hibernate.atlassian.net/browse/HSEARCH-3834 ) Open. ( https://hibernate.atlassian.net/browse/HSEARCH-3835#add-comment?atlOrigin... ) Add Comment ( https://hibernate.atlassian.net/browse/HSEARCH-3835#add-comment?atlOrigin... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100121- sha1:b179e60 )

4 years, 4 months

1
0
0 / 0

[JIRA] (HSEARCH-3834) Nested documents are never deleted

by Yoann Rodière (JIRA)

Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *updated* an issue Hibernate Search ( https://hibernate.atlassian.net/browse/HSEARCH?atlOrigin=eyJpIjoiMGVkNDgw... ) / Bug ( https://hibernate.atlassian.net/browse/HSEARCH-3834?atlOrigin=eyJpIjoiMGV... ) HSEARCH-3834 ( https://hibernate.atlassian.net/browse/HSEARCH-3834?atlOrigin=eyJpIjoiMGV... ) Nested documents are never deleted ( https://hibernate.atlassian.net/browse/HSEARCH-3834?atlOrigin=eyJpIjoiMGV... ) Change By: Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Our current code in the Lucene backend deletes only the root document, but leaves nested documents in the index. That's because we use the "__HSEARCH_id" field to designate nested documents to delete, but nested documents to not have that field. Instead, they have a "__HSEARCH_root_id" field, and that field is not even indexed. Maybe we should use the same ID field for nested documents? I managed to check that locally using luke, but I believe we could design an automated test that creates a document with nested documents, deletes it, then recreates it without nested documents. The nested documents will magically still be matched when searching, which is an evidence there is a bug. We should also check updates, since they rely on the same principle. ( https://hibernate.atlassian.net/browse/HSEARCH-3834#add-comment?atlOrigin... ) Add Comment ( https://hibernate.atlassian.net/browse/HSEARCH-3834#add-comment?atlOrigin... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100121- sha1:b179e60 )

4 years, 4 months

1
0
0 / 0

[JIRA] (HSEARCH-3834) Nested documents are never deleted

by Yoann Rodière (JIRA)

4 years, 4 months

1
0
0 / 0

[JIRA] (HSEARCH-3834) Nested documents are never deleted

by Yoann Rodière (JIRA)

4 years, 4 months

1
0
0 / 0

[JIRA] (HSEARCH-3834) Nested documents are never deleted

by Yoann Rodière (JIRA)

Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate Search ( https://hibernate.atlassian.net/browse/HSEARCH?atlOrigin=eyJpIjoiMWFmMzE4... ) / Bug ( https://hibernate.atlassian.net/browse/HSEARCH-3834?atlOrigin=eyJpIjoiMWF... ) HSEARCH-3834 ( https://hibernate.atlassian.net/browse/HSEARCH-3834?atlOrigin=eyJpIjoiMWF... ) Nested documents are never deleted ( https://hibernate.atlassian.net/browse/HSEARCH-3834?atlOrigin=eyJpIjoiMWF... ) Issue Type: Bug Assignee: Unassigned Components: backend-lucene Created: 20/Feb/2020 01:04 AM Fix Versions: 6.0.0.Beta-backlog-high-priority Priority: Major Reporter: Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Our current code in the Lucene backend deletes only the root document, but leaves nested documents in the index. That's because we use the "_ HSEARCH_id" field to designate nested documents to delete, but nested documents to not have that field. Instead, they have a " _HSEARCH_root_id" field, and that field is not even indexed. Maybe we should use the same ID field for nested documents? I managed to check that locally using luke, but I believe we could design an automated test that creates a document with nested documents, deletes it, then recreates it without nested documents. The nested documents will magically still be matched when searching, which is an evidence there is a bug. ( https://hibernate.atlassian.net/browse/HSEARCH-3834#add-comment?atlOrigin... ) Add Comment ( https://hibernate.atlassian.net/browse/HSEARCH-3834#add-comment?atlOrigin... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100121- sha1:b179e60 )

4 years, 4 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues February 2020