March 2020 - hibernate-issues - Jboss List Archives

[JIRA] (HV-1761) Not Work!! When i use custom validation，ALL version!!!

by deng A (JIRA)

deng A ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=5e6cb37... ) *created* an issue Hibernate Validator ( https://hibernate.atlassian.net/browse/HV?atlOrigin=eyJpIjoiYWFlYzBjYzJjN... ) / Bug ( https://hibernate.atlassian.net/browse/HV-1761?atlOrigin=eyJpIjoiYWFlYzBj... ) HV-1761 ( https://hibernate.atlassian.net/browse/HV-1761?atlOrigin=eyJpIjoiYWFlYzBj... ) Not Work!! When i use custom validation，ALL version!!! ( https://hibernate.atlassian.net/browse/HV-1761?atlOrigin=eyJpIjoiYWFlYzBj... ) Issue Type: Bug Affects Versions: 6.0.18.Final, 6.1.2.Final Assignee: Unassigned Attachments: 微信图片_20200314190706.png Components: engine Created: 14/Mar/2020 04:09 AM Environment: spring-boot-2.2.5 jdk11 spring-boot-starter-validation Labels: validation Priority: Blocker Reporter: deng A ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=5e6cb37... ) Original Estimate: 32h Remaining Estimate: 32h i learn springboot validation with hibernate-validator recently. i write some custom validator however it not work when i custom message i want to valid a enum flag /* * Copyright (c) 2020. ascend 版权所有禁止转载。 */ package cn.edu.zua.springbootdemo2.util.core.validation; import cn.edu.zua.springbootdemo2.util.core.validation.bound.IntEnumValidatorForInteger; import javax.validation.Constraint; import javax.validation.Payload; import java.lang.annotation.*; import static java.lang.annotation.ElementType.*; import static java.lang.annotation.RetentionPolicy.RUNTIME; /** * 说明：The annotated element must be a number of values . * * @author adeng 2020/3/14 10:12 */ @Documented @Constraint(validatedBy = {IntEnumValidatorForInteger.class}) @Target({METHOD, FIELD, ANNOTATION_TYPE, CONSTRUCTOR, PARAMETER, TYPE_USE}) @Retention(RetentionPolicy.RUNTIME) @Repeatable(IntEnum.List.class) public @ interface IntEnum { /** * 合法值 */ int [] value() default {}; String message() default "{javax.validation.constraints.IntEnum.message}" ; Class <?>[] groups() default {}; Class <? extends Payload>[] payload() default {}; /** * Defines several {@code @Email} constraints on the same element. * * @see IntEnum */ @Target({METHOD, FIELD, ANNOTATION_TYPE, CONSTRUCTOR, PARAMETER, TYPE_USE}) @Retention(RUNTIME) @Documented @ interface List { IntEnum[] value(); } } /* * Copyright (c) 2020. ascend 版权所有禁止转载。 */ package cn.edu.zua.springbootdemo2.util.core.validation.bound; import cn.edu.zua.springbootdemo2.util.core.validation.IntEnum; import javax.validation.ConstraintValidator; import javax.validation.ConstraintValidatorContext; /** * 说明： * 验证提供的值是否合法 * * @author adeng 2020/3/14 15:21 */ public class IntEnumValidatorForInteger implements ConstraintValidator<IntEnum, Integer > { /** * 合法值 */ private int [] values; /** * Initializes the validator in preparation for * {@link #isValid( Integer , ConstraintValidatorContext)} calls. * The constraint annotation for a given constraint declaration * is passed. * <p> * This method is guaranteed to be called before any use of this instance for * validation. * <p> * The default implementation is a no-op. * * @param intEnum annotation instance for a given constraint declaration */ @Override public void initialize(IntEnum intEnum) { this.values = intEnum.value(); } /** * Implements the validation logic. * The state of {@code value} must not be altered. * <p> * This method can be accessed concurrently, thread-safety must be ensured * by the implementation. * * @param value object to validate * @param context context in which the constraint is evaluated * @ return {@code false } if {@code value} does not pass the constraint */ @Override public boolean isValid( Integer value, ConstraintValidatorContext context) { for ( int item : values) { if (value == item) { return true ; } } return false ; } } *controller* /** * 自定义int枚举校验 * * @param input 输入 * @ return 输出 */ @GetMapping(value = "/get/custom/integer" ) public CommonResult< Integer > getCustomInteger(@IntEnum(value = {0, 1}) Integer input) { CommonResult< Integer > retResult = new CommonResult<>(); retResult.fillResult(CommonCode.SUCCESS(), input); return retResult; } messages.properties javax.validation.constraints.IntEnum.message=value not valid（valid values have {value}） error!!! Caused by: java.lang.ClassCastException: class [I cannot be cast to class [Ljava.lang. Object ; ([I and [Ljava.lang. Object ; are in module java.base of loader 'bootstrap' ) at org.hibernate.validator.internal.engine.messageinterpolation.ParameterTermResolver.interpolate(ParameterTermResolver.java:30) at org.hibernate.validator.internal.engine.messageinterpolation.InterpolationTerm.interpolate(InterpolationTerm.java:64) at org.hibernate.validator.messageinterpolation.ResourceBundleMessageInterpolator.interpolate(ResourceBundleMessageInterpolator.java:159) at org.hibernate.validator.messageinterpolation.AbstractMessageInterpolator.interpolateExpression(AbstractMessageInterpolator.java:519) at org.hibernate.validator.messageinterpolation.AbstractMessageInterpolator.interpolateMessage(AbstractMessageInterpolator.java:408) at org.hibernate.validator.messageinterpolation.AbstractMessageInterpolator.interpolate(AbstractMessageInterpolator.java:355) at org.springframework.validation.beanvalidation.LocaleContextMessageInterpolator.interpolate(LocaleContextMessageInterpolator.java:51) at org.hibernate.validator.internal.engine.validationcontext.AbstractValidationContext.interpolate(AbstractValidationContext.java:313) ... 75 common frames omitted ( https://hibernate.atlassian.net/browse/HV-1761#add-comment?atlOrigin=eyJp... ) Add Comment ( https://hibernate.atlassian.net/browse/HV-1761#add-comment?atlOrigin=eyJp... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100121- sha1:a2b3dcc )

4 years, 3 months

1
0
0 / 0

[JIRA] (HHH-13882) NullPointerException when using JPA @Lock + @EntityGraph + @ElementCollection

by Nathan Xu (JIRA)

Nathan Xu ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-13882 ( https://hibernate.atlassian.net/browse/HHH-13882?atlOrigin=eyJpIjoiNzI0OT... ) Re: NullPointerException when using JPA @Lock + @EntityGraph + @ElementCollection ( https://hibernate.atlassian.net/browse/HHH-13882?atlOrigin=eyJpIjoiNzI0OT... ) I investigated a little bit. It seems the root cause is some internal bug that collection from element is registered with class alias ending up with overriding existing entity from element. I’ll create a PR quickly. The bugfix will only be applied to v5.x for v6 has gone through dramatic redesign in the relevant code part. ( https://hibernate.atlassian.net/browse/HHH-13882#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-13882#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100121- sha1:a2b3dcc )

4 years, 3 months

1
0
0 / 0

[JIRA] (HSEARCH-3752) Implicit nested predicates

by Waldemar Kłaczyński (JIRA)

Waldemar Kłaczyński ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HSEARCH-3752 ( https://hibernate.atlassian.net/browse/HSEARCH-3752?atlOrigin=eyJpIjoiMWZ... ) Re: Implicit nested predicates ( https://hibernate.atlassian.net/browse/HSEARCH-3752?atlOrigin=eyJpIjoiMWZ... ) Filtering queries cannot have BlockJoinQuery. It would be great if they were wrapped up in a class like Elasticsearch. In elastic search is ESToParentBlockJoinQuery. You can always delete and extract the original query, but not to remove other nested query elements. You can even rebuild the wrap, automatically adding or removing nesting elements. Depending on the need. public abstract class AbstractLuceneSearchPredicateBuilder implements SearchPredicateBuilder<LuceneSearchPredicateBuilder>, LuceneSearchPredicateBuilder { ...... @Override public final Query build(LuceneSearchPredicateContext context) { ..... query = Queries.recompileToMaster(query, indexScope); ..... The function compiles the query in one place, it would also work for LuceneSearchPredicateFactory.fromLuceneQuery. Recompiles so deeply until it encounters ESToParentBlockJoinQuery. In order not to repeat actions from previous predicates. query = Queries.recompileToPatrial(query, nestedDocumentPath, indexScope); Recompilation only removes ESToParentBlockJoinQuery and ToParentBlockJoinQuery associated with the path. ( https://hibernate.atlassian.net/browse/HSEARCH-3752#add-comment?atlOrigin... ) Add Comment ( https://hibernate.atlassian.net/browse/HSEARCH-3752#add-comment?atlOrigin... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100121- sha1:a2b3dcc )

4 years, 3 months

1
0
0 / 0

[JIRA] (HSEARCH-3325) Search 6 groundwork - Restore support for full-text filters

by Yoann Rodière (JIRA)

Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HSEARCH-3325 ( https://hibernate.atlassian.net/browse/HSEARCH-3325?atlOrigin=eyJpIjoiMzd... ) Re: Search 6 groundwork - Restore support for full-text filters ( https://hibernate.atlassian.net/browse/HSEARCH-3325?atlOrigin=eyJpIjoiMzd... ) > > > > This is a completely different problem, not related to filter definitions > > I gave you a snippet of code that does exactly the same thing as the example you gave, without needing to change Hibernate Search at all. If it's not doing the same thing as your example, please explain why. If it's doing the same thing as your example, but you're thinking of other use cases, please give one of them. > > > > HSEARCH-3752 ( https://hibernate.atlassian.net/browse/HSEARCH-3752 ) Pull > Request Sent Pull Request Sent problem. I can quickly insert a patch there. > If you don't have time to solve it, I can deal with this problem. > > Please don't do anything related to HSEARCH-3752 ( https://hibernate.atlassian.net/browse/HSEARCH-3752 ) Pull Request Sent. HSEARCH-3752 ( https://hibernate.atlassian.net/browse/HSEARCH-3752 ) Pull Request Sent already has a pull request, we're currently reviewing it. ( https://hibernate.atlassian.net/browse/HSEARCH-3325#add-comment?atlOrigin... ) Add Comment ( https://hibernate.atlassian.net/browse/HSEARCH-3325#add-comment?atlOrigin... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100121- sha1:a2b3dcc )

4 years, 3 months

1
0
0 / 0

[JIRA] (HSEARCH-3752) Implicit nested predicates

by Yoann Rodière (JIRA)

Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HSEARCH-3752 ( https://hibernate.atlassian.net/browse/HSEARCH-3752?atlOrigin=eyJpIjoiMjE... ) Re: Implicit nested predicates ( https://hibernate.atlassian.net/browse/HSEARCH-3752?atlOrigin=eyJpIjoiMjE... ) Yes, but explicit filters passed to sorts and aggregations are another problem. Since we now in which context these filters must be executed, we should be able to not apply the "join query" in this case. ( https://hibernate.atlassian.net/browse/HSEARCH-3752#add-comment?atlOrigin... ) Add Comment ( https://hibernate.atlassian.net/browse/HSEARCH-3752#add-comment?atlOrigin... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100121- sha1:a2b3dcc )

4 years, 3 months

1
0
0 / 0

[JIRA] (HSEARCH-3325) Search 6 groundwork - Restore support for full-text filters

by Waldemar Kłaczyński (JIRA)

Waldemar Kłaczyński ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HSEARCH-3325 ( https://hibernate.atlassian.net/browse/HSEARCH-3325?atlOrigin=eyJpIjoiM2I... ) Re: Search 6 groundwork - Restore support for full-text filters ( https://hibernate.atlassian.net/browse/HSEARCH-3325?atlOrigin=eyJpIjoiM2I... ) HSEARCH-3752 ( https://hibernate.atlassian.net/browse/HSEARCH-3752 ) Pull Request Sent problem. I can quickly insert a patch there. If you don't have time to solve it, I can deal with this problem. The more that I have to do the reverse to get a general filter for sorting multiple values. I know the solution that elesticsearch managed in an identical case, including matching multiple values. ( https://hibernate.atlassian.net/browse/HSEARCH-3325#add-comment?atlOrigin... ) Add Comment ( https://hibernate.atlassian.net/browse/HSEARCH-3325#add-comment?atlOrigin... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100121- sha1:a2b3dcc )

4 years, 3 months

1
0
0 / 0

[JIRA] (HSEARCH-3752) Implicit nested predicates

by Waldemar Kłaczyński (JIRA)

Waldemar Kłaczyński ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HSEARCH-3752 ( https://hibernate.atlassian.net/browse/HSEARCH-3752?atlOrigin=eyJpIjoiNTQ... ) Re: Implicit nested predicates ( https://hibernate.atlassian.net/browse/HSEARCH-3752?atlOrigin=eyJpIjoiNTQ... ) Elasticsearch wraps the query thus detected in the ESToParentBlockJoinQuery object. A nested query is not always recommended. Because for sorting and agrgregation you need to recover the original form of the query. ( https://hibernate.atlassian.net/browse/HSEARCH-3752#add-comment?atlOrigin... ) Add Comment ( https://hibernate.atlassian.net/browse/HSEARCH-3752#add-comment?atlOrigin... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100121- sha1:a2b3dcc )

4 years, 3 months

1
0
0 / 0

[JIRA] (HSEARCH-3325) Search 6 groundwork - Restore support for full-text filters

by Waldemar Kłaczyński (JIRA)

Waldemar Kłaczyński ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HSEARCH-3325 ( https://hibernate.atlassian.net/browse/HSEARCH-3325?atlOrigin=eyJpIjoiZmI... ) Re: Search 6 groundwork - Restore support for full-text filters ( https://hibernate.atlassian.net/browse/HSEARCH-3325?atlOrigin=eyJpIjoiZmI... ) I know HSEARCH-3752 ( https://hibernate.atlassian.net/browse/HSEARCH-3752 ) Pull Request Sent. This is a completely different problem, not related to filter definitions. Just by way of example, I can give some information to the filter context. In the current implementation of full-text filters, I allowed access to filters in nested documents. Thanks to the information collected in the context of the filter factory, you can dynamically influence the method of generating such a filter. ( https://hibernate.atlassian.net/browse/HSEARCH-3325#add-comment?atlOrigin... ) Add Comment ( https://hibernate.atlassian.net/browse/HSEARCH-3325#add-comment?atlOrigin... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100121- sha1:a2b3dcc )

4 years, 3 months

1
0
0 / 0

[JIRA] (HSEARCH-3864) java.lang.Error thrown during mass indexing are swallowed and not reported to the user

by Yoann Rodière (JIRA)

Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate Search ( https://hibernate.atlassian.net/browse/HSEARCH?atlOrigin=eyJpIjoiM2E3NzQ1... ) / Bug ( https://hibernate.atlassian.net/browse/HSEARCH-3864?atlOrigin=eyJpIjoiM2E... ) HSEARCH-3864 ( https://hibernate.atlassian.net/browse/HSEARCH-3864?atlOrigin=eyJpIjoiM2E... ) java.lang.Error thrown during mass indexing are swallowed and not reported to the user ( https://hibernate.atlassian.net/browse/HSEARCH-3864?atlOrigin=eyJpIjoiM2E... ) Issue Type: Bug Assignee: Unassigned Components: mapper-orm Created: 13/Mar/2020 00:20 AM Fix Versions: 6.0.0.Beta-backlog-low-priority Priority: Major Reporter: Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) See https://discourse.hibernate.org/t/massindexer-not-working-on-latest-snaps... In org.hibernate.search.mapper.orm.massindexing.impl.FailureHandledRunnable#run in particular, we only catch and report RuntimeException , but we completely ignore Error. We should report the error *some* way. ( https://hibernate.atlassian.net/browse/HSEARCH-3864#add-comment?atlOrigin... ) Add Comment ( https://hibernate.atlassian.net/browse/HSEARCH-3864#add-comment?atlOrigin... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100121- sha1:a2b3dcc )

4 years, 3 months

1
0
0 / 0

[JIRA] (HSEARCH-3325) Search 6 groundwork - Restore support for full-text filters

by Yoann Rodière (JIRA)

Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HSEARCH-3325 ( https://hibernate.atlassian.net/browse/HSEARCH-3325?atlOrigin=eyJpIjoiM2I... ) Re: Search 6 groundwork - Restore support for full-text filters ( https://hibernate.atlassian.net/browse/HSEARCH-3325?atlOrigin=eyJpIjoiM2I... ) We're already working on making nested predicates optional in HSEARCH-3752 ( https://hibernate.atlassian.net/browse/HSEARCH-3752 ) Pull Request Sent , so the part you added about getting the nested path won't be useful in the next version of Hibernate Search. In the light of this, what exactly do full-text filters bring compared to this solution, which is simpler and type-safe? public static class TestFilterFactory { public SearchPredicate filter(SearchPredicateFactory f, String match) { return f.match().field( fieldPath ) .matching( match ) .toPredicate(); } } () -> scope.query() .where( f -> f.bool() .minimumShouldMatchNumber( 3 ) .should( TestFilterFactory.filter( "match_fieldName" , "blablabla" ) ) .should( TestFilterFactory.filter( "nested.match_fieldName" , "blablabla" ) ); } ).toQuery() ( https://hibernate.atlassian.net/browse/HSEARCH-3325#add-comment?atlOrigin... ) Add Comment ( https://hibernate.atlassian.net/browse/HSEARCH-3325#add-comment?atlOrigin... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100121- sha1:a2b3dcc )

4 years, 3 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues March 2020