[JIRA] (HSEARCH-1807) Provide SPIs required by ISPN query
by Yoann Rodière (JIRA)
Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *updated* an issue
Hibernate Search ( https://hibernate.atlassian.net/browse/HSEARCH?atlOrigin=eyJpIjoiYzgwYzYw... ) / Task ( https://hibernate.atlassian.net/browse/HSEARCH-1807?atlOrigin=eyJpIjoiYzg... ) HSEARCH-1807 ( https://hibernate.atlassian.net/browse/HSEARCH-1807?atlOrigin=eyJpIjoiYzg... ) Provide SPIs required by ISPN query ( https://hibernate.atlassian.net/browse/HSEARCH-1807?atlOrigin=eyJpIjoiYzg... )
Change By: Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Sprint: HSEARCH - 2019-18, HSEARCH - 2019-19, HSEARCH - 2019-20, HSEARCH - 2019-21, HSEARCH - 2019-22, HSEARCH - 2019-23, HSEARCH - 2019-24, HSEARCH - 2020-01, HSEARCH - 2020-02, HSEARCH - 2020-03, HSEARCH - 2020-04, HSEARCH - 2020-05, HSEARCH - 2020-06, HSEARCH - 2020-07, HSEARCH - 2020-08 , HSEARCH - 2020-09
( https://hibernate.atlassian.net/browse/HSEARCH-1807#add-comment?atlOrigin... ) Add Comment ( https://hibernate.atlassian.net/browse/HSEARCH-1807#add-comment?atlOrigin... )
Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100126- sha1:82783e0 )
5 years, 10 months
[JIRA] (HSEARCH-3922) Remove "get"/"set" prefixes from API methods
by Yoann Rodière (JIRA)
Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue
Hibernate Search ( https://hibernate.atlassian.net/browse/HSEARCH?atlOrigin=eyJpIjoiZjEzODA4... ) / Task ( https://hibernate.atlassian.net/browse/HSEARCH-3922?atlOrigin=eyJpIjoiZjE... ) HSEARCH-3922 ( https://hibernate.atlassian.net/browse/HSEARCH-3922?atlOrigin=eyJpIjoiZjE... ) Remove "get"/"set" prefixes from API methods ( https://hibernate.atlassian.net/browse/HSEARCH-3922?atlOrigin=eyJpIjoiZjE... )
Issue Type: Task Assignee: Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Components: backend-elasticsearch, backend-lucene, engine, mapper-javabean, mapper-orm, mapper-pojo Created: 18/May/2020 00:07 AM Fix Versions: 6.0.0.Beta-backlog-high-priority Priority: Major Reporter: Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... )
We sometimes use a "get"/"set" prefix ( SearchResult.getHits() , PropertyBindingContext.setBridge(...) , ...), but most of the time we don't ( Search.session(...) , IndexManager.descriptor() , various DSLs that don't use "set", ...).
I think we should be consistent and not use the prefixes anywhere, for the sake of consistency and brevity. JavaBeans or JPA entity conventions don't apply here, as we're not talking about JavaBeans nor JPA entities.
Old methods with the prefixes should be kept as deprecated for now, of course. There shouldn't be many of them.
( https://hibernate.atlassian.net/browse/HSEARCH-3922#add-comment?atlOrigin... ) Add Comment ( https://hibernate.atlassian.net/browse/HSEARCH-3922#add-comment?atlOrigin... )
Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100126- sha1:82783e0 )
5 years, 10 months