June 2020 - hibernate-issues - Jboss List Archives

[JIRA] (HHH-14043) Two concurrent element shifts in a list damage database integrity.

by Björn Zurmaar (JIRA)

Björn Zurmaar ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=5ecd86c... ) *commented* on HHH-14043 ( https://hibernate.atlassian.net/browse/HHH-14043?atlOrigin=eyJpIjoiY2ExYz... ) Re: Two concurrent element shifts in a list damage database integrity. ( https://hibernate.atlassian.net/browse/HHH-14043?atlOrigin=eyJpIjoiY2ExYz... ) Thanks for the feedback and your help. ( https://hibernate.atlassian.net/browse/HHH-14043#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-14043#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100130- sha1:5f5b10c )

5 years, 9 months

1
0
0 / 0

[JIRA] (HHH-14078) Hibernate returns duplicates into @OneToMany collection after merge

by Viktar Ramashko (JIRA)

Viktar Ramashko ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=5d66387... ) *updated* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiMzY4YmFmNTEz... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-14078?atlOrigin=eyJpIjoiMzY4Ym... ) HHH-14078 ( https://hibernate.atlassian.net/browse/HHH-14078?atlOrigin=eyJpIjoiMzY4Ym... ) Hibernate returns duplicates into @OneToMany collection after merge ( https://hibernate.atlassian.net/browse/HHH-14078?atlOrigin=eyJpIjoiMzY4Ym... ) Change By: Viktar Ramashko ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=5d66387... ) Consider following entities (getters and setters are omitted for brevity): {code:java}@Entity public class Parent { @Id @GeneratedValue private int id; @OneToMany(mappedBy = "parent", orphanRemoval = true, cascade = CascadeType.ALL) @BatchSize(size = 20) private List<Child> children = new ArrayList<Child>(); public void addChild(Child child) { child.setParent(this); this.children.add(child); } } @Entity public class Child { @Id @GeneratedValue private int id; @ManyToOne(optional = false, fetch = FetchType.LAZY) @JoinColumn(name = "parent_id", referencedColumnName = "id", nullable = false, updatable = false) private Parent parent; }{code} We have already saved the parent in the database and want to add a child to it. We use Spring Data JPA and test is written with it. {code:java}Parent existingParent = parentRepository.findById(PARENT_ID).get(); Child newChild= new Child (); existingParent .addChild(newChild); Parent savedParent = parentRepository.save(existingParent);{code} After that hibernate perform Merge operation on Parent entity and Cascade merge on Child collection. We expect that _savedParent_ will have one element in children collection, but it contains two the same elements. In database created only one. This example works fine. {code:java}Parent existingParent = parentRepository.findById(PARENT_ID).get(); Child newChild= new Child (); existingParent.getChildren().size(); existingParent .addChild(newChild); Parent savedParent = parentRepository.save(existingParent);{code} After debugging I found out, that in Class DefaultMergeEventListener {code:java}protected void entityIsPersistent(MergeEvent event, Map copyCache) { LOG.trace( "Ignoring persistent instance" ); //TODO: check that entry.getIdentifier().equals(requestedId) final Object entity = event.getEntity(); final EventSource source = event.getSession(); final EntityPersister persister = source.getEntityPersister( event.getEntityName(), entity ); ( (MergeContext) copyCache ).put( entity, entity, true ); //before cascade! cascadeOnMerge( source, persister, entity, copyCache ); // here we have two elements in collection, one Child that has been persisted in database, and the same Child object, before it persisted in database. copyValues( persister, entity, entity, source, copyCache ); // here we have two the same Child object that have been persisted in database event.setResult( entity ); }{code} Verified this bug with the latest Hibernate-core. ( https://hibernate.atlassian.net/browse/HHH-14078#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-14078#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100130- sha1:5f5b10c )

5 years, 9 months

1
0
0 / 0

[JIRA] (HHH-14078) Hibernate returns duplicates into @OneToMany collection after merge

by Viktar Ramashko (JIRA)

5 years, 9 months

1
0
0 / 0

[JIRA] (HHH-14078) Hibernate returns duplicates into @OneToMany collection after merge

by Viktar Ramashko (JIRA)

5 years, 9 months

1
0
0 / 0

[JIRA] (HHH-14078) Hibernate returns duplicates into @OneToMany collection after merge

by Viktar Ramashko (JIRA)

5 years, 9 months

1
0
0 / 0

[JIRA] (HHH-14078) Hibernate returns duplicates into @OneToMany collection after merge

by Viktar Ramashko (JIRA)

Viktar Ramashko ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=5d66387... ) *updated* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiNzQ1YjUxMzVk... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-14078?atlOrigin=eyJpIjoiNzQ1Yj... ) HHH-14078 ( https://hibernate.atlassian.net/browse/HHH-14078?atlOrigin=eyJpIjoiNzQ1Yj... ) Hibernate returns duplicates into @OneToMany collection after merge ( https://hibernate.atlassian.net/browse/HHH-14078?atlOrigin=eyJpIjoiNzQ1Yj... ) Change By: Viktar Ramashko ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=5d66387... ) Consider following entities (getters and setters are omitted for brevity): {code:java} @Entity public class Parent { @Id @GeneratedValue private int id; @OneToMany(mappedBy = "parent", orphanRemoval = true, cascade = CascadeType.ALL) @BatchSize(size = 20) private List<Child> children = new ArrayList<Child>(); public void addChild(Child child) { child.setParent(this); this.children.add(child); } } @Entity public class Child { @Id @GeneratedValue private int id; @ManyToOne(optional = false, fetch = FetchType.LAZY) @JoinColumn(name = "parent_id", referencedColumnName = "id", nullable = false, updatable = false) private Parent parent; } {code} We have already saved the parent in the database and want to add a child to it. We use Spring Data JPA and test is written with it. {code:java} Parent existingParent = parentRepository.findById(PARENT_ID).get(); Child newChild= new Child (); existingParent .addChild(newChild); //when Parent savedParent = parentRepository.save(existingParent); {code} After that hibernate perform Merge operation on Parent entity and Cascade merge on Child collection. We expect that _savedParent_ will have one element in children collection, but it contains two the same elements. In database created only one. This example works fine. {code:java} Parent existingParent = parentRepository.findById(PARENT_ID).get(); Child newChild= new Child (); existingParent.getChildren().size(); existingParent .addChild(newChild); //when Parent savedParent = parentRepository.save(existingParent); {code} After debugging I found out, that in Class DefaultMergeEventListener {code:java} protected void entityIsPersistent(MergeEvent event, Map copyCache) { LOG.trace( "Ignoring persistent instance" ); //TODO: check that entry.getIdentifier().equals(requestedId) final Object entity = event.getEntity(); final EventSource source = event.getSession(); final EntityPersister persister = source.getEntityPersister( event.getEntityName(), entity ); ( (MergeContext) copyCache ).put( entity, entity, true ); //before cascade! cascadeOnMerge( source, persister, entity, copyCache ); // here we have two elements in collection, one Child that has been persisted in database, and the same Child object, before it persisted in database. copyValues( persister, entity, entity, source, copyCache ); // here we have two the same Child object that have been persisted in database event.setResult( entity ); } {code} ( https://hibernate.atlassian.net/browse/HHH-14078#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-14078#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100130- sha1:5f5b10c )

5 years, 9 months

1
0
0 / 0

[JIRA] (HHH-14078) Hibernate returns duplicates into @OneToMany collection after merge

by Viktar Ramashko (JIRA)

Viktar Ramashko ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=5d66387... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiM2M0ZmI2ZDNh... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-14078?atlOrigin=eyJpIjoiM2M0Zm... ) HHH-14078 ( https://hibernate.atlassian.net/browse/HHH-14078?atlOrigin=eyJpIjoiM2M0Zm... ) Hibernate returns duplicates into @OneToMany collection after merge ( https://hibernate.atlassian.net/browse/HHH-14078?atlOrigin=eyJpIjoiM2M0Zm... ) Issue Type: Bug Affects Versions: 5.4.9, 5.4.17 Assignee: Unassigned Created: 19/Jun/2020 01:28 AM Labels: bag collection duplicates one-to-many proxy Priority: Major Reporter: Viktar Ramashko ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=5d66387... ) Consider following entities (getters and setters are omitted for brevity): @Entity public class Parent { @Id @GeneratedValue private int id; @OneToMany(mappedBy = "parent" , orphanRemoval = true , cascade = CascadeType.ALL) @BatchSize(size = 20) private List<Child> children = new ArrayList<Child>(); public void addChild(Child child) { child.setParent( this ); this.children.add(child); } } @Entity public class Child { @Id @GeneratedValue private int id; @ManyToOne(optional = false , fetch = FetchType.LAZY) @JoinColumn(name = "parent_id" , referencedColumnName = "id" , nullable = false , updatable = false ) private Parent parent; } We have already saved the parent in the database and want to add a child to it. We use Spring Data JPA and test is written with it. Parent existingParent = parentRepository.findById(PARENT_ID).get(); Child newChild= new Child (); existingParent .addChild(newChild); //when Parent savedParent = parentRepository.save(existingParent); After that hibernate perform Merge operation on Parent entity and Cascade merge on Child collection. We expect that savedParent will have one element in children collection, but it contains two the same elements. In database created only one. This example works fine. Parent existingParent = parentRepository.findById(PARENT_ID).get(); Child newChild= new Child (); existingParent.getChildren().size(); existingParent .addChild(newChild); //when Parent savedParent = parentRepository.save(existingParent); After debugging I found out, that in Class DefaultMergeEventListener protected void entityIsPersistent(MergeEvent event, Map copyCache) { LOG.trace( "Ignoring persistent instance" ); //TODO: check that entry.getIdentifier().equals(requestedId) final Object entity = event.getEntity(); final EventSource source = event.getSession(); final EntityPersister persister = source.getEntityPersister( event.getEntityName(), entity ); ( (MergeContext) copyCache ).put( entity, entity, true ); //before cascade! cascadeOnMerge( source, persister, entity, copyCache ); // here we have two elements in collection, one Child that has been persisted in database, and the same Child object, before it persisted in database. copyValues( persister, entity, entity, source, copyCache ); // here we have two the same Child object that have been persisted in database event.setResult( entity ); } ( https://hibernate.atlassian.net/browse/HHH-14078#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-14078#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100130- sha1:5f5b10c )

5 years, 9 months

1
0
0 / 0

[JIRA] (HHH-14043) Two concurrent element shifts in a list damage database integrity.

by Christian Beikov (JIRA)

5 years, 9 months

1
0
0 / 0

[JIRA] (HHH-14043) Two concurrent element shifts in a list damage database integrity.

by Christian Beikov (JIRA)

Christian Beikov ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-14043 ( https://hibernate.atlassian.net/browse/HHH-14043?atlOrigin=eyJpIjoiOTgxYW... ) Re: Two concurrent element shifts in a list damage database integrity. ( https://hibernate.atlassian.net/browse/HHH-14043?atlOrigin=eyJpIjoiOTgxYW... ) You are asking very basic JPA questions and I don’t think this is the right place to ask these question. I don’t want to be rude but maybe you should buy a book about JPA/Hibernate and read about the core concepts to understand this better. In general, optimistic locking requires a version field, that’s just how optimistic locking works. You could also use pessimistic locking which uses a database lock, but that only holds for the transaction lifetime. ( https://hibernate.atlassian.net/browse/HHH-14043#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-14043#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100130- sha1:5f5b10c )

5 years, 9 months

1
0
0 / 0

[JIRA] (HHH-14043) Two concurrent element shifts in a list damage database integrity.

by Björn Zurmaar (JIRA)

Björn Zurmaar ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=5ecd86c... ) *commented* on HHH-14043 ( https://hibernate.atlassian.net/browse/HHH-14043?atlOrigin=eyJpIjoiZDkxZT... ) Re: Two concurrent element shifts in a list damage database integrity. ( https://hibernate.atlassian.net/browse/HHH-14043?atlOrigin=eyJpIjoiZDkxZT... ) Ok, as you wrote about the missing flushes I assumed you just added the flushes and only copied JPAUnitTestCase.java. Sorry for the confusion. After some experiments I found out that the flush() call does not change anything. The key here is that you modified Foo.java and added: @Version Long version; Thank you so much for showing me a way to fix the problem. While the problem can be fixed this way I’m even more puzzled than before. Hibernate uses optimistic locking by default. But in order to make this work you need a version field in your entity. If this is correct: * Is there any scenario where you can safely or actually should omit a version field? * If this is a requirement for optimistic locking to work properly, why does hibernate not complain about the missing field or automatically generate such a field on the DB level? ( https://hibernate.atlassian.net/browse/HHH-14043#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-14043#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100130- sha1:5f5b10c )

5 years, 9 months

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues June 2020