November 2022 - hibernate-issues - Jboss List Archives

[JIRA] (HHH-15779) Avoid stateful lambdas in hot processing of JdbcValuesResultSetImpl

by Sanne Grinovero (JIRA)

Sanne Grinovero ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiNDhiOTczNzMz... ) / Improvement ( https://hibernate.atlassian.net/browse/HHH-15779?atlOrigin=eyJpIjoiNDhiOT... ) HHH-15779 ( https://hibernate.atlassian.net/browse/HHH-15779?atlOrigin=eyJpIjoiNDhiOT... ) Avoid stateful lambdas in hot processing of JdbcValuesResultSetImpl ( https://hibernate.atlassian.net/browse/HHH-15779?atlOrigin=eyJpIjoiNDhiOT... ) Issue Type: Improvement Assignee: Sanne Grinovero ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Components: hibernate-core Created: 29/Nov/2022 04:51 AM Fix Versions: 6.2.0, 6.1.6 Priority: Major Reporter: Sanne Grinovero ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) The performance team identified an issue in JdbcValuesResultSetImpl and how the lambda’s in this class are being optimised by the JVM. We’re not yet sure exactly of why the JVM is not optimising these (as at first glance it should be able to) and they’ll investigate further about that, but it seems we can easily bypass the problem by avoiding the use of the Advancer functional interface. In addition this also allows us to avoid allocating at runtime, as it turns out that some of these Advancer implementations were needing to capture state (e.g. processPosition method needing to carry the position variable). ( https://hibernate.atlassian.net/browse/HHH-15779#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15779#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:4037f92 )

1 year, 4 months

1
0
0 / 0

[JIRA] (HHH-15712) Hibernate Gradle plugin broken with Kotlin projects

by Steve Ebersole (JIRA)

Steve Ebersole ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-15712 ( https://hibernate.atlassian.net/browse/HHH-15712?atlOrigin=eyJpIjoiNGNlMD... ) Re: Hibernate Gradle plugin broken with Kotlin projects ( https://hibernate.atlassian.net/browse/HHH-15712?atlOrigin=eyJpIjoiNGNlMD... ) Assuming the 2 attachments are test projects, why are there 2? What does each do? ( https://hibernate.atlassian.net/browse/HHH-15712#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15712#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:4037f92 )

1 year, 4 months

1
0
0 / 0

[JIRA] (HHH-15712) Hibernate Gradle plugin broken with Kotlin projects

by Steve Ebersole (JIRA)

Steve Ebersole ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-15712 ( https://hibernate.atlassian.net/browse/HHH-15712?atlOrigin=eyJpIjoiMDVmZT... ) Re: Hibernate Gradle plugin broken with Kotlin projects ( https://hibernate.atlassian.net/browse/HHH-15712?atlOrigin=eyJpIjoiMDVmZT... ) I need a test project at the least. I've been asked multiple times now to "fix" support for Kotlin projects with the plugin and each time I have to implement my own Kotlin project from thin air. And every time it works for me. For example, there are tests for building a Kotlin project: * tooling/hibernate-gradle-plugin/src/test/java/org/hibernate/orm/tooling/gradle/KotlinProjectTests.java * tooling/hibernate-gradle-plugin/src/test/resources/projects/simple-kotlin So without at least a test project, not much I plan on doing. ( https://hibernate.atlassian.net/browse/HHH-15712#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15712#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:4037f92 )

1 year, 4 months

1
0
0 / 0

[JIRA] (HHH-15778) Fetching an Entity with a lazily loaded Embeddable with more fields than the parent results in an ArrayIndexOutOfBoundsException

by Georg Echterling (JIRA)

1 year, 4 months

1
0
0 / 0

[JIRA] (HHH-15741) Explicit declaration assigned identifier generator does not work

by Andrea Boriero (JIRA)

1 year, 4 months

1
0
0 / 0

[JIRA] (HHH-15733) @Convert on Map should not require "attributeName=value"

by Marco Belladelli (JIRA)

Marco Belladelli ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=637b480... ) *commented* on HHH-15733 ( https://hibernate.atlassian.net/browse/HHH-15733?atlOrigin=eyJpIjoiNzFlNT... ) Re: @Convert on Map should not require "attributeName=value" ( https://hibernate.atlassian.net/browse/HHH-15733?atlOrigin=eyJpIjoiNzFlNT... ) The latest Jakarta Persistence spec ( https://jakarta.ee/specifications/persistence/3.1/jakarta-persistence-spe... ) specifies that: > > > > The Convert annotation may be applied to a basic attribute or to an element > collection of basic type (in which case the converter is applied to the > elements of the collection). In these cases, the attributeName element must > not be specified. > > We should only throw the Exception when the Map element is of non-basic type. ( https://hibernate.atlassian.net/browse/HHH-15733#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15733#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:4037f92 )

1 year, 4 months

1
0
0 / 0

[JIRA] (HHH-15777) wrong column type expected for audit table keys

by Donal Murtagh (JIRA)

Donal Murtagh ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=70121%3... ) *commented* on HHH-15777 ( https://hibernate.atlassian.net/browse/HHH-15777?atlOrigin=eyJpIjoiYTcwMz... ) Re: wrong column type expected for audit table keys ( https://hibernate.atlassian.net/browse/HHH-15777?atlOrigin=eyJpIjoiYTcwMz... ) I managed to work around this bug by converting all my primary/foreign key column types from a varchar(255) to a uuid , and removing @JdbcType(VarcharJdbcType.class) from the entity classes, but this is unlikely to be a practical solution for many projects. ( https://hibernate.atlassian.net/browse/HHH-15777#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15777#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:4037f92 )

1 year, 4 months

1
0
0 / 0

[JIRA] (HHH-15777) wrong column type expected for audit table keys

by Donal Murtagh (JIRA)

1 year, 4 months

1
0
0 / 0

[JIRA] (HBX-2432) Implement and use the generic adapter for IConfiguration in the experimental Hibernate runtime

by Koen Aers (JIRA)

1 year, 4 months

1
0
0 / 0

[JIRA] (HHH-15778) Fetching an Entity with a lazily loaded Embeddable with more fields than the parent results in an ArrayIndexOutOfBoundsException

by Georg Echterling (JIRA)

Georg Echterling ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *updated* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiNzRmMTU4M2Qx... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-15778?atlOrigin=eyJpIjoiNzRmMT... ) HHH-15778 ( https://hibernate.atlassian.net/browse/HHH-15778?atlOrigin=eyJpIjoiNzRmMT... ) Fetching an Entity with a lazily loaded Embeddable with more fields than the parent results in an ArrayIndexOutOfBoundsException ( https://hibernate.atlassian.net/browse/HHH-15778?atlOrigin=eyJpIjoiNzRmMT... ) Change By: Georg Echterling ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Fetching an Entity containing an Embeddable fails if the Embeddable has more fields than the Entity and is not loaded eagerly. This exception happens before the Entity is loaded from the database. {code:none}java.lang.ArrayIndexOutOfBoundsException: Index 1 out of bounds for length 1 at org.hibernate.metamodel.mapping.internal.BasicAttributeMapping.generateFetch(BasicAttributeMapping.java:304) at org.hibernate.sql.results.graph.FetchParent.generateFetchableFetch(FetchParent.java:105) at org.hibernate.loader.ast.internal.LoaderSelectBuilder.lambda$createFetchableBiConsumer$5(LoaderSelectBuilder.java:833) at org.hibernate.loader.ast.internal.LoaderSelectBuilder.visitFetches(LoaderSelectBuilder.java:672) at org.hibernate.loader.ast.internal.LoaderSqlAstCreationState.visitFetches(LoaderSqlAstCreationState.java:123) at org.hibernate.sql.results.graph.AbstractFetchParent.afterInitialize(AbstractFetchParent.java:32) at org.hibernate.sql.results.graph.embeddable.internal.EmbeddableFetchImpl.<init>(EmbeddableFetchImpl.java:75) at org.hibernate.metamodel.mapping.internal.EmbeddedAttributeMapping.generateFetch(EmbeddedAttributeMapping.java:238) at org.hibernate.sql.results.graph.FetchParent.generateFetchableFetch(FetchParent.java:105) at org.hibernate.loader.ast.internal.LoaderSelectBuilder.lambda$createFetchableBiConsumer$5(LoaderSelectBuilder.java:833) at org.hibernate.loader.ast.internal.LoaderSelectBuilder.visitFetches(LoaderSelectBuilder.java:672) at org.hibernate.loader.ast.internal.LoaderSqlAstCreationState.visitFetches(LoaderSqlAstCreationState.java:123) at org.hibernate.sql.results.graph.AbstractFetchParent.afterInitialize(AbstractFetchParent.java:32) at org.hibernate.sql.results.graph.entity.AbstractEntityResultGraphNode.afterInitialize(AbstractEntityResultGraphNode.java:100) at org.hibernate.persister.entity.AbstractEntityPersister.createDomainResult(AbstractEntityPersister.java:1298) at org.hibernate.loader.ast.internal.LoaderSelectBuilder.generateSelect(LoaderSelectBuilder.java:451) at org.hibernate.loader.ast.internal.LoaderSelectBuilder.createSelect(LoaderSelectBuilder.java:178) at org.hibernate.loader.ast.internal.SingleIdEntityLoaderStandardImpl.createLoadPlan(SingleIdEntityLoaderStandardImpl.java:180) at org.hibernate.loader.ast.internal.SingleIdEntityLoaderStandardImpl.resolveLoadPlan(SingleIdEntityLoaderStandardImpl.java:153) at org.hibernate.loader.ast.internal.SingleIdEntityLoaderStandardImpl.load(SingleIdEntityLoaderStandardImpl.java:66) at org.hibernate.persister.entity.AbstractEntityPersister.doLoad(AbstractEntityPersister.java:4380) at org.hibernate.persister.entity.AbstractEntityPersister.load(AbstractEntityPersister.java:4370) at org.hibernate.event.internal.DefaultLoadEventListener.loadFromDatasource(DefaultLoadEventListener.java:590) at org.hibernate.event.internal.DefaultLoadEventListener.loadFromCacheOrDatasource(DefaultLoadEventListener.java:576) at org.hibernate.event.internal.DefaultLoadEventListener.load(DefaultLoadEventListener.java:545) at org.hibernate.event.internal.DefaultLoadEventListener.doLoad(DefaultLoadEventListener.java:538) at org.hibernate.event.internal.DefaultLoadEventListener.load(DefaultLoadEventListener.java:200) at org.hibernate.event.internal.DefaultLoadEventListener.loadWithRegularProxy(DefaultLoadEventListener.java:280) at org.hibernate.event.internal.DefaultLoadEventListener.proxyOrLoad(DefaultLoadEventListener.java:235) at org.hibernate.event.internal.DefaultLoadEventListener.doOnLoad(DefaultLoadEventListener.java:104) at org.hibernate.event.internal.DefaultLoadEventListener.onLoad(DefaultLoadEventListener.java:76) at org.hibernate.event.service.internal.EventListenerGroupImpl.fireEventOnEachListener(EventListenerGroupImpl.java:118) at org.hibernate.internal.SessionImpl.fireLoadNoChecks(SessionImpl.java:1221) at org.hibernate.internal.SessionImpl.fireLoad(SessionImpl.java:1209) at org.hibernate.loader.access.IdentifierLoadAccessImpl.doLoad(IdentifierLoadAccessImpl.java:192) at org.hibernate.loader.access.IdentifierLoadAccessImpl.lambda$load$1(IdentifierLoadAccessImpl.java:158) at org.hibernate.loader.access.IdentifierLoadAccessImpl.perform(IdentifierLoadAccessImpl.java:105) at org.hibernate.loader.access.IdentifierLoadAccessImpl.load(IdentifierLoadAccessImpl.java:158) at org.hibernate.internal.SessionImpl.find(SessionImpl.java:2336) at org.hibernate.internal.SessionImpl.find(SessionImpl.java:2303) at org.hibernate.orm.test.query.sql.EmbeddableLazyFetchTest.lambda$testSelect$2(EmbeddableLazyFetchTest.java:60) at org.hibernate.testing.orm.transaction.TransactionUtil.wrapInTransaction(TransactionUtil.java:49) at org.hibernate.testing.orm.transaction.TransactionUtil.inTransaction(TransactionUtil.java:24) at org.hibernate.testing.orm.junit.SessionFactoryExtension$SessionFactoryScopeImpl.inTransaction(SessionFactoryExtension.java:375) at org.hibernate.testing.orm.junit.SessionFactoryExtension$SessionFactoryScopeImpl.inTransaction(SessionFactoryExtension.java:352) at org.hibernate.orm.test.query.sql.EmbeddableLazyFetchTest.testSelect(EmbeddableLazyFetchTest.java:56){code} BasicAttributeMapping.generateFetch seems to load the Entity’s property laziness with the Embeddable’s property index. Since this bug is very similar to [https://hibernate.atlassian.net/browse/HHH-15658|https://hibernate.atlass...], I have adapted its test case. In the test, the Embeddable is loaded lazily because it is omitted from the EntityGraph: {code:java}package org.hibernate.orm.test.query.sql; import java.util.Collections; import org.hibernate.graph.spi.RootGraphImplementor; import org.hibernate.testing.TestForIssue; import org.hibernate.testing.orm.junit.DomainModel; import org.hibernate.testing.orm.junit.SessionFactory; import org.hibernate.testing.orm.junit.SessionFactoryScope; import org.junit.jupiter.api.AfterEach; import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.Test; import jakarta.persistence.Embeddable; import jakarta.persistence.Entity; import jakarta.persistence.Id; import static org.assertj.core.api.AssertionsForClassTypes.assertThat; @DomainModel( annotatedClasses = EmbeddableLazyFetchTest.Person.class ) @SessionFactory @TestForIssue(jiraKey = " HHH-15778 ") public class EmbeddableLazyFetchTest { @BeforeEach public void setUp(SessionFactoryScope scope) { scope.inTransaction( session -> { Address address = new Address( "Milan", "Italy", "Italy", "20133" ); Person person = new Person( 1, address ); session.persist( person ); } ); } @AfterEach public void tearDown(SessionFactoryScope scope) { scope.inTransaction( session -> session.createMutationQuery( "delete from Person" ).executeUpdate() ); } @Test public void testSelect(SessionFactoryScope scope) { scope.inTransaction( session -> { RootGraphImplementor<Person> graph = session.createEntityGraph( Person.class ); Person person = session.find( Person.class, 1, Collections.singletonMap( "jakarta.persistence.fetchgraph", graph ) ); assertThat( person ).isNotNull(); } ); } @Entity(name = "Person") public static class Person { @Id private Integer id; private Address address; public Person() { } public Person(Integer id, Address address) { this.id = id; this.address = address; } } @Embeddable public static class Address { private String city; private String state; private String country; private String postcode; public Address() { } public Address(String city, String state, String country, String postcode) { this.city = city; this.state = state; this.country = country; this.postcode = postcode; } } }{code} ( https://hibernate.atlassian.net/browse/HHH-15778#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15778#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:4037f92 )

1 year, 4 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues November 2022