November 2022 - hibernate-issues - Jboss List Archives

[JIRA] (HHH-15712) Hibernate Gradle plugin broken with Kotlin projects

by sdeleuze (JIRA)

1 year, 10 months

1
0
0 / 0

[JIRA] (HHH-15712) Hibernate Gradle plugin broken with Kotlin projects

by sdeleuze (JIRA)

1 year, 10 months

1
0
0 / 0

[JIRA] (HHH-15712) Hibernate Gradle plugin broken with Kotlin projects

by sdeleuze (JIRA)

sdeleuze ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=634667c... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiYTkyYjUwN2Nl... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-15712?atlOrigin=eyJpIjoiYTkyYj... ) HHH-15712 ( https://hibernate.atlassian.net/browse/HHH-15712?atlOrigin=eyJpIjoiYTkyYj... ) Hibernate Gradle plugin broken with Kotlin projects ( https://hibernate.atlassian.net/browse/HHH-15712?atlOrigin=eyJpIjoiYTkyYj... ) Issue Type: Bug Affects Versions: 6.1.5 Assignee: Unassigned Components: hibernate-gradle-plugin Created: 12/Nov/2022 11:39 AM Environment: Java 17, Hibernate 6.1.5.Final Priority: Major Reporter: sdeleuze ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=634667c... ) When I declare: plugins { id("org.springframework.boot") version "3.0.0-RC2" id("io.spring.dependency-management") version "1.1.0" id("org.hibernate.orm") version "6.1.5.Final" kotlin("jvm") version "1.7.20" kotlin("plugin.spring") version "1.7.20" kotlin("plugin.jpa") version "1.7.20" } I get this error: An exception occurred applying plugin request [id: 'org.hibernate.orm', version: '6.1.5.Final'] Failed to apply plugin 'org.hibernate.orm'.Could not create an instance of type org.hibernate.orm.tooling.gradle.HibernateOrmSpec.Extension of type 'JavaPluginExtension' does not exist. Currently registered extension types: [ExtraPropertiesExtension, SpringBootExtension, StandardDependencyManagementExtension, SourceSetContainer] If I change the order and put Hibernate plugin at the end with: plugins { id("org.springframework.boot") version "3.0.0-RC2" id("io.spring.dependency-management") version "1.1.0" kotlin("jvm") version "1.7.20" kotlin("plugin.spring") version "1.7.20" kotlin("plugin.jpa") version "1.7.20" id("org.hibernate.orm") version "6.1.5.Final" } Then I get another error: class org.jetbrains.kotlin.gradle.tasks.KotlinCompile_Decorated cannot be cast to class org.gradle.api.tasks.compile.AbstractCompile (org.jetbrains.kotlin.gradle.tasks.KotlinCompile_Decorated is in unnamed module of loader org.gradle.internal.classloader.VisitableURLClassLoader @7ecada45; org.gradle.api.tasks.compile.AbstractCompile is in unnamed module of loader org.gradle.initialization.MixInLegacyTypesClassLoader @68c72235) Both error only happen with Hibernate Gradle plugin and prevent Spring Boot to use Hibernate Gradle plugin on Kotlin project. Could you please fix those 2 use cases? I attach the 2 related sample project where you should be able to reproduce by running./gradlew clean build. ( https://hibernate.atlassian.net/browse/HHH-15712#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15712#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:583150f )

1 year, 10 months

1
0
0 / 0

[JIRA] (HHH-15711) ArgumentTypesValidator doesn't support enums in string functions

by Christoph Dreis (JIRA)

Christoph Dreis ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *updated* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiNjI2MzliZDQ0... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-15711?atlOrigin=eyJpIjoiNjI2Mz... ) HHH-15711 ( https://hibernate.atlassian.net/browse/HHH-15711?atlOrigin=eyJpIjoiNjI2Mz... ) ArgumentTypesValidator doesn't support enums in string functions ( https://hibernate.atlassian.net/browse/HHH-15711?atlOrigin=eyJpIjoiNjI2Mz... ) Change By: Christoph Dreis ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Hi, I have upgraded a project from 5.x to 6.x and noticed that one of our queries is not working anymore. The original one looks different and is part of a Spring-Boot app, but I’ve locally added a minimal reproducing test to {{FunctionTests}} already that looks like the following: {noformat} @Test public void testLowerUpperFunctionsWithEnums(SessionFactoryScope scope) { scope.inTransaction( session -> { session.createQuery("select lower(e.gender) from EntityOfBasics e") .list(); session.createQuery("select upper(e.gender) from EntityOfBasics e") .list(); } ); }{noformat} {{gender}} (more respectively its getter) has been annotated with {{@Enumerated( EnumType.STRING )}} This test fails with the following exception {noformat}Caused by: org.hibernate.QueryException: Parameter 1 of function lower() has type STRING, but argument is of type org.hibernate.testing.orm.domain.gambit.EntityOfBasics$Gender at app//org.hibernate.query.sqm.produce.function.ArgumentTypesValidator.throwError(ArgumentTypesValidator.java:214) at app//org.hibernate.query.sqm.produce.function.ArgumentTypesValidator.checkType(ArgumentTypesValidator.java:169) at app//org.hibernate.query.sqm.produce.function.ArgumentTypesValidator.validate(ArgumentTypesValidator.java:74) at app//org.hibernate.query.sqm.function.AbstractSqmFunctionDescriptor.generateSqmExpression(AbstractSqmFunctionDescriptor.java:104) ...{noformat} With the following little patch this seems to be working again, but I’m not quite sure If this might be breaking in other cases I don’t know. {noformat}--- a/hibernate-core/src/main/java/org/hibernate/query/sqm/produce/function/ArgumentTypesValidator.java +++ b/hibernate-core/src/main/java/org/hibernate/query/sqm/produce/function/ArgumentTypesValidator.java @@ -166,6 +166,9 @@ public class ArgumentTypesValidator implements ArgumentsValidator { break; case STRING: if ( !isCharacterType(code) ) { + if (Enum.class.isAssignableFrom((Class<?>) javaType)) { + return; + } throwError(type, javaType, functionName, count); } break;{noformat} If you feel, this is the correct solution, I’d be happy to contribute both the test and the fix. Cheers, Christoph ( https://hibernate.atlassian.net/browse/HHH-15711#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15711#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:583150f )

1 year, 10 months

1
0
0 / 0

[JIRA] (HHH-15711) ArgumentTypesValidator doesn't support enums in string functions

by Christoph Dreis (JIRA)

Christoph Dreis ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-15711 ( https://hibernate.atlassian.net/browse/HHH-15711?atlOrigin=eyJpIjoiYjA3Nz... ) Re: ArgumentTypesValidator doesn't support enums in string functions ( https://hibernate.atlassian.net/browse/HHH-15711?atlOrigin=eyJpIjoiYjA3Nz... ) On closer inspection I have the feeling that this might be caused by not choosing the correct JdbcType. SmallIntTypeDescriptor is chosen rather than e.g. VarcharJdbcType - indicating that the @Enumerated( EnumType.STRING ) is ignored. ( https://hibernate.atlassian.net/secure/attachment/50101/50101_image-20221... ) ( https://hibernate.atlassian.net/browse/HHH-15711#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15711#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:583150f )

1 year, 10 months

1
0
0 / 0

[JIRA] (HHH-15705) Properly document requirements for building Hibernate in the README

by Gavin King (JIRA)

Gavin King ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-15705 ( https://hibernate.atlassian.net/browse/HHH-15705?atlOrigin=eyJpIjoiNzk5Zm... ) Re: Properly document requirements for building Hibernate in the README ( https://hibernate.atlassian.net/browse/HHH-15705?atlOrigin=eyJpIjoiNzk5Zm... ) FTR, after a successful build with Java 11, I typed: sdk use java 17.0.5-tem ./gradlew hibernate-core:build And I get lots of compilation errors. Switching back to 11.0.17-tem , the errors are gone. ( https://hibernate.atlassian.net/browse/HHH-15705#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15705#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:583150f )

1 year, 10 months

1
0
0 / 0

[JIRA] (HHH-15711) ArgumentTypesValidator doesn't support enums in string functions

by Christoph Dreis (JIRA)

Christoph Dreis ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiMDQ1MjE5Nzg1... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-15711?atlOrigin=eyJpIjoiMDQ1Mj... ) HHH-15711 ( https://hibernate.atlassian.net/browse/HHH-15711?atlOrigin=eyJpIjoiMDQ1Mj... ) ArgumentTypesValidator doesn't support enums in string functions ( https://hibernate.atlassian.net/browse/HHH-15711?atlOrigin=eyJpIjoiMDQ1Mj... ) Issue Type: Bug Affects Versions: 6.1.5 Assignee: Unassigned Components: hibernate-core Created: 12/Nov/2022 02:09 AM Priority: Major Reporter: Christoph Dreis ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Hi, I have upgraded a project from 5.x to 6.x and noticed that one of our queries is not working anymore. I’ve locally added a test to FunctionTests already that looks like the following: @Test public void testLowerUpperFunctionsWithEnums(SessionFactoryScope scope) { scope.inTransaction( session -> { session.createQuery("select lower(e.gender) from EntityOfBasics e") .list(); session.createQuery("select upper(e.gender) from EntityOfBasics e") .list(); } ); } gender has been annotated with @Enumerated( EnumType.STRING ) This test fails with the following exception Caused by: org.hibernate.QueryException: Parameter 1 of function lower() has type STRING, but argument is of type org.hibernate.testing.orm.domain.gambit.EntityOfBasics$Gender at app//org.hibernate.query.sqm.produce.function.ArgumentTypesValidator.throwError(ArgumentTypesValidator.java:214) at app//org.hibernate.query.sqm.produce.function.ArgumentTypesValidator.checkType(ArgumentTypesValidator.java:169) at app//org.hibernate.query.sqm.produce.function.ArgumentTypesValidator.validate(ArgumentTypesValidator.java:74) at app//org.hibernate.query.sqm.function.AbstractSqmFunctionDescriptor.generateSqmExpression(AbstractSqmFunctionDescriptor.java:104) ... With the following little patch this seems to be working again, but I’m not quite sure If this might be breaking in other cases I don’t know. --- a/hibernate-core/src/main/java/org/hibernate/query/sqm/produce/function/ArgumentTypesValidator.java +++ b/hibernate-core/src/main/java/org/hibernate/query/sqm/produce/function/ArgumentTypesValidator.java @@ -166,6 +166,9 @@ public class ArgumentTypesValidator implements ArgumentsValidator { break; case STRING: if ( !isCharacterType(code) ) { + if (Enum.class.isAssignableFrom((Class<?>) javaType)) { + return; + } throwError(type, javaType, functionName, count); } break; If you feel, this is the correct solution, I’d be happy to contribute both the test and the fix. Cheers, Christoph ( https://hibernate.atlassian.net/browse/HHH-15711#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15711#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:583150f )

1 year, 10 months

1
0
0 / 0

[JIRA] (HHH-15710) ReflectHelper and RegistryHelper do not handle generic types correctly

by Wolfgang Seifert (JIRA)

Wolfgang Seifert ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=635f717... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiNzU3NmE2ZmZm... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-15710?atlOrigin=eyJpIjoiNzU3Nm... ) HHH-15710 ( https://hibernate.atlassian.net/browse/HHH-15710?atlOrigin=eyJpIjoiNzU3Nm... ) ReflectHelper and RegistryHelper do not handle generic types correctly ( https://hibernate.atlassian.net/browse/HHH-15710?atlOrigin=eyJpIjoiNzU3Nm... ) Issue Type: Bug Affects Versions: 6.1.5 Assignee: Unassigned Components: hibernate-core Created: 11/Nov/2022 23:26 PM Environment: hibernate 6.1.5 orm, jdk 17 Priority: Major Reporter: Wolfgang Seifert ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=635f717... ) This issue is a result of further investigating https://hibernate.atlassian.net/browse/HHH-15646 ( https://hibernate.atlassian.net/browse/HHH-15646 ). The Exceptions are thrown from ReflectHelper and RegistryHelper. Changing ReflectHelper to public static <T> Class<T> getClass(java.lang.reflect.Type type) { if ( type == null ) { return null; } else if ( type instanceof Class<?> ) { return (Class<T>) type; } else if ( type instanceof TypeVariable<?>) { return getClass( ( (TypeVariable) type ).getBounds()[0]); } else if ( type instanceof ParameterizedType ) { return (Class<T>) ( (ParameterizedType) type ).getRawType(); } throw new UnsupportedOperationException( "Can't get java type class from type: " + type ); } and RegistryHelper to private <J> Class<J> determineJavaTypeClass(Type javaType) { final Class<J> javaTypeClass; if ( javaType instanceof Class<?> ) { javaTypeClass = (Class<J>) javaType; } else if ( javaType instanceof TypeVariable<?>){ final TypeVariable typeVariable = (TypeVariable) javaType; javaTypeClass = determineJavaTypeClass(typeVariable.getBounds()[0]); } else { final ParameterizedType parameterizedType = (ParameterizedType) javaType; javaTypeClass = (Class<J>) parameterizedType.getRawType(); } return javaTypeClass; } resolves the issue, but getBounds() [0] is certainly not a safe solution. An expert is needed here. ( https://hibernate.atlassian.net/browse/HHH-15710#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15710#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:583150f )

1 year, 10 months

1
0
0 / 0

[JIRA] (HHH-15709) HQL local datetime literals on Postgres, Cockroach H2

by Gavin King (JIRA)

Gavin King ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-15709 ( https://hibernate.atlassian.net/browse/HHH-15709?atlOrigin=eyJpIjoiYWYyMD... ) Re: HQL local datetime literals on Postgres, Cockroach H2 ( https://hibernate.atlassian.net/browse/HHH-15709?atlOrigin=eyJpIjoiYWYyMD... ) Fixed. ( https://hibernate.atlassian.net/browse/HHH-15709#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15709#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:583150f )

1 year, 10 months

1
0
0 / 0

[JIRA] (HHH-15679) Use OffsetTime on JDBC level for TIME WITH TIME ZONE type

by Gavin King (JIRA)

Gavin King ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-15679 ( https://hibernate.atlassian.net/browse/HHH-15679?atlOrigin=eyJpIjoiYzlmZT... ) Re: Use OffsetTime on JDBC level for TIME WITH TIME ZONE type ( https://hibernate.atlassian.net/browse/HHH-15679?atlOrigin=eyJpIjoiYzlmZT... ) I have fixed the bug here. We now no longer just throw away the offset when persisting an OffsetTime. ( https://hibernate.atlassian.net/browse/HHH-15679#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-15679#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100210- sha1:583150f )

1 year, 10 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues November 2022