April 2023 - hibernate-issues - Jboss List Archives

[JIRA] (HSEARCH-4574) Explicit binding of constructor parameters for @ProjectionConstructor

by Yoann Rodière (JIRA)

Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *updated* an issue Hibernate Search ( https://hibernate.atlassian.net/browse/HSEARCH?atlOrigin=eyJpIjoiMDgxZWEz... ) / New Feature ( https://hibernate.atlassian.net/browse/HSEARCH-4574?atlOrigin=eyJpIjoiMDg... ) HSEARCH-4574 ( https://hibernate.atlassian.net/browse/HSEARCH-4574?atlOrigin=eyJpIjoiMDg... ) Explicit binding of constructor parameters for @ProjectionConstructor ( https://hibernate.atlassian.net/browse/HSEARCH-4574?atlOrigin=eyJpIjoiMDg... ) Change By: Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Follows up on [https://hibernate.atlassian.net/browse/HSEARCH-3927|https://hibernate.atl...]. Use case: define a parameter of a projection constructor as a specific inner projection either something completely different from field projections such as an identifier projection, or more precise configuration of field value/object projections. For example: {code:java}@ProjectionConstructor record MyProjection(@IdProjection String id, @FieldProjection(convert = ValueConvert.NO) String myEnum){code} Currently, all constructor parameters are bound implicitly, which limits users to field projections or object projections. There is no ID projection in particular, which prevents from fully loading an entity through its projection constructor, since it can’t project on the ID. This also means {{-parameters}} _must_ be passed to the compiler when compiling projection constructors. Core set of annotations (must be implemented): * {{@IdProjection}} * {{@FieldProjection}} * {{@ObjectProjection}} ** we might want a {{includeDepth}} in here (=> moved to [https://hibernate.atlassian.net/browse/HSEARCH-4725|https://hibernate.atl...] ) * {{@ProjectionBinding(binder = ...)}} (for custom projection annotations) Less useful/more challenging annotations that could be split into another ticket: * {{@ScoreProjection}} * {{@DistanceProjection}} (=> moved to [https://hibernate.atlassian.net/browse/HSEARCH-4807|https://hibernate.atl...] ) * {{@EntityProjection}} * {{@EntityReferenceProjection}} * {{@DocumentReferenceProjection}} * {{@HighlightProjection}} ( [https://hibernate.atlassian.net/browse/HSEARCH-2192|https://hibernate.atl...] ) * Others, see all projections available. Some things to test in particular: * There should be no error if {{-parameters}} is not used when compiling, as long as all constructor parameters of a projection constructor have a {{@*Projection}} annotation (and that projection specifies the field path, if relevant). * There should be an error if {{-parameters}} is not used when compiling, and all constructor parameters of a projection constructor have a {{@*Projection}} annotation, but one of them is annotated with {{@FieldProjection}} or {{@ObjectProjection}} and does not specify the field path. * There should be an error when using two {{@*Projection}} annotations on the same constructor parameter. * And more (the list above is not exhaustive, obviously). ( https://hibernate.atlassian.net/browse/HSEARCH-4574#add-comment?atlOrigin... ) Add Comment ( https://hibernate.atlassian.net/browse/HSEARCH-4574#add-comment?atlOrigin... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100221- sha1:c4871f2 )

3 years

1
0
0 / 0

[JIRA] (HSEARCH-4828) Lucene's unified highlighter should produce multiple highlighted snippets for multi-valued fields

by Yoann Rodière (JIRA)

3 years

1
0
0 / 0

[JIRA] (HHH-16461) @Version + session.refresh(entity, LockMode.PESSIMISTIC_WRITE) leads to StaleObjectStateException

by Andrea Boriero (JIRA)

3 years

1
0
0 / 0

[JIRA] (HHH-16464) Foreign key constraint not created for @OneToOne mapping with missing @MapsId

by Gavin King (JIRA)

Gavin King ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *updated* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiMGMzNzc0MzBl... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-16464?atlOrigin=eyJpIjoiMGMzNz... ) HHH-16464 ( https://hibernate.atlassian.net/browse/HHH-16464?atlOrigin=eyJpIjoiMGMzNz... ) Foreign key constraint not created for @OneToOne mapping with missing @MapsId ( https://hibernate.atlassian.net/browse/HHH-16464?atlOrigin=eyJpIjoiMGMzNz... ) Change By: Gavin King ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Given the following mapping: {code:java}@OneToOne @JoinColumn(name = "id") private User user;{code} No foreign key constraint is created. The fix is to either: * add a {{@MapsId}} annotation, or * add {{optional=false}} but this is not obvious at all. Since we don’t reject this mapping, we should create the correct FK constraint even when {{@MapsId}} is missing. ( https://hibernate.atlassian.net/browse/HHH-16464#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16464#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100221- sha1:c4871f2 )

3 years

1
0
0 / 0

[JIRA] (HHH-16463) @PrimaryKeyJoinColumn ignored for @OneToOne mappings

by Gavin King (JIRA)

Gavin King ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *updated* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiOWRlYTVhMDRk... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-16463?atlOrigin=eyJpIjoiOWRlYT... ) HHH-16463 ( https://hibernate.atlassian.net/browse/HHH-16463?atlOrigin=eyJpIjoiOWRlYT... ) @PrimaryKeyJoinColumn ignored for @OneToOne mappings ( https://hibernate.atlassian.net/browse/HHH-16463?atlOrigin=eyJpIjoiOWRlYT... ) Change By: Gavin King ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Given the following mapping: {code:java}@OneToOne @MapsId @PrimaryKeyJoinColumn(name = "id") //ignored! private User user;{code} The column name is simply ignored. There are two possible workarounds: # Remove {{@MapsId}} and add {{optional=false}}: {code:java}@OneToOne(optional = false) @PrimaryKeyJoinColumn(name = "id") private User user;{code} # Use {{@JoinColumn}} instead of {{@PrimaryKeyJoinColumn}} : {code:java}@OneToOne @MapsId @JoinColumn(name = "id"){code} But my reading of the JPA spec is that the first example should work. ( https://hibernate.atlassian.net/browse/HHH-16463#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16463#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100221- sha1:c4871f2 )

3 years

1
0
0 / 0

[JIRA] (HHH-16463) @PrimaryKeyJoinColumn ignored for @OneToOne mappings

by Gavin King (JIRA)

Gavin King ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *updated* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiNDcwMDg2YmQz... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-16463?atlOrigin=eyJpIjoiNDcwMD... ) HHH-16463 ( https://hibernate.atlassian.net/browse/HHH-16463?atlOrigin=eyJpIjoiNDcwMD... ) @PrimaryKeyJoinColumn ignored for @OneToOne mappings ( https://hibernate.atlassian.net/browse/HHH-16463?atlOrigin=eyJpIjoiNDcwMD... ) Change By: Gavin King ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Given the following mapping: {code:java}@OneToOne @MapsId @PrimaryKeyJoinColumn(name = "id") //ignored! private User user;{code} The column name is simply ignored. There are two possible workarounds: # Remove {{@MapsId}} and add {{optional=false}} (but see *HHH-16464*) : {code:java}@OneToOne(optional = false) @PrimaryKeyJoinColumn(name = "id") private User user;{code} # Use {{@JoinColumn}} instead of {{@PrimaryKeyJoinColumn}} {code:java}@OneToOne @MapsId @JoinColumn(name = "id"){code} But my reading of the JPA spec is that the first example should work. ( https://hibernate.atlassian.net/browse/HHH-16463#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16463#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100221- sha1:c4871f2 )

3 years

1
0
0 / 0

[JIRA] (HHH-16463) @PrimaryKeyJoinColumn ignored for @OneToOne mappings

by Gavin King (JIRA)

Gavin King ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *updated* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiZGFhOTZmOTJj... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-16463?atlOrigin=eyJpIjoiZGFhOT... ) HHH-16463 ( https://hibernate.atlassian.net/browse/HHH-16463?atlOrigin=eyJpIjoiZGFhOT... ) @PrimaryKeyJoinColumn ignored for @OneToOne mappings ( https://hibernate.atlassian.net/browse/HHH-16463?atlOrigin=eyJpIjoiZGFhOT... ) Change By: Gavin King ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Given the following mapping: {code:java}@OneToOne @MapsId @PrimaryKeyJoinColumn(name = "id") //ignored! private User user;{code} The column name is simply ignored. There are two possible workarounds: # Remove {{@MapsId}} and add {{optional=false}} (but see *HHH-16464*) : {code:java}@OneToOne(optional = false) @PrimaryKeyJoinColumn(name = "id") private User user;{code} # Use {{@JoinColumn}} instead of {{@PrimaryKeyJoinColumn}} {code:java}@OneToOne @MapsId @JoinColumn(name = "id"){code} But my reading of the JPA spec is that the first example should work. ( https://hibernate.atlassian.net/browse/HHH-16463#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16463#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100221- sha1:c4871f2 )

3 years

1
0
0 / 0

[JIRA] (HHH-16464) Foreign key constraint not created for @OneToOne mapping with missing @MapsId

by Gavin King (JIRA)

Gavin King ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiNGEyOTM3N2Fi... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-16464?atlOrigin=eyJpIjoiNGEyOT... ) HHH-16464 ( https://hibernate.atlassian.net/browse/HHH-16464?atlOrigin=eyJpIjoiNGEyOT... ) Foreign key constraint not created for @OneToOne mapping with missing @MapsId ( https://hibernate.atlassian.net/browse/HHH-16464?atlOrigin=eyJpIjoiNGEyOT... ) Issue Type: Bug Assignee: Unassigned Components: hibernate-core Created: 12/Apr/2023 04:23 AM Priority: Major Reporter: Gavin King ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Given the following mapping: @OneToOne @JoinColumn(name = "id" ) private User user; No foreign key constraint is created. The fix is to add a @MapsId annotation, but this is not obvious at all. Since we don’t reject this mapping, we should create the correct FK constraint even when @MapsId is missing. ( https://hibernate.atlassian.net/browse/HHH-16464#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16464#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100221- sha1:c4871f2 )

3 years

1
0
0 / 0

[JIRA] (HHH-16461) @Version + session.refresh(entity, LockMode.PESSIMISTIC_WRITE) leads to StaleObjectStateException

by Yoann Rodière (JIRA)

Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-16461 ( https://hibernate.atlassian.net/browse/HHH-16461?atlOrigin=eyJpIjoiZTg3ZT... ) Re: @Version + session.refresh(entity, LockMode.PESSIMISTIC_WRITE) leads to StaleObjectStateException ( https://hibernate.atlassian.net/browse/HHH-16461?atlOrigin=eyJpIjoiZTg3ZT... ) Submitted a reproducer here: https://github.com/hibernate/hibernate-orm/pull/6400 And backported to 5.6 just to check: https://github.com/hibernate/hibernate-orm/pull/6401. I confirm this is a regression, as it worked in 5.6. ( https://hibernate.atlassian.net/browse/HHH-16461#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16461#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100221- sha1:c4871f2 )

3 years

1
0
0 / 0

[JIRA] (HHH-16463) @PrimaryKeyJoinColumn ignored for @OneToOne mappings

by Gavin King (JIRA)

Gavin King ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiMTI5MTQ2MGU5... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-16463?atlOrigin=eyJpIjoiMTI5MT... ) HHH-16463 ( https://hibernate.atlassian.net/browse/HHH-16463?atlOrigin=eyJpIjoiMTI5MT... ) @PrimaryKeyJoinColumn ignored for @OneToOne mappings ( https://hibernate.atlassian.net/browse/HHH-16463?atlOrigin=eyJpIjoiMTI5MT... ) Issue Type: Bug Assignee: Unassigned Components: hibernate-core Created: 12/Apr/2023 04:19 AM Priority: Major Reporter: Gavin King ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Given the following mapping: @OneToOne @MapsId @PrimaryKeyJoinColumn(name = "id" ) //ignored! private User user; The column name is simply ignored. There are two possible workarounds: * Remove @MapsId and add optional=false : @OneToOne(optional = false ) @PrimaryKeyJoinColumn(name = "id" ) private User user; * Use @JoinColumn instead of @PrimaryKeyJoinColumn @OneToOne @MapsId @JoinColumn(name = "id" ) But my reading of the JPA spec is that the first example should work. ( https://hibernate.atlassian.net/browse/HHH-16463#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16463#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100221- sha1:c4871f2 )

3 years

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues April 2023