May 2023 - hibernate-issues - Jboss List Archives

[JIRA] (HHH-16558) Detaching an entity removes natural-id cross-reference from shared cache

by Steve Ebersole (JIRA)

Steve Ebersole ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-16558 ( https://hibernate.atlassian.net/browse/HHH-16558?atlOrigin=eyJpIjoiZWQ1Mz... ) Re: Detaching an entity removes natural-id cross-reference from shared cache ( https://hibernate.atlassian.net/browse/HHH-16558?atlOrigin=eyJpIjoiZWQ1Mz... ) Applied this upstream. Thanks Guenther! ( https://hibernate.atlassian.net/browse/HHH-16558#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16558#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:2b972a1 )

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-14944) Bug: Detach entity removes NaturalIdCrossReference in shared cache too

by Steve Ebersole (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-14944) Bug: Detach entity removes NaturalIdCrossReference in shared cache too

by Steve Ebersole (JIRA)

Steve Ebersole ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-14944 ( https://hibernate.atlassian.net/browse/HHH-14944?atlOrigin=eyJpIjoiOTgxYj... ) Re: Bug: Detach entity removes NaturalIdCrossReference in shared cache too ( https://hibernate.atlassian.net/browse/HHH-14944?atlOrigin=eyJpIjoiOTgxYj... ) Applied this upstream. Thanks Guenther! ( https://hibernate.atlassian.net/browse/HHH-14944#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-14944#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:2b972a1 )

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16558) Detaching an entity removes natural-id cross-reference from shared cache

by Steve Ebersole (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16558) Detaching an entity removes natural-id cross-reference from shared cache

by Steve Ebersole (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16558) Detaching an entity removes natural-id cross-reference from shared cache

by Steve Ebersole (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16558) Detaching an entity removes natural-id cross-reference from shared cache

by Steve Ebersole (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16560) Nested @Embedded within an @EmbeddedId fails assertion in 6.2.2

by Andrea Boriero (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16686) LocalTime to java.sql.Time unwrap bug.

by Christian Beikov (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16594) Query cache miss when query contains multiple parameters

by Marco Belladelli (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16617) When caching queries, filter parameters are not included in the cache key

by Marco Belladelli (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16617) When caching queries, filter parameters are not included in the cache key

by Marco Belladelli (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16617) When caching queries, filter parameters are not included in the cache key

by Marco Belladelli (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16649) Hibernate.remove() doesn't work at all

by Jan Schatteman (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16649) Hibernate.remove() doesn't work at all

by Jan Schatteman (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16649) Hibernate.remove() doesn't work at all

by Jan Schatteman (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16633) Render "repository" methods into generated metamodel

by Steve Ebersole (JIRA)

Steve Ebersole ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *updated* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiMDlhYzVjYTAx... ) / Improvement ( https://hibernate.atlassian.net/browse/HHH-16633?atlOrigin=eyJpIjoiMDlhYz... ) HHH-16633 ( https://hibernate.atlassian.net/browse/HHH-16633?atlOrigin=eyJpIjoiMDlhYz... ) Render "repository" methods into generated metamodel ( https://hibernate.atlassian.net/browse/HHH-16633?atlOrigin=eyJpIjoiMDlhYz... ) Change By: Steve Ebersole ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) For simple named queries, generate “repository” methods. E.g. {code:java}@NamedQuery( name = "persons_by_city", query = "from Person where city = :theCity" ... ) @Entity class Person { ... @Basic String city; }{code} leads to {code:java}@Generated class Person_ { ... public static List<Person> getPersonsByCity(String city, Session session) { ... } }{code} An alternative would be to instead generate a distinct repository class which might be better given that: # Hibernate named-queries can be defined at the package level # Realistically, JPA static metamodel generation effective has to be done from an annotation processor. We need to be able to parse the query (into SQM most likely) for semantic information. Not - not sure how feasible it is to do this from an annotation processor. ( https://hibernate.atlassian.net/browse/HHH-16633#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16633#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:2b972a1 )

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16633) Render "repository" methods into generated metamodel

by Steve Ebersole (JIRA)

Steve Ebersole ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *updated* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiNDcyNTBjNjkw... ) / Improvement ( https://hibernate.atlassian.net/browse/HHH-16633?atlOrigin=eyJpIjoiNDcyNT... ) HHH-16633 ( https://hibernate.atlassian.net/browse/HHH-16633?atlOrigin=eyJpIjoiNDcyNT... ) Render "repository" methods into generated metamodel ( https://hibernate.atlassian.net/browse/HHH-16633?atlOrigin=eyJpIjoiNDcyNT... ) Change By: Steve Ebersole ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) For simple named queries, generate “repository” methods. E.g. {code:java}@NamedQuery( name = "persons_by_city", query = "from Person where city = :theCity" ... ) @Entity class Person { ... @Basic String city; }{code} leads to {code:java}@Generated class Person_ { ... public static List<Person> getPersonsByCity(String city, Session session) { ... } }{code} An alternative would be to instead generate a distinct repository class which might be better given that: # Hibernate named-queries can be defined at the package level # JPA static metamodel generation effective has to be done from an annotation processor ; I’m not sure how feasible it is to do this from an annotation processor. We need to be able to parse the query (into SQM most likely) for semantic information. Again, not Not sure how feasible it is to do this from an annotation processor. ( https://hibernate.atlassian.net/browse/HHH-16633#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16633#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:2b972a1 )

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16633) Render "repository" methods into generated metamodel

by Steve Ebersole (JIRA)

Steve Ebersole ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *updated* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiMWZjODlkZjdh... ) / Improvement ( https://hibernate.atlassian.net/browse/HHH-16633?atlOrigin=eyJpIjoiMWZjOD... ) HHH-16633 ( https://hibernate.atlassian.net/browse/HHH-16633?atlOrigin=eyJpIjoiMWZjOD... ) Render "repository" methods into generated metamodel ( https://hibernate.atlassian.net/browse/HHH-16633?atlOrigin=eyJpIjoiMWZjOD... ) Change By: Steve Ebersole ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) For simple named queries, generate “repository” methods. E.g. {code:java}@NamedQuery( name = "persons_by_city", query = "from Person where city = :theCity" ... ) @Entity class Person { ... @Basic String city; }{code} leads to {code:java}@Generated class Person_ { ... public static List<Person> getPersonsByCity(String city, Session session) { ... } }{code} An alternative would be to instead generate a distinct repository class which might be better given that: # Hibernate named-queries can be defined at the package level # JPA static metamodel generation effective has to be done from an annotation processor; I’m not sure how feasible it is to do this from an annotation processor. We need to be able to parse the query (into SQM most likely) for semantic information. Again, not sure how feasible it is to do this from an annotation processor. ( https://hibernate.atlassian.net/browse/HHH-16633#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16633#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:2b972a1 )

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16684) Query cache with entity having enum and custom converter throws SerializerException

by Mike Zhao (JIRA)

Mike Zhao ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *updated* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiNmI1YzNhMzcx... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-16684?atlOrigin=eyJpIjoiNmI1Yz... ) HHH-16684 ( https://hibernate.atlassian.net/browse/HHH-16684?atlOrigin=eyJpIjoiNmI1Yz... ) Query cache with entity having enum and custom converter throws SerializerException ( https://hibernate.atlassian.net/browse/HHH-16684?atlOrigin=eyJpIjoiNmI1Yz... ) Change By: Mike Zhao ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Caching query results in a spring JPA repository using query-hint, hibernate throws SerializerException when the entity involved has Enum field and a customer converter. In org {code:java}java. hibernate io. cache.spi.QueryKey there is a field NotSerializableException: org.hibernate. transform metamodel. CacheableResultTransformer which is not transient model. It seems like this field is causing the exception convert. internal.JpaAttributeConverterImpl{code} ehcach.xml (note that there are far less entries than 1000 as configured) {code:xml}<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://www.ehcache.org/v3" xmlns:jsr107="http://www.ehcache.org/v3/jsr107" xsi:schemaLocation=" http://www.ehcache.org/v3 http://www.ehcache.org/schema/ehcache-core-3.0.xsd http://www.ehcache.org/v3/jsr107 http://www.ehcache.org/schema/ehcache-107-ext-3.0.xsd"> <service> <jsr107:defaults enable-management="true" enable-statistics="true"/> </service>  <cache-template name="simple"> <expiry> <none/> </expiry> <heap unit="entries">1000</heap> </cache-template> <cache alias="org.hibernate.cache.internal.StandardQueryCache" uses-template="simple"/> <cache alias="org.hibernate.cache.spi.TimestampsCache" uses-template="simple"/> </config>{code} ( https://hibernate.atlassian.net/browse/HHH-16684#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16684#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:2b972a1 )

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16360) On Postgresql with hbm2ddl.auto=update, timestamp columns are updated even when correct

by Nils Israel (JIRA)

Nils Israel ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=712020%... ) *commented* on HHH-16360 ( https://hibernate.atlassian.net/browse/HHH-16360?atlOrigin=eyJpIjoiZTk3Yj... ) Re: On Postgresql with hbm2ddl.auto=update, timestamp columns are updated even when correct ( https://hibernate.atlassian.net/browse/HHH-16360?atlOrigin=eyJpIjoiZTk3Yj... ) ah, great. Thank you. ( https://hibernate.atlassian.net/browse/HHH-16360#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16360#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:2b972a1 )

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16360) On Postgresql with hbm2ddl.auto=update, timestamp columns are updated even when correct

by Gavin King (JIRA)

Gavin King ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-16360 ( https://hibernate.atlassian.net/browse/HHH-16360?atlOrigin=eyJpIjoiOTljOT... ) Re: On Postgresql with hbm2ddl.auto=update, timestamp columns are updated even when correct ( https://hibernate.atlassian.net/browse/HHH-16360?atlOrigin=eyJpIjoiOTljOT... ) This should fix it: https://github.com/hibernate/hibernate-orm/pull/6639/files I tried hard but could not find a reasonable way to handle updating the precision of floating-point types, so now I don’t even try. ( https://hibernate.atlassian.net/browse/HHH-16360#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16360#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:2b972a1 )

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-14944) Bug: Detach entity removes NaturalIdCrossReference in shared cache too

by Steve Ebersole (JIRA)

Steve Ebersole ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-14944 ( https://hibernate.atlassian.net/browse/HHH-14944?atlOrigin=eyJpIjoiYjliMT... ) Re: Bug: Detach entity removes NaturalIdCrossReference in shared cache too ( https://hibernate.atlassian.net/browse/HHH-14944?atlOrigin=eyJpIjoiYjliMT... ) Yes, glad to see you still around 🙂 I will take a look. ( https://hibernate.atlassian.net/browse/HHH-14944#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-14944#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:2b972a1 )

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16686) LocalTime to java.sql.Time unwrap bug.

by 하민 (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16684) Query cache with entity having enum and custom converter throws SerializerException

by Mike Zhao (JIRA)

Mike Zhao ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *updated* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiYmZlNWZlMzFl... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-16684?atlOrigin=eyJpIjoiYmZlNW... ) HHH-16684 ( https://hibernate.atlassian.net/browse/HHH-16684?atlOrigin=eyJpIjoiYmZlNW... ) Query cache with entity having enum and custom converter throws SerializerException ( https://hibernate.atlassian.net/browse/HHH-16684?atlOrigin=eyJpIjoiYmZlNW... ) Change By: Mike Zhao ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Caching query results in a spring JPA repository using query-hint, hibernate throws SerializerException when the entity involved has Enum field and a customer converter. In org.hibernate.cache.spi.QueryKey there is a field org.hibernate.transform.CacheableResultTransformer which is not transient. It seems like this field is causing the exception. ehcach.xml (note that there are far less entries than 1000 as configured) {code:xml}<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://www.ehcache.org/v3" xmlns:jsr107="http://www.ehcache.org/v3/jsr107" xsi:schemaLocation=" http://www.ehcache.org/v3 http://www.ehcache.org/schema/ehcache-core-3.0.xsd http://www.ehcache.org/v3/jsr107 http://www.ehcache.org/schema/ehcache-107-ext-3.0.xsd"> <service> <jsr107:defaults enable-management="true" enable-statistics="true"/> </service>  <cache-template name="simple"> <expiry> <none/> </expiry> <heap unit="entries">1000</heap> </cache-template> <cache alias="org.hibernate.cache.internal.StandardQueryCache" uses-template="simple"/> <cache alias="org.hibernate.cache.spi.TimestampsCache" uses-template="simple"/> </config>{code} ( https://hibernate.atlassian.net/browse/HHH-16684#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16684#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:2b972a1 )

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16684) Query cache with entity having enum and custom converter throws SerializerException

by Mike Zhao (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16639) Cannot load entity with EnumType identifier and batch size > 1

by Andrea Boriero (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HBX-2518) Update hibernate tools dependency of org.jboss.tools.hibernate.runtime.v_6_2 to version 6.2.3.Final

by Koen Aers (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16360) On Postgresql with hbm2ddl.auto=update, timestamp columns are updated even when correct

by Nils Israel (JIRA)

Nils Israel ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=712020%... ) *commented* on HHH-16360 ( https://hibernate.atlassian.net/browse/HHH-16360?atlOrigin=eyJpIjoiYTk1MD... ) Re: On Postgresql with hbm2ddl.auto=update, timestamp columns are updated even when correct ( https://hibernate.atlassian.net/browse/HHH-16360?atlOrigin=eyJpIjoiYTk1MD... ) I tried to add a custom SizeStrategy to PostgreSQLDialect and setting the Size.length according to precision. But that had to much side effects. But what about this? static boolean hasMatchingLength(Column column, ColumnInformation columnInformation, Metadata metadata, Dialect dialect) { final int actualSize = columnInformation.getColumnSize(); final int actualDecimalDigits = columnInformation.getDecimalDigits(); if (actualSize == 0 && actualDecimalDigits == 0) { return true ; } else { final Size size = column.getColumnSize(dialect, metadata); final Long requiredLength = size.getLength(); final Integer requiredPrecision = size.getPrecision(); return requiredLength != null && requiredLength == actualSize || requiredPrecision != null && requiredPrecision == actualDecimalDigits || requiredPrecision != null && requiredPrecision == actualSize // according to IEEE 754 standard: binary64 precision of 53 bit has up 17 significant decimal digits || (requiredPrecision != null && requiredPrecision == 53 && actualSize == 17) // according to IEEE 754 standard: binary32 precision of 23 bit has up 9 significant decimal digits || (requiredPrecision != null && requiredPrecision == 23 && actualSize == 9) || requiredPrecision == null && requiredLength == null ; } } ( https://hibernate.atlassian.net/browse/HHH-16360#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16360#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:2b972a1 )

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16684) Query cache with entity having enum and custom converter throws SerializerException

by Mike Zhao (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16360) On Postgresql with hbm2ddl.auto=update, timestamp columns are updated even when correct

by Gavin King (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16685) Avoid extreme cache misses on EntityPersister#implementsLifecycle()

by Sanne Grinovero (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16683) Micro optimisations for MappingMetamodelImpl.getEntityDescriptor

by Sanne Grinovero (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16532) Hibernate entity with @Any attribute throws a nullpointer exception when merging

by Marco Belladelli (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16532) Hibernate entity with @Any attribute throws a nullpointer exception when merging

by Marco Belladelli (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16532) Hibernate entity with @Any attribute throws a nullpointer exception when merging

by Marco Belladelli (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16532) Hibernate entity with @Any attribute throws a nullpointer exception when merging

by Marco Belladelli (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16360) On Postgresql with hbm2ddl.auto=update, timestamp columns are updated even when correct

by Gavin King (JIRA)

Gavin King ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-16360 ( https://hibernate.atlassian.net/browse/HHH-16360?atlOrigin=eyJpIjoiYWIyNG... ) Re: On Postgresql with hbm2ddl.auto=update, timestamp columns are updated even when correct ( https://hibernate.atlassian.net/browse/HHH-16360?atlOrigin=eyJpIjoiYWIyNG... ) Yes, indeed it looks like that’s it. What’s interesting is that h2 does give us 53 as the column size, whereas postgres gives 17 as both the size and the decimal digits. Oh and for int4 and int8 it gives us the # of decimal digits as the column size, and 0 as the number of decimal digits. Fun. ( https://hibernate.atlassian.net/browse/HHH-16360#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16360#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:2b972a1 )

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16685) Avoid extreme cache misses on EntityPersister#implementsLifecycle()

by Sanne Grinovero (JIRA)

Sanne Grinovero ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiZDg1NWMxNDYx... ) / Improvement ( https://hibernate.atlassian.net/browse/HHH-16685?atlOrigin=eyJpIjoiZDg1NW... ) HHH-16685 ( https://hibernate.atlassian.net/browse/HHH-16685?atlOrigin=eyJpIjoiZDg1NW... ) Avoid extreme cache misses on EntityPersister#implementsLifecycle() ( https://hibernate.atlassian.net/browse/HHH-16685?atlOrigin=eyJpIjoiZDg1NW... ) Issue Type: Improvement Assignee: Sanne Grinovero ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Created: 24/May/2023 03:18 AM Fix Versions: 6.2.4 Labels: performance Priority: Minor Reporter: Sanne Grinovero ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Method EntityPersister#implementsLifecycle() is responsible for an extreme amount of secondary super type cache misses. We can easily avoid this by storing the result in a constant. ( https://hibernate.atlassian.net/browse/HHH-16685#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16685#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:2b972a1 )

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16649) Hibernate.remove() doesn't work at all

by Gavin King (JIRA)

Gavin King ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-16649 ( https://hibernate.atlassian.net/browse/HHH-16649?atlOrigin=eyJpIjoiYmM5OG... ) Re: Hibernate.remove() doesn't work at all ( https://hibernate.atlassian.net/browse/HHH-16649?atlOrigin=eyJpIjoiYmM5OG... ) In fact we should just remove these methods, it turns ot that this is not something Hibernate ever supported. ( https://hibernate.atlassian.net/browse/HHH-16649#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16649#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:2b972a1 )

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16684) Query cache with entities having enums and custom converter throws SerializerException

by Mike Zhao (JIRA)

Mike Zhao ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiNTZhYmMzZDkz... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-16684?atlOrigin=eyJpIjoiNTZhYm... ) HHH-16684 ( https://hibernate.atlassian.net/browse/HHH-16684?atlOrigin=eyJpIjoiNTZhYm... ) Query cache with entities having enums and custom converter throws SerializerException ( https://hibernate.atlassian.net/browse/HHH-16684?atlOrigin=eyJpIjoiNTZhYm... ) Issue Type: Bug Affects Versions: 5.6.15 Assignee: Unassigned Components: hibernate-jcache Created: 24/May/2023 03:00 AM Environment: JDK Temurin 17.0.4, Mac OS X, Oracle 19.3.0.0, Hibernate 5.6.15.Final, Spring Boot JPA 2.7.12 Priority: Major Reporter: Mike Zhao ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Caching query results in a spring JPA repository using query-hint, hibernate throws SerializerException when the entity involved has Enum field and a customer converter. In org.hibernate.cache.spi.QueryKey there is a field org.hibernate.transform.CacheableResultTransformer which is not transient. It seems like this field is causing the exception. ehcach.xml <config xmlns:xsi = "http://www.w3.org/2001/XMLSchema-instance" xmlns= "http://www.ehcache.org/v3" xmlns:jsr107 = "http://www.ehcache.org/v3/jsr107" xsi:schemaLocation=" http://www.ehcache.org/v3 http://www.ehcache.org/schema/ehcache-core-3.0.xsd http://www.ehcache.org/v3/jsr107 http://www.ehcache.org/schema/ehcache-107-ext-3.0.xsd"> <service> <jsr107:defaults enable-management= "true" enable-statistics= "true" /> </service>  <cache-template name= "simple" > <expiry> <none/> </expiry> <heap unit= "entries" > 1000 </heap> </cache-template> <cache alias= "org.hibernate.cache.internal.StandardQueryCache" uses-template= "simple" /> <cache alias= "org.hibernate.cache.spi.TimestampsCache" uses-template= "simple" /> </config> ( https://hibernate.atlassian.net/browse/HHH-16684#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16684#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:2b972a1 )

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16629) Resolve type-pollution problems related to Techempower agent runs on Hibernate ORM 6.2.3-SNAPSHOT

by Sanne Grinovero (JIRA)

Sanne Grinovero ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-16629 ( https://hibernate.atlassian.net/browse/HHH-16629?atlOrigin=eyJpIjoiYjk5MD... ) Re: Resolve type-pollution problems related to Techempower agent runs on Hibernate ORM 6.2.3-SNAPSHOT ( https://hibernate.atlassian.net/browse/HHH-16629?atlOrigin=eyJpIjoiYjk5MD... ) And one aspect (only) of 1 is resolved by https://hibernate.atlassian.net/browse/HHH-16683 ( https://hibernate.atlassian.net/browse/HHH-16629#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16629#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:2b972a1 )

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16683) Micro optimisations for MappingMetamodelImpl.getEntityDescriptor

by Sanne Grinovero (JIRA)

Sanne Grinovero ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiNjM4ZTk4ZjNi... ) / Improvement ( https://hibernate.atlassian.net/browse/HHH-16683?atlOrigin=eyJpIjoiNjM4ZT... ) HHH-16683 ( https://hibernate.atlassian.net/browse/HHH-16683?atlOrigin=eyJpIjoiNjM4ZT... ) Micro optimisations for MappingMetamodelImpl.getEntityDescriptor ( https://hibernate.atlassian.net/browse/HHH-16683?atlOrigin=eyJpIjoiNjM4ZT... ) Issue Type: Improvement Assignee: Sanne Grinovero ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Created: 24/May/2023 02:54 AM Fix Versions: 6.2.4 Labels: performance Priority: Minor Reporter: Sanne Grinovero ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) The ConcurrentHashMap#get operations are very frequent on looking up the EntityPersister from the metamodel and are a severe cause of type pollution on the Persisters. We can avoid this with a minor inconvenience. ( https://hibernate.atlassian.net/browse/HHH-16683#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16683#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:2b972a1 )

2 years, 11 months

1
0
0 / 0

[JIRA] (HV-1949) Nondeterministic behavior of HibernateValidator (in springboot?) when both annotation and xml-based definition are used

by Marko Bekhta (JIRA)

Marko Bekhta ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HV-1949 ( https://hibernate.atlassian.net/browse/HV-1949?atlOrigin=eyJpIjoiZTQ3NGMw... ) Re: Nondeterministic behavior of HibernateValidator (in springboot?) when both annotation and xml-based definition are used ( https://hibernate.atlassian.net/browse/HV-1949?atlOrigin=eyJpIjoiZTQ3NGMw... ) Hey Martin, thanks for getting back with your experiments. I’ve looked at your various fix branches – https://github.com/alfonz19/validator-fail-mwe/compare/fixC#diff-4703104a... this one is good you only need to remove the XML files to make it work. You have correctly added a mapping here: ConstraintMapping constraintMapping = hvc.createConstraintMapping(); constraintMapping.type( mwe.validatorfail.dto.SampleDTO.class ) // instead of an XML .getter( "uuid" ) .constraint( new GenericConstraintDef<>(AnyUuid.class) ) .constraint( new NotNullDef() ); hvc.addMapping(constraintMapping); But since the XML files are still present – the constraints for mwe.validatorfail.dto.SampleDTO are coming from multiple places (including XML) and that leads to problems. So give this fixC a try and remove the validation.xml , validation-constraints.xml files. as for (3) yeah … I’ve been thinking about this one. If a constraint validator is loaded via service loader, then trying to do something about it with programmatic mappings doesn’t work since HV considers both explicit programmatic mappings and service-loaded validators as the “same programmatic definitions”. What bugs me here is that if that's so – there’s no way to override whatever comes from service loader… I’ll think about it of maybe we should change that. ( https://hibernate.atlassian.net/browse/HV-1949#add-comment?atlOrigin=eyJp... ) Add Comment ( https://hibernate.atlassian.net/browse/HV-1949#add-comment?atlOrigin=eyJp... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:2b972a1 )

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16682) Changes in @JdbcTypeCode(SqlTypes.JSON) are not written to DB

by Christian Beikov (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16682) Changes in @JdbcTypeCode(SqlTypes.JSON) are not written to DB

by Christian Thiel (JIRA)

Christian Thiel ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=712020%... ) *updated* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiNTAyNzczMWU0... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-16682?atlOrigin=eyJpIjoiNTAyNz... ) HHH-16682 ( https://hibernate.atlassian.net/browse/HHH-16682?atlOrigin=eyJpIjoiNTAyNz... ) Changes in @JdbcTypeCode(SqlTypes.JSON) are not written to DB ( https://hibernate.atlassian.net/browse/HHH-16682?atlOrigin=eyJpIjoiNTAyNz... ) Change By: Christian Thiel ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=712020%... ) I have a JSON-Mapping in my entity {code:java}@Entity public class MyEntity { @Id private Long id; @JdbcTypeCode(SqlTypes.JSON) private MyJson jsonProperty; private String info; }{code} MyJson is a simple POJO: {code:java}@Embeddable public class MyJson { private String stringProp; private Long longProp; }{code} If i change only the jsonProperty, it seems the entity is _not marked dirty_ → changes are not written to the DB. If i change any other field-value to , too (in my test-case the String-field _info_), the entity is marked dirty and all changes are written to DB, even the JSON-changes. (see _MyEntityTest.java_ in attached Test-project): {code:java}@QuarkusTest @Transactional(Transactional.TxType.REQUIRES_NEW) class MyEntityTest { @Inject EntityManager em; static final long PK = 123L; static final String CHANGED = "CHANGED"; @Test void shouldCreateUpdateAndSelectMyEntity() throws Exception { insert(); findAndUpdate(); selectFiltered(); } void insert() { MyEntity myEntity = new MyEntity(); myEntity.setId(PK); MyJson myJson = new MyJson(); myJson.setLongProp(100L); myJson.setStringProp("Hello"); myEntity.setJsonProperty(myJson); em.persist(myEntity); } void findAndUpdate() { MyEntity found = em.find(MyEntity.class, PK); found.getJsonProperty().setStringProp(CHANGED); // found.setInfo(CHANGED); // by changing any other property of the entity, it will be marked as dirty and EVERY change will be written to the DB } void selectFiltered() { List<MyEntity> result = em .createQuery("SELECT e FROM MyEntity e WHERE e.jsonProperty.longProp = :x", MyEntity.class) .setParameter("x", 100L) .getResultList(); assertEquals(1, result.size()); assertEquals(CHANGED, result.get(0).getJsonProperty().getStringProp(), "json property not changed"); assertEquals(CHANGED, result.get(0).getInfo(), "plain property not changed"); } }{code} see [https://discourse.hibernate.org/t/changes-in-jsonb-field-do-not-mark-enti...] ( https://hibernate.atlassian.net/browse/HHH-16682#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16682#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:2b972a1 )

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16543) Attribute from MappedSuperClass can't be resolved if number of subclasses is greater than 2

by Marco Belladelli (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16543) Attribute from MappedSuperClass can't be resolved if number of subclasses is greater than 2

by Marco Belladelli (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16543) Attribute from MappedSuperClass can't be resolved if number of subclasses is greater than 2

by Marco Belladelli (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16543) Attribute from MappedSuperClass can't be resolved if number of subclasses is greater than 2

by Marco Belladelli (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16594) Query cache miss when query contains multiple parameters

by Marco Belladelli (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16682) Changes in @JdbcTypeCode(SqlTypes.JSON) are not written to DB

by Christian Thiel (JIRA)

Christian Thiel ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=712020%... ) *updated* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiNTQ5Mjk3ZmZk... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-16682?atlOrigin=eyJpIjoiNTQ5Mj... ) HHH-16682 ( https://hibernate.atlassian.net/browse/HHH-16682?atlOrigin=eyJpIjoiNTQ5Mj... ) Changes in @JdbcTypeCode(SqlTypes.JSON) are not written to DB ( https://hibernate.atlassian.net/browse/HHH-16682?atlOrigin=eyJpIjoiNTQ5Mj... ) Change By: Christian Thiel ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=712020%... ) I have a JSON-Mapping in my entity {code:java}@Entity public class MyEntity { @Id private Long id; @JdbcTypeCode(SqlTypes.JSON) private MyJson jsonProperty; private String info; }{code} MyJson is a simple POJO: {code:java}@Embeddable public class MyJson { private String stringProp; private Long longProp; }{code} If i change only the jsonProperty, it seems the entity is _not marked dirty_ → changes are not written to the DB. If i change any other field-value to (in my test-case the String-field _info_), the entity is marked dirty and all changes are written to DB, even the JSON-changes. (see _MyEntityTest.java_ in attached Test-project): {code:java}@QuarkusTest @Transactional(Transactional.TxType.REQUIRES_NEW) class MyEntityTest { @Inject EntityManager em; static final long PK = 123L; static final String CHANGED = "CHANGED"; @Test void shouldCreateUpdateAndSelectMyEntity() throws Exception { insert(); findAndUpdate(); selectFiltered(); } void insert() { MyEntity myEntity = new MyEntity(); myEntity.setId(PK); MyJson myJson = new MyJson(); myJson.setLongProp(100L); myJson.setStringProp("Hello"); myEntity.setJsonProperty(myJson); em.persist(myEntity); } void findAndUpdate() { MyEntity found = em.find(MyEntity.class, PK); found.getJsonProperty().setStringProp(CHANGED); // found.setInfo(CHANGED); // by changing any other property of the entity, it will be marked as dirty and EVERY change will be written to the DB } void selectFiltered() { List<MyEntity> result = em .createQuery("SELECT e FROM MyEntity e WHERE e.jsonProperty.longProp = :x", MyEntity.class) .setParameter("x", 100L) .getResultList(); assertEquals(1, result.size()); assertEquals(CHANGED, result.get(0).getJsonProperty().getStringProp(), "json property not changed"); assertEquals(CHANGED, result.get(0).getInfo(), "plain property not changed"); } }{code} see [https://discourse.hibernate.org/t/changes-in-jsonb-field-do-not-mark-enti...] ( https://hibernate.atlassian.net/browse/HHH-16682#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16682#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:2b972a1 )

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16360) On Postgresql with hbm2ddl.auto=update, timestamp columns are updated even when correct

by Nils Israel (JIRA)

Nils Israel ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=712020%... ) *commented* on HHH-16360 ( https://hibernate.atlassian.net/browse/HHH-16360?atlOrigin=eyJpIjoiZGNiNW... ) Re: On Postgresql with hbm2ddl.auto=update, timestamp columns are updated even when correct ( https://hibernate.atlassian.net/browse/HHH-16360?atlOrigin=eyJpIjoiZGNiNW... ) Is this possibly where the problem lies? from org.hibernate.dialect.Dialect.SizeStrategyImpl.resolveSize(…) So that the 17 are the DecimalDigits (Base10) and 53 the preicision is the BinaryDigits (Base2)? static boolean hasMatchingLength(Column column, ColumnInformation columnInformation, Metadata metadata, Dialect dialect) { final int actualSize = columnInformation.getColumnSize(); // 17 final int actualDecimalDigits = columnInformation.getDecimalDigits(); // 17 if (actualSize == 0 && actualDecimalDigits == 0) { return true ; } else { final Size size = column.getColumnSize(dialect, metadata); final Long requiredLength = size.getLength(); final Integer requiredPrecision = size.getPrecision(); // 53 final Integer requiredDecimalDigits = size.getPrecision() != null ? ( int ) ceil(size.getPrecision() * log(2) / log(10)) : null ; // 16 return requiredLength != null && requiredLength == actualSize || requiredPrecision != null && requiredPrecision == actualDecimalDigits || requiredPrecision != null && requiredPrecision == actualSize || requiredDecimalDigits != null && requiredDecimalDigits == actualDecimalDigits // 16 != 17 || requiredDecimalDigits != null && requiredDecimalDigits == actualSize // 16 != 17 || requiredPrecision == null && requiredLength == null ; } } Unfortunateley this isn’t working either. Since converting to Base10 leads to 16 digits. And the doc only talks about “at least 15”: https://www.postgresql.org/docs/current/datatype-numeric.html#DATATYPE-FLOAT ( https://hibernate.atlassian.net/browse/HHH-16360#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16360#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:2b972a1 )

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16682) Changes in @JdbcTypeCode(SqlTypes.JSON) are not written to DB

by Christian Thiel (JIRA)

Christian Thiel ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=712020%... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiZDk5ZDdlNTI5... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-16682?atlOrigin=eyJpIjoiZDk5ZD... ) HHH-16682 ( https://hibernate.atlassian.net/browse/HHH-16682?atlOrigin=eyJpIjoiZDk5ZD... ) Changes in @JdbcTypeCode(SqlTypes.JSON) are not written to DB ( https://hibernate.atlassian.net/browse/HHH-16682?atlOrigin=eyJpIjoiZDk5ZD... ) Issue Type: Bug Affects Versions: 6.2.1, 6.2.3 Assignee: Unassigned Attachments: code-with-quarkus.zip Components: hibernate-core Created: 24/May/2023 01:51 AM Environment: Quarkus 3.0.3 (integrates hibernate-orm 6.2.1-final) Quarkus 3 SNAPHSOT with hibernate-orm 6.2.3 (see https://github.com/Sanne/quarkus/tree/ORM6) Priority: Major Reporter: Christian Thiel ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=712020%... ) I have a JSON-Mapping in my entity @Entity public class MyEntity { @Id private Long id; @JdbcTypeCode(SqlTypes.JSON) private MyJson jsonProperty; private String info; } MyJson is a simple POJO: @Embeddable public class MyJson { private String stringProp; private Long longProp; } If i change only the jsonProperty, it seems the entity is not marked dirty → changes are not written to the DB. If i change any other field-value to (in my test-case the String-field info ), the entity is marked dirty and all changes are written to DB, even the JSON-changes. (see MyEntityTest.java in attached Test-project): @QuarkusTest @Transactional(Transactional.TxType.REQUIRES_NEW) class MyEntityTest { @Inject EntityManager em; static final long PK = 123L; static final String CHANGED = "CHANGED" ; @Test void shouldCreateUpdateAndSelectMyEntity() throws Exception { insert(); findAndUpdate(); selectFiltered(); } void insert() { MyEntity myEntity = new MyEntity(); myEntity.setId(PK); MyJson myJson = new MyJson(); myJson.setLongProp(100L); myJson.setStringProp( "Hello" ); myEntity.setJsonProperty(myJson); em.persist(myEntity); } void findAndUpdate() { MyEntity found = em.find(MyEntity.class, PK); found.getJsonProperty().setStringProp(CHANGED); // found.setInfo(CHANGED); // by changing any other property of the entity, it will be marked as dirty and EVERY change will be written to the DB } void selectFiltered() { List<MyEntity> result = em .createQuery( "SELECT e FROM MyEntity e WHERE e.jsonProperty.longProp = :x" , MyEntity.class) .setParameter( "x" , 100L) .getResultList(); assertEquals(1, result.size()); assertEquals(CHANGED, result.get(0).getJsonProperty().getStringProp(), "json property not changed" ); assertEquals(CHANGED, result.get(0).getInfo(), "plain property not changed" ); } } ( https://hibernate.atlassian.net/browse/HHH-16682#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16682#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:2b972a1 )

2 years, 11 months

1
0
0 / 0

[JIRA] (HV-1949) Nondeterministic behavior of HibernateValidator (in springboot?) when both annotation and xml-based definition are used

by martin mucha (JIRA)

martin mucha ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=70121%3... ) *commented* on HV-1949 ( https://hibernate.atlassian.net/browse/HV-1949?atlOrigin=eyJpIjoiOGFhZTg3... ) Re: Nondeterministic behavior of HibernateValidator (in springboot?) when both annotation and xml-based definition are used ( https://hibernate.atlassian.net/browse/HV-1949?atlOrigin=eyJpIjoiOGFhZTg3... ) So far I have no luck with this. * When I attempt quick fix with touching ConstraintValidator during startup to be initialized on working path it works, but ONLY for that specific validator. So in order for this to work I’d need to correctly know all available validators across whole module tree discoverable via ServiceLoader, make fake class to init them all, and hope everyone who will potentially adds new validator in future anywhere will know about this, and will also update my workaround. Maybe for me and my <20 validators and theoretically full control over everything it’s doable, but generally not viable soluion. 2. Then I tried to used programmatic validators definition(validators on fields/properties instead of xml declaration) while still using service loader to declare custom ConstraintValidator. Won’t work (new to programmatic approach) as ServiceLoader declaration does not apply for programmatic ConstraintValidator definition. So this is also dead end. 3. Then I tried both programmatic validators definition(instead of xml) and programmatic validators declaration. And this one does not work either. Since we do have the validators implemented in library which already uses ServiceLoader, which is used by several apps. So again, maybe it’s somehow doable, but generally no, we cannot make the ServiceLoader file go away, it is used already in public library, I cannot easily replace it. So what I did here, that I read ServiceLoader file myself and fed it into programmatic declaration of pairing, to make sure it’s there when needed. Which is this beauty: @Beanpublic static LocalValidatorFactoryBean defaultValidator(ApplicationContext applicationContext) { LocalValidatorFactoryBean factoryBean = new LocalValidatorFactoryBean() { @Override protected void postProcessConfiguration(javax.validation.Configuration<?> configuration) { super.postProcessConfiguration(configuration); if (configuration instanceof HibernateValidatorConfiguration hvc) { ConstraintMapping constraintMapping = hvc.createConstraintMapping(); ServiceLoader.load(ConstraintValidator.class).forEach(cv->{ Arrays.stream(cv.getClass().getGenericInterfaces()) .filter(e -> e instanceof ParameterizedType) .map(e -> (ParameterizedType) e) .filter(e -> e.getRawType().equals(ConstraintValidator.class)) .map(ParameterizedType::getActualTypeArguments) .forEach(aa -> { Type annotationType = aa[0]; Class annotationClass = (Class<?>) annotationType; Class constraintValidatorClass = cv.getClass(); System.out.println(String.format("registering %s", constraintValidatorClass)); registerConstraint(constraintMapping, annotationClass, constraintValidatorClass); System.out.println(String.format("%s registered", constraintValidatorClass)); }); }); //registering instead of xml constraintMapping.type( mwe.validatorfail.dto.SampleDTO.class ) .getter( "uuid" ) .constraint( new GenericConstraintDef<>(AnyUuid.class) ) .constraint( new NotNullDef() ); hvc.addMapping(constraintMapping); } else { throw new IllegalStateException("Should not happen, we explicitly depend on HibernateValidator ValidationProvider"); } } }; factoryBean.setProviderClass(HibernateValidator.class); MessageInterpolatorFactory interpolatorFactory = new MessageInterpolatorFactory(applicationContext); factoryBean.setMessageInterpolator(interpolatorFactory.getObject()); return factoryBean; } public static <A extends Annotation> void registerConstraint(ConstraintMapping constraintMapping, Class<A> annotation, Class<? extends ConstraintValidator<A, ?>> validator) { constraintMapping.constraintDefinition(annotation) .includeExistingValidators(false) .validatedBy(validator); } which will produce this error on startup: Caused by: javax.validation.ValidationException: HV000193: mwe.validatorfail.validation.AnyUuid is configured more than once via the programmatic constraint definition API. Which is kinda funny. This code registers AnyUuid ONLY ONCE. So if this code does not run, validator for AnyUuid does not exist, if it does run it creates duplicity. Which means, that HibernateValidator after initialization is in ambivalent state, where it does have and does not have validator declared at the same time. So unless I’m doing something wrong, this is not a viable workaround either, since ServiceLoader and manual registration of validators cannot coexist. For me it might be doable, since I theoretically have full control over all apps using given library and can rewrite everything to avoid wrong parts of HibernateValidator, but generally it’s not viable workaround. Is there a another way, how we can keep ServiceLoader in place (we might not be able to rewrite public libraries depending on it) and somehow add non-annotation-based validations, which will work with validators defined in ServiceLoader? What is motivation behind it: we want to use annotation where possible, but some sources, like generated stubs, does not allow us (without nasty tricks which even might not be available everytime) to add annotation. ( https://hibernate.atlassian.net/browse/HV-1949#add-comment?atlOrigin=eyJp... ) Add Comment ( https://hibernate.atlassian.net/browse/HV-1949#add-comment?atlOrigin=eyJp... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:2b972a1 )

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16681) Can't disable global temporary table creation

by Thomas B. (JIRA)

Thomas B. ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=6099013... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiOTlkNmM4ZjBl... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-16681?atlOrigin=eyJpIjoiOTlkNm... ) HHH-16681 ( https://hibernate.atlassian.net/browse/HHH-16681?atlOrigin=eyJpIjoiOTlkNm... ) Can't disable global temporary table creation ( https://hibernate.atlassian.net/browse/HHH-16681?atlOrigin=eyJpIjoiOTlkNm... ) Issue Type: Bug Affects Versions: 6.1.7 Assignee: Unassigned Components: hibernate-core Created: 24/May/2023 01:04 AM Environment: Hibernate 6.1.7.Final Spring Boot 3.0.6 Priority: Major Reporter: Thomas B. ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=6099013... ) Hibernate creates temporary tables for bulk operations. We're using Oracle ( v19.0.0.0.0 ) and our user won't have the privilege to create temporary table. I've tried a lot of different configurations, but HTE_ tables are still created at startup : 09:07:43.658 INFO [com.zaxxer.hikari.HikariDataSource ] HikariPool-1 - Starting... 09:07:44.285 INFO [com.zaxxer.hikari.pool.HikariPool ] HikariPool-1 - Added connection oracle.jdbc.driver.T4CConnection@6dc5e857 09:07:44.286 INFO [com.zaxxer.hikari.HikariDataSource ] HikariPool-1 - Start completed. 09:07:44.596 INFO [SQL dialect ] HHH000400: Using dialect: org.hibernate.dialect.Oracle12cDialect Hibernate: create global temporary table HTE_xxxxx(...) on commit delete rows Hibernate: create global temporary table HTE_yyyyy(...) on commit delete rows 09:07:45.551 INFO [j.LocalContainerEntityManagerFactoryBean] Initialized JPA EntityManagerFactory for persistence unit 'default' Here is the properties I’ve tried : spring.jpa.properties.hibernate.query.mutation_strategy=org.hibernate.query.sqm.mutation.internal.inline.InlineMutationStrategy spring.jpa.properties.hibernate.hql.bulk_id_strategy.persistent.create_tables=false spring.jpa.properties.hibernate.hql.bulk_id_strategy.persistent.drop_tables=false spring.jpa.properties.hibernate.hql.bulk_id_strategy.global_temporary.create_tables=false spring.jpa.properties.hibernate.hql.bulk_id_strategy.global_temporary.drop_tables=false I can’t find a spring.jpa.properties.hibernate.query.insert_strategy that is working because it gives me an exception : Cannot instantiate the class [org.hibernate.query.sqm.mutation.internal.temptable.LocalTemporaryTableMutationStrategy] because it does not have a constructor that accepts a dialect or an empty constructor I didn’t find anything more to try, according to the documentation : https://docs.jboss.org/hibernate/orm/6.1/userguide/html_single/Hibernate_... I also tried to find some help on StackOverflow ( https://stackoverflow.com/questions/76312361/hibernate-6-1-x-spring-boot-... ) , without succcess. ( https://hibernate.atlassian.net/browse/HHH-16681#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16681#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:2b972a1 )

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16680) Treat of correlated alias generates broken SQL

by Christian Beikov (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16360) On Postgresql with hbm2ddl.auto=update, timestamp columns are updated even when correct

by Nils Israel (JIRA)

Nils Israel ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=712020%... ) *commented* on HHH-16360 ( https://hibernate.atlassian.net/browse/HHH-16360?atlOrigin=eyJpIjoiYTZlMm... ) Re: On Postgresql with hbm2ddl.auto=update, timestamp columns are updated even when correct ( https://hibernate.atlassian.net/browse/HHH-16360?atlOrigin=eyJpIjoiYTZlMm... ) This works for Date but not for Double static boolean hasMatchingLength(Column column, ColumnInformation columnInformation, Metadata metadata, Dialect dialect) { final int actualSize = columnInformation.getColumnSize(); // 17 final int actualDecimalDigits = columnInformation.getDecimalDigits(); // 17 if ( actualSize == 0 && actualDecimalDigits == 0 ) { return true; } else { final Size size = column.getColumnSize( dialect, metadata ); final Long requiredLength = size.getLength(); // null final Integer requiredPrecision = size.getPrecision(); // 53 return requiredLength != null && requiredLength == actualSize || requiredPrecision != null && requiredPrecision == actualDecimalDigits // actualDecimalDigits = 17 || requiredPrecision != null && requiredPrecision == actualSize // actualSize = 17, requiredPrecision = 53 || requiredPrecision == null && requiredLength == null; } } ( https://hibernate.atlassian.net/browse/HHH-16360#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16360#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:2b972a1 )

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16680) Treat of correlated alias generates broken SQL

by Christian Beikov (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16680) Treat of correlated alias generates broken SQL

by Christian Beikov (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16585) In hibernate 6 a EnumType is returned as an ordinal instead of the actual enum type

by Christian Beikov (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16584) @JoinTable @ManyToOne should have a unique constraint on association table

by Christian Beikov (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16583) @JoinTable @ManyToOne blows up if no table name is explicitly specified

by Christian Beikov (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-12145) Example criteria doesn't include Id-Fields

by Christian Beikov (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16523) hibernate.cache.use_minimal_puts appears to be missing from H6

by Christian Beikov (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16610) Sequence ID generation increment size global setting

by Christian Beikov (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-15705) Properly document requirements for building Hibernate in the README

by Christian Beikov (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-14944) Bug: Detach entity removes NaturalIdCrossReference in shared cache too

by Christian Beikov (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16619) associations on fields beginning with underscore

by Christian Beikov (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16565) ClassCastException when batch fetch and 2nd level cache are enabled for polymorphic entities

by Marco Belladelli (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16619) associations on fields beginning with underscore

by Christian Beikov (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16649) Hibernate.remove() doesn't work at all

by Christian Beikov (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-4048) Phase 2 - implement rest of strategies

by Christian Beikov (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-3414) fetch profiles

by Christian Beikov (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HBX-2390) Create a JBoss Tools adaptation layer

by Koen Aers (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16654) auto-addition of joins to queries for EAGER to-one associations

by Christian Beikov (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HBX-2134) Resolve test errors/failures for Oracle

by Koen Aers (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HBX-2127) Resolve test errors/failures for MySQL

by Koen Aers (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HBX-2073) Investigate and reenable failing test 'org.hibernate.tool.hbm2x.hbm2hbmxml.FormulaTest.TestCase#testReadable()'

by Koen Aers (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HBX-1413) Fix the identity detection in SQLServerMetaDataDialect

by Koen Aers (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HBX-2064) Investigate class 'org.hibernate.tool.ide.completion.HQLAnalyzer' to fix the failing test 'org.hibernate.tool.ide.completion.HqlAnalyzer.TestCase. testShouldShowTables()'

by Koen Aers (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HBX-1412) Implement identity detection in the OracleMetaDataDialect

by Koen Aers (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HBX-1404) Guard against connection leaks

by Koen Aers (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HBX-1399) Investigate how to make org.hibernate.tool.hbm2x.DefaultSchemaCatalog.TestCase run on MySQL

by Koen Aers (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HBX-1349) Implement HBM to JPA annotation generation

by Koen Aers (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HBX-1225) Proxy class should be used for referring property declaration

by Koen Aers (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HBX-1179) <one-to-one> should not generate Sets

by Koen Aers (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HBX-2517) Update version identifier to 6.2.3.Final

by Koen Aers (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16645) XxxxLoadAccess and EntityGraphs

by Christian Beikov (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16645) XxxxLoadAccess and EntityGraphs

by Christian Beikov (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HBX-2516) Update Hibernate ORM Dependency to Version 6.2.3.Final

by Koen Aers (JIRA)

2 years, 11 months

1
0
0 / 0

[JIRA] (HHH-16360) On Postgresql with hbm2ddl.auto=update, timestamp columns are updated even when correct

by Gavin King (JIRA)

Gavin King ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-16360 ( https://hibernate.atlassian.net/browse/HHH-16360?atlOrigin=eyJpIjoiYWE0MD... ) Re: On Postgresql with hbm2ddl.auto=update, timestamp columns are updated even when correct ( https://hibernate.atlassian.net/browse/HHH-16360?atlOrigin=eyJpIjoiYWE0MD... ) So it looks like this works: static boolean hasMatchingLength(Column column, ColumnInformation columnInformation, Metadata metadata, Dialect dialect) { final int actualSize = columnInformation.getColumnSize(); final int actualDecimalDigits = columnInformation.getDecimalDigits(); if ( actualSize == 0 && actualDecimalDigits == 0 ) { return true ; } else { final Size size = column.getColumnSize( dialect, metadata ); final Long requiredLength = size.getLength(); final Integer requiredPrecision = size.getPrecision(); return requiredLength != null && requiredLength == actualSize || requiredPrecision != null && requiredPrecision == actualDecimalDigits || requiredPrecision != null && requiredPrecision == actualSize || requiredPrecision == null && requiredLength == null ; } } It’s a bit strange that the precision of a double is returned as a length, and the precision of a timestamp is returned as decimal digits, but whatever. ( https://hibernate.atlassian.net/browse/HHH-16360#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16360#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100225- sha1:2b972a1 )

2 years, 11 months