May 2023 - hibernate-issues - Jboss List Archives

[JIRA] (HHH-16542) (Jakarta EE 10 Platform TCK) jpa/core/entitytest/cascadeall/oneXone/cascadeAll1X1Test10 test regression

by Andrea Boriero (JIRA)

Andrea Boriero ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-16542 ( https://hibernate.atlassian.net/browse/HHH-16542?atlOrigin=eyJpIjoiMzQ4Nz... ) Re: (Jakarta EE 10 Platform TCK) jpa/core/entitytest/cascadeall/oneXone/cascadeAll1X1Test10 test regression ( https://hibernate.atlassian.net/browse/HHH-16542?atlOrigin=eyJpIjoiMzQ4Nz... ) I may be wrong but I think it is Hibernate specific and probably the reason is to decide which method to enhance. ( https://hibernate.atlassian.net/browse/HHH-16542#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16542#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100224- sha1:4684446 )

2 years, 7 months

1
0
0 / 0

[JIRA] (HHH-16542) (Jakarta EE 10 Platform TCK) jpa/core/entitytest/cascadeall/oneXone/cascadeAll1X1Test10 test regression

by Scott Marlow (JIRA)

Scott Marlow ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-16542 ( https://hibernate.atlassian.net/browse/HHH-16542?atlOrigin=eyJpIjoiNDVlM2... ) Re: (Jakarta EE 10 Platform TCK) jpa/core/entitytest/cascadeall/oneXone/cascadeAll1X1Test10 test regression ( https://hibernate.atlassian.net/browse/HHH-16542?atlOrigin=eyJpIjoiNDVlM2... ) private static void checkGetAndIsVariants( Class containerClass, String propertyName, Method getMethod, Method isMethod) { // Check the return types. If they are the same, its ok. If they are different // we are in a situation where we could not reasonably know which to use. if ( !isMethod.getReturnType().equals( getMethod.getReturnType() ) ) { throw new MappingException( String.format( Locale.ROOT, "In trying to locate getter for property [%s], Class [%s] defined " + "both a `get` [%s] and `is` [%s] variant", propertyName, containerClass.getName(), getMethod.toString(), isMethod.toString() ) ); } } Mentioned ReflectHelper code is ^ and error is: org.hibernate.MappingException: In trying to locate getter for property [b1] , Class [com.sun.ts.tests.jpa.core.entitytest.cascadeall.oneXone.A] defined both a get [public com.sun.ts.tests.jpa.core.entitytest.cascadeall.oneXone.B com.sun.ts.tests.jpa.core.entitytest.cascadeall.oneXone.A.getB1()] and is [public boolean com.sun.ts.tests.jpa.core.entitytest.cascadeall.oneXone.A.isB1()] variant The offending TCK source code is: @OneToOne(targetEntity = com.sun.ts.tests.jpa.core.entitytest.cascadeall.oneXone.B.class, mappedBy = "a1", orphanRemoval = true) protected B b1; public B getB1() { return b1; } public boolean isB1() { TestUtil.logTrace("isB1"); if (getB1() != null) TestUtil.logTrace("Relationship to B is not null..."); else TestUtil.logTrace("Relationship for B is null ..."); return getB1() != null; } Apologies for pasting all of the above but it helps me to see it all together as one comment. 🙂 From the above pasted code + error, I think the test would pass if both methods returned either B or boolean but is that only a Hibernate requirement or is that also Persistence Specification requirement? Could ReflectHelper be enhanced to handle ^ differently in JPA_COMPLIANCE mode? ( https://hibernate.atlassian.net/browse/HHH-16542#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16542#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100224- sha1:4684446 )

2 years, 7 months

1
0
0 / 0

[JIRA] (HBX-2453) Implement and use the generic adapter for ISchemaExport in the experimental Hibernate runtime

by Koen Aers (JIRA)

2 years, 7 months

1
0
0 / 0

[JIRA] (HHH-16546) Reduce verbosity of logs in a few edge cases

by Yoann Rodière (JIRA)

Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-16546 ( https://hibernate.atlassian.net/browse/HHH-16546?atlOrigin=eyJpIjoiY2MxNW... ) Re: Reduce verbosity of logs in a few edge cases ( https://hibernate.atlassian.net/browse/HHH-16546?atlOrigin=eyJpIjoiY2MxNW... ) Note I went through the whole CoreMessageLogger class and found only those two that were both used and too noisy, but there are a few different problems that we might also want to address (in a different issue): * some logs are no longer used: we could remove the methods or at least deprecate them * some logs are only used in deprecated classes (e.g. in org.hibernate.tool.hbm2ddl.TableMetadata ): we should deprecate them so that we can remove them when we remove that deprecated class. * some logs report failures but are marked as INFO… I’m pretty sure at least some of those should be WARN instead of INFO. ( https://hibernate.atlassian.net/browse/HHH-16546#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16546#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100224- sha1:4684446 )

2 years, 7 months

1
0
0 / 0

[JIRA] (HHH-16541) (Jakarta EE 10 Platform TCK) jpa/core/lock/query/Client.java#getResultListTest1 test regression

by Scott Marlow (JIRA)

Scott Marlow ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-16541 ( https://hibernate.atlassian.net/browse/HHH-16541?atlOrigin=eyJpIjoiZDc4Nz... ) Re: (Jakarta EE 10 Platform TCK) jpa/core/lock/query/Client.java#getResultListTest1 test regression ( https://hibernate.atlassian.net/browse/HHH-16541?atlOrigin=eyJpIjoiZDc4Nz... ) Agreed that we don’t have it reproduced in the Hibernate ORM test suite. ( https://hibernate.atlassian.net/browse/HHH-16541#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16541#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100224- sha1:4684446 )

2 years, 7 months

1
0
0 / 0

[JIRA] (HHH-16542) (Jakarta EE 10 Platform TCK) jpa/core/entitytest/cascadeall/oneXone/cascadeAll1X1Test10 test regression

by Andrea Boriero (JIRA)

Andrea Boriero ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-16542 ( https://hibernate.atlassian.net/browse/HHH-16542?atlOrigin=eyJpIjoiZTJmZG... ) Re: (Jakarta EE 10 Platform TCK) jpa/core/entitytest/cascadeall/oneXone/cascadeAll1X1Test10 test regression ( https://hibernate.atlassian.net/browse/HHH-16542?atlOrigin=eyJpIjoiZTJmZG... ) this is the test I used import org.hibernate.testing.bytecode.enhancement.BytecodeEnhancerRunner; import org.hibernate.testing.bytecode.enhancement.EnhancementOptions; import org.hibernate.testing.junit4.BaseCoreFunctionalTestCase; import org.junit.Test; import org.junit.runner.RunWith; import jakarta.persistence.Basic; import jakarta.persistence.CascadeType; import jakarta.persistence.Entity; import jakarta.persistence.Id; import jakarta.persistence.JoinColumn; import jakarta.persistence.OneToOne; import jakarta.persistence.Table; @RunWith(BytecodeEnhancerRunner.class) @EnhancementOptions(inlineDirtyChecking = true, lazyLoading = true, extendedEnhancement = true) public class TestIt extends BaseCoreFunctionalTestCase { @Override protected Class<?>[] getAnnotatedClasses() { return new Class[]{ A.class, B.class }; } @Test public void testIt(){ inTransaction( entityManager -> { } ); } @Entity @Table(name = "AEJB_1X1_BI_BTOB") public class A implements java.io.Serializable { // =========================================================== // instance variables @Id protected String id; @Basic protected String name; @Basic protected int value; // =========================================================== // constructors public A() { } public A(String id, String name, int value) { this.id = id; this.name = name; this.value = value; } public A(String id, String name, int value, B b1) { this.id = id; this.name = name; this.value = value; this.b1 = b1; } // =========================================================== // relationship fields @OneToOne(targetEntity = B.class, mappedBy = "a1", orphanRemoval = true) protected B b1; // ======================================================================= // Business methods for test cases public B getB1() { return b1; } public boolean isB1() { return getB1() != null; } public B getB1Info() { if (isB1()) { B b1 = getB1(); return b1; } else return null; } public String getAId() { return id; } public String getAName() { return name; } public int getAValue() { return value; } } @Entity @Table(name = "BEJB_1X1_BI_BTOB") public class B implements java.io.Serializable { // =========================================================== // instance variables @Id protected String id; @Basic protected String name; @Basic protected int value; // =========================================================== // relationship fields @OneToOne(targetEntity = A.class, cascade = CascadeType.ALL, optional = true, orphanRemoval = true) @JoinColumn(name = "FK_FOR_AEJB_1X1_BI_BTOB") protected A a1; // =========================================================== // constructors public B() { } public B(String id, String name, int value) { this.id = id; this.name = name; this.value = value; } public B(String id, String name, int value, A a1) { this.id = id; this.name = name; this.value = value; this.a1 = a1; } // ========================================================== // Business Methods for Test Cases public A getA1() { return a1; } public void setA1(A a1) { this.a1 = a1; } public boolean isA() { return getA1() != null; } public A getA1Info() { if (isA()) { A a1 = getA1(); return a1; } else return null; } public String getBId() { return id; } public String getBName() { return name; } public void setBName(String name) { this.name = name; } public int getBValue() { return value; } } } but as I said I think the exception is the expected behaviour with bytecode enhancement, see https://github.com/hibernate/hibernate-orm/blob/main/hibernate-core/src/m... ( https://hibernate.atlassian.net/browse/HHH-16542#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16542#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100224- sha1:4684446 )

2 years, 7 months

1
0
0 / 0

[JIRA] (HHH-16544) nested tables on Oracle

by Gavin King (JIRA)

Gavin King ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-16544 ( https://hibernate.atlassian.net/browse/HHH-16544?atlOrigin=eyJpIjoiN2I5ND... ) Re: nested tables on Oracle ( https://hibernate.atlassian.net/browse/HHH-16544?atlOrigin=eyJpIjoiN2I5ND... ) Done. ( https://hibernate.atlassian.net/browse/HHH-16544#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16544#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100224- sha1:4684446 )

2 years, 7 months

1
0
0 / 0

[JIRA] (HHH-16547) New `hibernate.jpa.compliance.delete` setting

by Steve Ebersole (JIRA)

Steve Ebersole ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiNWY2MzY4NDdm... ) / Improvement ( https://hibernate.atlassian.net/browse/HHH-16547?atlOrigin=eyJpIjoiNWY2Mz... ) HHH-16547 ( https://hibernate.atlassian.net/browse/HHH-16547?atlOrigin=eyJpIjoiNWY2Mz... ) New `hibernate.jpa.compliance.delete` setting ( https://hibernate.atlassian.net/browse/HHH-16547?atlOrigin=eyJpIjoiNWY2Mz... ) Issue Type: Improvement Assignee: Unassigned Created: 03/May/2023 06:22 AM Priority: Major Reporter: Steve Ebersole ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Add a new setting hibernate.jpa.compliance.delete which controls how to handle deletion / removal of a detached entity. While Hibernate allows this, JPA says it is illegal. ( https://hibernate.atlassian.net/browse/HHH-16547#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16547#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100224- sha1:4684446 )

2 years, 7 months

1
0
0 / 0

[JIRA] (HHH-16542) (Jakarta EE 10 Platform TCK) jpa/core/entitytest/cascadeall/oneXone/cascadeAll1X1Test10 test regression

by Scott Marlow (JIRA)

Scott Marlow ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-16542 ( https://hibernate.atlassian.net/browse/HHH-16542?atlOrigin=eyJpIjoiODk0Mm... ) Re: (Jakarta EE 10 Platform TCK) jpa/core/entitytest/cascadeall/oneXone/cascadeAll1X1Test10 test regression ( https://hibernate.atlassian.net/browse/HHH-16542?atlOrigin=eyJpIjoiODk0Mm... ) Andrea Boriero ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) did you examine the updated bytecode? If not, would it help if I hack something together to obtain the enhanced bytecode for the test class (I think https://github.com/jakartaee/platform-tck/blob/master/src/com/sun/ts/test... )? ( https://hibernate.atlassian.net/browse/HHH-16542#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16542#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100224- sha1:4684446 )

2 years, 7 months

1
0
0 / 0

[JIRA] (HHH-16541) (Jakarta EE 10 Platform TCK) jpa/core/lock/query/Client.java#getResultListTest1 test regression

by Steve Ebersole (JIRA)

Steve Ebersole ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-16541 ( https://hibernate.atlassian.net/browse/HHH-16541?atlOrigin=eyJpIjoiODFiOW... ) Re: (Jakarta EE 10 Platform TCK) jpa/core/lock/query/Client.java#getResultListTest1 test regression ( https://hibernate.atlassian.net/browse/HHH-16541?atlOrigin=eyJpIjoiODFiOW... ) To be clear, I was never able to reproduce this in vanilla ORM. I made the change we discussed and you verified, but regression testing is still missing since I could not reproduce. ( https://hibernate.atlassian.net/browse/HHH-16541#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16541#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100224- sha1:4684446 )

2 years, 7 months

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues May 2023