June 2023 - hibernate-issues - Jboss List Archives

[JIRA] (HHH-16545) PersistenceUtilHelper.MetadataCache is not Thread-Safe

by Shenglei Yang (JIRA)

Shenglei Yang ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-16545 ( https://hibernate.atlassian.net/browse/HHH-16545?atlOrigin=eyJpIjoiNDNiY2... ) Re: PersistenceUtilHelper.MetadataCache is not Thread-Safe ( https://hibernate.atlassian.net/browse/HHH-16545?atlOrigin=eyJpIjoiNDNiY2... ) Is there a release plan for version 5.6.16? I encountered the same problem in the production environment, and it is currently solved by restarting. ( https://hibernate.atlassian.net/browse/HHH-16545#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16545#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100227- sha1:3bc807d )

1 year

1
0
0 / 0

[JIRA] (HHH-16855) With IdClass if parts of composite key is auto generated, while saving PropertyAccessException thrown

by Arul Pragasam (JIRA)

Arul Pragasam ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=59fd553... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiM2E4OTczMGVl... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-16855?atlOrigin=eyJpIjoiM2E4OT... ) HHH-16855 ( https://hibernate.atlassian.net/browse/HHH-16855?atlOrigin=eyJpIjoiM2E4OT... ) With IdClass if parts of composite key is auto generated, while saving PropertyAccessException thrown ( https://hibernate.atlassian.net/browse/HHH-16855?atlOrigin=eyJpIjoiM2E4OT... ) Issue Type: Bug Assignee: Unassigned Attachments: JPAUnitTestCaseIdClass.java Created: 26/Jun/2023 20:08 PM Priority: Major Reporter: Arul Pragasam ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=59fd553... ) I have a composite primary key * Account_id * id Id column is a generated value using GenerationType.IDENTITY strategy. When we create a new instance and save using hibernate entity manager, we get below exception *Code:* doInJPA( ()->entityManagerFactory, em -> { SalesContact contact = new SalesContact(); contact.setFirstName( "John" ); contact.setAccountId(1L); entityManager.persist( contact ); Assertions.assertNotNull(contact.getId()); }); *Exception* org.hibernate.PropertyAccessException: Could not set value of type [org.hibernate.id.IdentifierGeneratorHelper$2] : `org.hibernate.bugs.JPAUnitTestCaseIdClass$CompositeKey.id` (setter) at org.hibernate.property.access.spi.SetterFieldImpl.set(SetterFieldImpl.java:86) at org.hibernate.mapping.Component$ValueGenerationPlan.execute(Component.java:666) at org.hibernate.id.CompositeNestedGeneratedValueGenerator.generate(CompositeNestedGeneratedValueGenerator.java:111) at org.hibernate.id.IdentifierGenerator.generate(IdentifierGenerator.java:147) at org.hibernate.event.internal.AbstractSaveEventListener.saveWithGeneratedId(AbstractSaveEventListener.java:120) at org.hibernate.event.internal.DefaultPersistEventListener.entityIsTransient(DefaultPersistEventListener.java:175) at org.hibernate.event.internal.DefaultPersistEventListener.persist(DefaultPersistEventListener.java:93) at org.hibernate.event.internal.DefaultPersistEventListener.onPersist(DefaultPersistEventListener.java:77) at org.hibernate.event.internal.DefaultPersistEventListener.onPersist(DefaultPersistEventListener.java:54) at org.hibernate.event.service.internal.EventListenerGroupImpl.fireEventOnEachListener(EventListenerGroupImpl.java:127) at org.hibernate.internal.SessionImpl.firePersist(SessionImpl.java:755) at org.hibernate.internal.SessionImpl.persist(SessionImpl.java:739) at org.hibernate.bugs.JPAUnitTestCaseIdClass.lambda$HHH16849$1(JPAUnitTestCaseIdClass.java:53) at org.hibernate.testing.transaction.TransactionUtil.doInJPA(TransactionUtil.java:258) at org.hibernate.testing.transaction.TransactionUtil.doInJPA(TransactionUtil.java:299) at org.hibernate.bugs.JPAUnitTestCaseIdClass.HHH16849(JPAUnitTestCaseIdClass.java:48) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:568) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59) at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12) at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56) at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17) at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26) at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27) at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) at org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100) at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103) at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63) at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331) at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79) at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329) at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66) at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293) at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306) at org.junit.runners.ParentRunner.run(ParentRunner.java:413) at org.junit.runner.JUnitCore.run(JUnitCore.java:137) at com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69) at com.intellij.rt.junit.IdeaTestRunner$Repeater$1.execute(IdeaTestRunner.java:38) at com.intellij.rt.execution.junit.TestsRepeater.repeat(TestsRepeater.java:11) at com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:35) at com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:235) at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:54) Caused by: java.lang.IllegalArgumentException: Can not set java.lang.Long field org.hibernate.bugs.JPAUnitTestCaseIdClass$CompositeKey.id to org.hibernate.id.IdentifierGeneratorHelper$2 at java.base/jdk.internal.reflect.UnsafeFieldAccessorImpl.throwSetIllegalArgumentException(UnsafeFieldAccessorImpl.java:167) at java.base/jdk.internal.reflect.UnsafeFieldAccessorImpl.throwSetIllegalArgumentException(UnsafeFieldAccessorImpl.java:171) at java.base/jdk.internal.reflect.UnsafeObjectFieldAccessorImpl.set(UnsafeObjectFieldAccessorImpl.java:81) at java.base/java.lang.reflect.Field.set(Field.java:799) at org.hibernate.property.access.spi.SetterFieldImpl.set(SetterFieldImpl.java:55) ... 44 more ( https://hibernate.atlassian.net/browse/HHH-16855#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16855#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100227- sha1:3bc807d )

1 year

1
0
0 / 0

[JIRA] (HHH-16854) With EmbeddedId having a generated value using GenerationType.IDENTITY does not have the generated value after save

by Arul Pragasam (JIRA)

Arul Pragasam ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=59fd553... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiYmY5M2MyZGNk... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-16854?atlOrigin=eyJpIjoiYmY5M2... ) HHH-16854 ( https://hibernate.atlassian.net/browse/HHH-16854?atlOrigin=eyJpIjoiYmY5M2... ) With EmbeddedId having a generated value using GenerationType.IDENTITY does not have the generated value after save ( https://hibernate.atlassian.net/browse/HHH-16854?atlOrigin=eyJpIjoiYmY5M2... ) Issue Type: Bug Assignee: Unassigned Attachments: JPAUnitTestCase.java Created: 26/Jun/2023 20:04 PM Priority: Major Reporter: Arul Pragasam ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=59fd553... ) I have a composite key which consists of two parts * Account_id * id Id column is generated using strategy GenerationType.IDENTITY. When we create a new object and save using entitymanager, after save the object does not have the generated id back. CompositeKey key = new CompositeKey(); key.setAccountId(1L); SalesContact contact = new SalesContact(); contact.setFirstName( "John" ); contact.setKey(key); entityManager.persist( contact ); Assertions.assertNotNull(key.getId()); JPAUnitTestCase.java ( https://hibernate.atlassian.net/rest/api/3/attachment/content/50473 ) ( https://hibernate.atlassian.net/browse/HHH-16854#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16854#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100227- sha1:3bc807d )

1 year

1
0
0 / 0

[JIRA] (HHH-16718) use table inheritance in DDL generation for TABLE_PER_CLASS mappings on PostgreSQL

by Gavin King (JIRA)

1 year

1
0
0 / 0

[JIRA] (HHH-14051) typesafe references to named queries, result set mappings, and entity graphs

by Gavin King (JIRA)

Gavin King ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-14051 ( https://hibernate.atlassian.net/browse/HHH-14051?atlOrigin=eyJpIjoiZDg0OT... ) Re: typesafe references to named queries, result set mappings, and entity graphs ( https://hibernate.atlassian.net/browse/HHH-14051?atlOrigin=eyJpIjoiZDg0OT... ) This can be closed. ( https://hibernate.atlassian.net/browse/HHH-14051#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-14051#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100227- sha1:3bc807d )

1 year

1
0
0 / 0

[JIRA] (HHH-16796) generate string constants for named queries, etc.

by Gavin King (JIRA)

Gavin King ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-16796 ( https://hibernate.atlassian.net/browse/HHH-16796?atlOrigin=eyJpIjoiMmQzYm... ) Re: generate string constants for named queries, etc. ( https://hibernate.atlassian.net/browse/HHH-16796?atlOrigin=eyJpIjoiMmQzYm... ) This can be closed. ( https://hibernate.atlassian.net/browse/HHH-16796#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16796#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100227- sha1:3bc807d )

1 year

1
0
0 / 0

[JIRA] (HHH-16853) Setting Named Query Parameters Is VERY Slow

by Joshua Swoyer (JIRA)

Joshua Swoyer ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=5fa3412... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiYzlmYzgzYTE1... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-16853?atlOrigin=eyJpIjoiYzlmYz... ) HHH-16853 ( https://hibernate.atlassian.net/browse/HHH-16853?atlOrigin=eyJpIjoiYzlmYz... ) Setting Named Query Parameters Is VERY Slow ( https://hibernate.atlassian.net/browse/HHH-16853?atlOrigin=eyJpIjoiYzlmYz... ) Issue Type: Bug Affects Versions: 6.1.6 Assignee: Unassigned Components: hibernate-core Created: 26/Jun/2023 13:56 PM Priority: Major Reporter: Joshua Swoyer ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=5fa3412... ) As a little bit of background, we are attempting to do bulk upsert statements for performance in an application. This lead to us generating our own sql from a list of models (1000 records at a time). We were using hibenrate’s native query generator. Since we were generating the sql, we initially implimented parameters positionally, before realizing these are no longer supported. Upong releasing the code and attempting to ingest data we eventually noticed that preparing a query was taking 10x as long as running the query did. Turning on profiling I was able to find that this is the issue: https://github.com/hibernate/hibernate-orm/blob/main/hibernate-core/src/m... @Override public QueryParameterImplementor<?> findQueryParameter(String name) { for ( QueryParameterImplementor<?> queryParameter : queryParameters.keySet() ) { if ( name.equals( queryParameter.getName() ) ) { return queryParameter; } } return null; } The above code is very slow when there are many query parameters. As best I can tell the queryParameters are immutable in this class, only created in the constructor, and new parameters are never added. It looks like it would be very easy to create two maps on initialization that has the name as the key. Though there may be things going on here that I’m not entirely following. Assuming this is all that is necessary I’d be happy to submit a PR if that is helpful. ( https://hibernate.atlassian.net/browse/HHH-16853#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16853#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100227- sha1:3bc807d )

1 year

1
0
0 / 0

[JIRA] (HHH-16759) Merge fails when entity has an Embedded Java record

by Jan Schatteman (JIRA)

1 year

1
0
0 / 0

[JIRA] (HHH-16759) Merge fails when entity has an Embedded Java record

by Jan Schatteman (JIRA)

1 year

1
0
0 / 0

[JIRA] (HHH-16852) JPA criteria query generates invalid JQL causing QuerySyntaxException

by Archie Cobbs (JIRA)

Archie Cobbs ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *updated* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiY2U4YTRlMTEz... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-16852?atlOrigin=eyJpIjoiY2U4YT... ) HHH-16852 ( https://hibernate.atlassian.net/browse/HHH-16852?atlOrigin=eyJpIjoiY2U4YT... ) JPA criteria query generates invalid JQL causing QuerySyntaxException ( https://hibernate.atlassian.net/browse/HHH-16852?atlOrigin=eyJpIjoiY2U4YT... ) Change By: Archie Cobbs ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Note: I have a reproducible test case available in 5.x; the same test case succeeds in 6.x: [https://github.com/archiecobbs/hibernate-test-case-templates/tree/HHH-168...] It appears that you can’t reuse a criteria {{Expression}} - perhaps Hibernate is mutating them when it builds the query? Example: {code:java} EntityManager entityManager = entityManagerFactory.createEntityManager(); entityManager.getTransaction().begin(); final CriteriaBuilder cb = entityManager.getCriteriaBuilder(); final CriteriaQuery<Object[]> query = cb.createQuery(Object[].class); final Root<Employee> employee = query.from(Employee.class); final Expression<Boolean> hasManager = cb.isNotNull(employee.get(Employee_.manager)); final Expression<Integer> numWithManager = cb.sum( cb.<Boolean, Integer>selectCase(cb.isTrue(hasManager)) .when(true, 1) .otherwise(0)); final Expression<Integer> numWithoutManager = cb.sum( cb.<Boolean, Integer>selectCase(cb.isFalse(hasManager)) .when(true, 1) .otherwise(0)); query.select(cb.array(numWithManager, numWithoutManager)); entityManager.createQuery(query).getResultStream().forEach(x -> System.out.println("RESULT: [" + x[0] + "," + x[1] + "]")); entityManager.getTransaction().commit(); entityManager.close();{code} Running this code results in this exception: {noformat}java.lang.IllegalArgumentException: org.hibernate.hql.internal.ast.QuerySyntaxException: unexpected token: is near line 1, column 41 [select sum(case generatedAlias0.manager is not null when true then 1 else 0 end), sum(case generatedAlias0.manager is not null when true then 1 else 0 end) from org.hibernate.bugs.Employee as generatedAlias0] at org.hibernate.internal.ExceptionConverterImpl.convert(ExceptionConverterImpl.java:138) at org.hibernate.internal.ExceptionConverterImpl.convert(ExceptionConverterImpl.java:181) at org.hibernate.internal.ExceptionConverterImpl.convert(ExceptionConverterImpl.java:188) at org.hibernate.internal.AbstractSharedSessionContract.createQuery(AbstractSharedSessionContract.java:757) at org.hibernate.internal.AbstractSharedSessionContract.createQuery(AbstractSharedSessionContract.java:811) at org.hibernate.query.criteria.internal.CriteriaQueryImpl$1.buildCompiledQuery(CriteriaQueryImpl.java:314) at org.hibernate.query.criteria.internal.compile.CriteriaCompiler.compile(CriteriaCompiler.java:170) at org.hibernate.internal.AbstractSharedSessionContract.createQuery(AbstractSharedSessionContract.java:774) at org.hibernate.internal.AbstractSessionImpl.createQuery(AbstractSessionImpl.java:23) at org.hibernate.bugs.JPAUnitTestCase.hhh123Test(JPAUnitTestCase.java:61){noformat} Note that the two generated {{ case …... when }} expressions are the same, whereas in the Java code they are supposed to be the opposite of each other. This is what makes me think the bug is triggered by the reuse of {{final Expression<Boolean> hasManager}} in the Java code - which could only matter if Hibernate is mutating the expression or whatever. AFAIK there is no restriction in the Criteria API that says you can’t use an {{Expression}} more than once… ? ( https://hibernate.atlassian.net/browse/HHH-16852#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16852#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100227- sha1:a102ba3 )

1 year

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues June 2023