July 2023 - hibernate-issues - Jboss List Archives

[JIRA] (HHH-16881) Envers RevisionListener it is not created when Hibernate CDI Extensions is enabled

by Manuel Garcia de Vinuesa (JIRA)

Manuel Garcia de Vinuesa ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiZWE4YzExNzZl... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-16881?atlOrigin=eyJpIjoiZWE4Yz... ) HHH-16881 ( https://hibernate.atlassian.net/browse/HHH-16881?atlOrigin=eyJpIjoiZWE4Yz... ) Envers RevisionListener it is not created when Hibernate CDI Extensions is enabled ( https://hibernate.atlassian.net/browse/HHH-16881?atlOrigin=eyJpIjoiZWE4Yz... ) Issue Type: Bug Affects Versions: 6.2.5, 6.2.6 Assignee: Chris Cranford ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Attachments: image-20230703-065313.png Components: hibernate-envers Created: 02/Jul/2023 23:57 PM Environment: Spring Boot 3.1.1 with JVM 17 on Windows 11 Labels: envers Priority: Major Reporter: Manuel Garcia de Vinuesa ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) From Hibernate 6.2 it is mandatory enabled CDI extensions to work with Spring Container, this is included in Spring 3.1 in the class HibernateJpaVendorAdapter (spring-orm). The problem it is in the class DefaultRevisionInfoGenerator (hibernate-envers) when the method resolveRevisionListenerBean it is executed due to the condition {{Helper.allowExtensionsInCdi( serviceRegistry )}}should be negated. private ManagedBean<? extends RevisionListener> resolveRevisionListenerBean( Class <? extends RevisionListener> listenerClass, ServiceRegistry serviceRegistry) { if ( !listenerClass.equals( RevisionListener.class ) ) { if ( Helper.allowExtensionsInCdi( serviceRegistry ) ) { return new ProvidedInstanceManagedBeanImpl<>( FallbackBeanInstanceProducer.INSTANCE.produceBeanInstance( listenerClass ) ); } return serviceRegistry.getService( ManagedBeanRegistry.class ).getBean( listenerClass ); } return null ; } To reproduce you can use my demo to test it, mgvinuesa/hibernate-envers-spring: A demo of how to wire Spring Framework 5.1+ to inject beans into Hibernate Envers RevisionListener (github.com) ( https://github.com/mgvinuesa/hibernate-envers-spring ) If you change the spring boot version to 3.0, everything works properly, but when it is updated to 3.1, the RevisionListener does not work properly. ( https://hibernate.atlassian.net/browse/HHH-16881#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16881#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100228- sha1:e911e2c )

10 months, 1 week

1
0
0 / 0

[JIRA] (HHH-16247) Criteria Query with Object-Typed Embedded Parameter throws AssertionError

by Nicolas Noffke (JIRA)

Nicolas Noffke ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=5a9bd36... ) *commented* on HHH-16247 ( https://hibernate.atlassian.net/browse/HHH-16247?atlOrigin=eyJpIjoiNjRiMD... ) Re: Criteria Query with Object-Typed Embedded Parameter throws AssertionError ( https://hibernate.atlassian.net/browse/HHH-16247?atlOrigin=eyJpIjoiNjRiMD... ) > > > > But it seems that your repository interface is actually WithEmbeddedRepository > , and that is the interface which Spring Data fills in the implementation > of. In this interface, AnEmbeddable was assigned a concrete type argument, > and so when Spring Data fills in the implementation of the > generically-typed interface method, it has all the information it needs to > pass the correct concrete parameter type to CriteriaBuilder.parameter(). > I’m guessing it's passing Object.class because someone is lazy and could > not be bothered substituting type arguments for type parameters. > > That is hard for me to answer. You’re right that it would generally be possible (with some effort) to get hold of the concrete types involved. As to the feasibility of doing it in spring data jpa, that is better answered by the maintainers of that project, I’m afraid. ( https://hibernate.atlassian.net/browse/HHH-16247#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16247#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100228- sha1:e911e2c )

10 months, 1 week

1
0
0 / 0

[JIRA] (HHH-14741) Schema validation fails for tinyint after upgrading mariadb-java-client

by wexoo (JIRA)

wexoo ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-14741 ( https://hibernate.atlassian.net/browse/HHH-14741?atlOrigin=eyJpIjoiZDNjYj... ) Re: Schema validation fails for tinyint after upgrading mariadb-java-client ( https://hibernate.atlassian.net/browse/HHH-14741?atlOrigin=eyJpIjoiZDNjYj... ) Have the same problem with spring boot 3.1.x (updated hibernate version to 6.2). My definitions of TINYINT UNSIGNED & SMALLINT UNSIGNED stopped working. I resolved it by changing definitions to TINYINT(3) UNSIGNED & SMALLINT(5) UNSIGNED , which sets the display width of the columns and has nothing to do with value ranges. More can be found in official mysql 8 doc here ( https://dev.mysql.com/doc/refman/8.0/en/numeric-type-attributes.html ). Found nothing in the changelog of version 6.2 matching my database (MySQL 8). ( https://hibernate.atlassian.net/browse/HHH-14741#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-14741#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100227- sha1:9e449c4 )

10 months, 1 week

1
0
0 / 0

[JIRA] (HHH-14741) Schema validation fails for tinyint after upgrading mariadb-java-client

by wexoo (JIRA)

10 months, 1 week

1
0
0 / 0

[JIRA] (HHH-14741) Schema validation fails for tinyint after upgrading mariadb-java-client

by wexoo (JIRA)

10 months, 1 week

1
0
0 / 0

[JIRA] (HHH-16815) add methods to SelectionQuery to add order by items

by Gavin King (JIRA)

Gavin King ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-16815 ( https://hibernate.atlassian.net/browse/HHH-16815?atlOrigin=eyJpIjoiNGFkNT... ) Re: add methods to SelectionQuery to add order by items ( https://hibernate.atlassian.net/browse/HHH-16815?atlOrigin=eyJpIjoiNGFkNT... ) So the question is, which is the least worst of: .setOrder(List.of(asc(Book_.isbn), desc(Book_.title))) And: .setOrder(by().asc(Book_.isbn).desc(Book_.title)) The first uses a regular Java List. The second uses a special-purpose linked list. ( https://hibernate.atlassian.net/browse/HHH-16815#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16815#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100227- sha1:9e449c4 )

10 months, 1 week

1
0
0 / 0

[JIRA] (HHH-16815) add methods to SelectionQuery to add order by items

by Gavin King (JIRA)

Gavin King ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-16815 ( https://hibernate.atlassian.net/browse/HHH-16815?atlOrigin=eyJpIjoiYzMzNz... ) Re: add methods to SelectionQuery to add order by items ( https://hibernate.atlassian.net/browse/HHH-16815?atlOrigin=eyJpIjoiYzMzNz... ) For those who weren’t in love with putting ascending() and descending() directly on Query , and wanted a separate object representing a sort order which can be passed around, how about the following “compromise” API which has nice features of both options: * Introduce an Order object which is some sort of linked list. * Add only Query.setOrder(Order)}}to {{Query. The most naive usage would look like: session.createSelectionQuery( "from Book" ) .setOrder(Order.asc(Book_.title).desc(Book_.isbn)) .getResultList(); Or, for sorting by column index: session.createSelectionQuery( "select isbn, title from Book" ) .setOrder(Order.asc(0).desc(1)) .getResultList(); The Order API itself could be quite flexible, accommodating stuff like: session.createSelectionQuery( "from Book" ) .setOrder(Order.by(Book_.title, SortOrder.ASCENDING).by(Book_.isbn, SortOrder.DESCENDING)) .getResultList(); along with other stuff we haven’t even thought of yet. Thus, Order would occupy a very similar role in the architecture that EntityGraph occupies for fetching. ( https://hibernate.atlassian.net/browse/HHH-16815#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16815#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100227- sha1:9e449c4 )

10 months, 1 week

1
0
0 / 0

[JIRA] (HHH-16875) more disciplined type checking for comparison expressions and assignments

by Gavin King (JIRA)

Gavin King ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-16875 ( https://hibernate.atlassian.net/browse/HHH-16875?atlOrigin=eyJpIjoiODQ3MG... ) Re: more disciplined type checking for comparison expressions and assignments ( https://hibernate.atlassian.net/browse/HHH-16875?atlOrigin=eyJpIjoiODQ3MG... ) This is done. I’ve opened the followup issue https://hibernate.atlassian.net/browse/HHH-16880 relating to converters. ( https://hibernate.atlassian.net/browse/HHH-16875#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16875#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100227- sha1:9e449c4 )

10 months, 1 week

1
0
0 / 0

[JIRA] (HHH-16880) AttributeConverters + HQL typechecking

by Gavin King (JIRA)

Gavin King ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiMWU3N2VjYjll... ) / Improvement ( https://hibernate.atlassian.net/browse/HHH-16880?atlOrigin=eyJpIjoiMWU3N2... ) HHH-16880 ( https://hibernate.atlassian.net/browse/HHH-16880?atlOrigin=eyJpIjoiMWU3N2... ) AttributeConverters + HQL typechecking ( https://hibernate.atlassian.net/browse/HHH-16880?atlOrigin=eyJpIjoiMWU3N2... ) Issue Type: Improvement Assignee: Unassigned Components: query-criteria, query-hql Created: 30/Jun/2023 21:40 PM Priority: Minor Reporter: Gavin King ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) As a follow-up to https://hibernate.atlassian.net/browse/HHH-16875 it is possible to simplify and tighten up the type-checking code in TypecheckUtil if the necessary information about converters is made available in the SQM tree. I was forced to add a hole in the logic to accommodate the fact that this information is not available. ( https://hibernate.atlassian.net/browse/HHH-16880#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16880#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100227- sha1:9e449c4 )

10 months, 1 week

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues July 2023