July 2023 - hibernate-issues - Jboss List Archives

[JIRA] (HHH-16948) JdbcTimestampJavaType.TimestampMutabilityPlan breaks entity's equals()

by Nick V (JIRA)

Nick V ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *updated* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiOWJkNmU5ODYx... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-16948?atlOrigin=eyJpIjoiOWJkNm... ) HHH-16948 ( https://hibernate.atlassian.net/browse/HHH-16948?atlOrigin=eyJpIjoiOWJkNm... ) JdbcTimestampJavaType.TimestampMutabilityPlan breaks entity's equals() ( https://hibernate.atlassian.net/browse/HHH-16948?atlOrigin=eyJpIjoiOWJkNm... ) Change By: Nick V ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) TimestampMutabilityPlan [returns|https://github.com/hibernate/hibernate-orm/blob/6.2.5/hibernate-c...] java.sql.Timestamp which breaks equals(). Test case [https://github.com/VboxNick/hibernate-orm-HHH-16948/tree/hibernate-orm-6-...] Steps to reproduce: Entity. {code:java}package com.example.demobug; import jakarta.persistence.Entity; import jakarta.persistence.Id; import jakarta.persistence.Temporal; import jakarta.persistence.TemporalType; import lombok.Data; import lombok.NoArgsConstructor; import java.util.Date; import java.util.UUID; @Entity @NoArgsConstructor @Data public class Company { @Id private UUID id; @Temporal(TemporalType.TIMESTAMP) private Date establishedAt; } {code} Test. {code:java}package com.example.demobug; import org.junit.jupiter.api.Test; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.boot.test.autoconfigure.orm.jpa.DataJpaTest; import org.springframework.boot.test.autoconfigure.orm.jpa.TestEntityManager; import java.util.Date; import java.util.UUID; import static org.assertj.core.api.Assertions.assertThat; @DataJpaTest class CompanyTest { @Autowired public TestEntityManager entityManager; @Test void shouldSaveEntity() { final Company company = createNewCompany(); final Company found = entityManager.find(Company.class, company.getId()); assertThat(found.getId()).isEqualTo(company.getId()); assertThat(found.getEstablishedAt()).isEqualTo(company.getEstablishedAt()); assertThat(found).isEqualTo(company); } private Company createNewCompany() { final Company company = new Company(); company.setId(UUID.randomUUID()); company.setEstablishedAt(new Date()); entityManager.persistAndFlush(company); entityManager.detach(company); entityManager.flush(); entityManager.clear(); return company; } }{code} Assertion error: {noformat}org.opentest4j.AssertionFailedError: expected: 2023-07-17T15:47:01.131 (java.util.Date) but was: 2023-07-17T15:47:01.131 (java.sql.Timestamp){noformat} ( https://hibernate.atlassian.net/browse/HHH-16948#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16948#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100232- sha1:33a7c72 )

2 years, 8 months

1
0
0 / 0

[JIRA] (HHH-16936) Entity not being removed from persistence context after a delete in JPQL

by Jean-Baptiste Hainaut (JIRA)

Jean-Baptiste Hainaut ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=712020%... ) *updated* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiZDY1ODA2MWJj... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-16936?atlOrigin=eyJpIjoiZDY1OD... ) HHH-16936 ( https://hibernate.atlassian.net/browse/HHH-16936?atlOrigin=eyJpIjoiZDY1OD... ) Entity not being removed from persistence context after a delete in JPQL ( https://hibernate.atlassian.net/browse/HHH-16936?atlOrigin=eyJpIjoiZDY1OD... ) Change By: Jean-Baptiste Hainaut ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=712020%... ) When using a composite id, the entity is not removed from the persistance context with a delete query written in JPQL Our Entity and composite id : {code:java}@Entity @NoArgsConstructor(access = AccessLevel.PRIVATE, force = true) public class SchoolSetting { @EmbeddedId private final SchoolSettingId id; @Getter private boolean activated; public SchoolSetting(@NonNull final String schoolId, @NonNull final String key, final boolean activated) { this.id = new SchoolSettingId(schoolId, key); this.activated = activated; } public String getKey() { return this.id.getKey(); } } @Embeddable @NoArgsConstructor(access = AccessLevel.PRIVATE, force = true) @Getter(AccessLevel.PROTECTED) @EqualsAndHashCode public class SchoolSettingId implements Serializable { private final String schoolId; private final String key; public SchoolSettingId(@NonNull final String schoolId, @NonNull final String key) { this.schoolId = schoolId; this.key = key; } }{code} The repository : {code:java}interface SpringDataSchoolSettingRepository extends CrudRepository<SchoolSetting, SchoolSettingId> { @Query("delete from SchoolSetting s WHERE s.id.key = :id") @Modifying void deleteById(@Param("id") SchoolSettingId id); }{code} The following test fail without the testEntityManager.clear() as the entity is still in the persistence context. We we are able to reproduce the same behavior with production code inside the same transaction {code:java}@DataJpaTest @AutoConfigureTestDatabase(replace = AutoConfigureTestDatabase.Replace.NONE) @Import(JpaSchoolSettingRepository.class) class JpaSchoolSettingRepositoryIT { static String SCHOOL_ID = "MY_SCHOOL"; @Autowired TestEntityManager testEntityManager; @Autowired JpaSchoolSettingRepository jpaSchoolSettingRepository; @Test void deleteTwiceShouldntThrowAnyException() { testEntityManager.persistAndFlush(createSetting()); assertThat(jpaSchoolSettingRepository.get(new SchoolSettingId(SCHOOL_ID, "ABSENCE_FOR_DAY_OFF"))) .isNotEmpty(); jpaSchoolSettingRepository.delete(new SchoolSettingId(SCHOOL_ID, "ABSENCE_FOR_DAY_OFF")); //testEntityManager.clear(); assertThat(jpaSchoolSettingRepository.get(new SchoolSettingId(SCHOOL_ID, "ABSENCE_FOR_DAY_OFF"))) .isEmpty(); assertThatCode(() -> jpaSchoolSettingRepository.delete(new SchoolSettingId(SCHOOL_ID, "ABSENCE_FOR_DAY_OFF"))) .doesNotThrowAnyException(); } private SchoolSetting createSetting() { return new SchoolSetting(SCHOOL_ID, ABSENCE_FOR_DAY_OFF, true); } }{code} If we change the query to the following, it work as expected : {code:java}@Query("delete from SchoolSetting s WHERE s.id.key = :schoolId and s.id.schoolId = :key") @Modifying void deleteById(String schoolId, String key);{code} So we conclude that the bug is related with the handling of the composite key ( https://hibernate.atlassian.net/browse/HHH-16936#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16936#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100232- sha1:33a7c72 )

2 years, 8 months

1
0
0 / 0

[JIRA] (HHH-16948) JdbcTimestampJavaType.TimestampMutabilityPlan breaks entity's equals()

by Nick V (JIRA)

Nick V ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *updated* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiNjU0ZjZlZTBj... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-16948?atlOrigin=eyJpIjoiNjU0Zj... ) HHH-16948 ( https://hibernate.atlassian.net/browse/HHH-16948?atlOrigin=eyJpIjoiNjU0Zj... ) JdbcTimestampJavaType.TimestampMutabilityPlan breaks entity's equals() ( https://hibernate.atlassian.net/browse/HHH-16948?atlOrigin=eyJpIjoiNjU0Zj... ) Change By: Nick V ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) TimestampMutabilityPlan [returns|https://github.com/hibernate/hibernate-orm/blob/6.2.5/hibernate-c...] java.sql.Timestamp which breaks equals(). Entity Steps to reproduce : Entity. {code:java}package com.example.demobug; import jakarta.persistence.Entity; import jakarta.persistence.Id; import jakarta.persistence.Temporal; import jakarta.persistence.TemporalType; import lombok.Data; import lombok.NoArgsConstructor; import java.util.Date; import java.util.UUID; @Entity @NoArgsConstructor @Data public class Company { @Id private UUID id; @Temporal(TemporalType.TIMESTAMP) private Date establishedAt; } {code} Test. {code:java}package com.example.demobug; import org.junit.jupiter.api.Test; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.boot.test.autoconfigure.orm.jpa.DataJpaTest; import org.springframework.boot.test.autoconfigure.orm.jpa.TestEntityManager; import java.util.Date; import java.util.UUID; import static org.assertj.core.api.Assertions.assertThat; @DataJpaTest class CompanyTest { @Autowired public TestEntityManager entityManager; @Test void shouldSaveEntity() { final Company company = createNewCompany(); final Company found = entityManager.find(Company.class, company.getId()); assertThat(found.getId()).isEqualTo(company.getId()); assertThat(found.getEstablishedAt()).isEqualTo(company.getEstablishedAt()); assertThat(found).isEqualTo(company); } private Company createNewCompany() { final Company company = new Company(); company.setId(UUID.randomUUID()); company.setEstablishedAt(new Date()); entityManager.persistAndFlush(company); entityManager.detach(company); entityManager.flush(); entityManager.clear(); return company; } }{code} Assertion error: {noformat}org.opentest4j.AssertionFailedError: expected: 2023-07-17T15:47:01.131 (java.util.Date) but was: 2023-07-17T15:47:01.131 (java.sql.Timestamp){noformat} ( https://hibernate.atlassian.net/browse/HHH-16948#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16948#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100232- sha1:33a7c72 )

2 years, 8 months

1
0
0 / 0

[JIRA] (HHH-16779) EntityManager.find(Class<T> entityClass, Object primaryKey) generate unexpected sql

by Christian Beikov (JIRA)

Christian Beikov ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-16779 ( https://hibernate.atlassian.net/browse/HHH-16779?atlOrigin=eyJpIjoiY2Q4N2... ) Re: EntityManager.find(Class<T> entityClass, Object primaryKey) generate unexpected sql ( https://hibernate.atlassian.net/browse/HHH-16779?atlOrigin=eyJpIjoiY2Q4N2... ) Making better use of prepared statement caches is the main motivation. Either way, there is nothing to discuss as this is fixed in 6.3 and 6.2.6 ( https://hibernate.atlassian.net/browse/HHH-16779#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16779#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100232- sha1:33a7c72 )

2 years, 8 months

1
0
0 / 0

[JIRA] (HHH-16942) OneToOne Mapping with PartitionKey fails

by Marco Belladelli (JIRA)

2 years, 8 months

1
0
0 / 0

[JIRA] (HHH-16948) JdbcTimestampJavaType.TimestampMutabilityPlan breaks entity's equals()

by Nick V (JIRA)

2 years, 8 months

1
0
0 / 0

[JIRA] (HHH-16948) TimestampMutabilityPlan breaks entity's equals()

by Nick V (JIRA)

Nick V ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *updated* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiYTk0MmFhYjhm... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-16948?atlOrigin=eyJpIjoiYTk0Mm... ) HHH-16948 ( https://hibernate.atlassian.net/browse/HHH-16948?atlOrigin=eyJpIjoiYTk0Mm... ) TimestampMutabilityPlan breaks entity's equals() ( https://hibernate.atlassian.net/browse/HHH-16948?atlOrigin=eyJpIjoiYTk0Mm... ) Change By: Nick V ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) TimestampMutabilityPlan [returns|https://github.com/hibernate/hibernate-orm/blob/6.2.5/hibernate-c...] java.sql.Timestamp which breaks equals(). Entity: {code:java}package com.example.demobug; import jakarta.persistence.Entity; import jakarta.persistence.Id; import jakarta.persistence.Temporal; import jakarta.persistence.TemporalType; import lombok.Data; import lombok.NoArgsConstructor; import java.util.Date; import java.util.UUID; @Entity @NoArgsConstructor @Data public class Company { @Id private UUID id; @Temporal(TemporalType.TIMESTAMP) private Date establishedAt; } {code} Test. {code:java}package com.example.demobug; import org.junit.jupiter.api.Test; import org.springframework.beans.factory.annotation.Autowired; import org.springframework.boot.test.autoconfigure.orm.jpa.DataJpaTest; import org.springframework.boot.test.autoconfigure.orm.jpa.TestEntityManager; import java.util.Date; import java.util.UUID; import static org.assertj.core.api.Assertions.assertThat; @DataJpaTest class CompanyTest { @Autowired public TestEntityManager entityManager; @Test void shouldSaveEntity() { final Company company = createNewCompany(); final Company found = entityManager.find(Company.class, company.getId()); assertThat(found.getId()).isEqualTo(company.getId()); assertThat(found.getEstablishedAt()).isEqualTo(company.getEstablishedAt()); assertThat(found).isEqualTo(company); } private Company createNewCompany() { final Company company = new Company(); company.setId(UUID.randomUUID()); company.setEstablishedAt(new Date()); entityManager.persistAndFlush(company); entityManager.detach(company); entityManager.flush(); entityManager.clear(); return company; } }{code} Assertion error: {noformat}org.opentest4j.AssertionFailedError: expected: 2023-07-17T15:47:01.131 (java.util.Date) but was: 2023-07-17T15:47:01.131 (java.sql.Timestamp){noformat} ( https://hibernate.atlassian.net/browse/HHH-16948#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16948#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100232- sha1:33a7c72 )

2 years, 8 months

1
0
0 / 0

[JIRA] (HHH-16756) orphanRemoval does not work when bytecode enhancement is enabled

by Andrea Boriero (JIRA)

Andrea Boriero ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-16756 ( https://hibernate.atlassian.net/browse/HHH-16756?atlOrigin=eyJpIjoiMjJiZW... ) Re: orphanRemoval does not work when bytecode enhancement is enabled ( https://hibernate.atlassian.net/browse/HHH-16756?atlOrigin=eyJpIjoiMjJiZW... ) Hi J. Gremmen ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) , please do not assign Jiras. ( https://hibernate.atlassian.net/browse/HHH-16756#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16756#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100232- sha1:33a7c72 )

2 years, 8 months

1
0
0 / 0

[JIRA] (HHH-16756) orphanRemoval does not work when bytecode enhancement is enabled

by Andrea Boriero (JIRA)

2 years, 8 months

1
0
0 / 0

[JIRA] (HHH-16948) TimestampMutabilityPlan breaks entity's equals()

by Nick V (JIRA)

2 years, 8 months

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues July 2023