August 2023 - hibernate-issues - Jboss List Archives

[JIRA] (HHH-17035) Bytecode enhancement leads to StackOverflowError with specific setup involving different generic parameter names

by Yoann Rodière (JIRA)

Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiYmIzMGZhMzEw... ) / Bug ( https://hibernate.atlassian.net/browse/HHH-17035?atlOrigin=eyJpIjoiYmIzMG... ) HHH-17035 ( https://hibernate.atlassian.net/browse/HHH-17035?atlOrigin=eyJpIjoiYmIzMG... ) Bytecode enhancement leads to StackOverflowError with specific setup involving different generic parameter names ( https://hibernate.atlassian.net/browse/HHH-17035?atlOrigin=eyJpIjoiYmIzMG... ) Issue Type: Bug Affects Versions: 6.3.0.CR1, 6.2.7 Assignee: Unassigned Components: hibernate-core Created: 04/Aug/2023 09:41 AM Fix Versions: 6.3.0, 6.2.8 Priority: Major Reporter: Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) I noticed this by accident while working on https://hibernate.atlassian.net/browse/HHH-17034. I will send a PR with a reproducer. May be related to https://hibernate.atlassian.net/browse/HHH-17034 , or may be a problem in how Hibernate ORM uses Bytebuddy, or may simply be a bug in bytebuddy. The model below triggers a StackOverflowError upon bytecode enhancement: java.lang.NoClassDefFoundError: org/hibernate/orm/test/bytecode/enhance/internal/bytebuddy/DirtyCheckingWithDifferentGenericParameterNameTest$MyEntity at org.hibernate.orm.test.bytecode.enhance.internal.bytebuddy.DirtyCheckingWithDifferentGenericParameterNameTest.shouldDeclareMethodsInEntityClass(DirtyCheckingWithDifferentGenericParameterNameTest.java:47) ... Caused by: java.lang.ClassNotFoundException: org.hibernate.orm.test.bytecode.enhance.internal.bytebuddy.DirtyCheckingWithDifferentGenericParameterNameTest$MyEntity not found at org.hibernate.testing.bytecode.enhancement.BytecodeEnhancerRunner$EnhancingClassLoader.loadClass(BytecodeEnhancerRunner.java:235) ... 42 more Caused by: java.lang.StackOverflowError at java.base/java.util.AbstractList$Itr.next(AbstractList.java:371) at net.bytebuddy.matcher.FilterableList$AbstractBase.filter(FilterableList.java:124) at net.bytebuddy.description.TypeVariableSource$AbstractBase.findVariable(TypeVariableSource.java:157) at net.bytebuddy.description.TypeVariableSource$AbstractBase.findVariable(TypeVariableSource.java:162) at net.bytebuddy.description.TypeVariableSource$AbstractBase.findExpectedVariable(TypeVariableSource.java:172) at net.bytebuddy.description.type.TypeDescription$Generic$Visitor$Substitutor$ForAttachment.onTypeVariable(TypeDescription.java:2062) at net.bytebuddy.description.type.TypeDescription$Generic$Visitor$Substitutor$ForAttachment.onTypeVariable(TypeDescription.java:1973) at net.bytebuddy.description.type.TypeDescription$Generic$OfTypeVariable.accept(TypeDescription.java:5705) at net.bytebuddy.description.type.TypeDescription$Generic$LazyProjection.accept(TypeDescription.java:6297) at net.bytebuddy.description.method.MethodDescription$Latent.getReturnType(MethodDescription.java:1478) at net.bytebuddy.description.method.MethodDescription$AbstractBase.toSafeString(MethodDescription.java:1041) at net.bytebuddy.description.TypeVariableSource$AbstractBase.findExpectedVariable(TypeVariableSource.java:174) at net.bytebuddy.description.type.TypeDescription$Generic$Visitor$Substitutor$ForAttachment.onTypeVariable(TypeDescription.java:2062) at net.bytebuddy.description.type.TypeDescription$Generic$Visitor$Substitutor$ForAttachment.onTypeVariable(TypeDescription.java:1973) at net.bytebuddy.description.type.TypeDescription$Generic$OfTypeVariable.accept(TypeDescription.java:5705) at net.bytebuddy.description.type.TypeDescription$Generic$LazyProjection.accept(TypeDescription.java:6297) at net.bytebuddy.description.method.MethodDescription$Latent.getReturnType(MethodDescription.java:1478) at net.bytebuddy.description.method.MethodDescription$AbstractBase.toSafeString(MethodDescription.java:1041) at net.bytebuddy.description.TypeVariableSource$AbstractBase.findExpectedVariable(TypeVariableSource.java:174) at net.bytebuddy.description.type.TypeDescription$Generic$Visitor$Substitutor$ForAttachment.onTypeVariable(TypeDescription.java:2062) at net.bytebuddy.description.type.TypeDescription$Generic$Visitor$Substitutor$ForAttachment.onTypeVariable(TypeDescription.java:1973) at net.bytebuddy.description.type.TypeDescription$Generic$OfTypeVariable.accept(TypeDescription.java:5705) at net.bytebuddy.description.type.TypeDescription$Generic$LazyProjection.accept(TypeDescription.java:6297) at net.bytebuddy.description.method.MethodDescription$Latent.getReturnType(MethodDescription.java:1478) at net.bytebuddy.description.method.MethodDescription$AbstractBase.toSafeString(MethodDescription.java:1041) at net.bytebuddy.description.TypeVariableSource$AbstractBase.findExpectedVariable(TypeVariableSource.java:174) at net.bytebuddy.description.type.TypeDescription$Generic$Visitor$Substitutor$ForAttachment.onTypeVariable(TypeDescription.java:2062) at net.bytebuddy.description.type.TypeDescription$Generic$Visitor$Substitutor$ForAttachment.onTypeVariable(TypeDescription.java:1973) at net.bytebuddy.description.type.TypeDescription$Generic$OfTypeVariable.accept(TypeDescription.java:5705) at net.bytebuddy.description.type.TypeDescription$Generic$LazyProjection.accept(TypeDescription.java:6297) at net.bytebuddy.description.method.MethodDescription$Latent.getReturnType(MethodDescription.java:1478) at net.bytebuddy.description.method.MethodDescription$AbstractBase.toSafeString(MethodDescription.java:1041) at net.bytebuddy.description.TypeVariableSource$AbstractBase.findExpectedVariable(TypeVariableSource.java:174) at net.bytebuddy.description.type.TypeDescription$Generic$Visitor$Substitutor$ForAttachment.onTypeVariable(TypeDescription.java:2062) at net.bytebuddy.description.type.TypeDescription$Generic$Visitor$Substitutor$ForAttachment.onTypeVariable(TypeDescription.java:1973) at net.bytebuddy.description.type.TypeDescription$Generic$OfTypeVariable.accept(TypeDescription.java:5705) at net.bytebuddy.description.type.TypeDescription$Generic$LazyProjection.accept(TypeDescription.java:6297) at net.bytebuddy.description.method.MethodDescription$Latent.getReturnType(MethodDescription.java:1478) at net.bytebuddy.description.method.MethodDescription$AbstractBase.toSafeString(MethodDescription.java:1041) at net.bytebuddy.description.TypeVariableSource$AbstractBase.findExpectedVariable(TypeVariableSource.java:174) at net.bytebuddy.description.type.TypeDescription$Generic$Visitor$Substitutor$ForAttachment.onTypeVariable(TypeDescription.java:2062) at net.bytebuddy.description.type.TypeDescription$Generic$Visitor$Substitutor$ForAttachment.onTypeVariable(TypeDescription.java:1973) at net.bytebuddy.description.type.TypeDescription$Generic$OfTypeVariable.accept(TypeDescription.java:5705) at net.bytebuddy.description.type.TypeDescription$Generic$LazyProjection.accept(TypeDescription.java:6297) at net.bytebuddy.description.method.MethodDescription$Latent.getReturnType(MethodDescription.java:1478) at net.bytebuddy.description.method.MethodDescription$AbstractBase.toSafeString(MethodDescription.java:1041) at net.bytebuddy.description.TypeVariableSource$AbstractBase.findExpectedVariable(TypeVariableSource.java:174) at net.bytebuddy.description.type.TypeDescription$Generic$Visitor$Substitutor$ForAttachment.onTypeVariable(TypeDescription.java:2062) at net.bytebuddy.description.type.TypeDescription$Generic$Visitor$Substitutor$ForAttachment.onTypeVariable(TypeDescription.java:1973) at net.bytebuddy.description.type.TypeDescription$Generic$OfTypeVariable.accept(TypeDescription.java:5705) at net.bytebuddy.description.type.TypeDescription$Generic$LazyProjection.accept(TypeDescription.java:6297) at net.bytebuddy.description.method.MethodDescription$Latent.getReturnType(MethodDescription.java:1478) at net.bytebuddy.description.method.MethodDescription$AbstractBase.toSafeString(MethodDescription.java:1041) at net.bytebuddy.description.TypeVariableSource$AbstractBase.findExpectedVariable(TypeVariableSource.java:174) at net.bytebuddy.description.type.TypeDescription$Generic$Visitor$Substitutor$ForAttachment.onTypeVariable(TypeDescription.java:2062) at net.bytebuddy.description.type.TypeDescription$Generic$Visitor$Substitutor$ForAttachment.onTypeVariable(TypeDescription.java:1973) at net.bytebuddy.description.type.TypeDescription$Generic$OfTypeVariable.accept(TypeDescription.java:5705) at net.bytebuddy.description.type.TypeDescription$Generic$LazyProjection.accept(TypeDescription.java:6297) at net.bytebuddy.description.method.MethodDescription$Latent.getReturnType(MethodDescription.java:1478) at net.bytebuddy.description.method.MethodDescription$AbstractBase.toSafeString(MethodDescription.java:1041) at net.bytebuddy.description.TypeVariableSource$AbstractBase.findExpectedVariable(TypeVariableSource.java:174) at net.bytebuddy.description.type.TypeDescription$Generic$Visitor$Substitutor$ForAttachment.onTypeVariable(TypeDescription.java:2062) at net.bytebuddy.description.type.TypeDescription$Generic$Visitor$Substitutor$ForAttachment.onTypeVariable(TypeDescription.java:1973) at net.bytebuddy.description.type.TypeDescription$Generic$OfTypeVariable.accept(TypeDescription.java:5705) at net.bytebuddy.description.type.TypeDescription$Generic$LazyProjection.accept(TypeDescription.java:6297) at net.bytebuddy.description.method.MethodDescription$Latent.getReturnType(MethodDescription.java:1478) at net.bytebuddy.description.method.MethodDescription$AbstractBase.toSafeString(MethodDescription.java:1041) at net.bytebuddy.description.TypeVariableSource$AbstractBase.findExpectedVariable(TypeVariableSource.java:174) at net.bytebuddy.description.type.TypeDescription$Generic$Visitor$Substitutor$ForAttachment.onTypeVariable(TypeDescription.java:2062) at net.bytebuddy.description.type.TypeDescription$Generic$Visitor$Substitutor$ForAttachment.onTypeVariable(TypeDescription.java:1973) at net.bytebuddy.description.type.TypeDescription$Generic$OfTypeVariable.accept(TypeDescription.java:5705) at net.bytebuddy.description.type.TypeDescription$Generic$LazyProjection.accept(TypeDescription.java:6297) ... The model: @MappedSuperclass public static abstract class MyAbstractEmbeddable { } @Embeddable public static class MyEmbeddable extends MyAbstractEmbeddable { @Column private String text; public MyEmbeddable() { } private MyEmbeddable(String text) { this.text = text; } public String getText() { return text; } public void setText(String text) { this.text = text; } } @MappedSuperclass // The key to reproducing the problem is to use a different name for the generic parameter // in this class than in the superclass. // Note that, as in other similar tests, the field of the superclass needs // to not be visible from the subclass in other to reproduce the problem. public static abstract class MyLevel2GenericMappedSuperclass<T extends MyAbstractEmbeddable> extends MyNonVisibleGenericMappedSuperclass<T> { } @Entity(name = "myentity") public static class MyEntity extends MyLevel2GenericMappedSuperclass<MyEmbeddable> { @Id private Integer id; public MyEntity() { } private MyEntity(Integer id, String text) { this.id = id; setEmbedded( new MyEmbeddable( text ) ); } public Integer getId() { return id; } public void setId(Integer id) { this.id = id; } } // This class must not be nested in the test class, otherwise its private fields will be visible // from subclasses and we won't reproduce the bug. @MappedSuperclass public abstract class MyNonVisibleGenericMappedSuperclass<C> { @Embedded private C embedded; public C getEmbedded() { return embedded; } public void setEmbedded(C embedded) { this.embedded = embedded; } } ( https://hibernate.atlassian.net/browse/HHH-17035#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-17035#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100233- sha1:06f5c37 )

11 months, 1 week

1
0
0 / 0

[JIRA] (HHH-17034) Bytecode enhancement leads to broken constructor for a generic embedded field in a twice removed MappedSuperclass

by Andrea Boriero (JIRA)

11 months, 1 week

1
0
0 / 0

[JIRA] (HHH-17034) Bytecode enhancement leads to broken constructor for a generic embedded field in a twice removed MappedSuperclass

by Andrea Boriero (JIRA)

11 months, 1 week

1
0
0 / 0

[JIRA] (HHH-17034) Bytecode enhancement leads to broken constructor for a generic embedded field in a twice removed MappedSuperclass

by Yoann Rodière (JIRA)

Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *commented* on HHH-17034 ( https://hibernate.atlassian.net/browse/HHH-17034?atlOrigin=eyJpIjoiNTBkMG... ) Re: Bytecode enhancement leads to broken constructor for a generic embedded field in a twice removed MappedSuperclass ( https://hibernate.atlassian.net/browse/HHH-17034?atlOrigin=eyJpIjoiNTBkMG... ) Reproducer: https://github.com/hibernate/hibernate-orm/pull/7126 Affects Quarkus: https://github.com/quarkusio/quarkus/pull/34465 ( https://hibernate.atlassian.net/browse/HHH-17034#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-17034#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100233- sha1:06f5c37 )

11 months, 1 week

1
0
0 / 0

[JIRA] (HHH-17034) Bytecode enhancement leads to broken constructor for a generic embedded field in a twice removed MappedSuperclass

by Yoann Rodière (JIRA)

11 months, 1 week

1
0
0 / 0

[JIRA] (HHH-17034) Bytecode enhancement leads to broken constructor for a generic embedded field in a twice removed MappedSuperclass

by Yoann Rodière (JIRA)

Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) *created* an issue Hibernate ORM ( https://hibernate.atlassian.net/browse/HHH?atlOrigin=eyJpIjoiNzBlYmI0YmJi... ) / Task ( https://hibernate.atlassian.net/browse/HHH-17034?atlOrigin=eyJpIjoiNzBlYm... ) HHH-17034 ( https://hibernate.atlassian.net/browse/HHH-17034?atlOrigin=eyJpIjoiNzBlYm... ) Bytecode enhancement leads to broken constructor for a generic embedded field in a twice removed MappedSuperclass ( https://hibernate.atlassian.net/browse/HHH-17034?atlOrigin=eyJpIjoiNzBlYm... ) Issue Type: Task Assignee: Unassigned Created: 04/Aug/2023 07:40 AM Fix Versions: 6.3.0, 6.2.8 Priority: Major Reporter: Yoann Rodière ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=557058%... ) Basically https://hibernate.atlassian.net/browse/HHH-16832 but with one more level of generic abstract classes, i.e. with the model below. I will send a PR with a reproducer. The exception: java.lang.NoSuchMethodError: 'org.hibernate.orm.test.bytecode.enhance.internal.bytebuddy.DirtyCheckingWithEmbeddableAndTwiceRemovedNonVisibleGenericMappedSuperclassTest$MyAbstractEmbeddable org.hibernate.orm.test.bytecode.enhance.internal.bytebuddy.DirtyCheckingWithEmbeddableAndTwiceRemovedNonVisibleGenericMappedSuperclassTest$MyMappedSuperclass.$$_hibernate_read_embedded()' at org.hibernate.orm.test.bytecode.enhance.internal.bytebuddy.DirtyCheckingWithEmbeddableAndTwiceRemovedNonVisibleGenericMappedSuperclassTest$MyEntity.$$_hibernate_write_embedded(DirtyCheckingWithEmbeddableAndTwiceRemovedNonVisibleGenericMappedSuperclassTest.java) at org.hibernate.orm.test.bytecode.enhance.internal.bytebuddy.MyNonVisibleGenericMappedSuperclass.setEmbedded(MyNonVisibleGenericMappedSuperclass.java:25) at org.hibernate.orm.test.bytecode.enhance.internal.bytebuddy.DirtyCheckingWithEmbeddableAndTwiceRemovedNonVisibleGenericMappedSuperclassTest$MyEntity.<init>(DirtyCheckingWithEmbeddableAndTwiceRemovedNonVisibleGenericMappedSuperclassTest.java:195) The model: @MappedSuperclass public abstract class MyAbstractEmbeddable { } @Embeddable public class MyEmbeddable extends MyAbstractEmbeddable { @Column private String text; public MyEmbeddable() { } private MyEmbeddable(String text) { this.text = text; } public String getText() { return text; } public void setText(String text) { this.text = text; } } @MappedSuperclass public abstract class MyMappedSuperclass<C extends MyAbstractEmbeddable> extends MyNonVisibleGenericMappedSuperclass<C> { } @Entity(name = "myentity") public class MyEntity extends MyMappedSuperclass<MyEmbeddable> { @Id private Integer id; public MyEntity() { } private MyEntity(Integer id, String text) { this.id = id; setEmbedded( new MyEmbeddable( text ) ); } public Integer getId() { return id; } public void setId(Integer id) { this.id = id; } } // This class must not be nested in the test class, otherwise its private fields will be visible // from subclasses and we won't reproduce the bug. @MappedSuperclass public abstract class MyNonVisibleGenericMappedSuperclass<C> { @Embedded private C embedded; public C getEmbedded() { return embedded; } public void setEmbedded(C embedded) { this.embedded = embedded; } } ( https://hibernate.atlassian.net/browse/HHH-17034#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-17034#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100233- sha1:06f5c37 )

11 months, 1 week

1
0
0 / 0

[JIRA] (HHH-17033) Invalid SQL generated when implicit joins are used

by Christian Beikov (JIRA)

11 months, 1 week

1
0
0 / 0

[JIRA] (HHH-16970) @OneToMany with orphanRemoval = true does not work in @Embeddable org.hibernate.property.access.spi.PropertyAccessException

by Marco Belladelli (JIRA)

Marco Belladelli ( https://hibernate.atlassian.net/secure/ViewProfile.jspa?accountId=637b480... ) *commented* on HHH-16970 ( https://hibernate.atlassian.net/browse/HHH-16970?atlOrigin=eyJpIjoiY2Y2NG... ) Re: @OneToMany with orphanRemoval = true does not work in @Embeddable org.hibernate.property.access.spi.PropertyAccessException ( https://hibernate.atlassian.net/browse/HHH-16970?atlOrigin=eyJpIjoiY2Y2NG... ) Thank you for reaching back and providing a reproducer, we will look into this issue. ( https://hibernate.atlassian.net/browse/HHH-16970#add-comment?atlOrigin=ey... ) Add Comment ( https://hibernate.atlassian.net/browse/HHH-16970#add-comment?atlOrigin=ey... ) Get Jira notifications on your phone! Download the Jira Cloud app for Android ( https://play.google.com/store/apps/details?id=com.atlassian.android.jira.... ) or iOS ( https://itunes.apple.com/app/apple-store/id1006972087?pt=696495&ct=EmailN... ) This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100233- sha1:06f5c37 )

11 months, 1 week

1
0
0 / 0

[JIRA] (HHH-16970) @OneToMany with orphanRemoval = true does not work in @Embeddable org.hibernate.property.access.spi.PropertyAccessException

by Marco Belladelli (JIRA)

11 months, 1 week

1
0
0 / 0

[JIRA] (HHH-16970) @OneToMany with orphanRemoval = true does not work in @Embeddable org.hibernate.property.access.spi.PropertyAccessException

by Marco Belladelli (JIRA)

11 months, 1 week

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

hibernate-issues August 2023